]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/DFRN.php
Fix: Posts sent to forums had been rejected
[friendica.git] / src / Protocol / DFRN.php
index cc0042d6b7f33618b6af1ea20503cf121ac85932..b6f7f1cb2b0cdc670b615059a01b7ee541a5b669 100644 (file)
@@ -39,6 +39,7 @@ use Friendica\Model\ItemURI;
 use Friendica\Model\Mail;
 use Friendica\Model\Notify\Type;
 use Friendica\Model\PermissionSet;
+use Friendica\Model\Post;
 use Friendica\Model\Post\Category;
 use Friendica\Model\Profile;
 use Friendica\Model\Tag;
@@ -1499,21 +1500,28 @@ class DFRN
 
                $fields = ['id', 'uid', 'url', 'network', 'avatar-date', 'avatar', 'name-date', 'uri-date', 'addr',
                        'name', 'nick', 'about', 'location', 'keywords', 'xmpp', 'bdyear', 'bd', 'hidden', 'contact-type'];
-               $condition = ["`uid` = ? AND `nurl` = ? AND `network` != ?",
+               $condition = ["`uid` = ? AND `nurl` = ? AND `network` != ? AND NOT `pending` AND NOT `blocked`",
                        $importer["importer_uid"], Strings::normaliseLink($author["link"]), Protocol::STATUSNET];
+
+               if ($importer['account-type'] != User::ACCOUNT_TYPE_COMMUNITY) {
+                       $condition = DBA::mergeConditions($condition, ['rel' => [Contact::SHARING, Contact::FRIEND]]);
+               }
+
                $contact_old = DBA::selectFirst('contact', $fields, $condition);
 
                if (DBA::isResult($contact_old)) {
                        $author["contact-id"] = $contact_old["id"];
                        $author["network"] = $contact_old["network"];
                } else {
+                       Logger::info('Blubb', ['condition' => $condition]);
                        if (!$onlyfetch) {
                                Logger::debug("Contact ".$author["link"]." wasn't found for user ".$importer["importer_uid"]." XML: ".$xml);
                        }
 
                        $author["contact-unknown"] = true;
-                       $author["contact-id"] = $importer["id"];
-                       $author["network"] = $importer["network"];
+                       $contact = Contact::getByURL($author["link"], null, ["id", "network"]);
+                       $author["contact-id"] = $contact["id"] ?? $importer["id"];
+                       $author["network"] = $contact["network"] ?? $importer["network"];
                        $onlyfetch = true;
                }
 
@@ -1791,91 +1799,13 @@ class DFRN
         */
        private static function processSuggestion($xpath, $suggestion, $importer)
        {
-               Logger::log('Processing suggestions');
-
-               /// @TODO Rewrite this to one statement
-               $suggest = [];
-               $suggest['uid'] = $importer['importer_uid'];
-               $suggest['cid'] = $importer['id'];
-               $suggest['url'] = $xpath->query('dfrn:url/text()', $suggestion)->item(0)->nodeValue;
-               $suggest['name'] = $xpath->query('dfrn:name/text()', $suggestion)->item(0)->nodeValue;
-               $suggest['photo'] = $xpath->query('dfrn:photo/text()', $suggestion)->item(0)->nodeValue;
-               $suggest['request'] = $xpath->query('dfrn:request/text()', $suggestion)->item(0)->nodeValue;
-               $suggest['body'] = $xpath->query('dfrn:note/text()', $suggestion)->item(0)->nodeValue;
-
-               // Does our member already have a friend matching this description?
-
-               /*
-                * The valid result means the friend we're about to send a friend
-                * suggestion already has them in their contact, which means no further
-                * action is required.
-                *
-                * @see https://github.com/friendica/friendica/pull/3254#discussion_r107315246
-                */
-               $condition = ['nurl' => Strings::normaliseLink($suggest['url']), 'uid' => $suggest['uid']];
-               if (DBA::exists('contact', $condition)) {
-                       return false;
-               }
-               // Do we already have an fcontact record for this person?
-
-               $fid = 0;
-               $fcontact = DBA::selectFirst('fcontact', ['id'], ['url' => $suggest['url']]);
-               if (DBA::isResult($fcontact)) {
-                       $fid = $fcontact['id'];
-
-                       // OK, we do. Do we already have an introduction for this person?
-                       if (DBA::exists('intro', ['uid' => $suggest['uid'], 'fid' => $fid])) {
-                               /*
-                                * The valid result means the friend we're about to send a friend
-                                * suggestion already has them in their contact, which means no further
-                                * action is required.
-                                *
-                                * @see https://github.com/friendica/friendica/pull/3254#discussion_r107315246
-                                */
-                               return false;
-                       }
-               }
-
-               if (!$fid) {
-                       $fields = ['name' => $suggest['name'], 'url' => $suggest['url'],
-                               'photo' => $suggest['photo'], 'request' => $suggest['request']];
-                       DBA::insert('fcontact', $fields);
-                       $fid = DBA::lastInsertId();
-               }
+               Logger::notice('Processing suggestions');
 
-               /*
-                * If no record in fcontact is found, below INSERT statement will not
-                * link an introduction to it.
-                */
-               if (empty($fid)) {
-                       // Database record did not get created. Quietly give up.
-                       exit();
-               }
-
-               $hash = Strings::getRandomHex();
-
-               $fields = ['uid' => $suggest['uid'], 'fid' => $fid, 'contact-id' => $suggest['cid'],
-                       'note' => $suggest['body'], 'hash' => $hash, 'datetime' => DateTimeFormat::utcNow(), 'blocked' => false];
-               DBA::insert('intro', $fields);
-
-               notification(
-                       [
-                               'type'         => Type::SUGGEST,
-                               'notify_flags' => $importer['notify-flags'],
-                               'language'     => $importer['language'],
-                               'to_name'      => $importer['username'],
-                               'to_email'     => $importer['email'],
-                               'uid'          => $importer['importer_uid'],
-                               'item'         => $suggest,
-                               'link'         => DI::baseUrl().'/notifications/intros',
-                               'source_name'  => $importer['name'],
-                               'source_link'  => $importer['url'],
-                               'source_photo' => $importer['photo'],
-                               'verb'         => Activity::REQ_FRIEND,
-                               'otype'        => 'intro']
-               );
+               $url = $xpath->evaluate('string(dfrn:url[1]/text())', $suggestion);
+               $cid = Contact::getIdForURL($url);
+               $note = $xpath->evaluate('string(dfrn:note[1]/text())', $suggestion);
 
-               return true;
+               return FContact::addSuggestion($importer['importer_uid'], $cid, $importer['id'], $note);
        }
 
        /**
@@ -2252,13 +2182,32 @@ class DFRN
                                                        $item["attach"] = "";
                                                }
 
-                                               $item["attach"] .= '[attach]href="' . $href . '" length="' . $length . '" type="' . $type . '" title="' . $title . '"[/attach]';
+                                               $item["attach"] .= Post\Media::getAttachElement($href, $length, $type, $title);
                                                break;
                                }
                        }
                }
        }
 
+       /**
+        * Checks if an incoming message is wanted
+        *
+        * @param array $item
+        * @return boolean Is the message wanted?
+        */
+       private static function isSolicitedMessage(array $item)
+       {
+               if (DBA::exists('contact', ["`nurl` = ? AND `uid` != ? AND `rel` IN (?, ?)",
+                       Strings::normaliseLink($item["author-link"]), 0, Contact::FRIEND, Contact::SHARING])) {
+                       Logger::info('Author has got followers - accepted', ['uri' => $item['uri'], 'author' => $item["author-link"]]);
+                       return true;
+               }
+
+               $taglist = Tag::getByURIId($item['uri-id'], [Tag::HASHTAG]);
+               $tags = array_column($taglist, 'name');
+               return Relay::isSolicitedPost($tags, $item['body'], $item['author-id'], $item['uri'], Protocol::DFRN);
+       }
+
        /**
         * Processes the entry elements which contain the items and comments
         *
@@ -2448,6 +2397,14 @@ class DFRN
                        }
                }
 
+               // Check if the message is wanted
+               if (($importer["importer_uid"] == 0) && ($item['uri'] == $item['parent-uri'])) {
+                       if (!self::isSolicitedMessage($item)) {
+                               DBA::delete('item-uri', ['uri' => $item['uri']]);
+                               return 403;
+                       }
+               }
+                               
                // Get the type of the item (Top level post, reply or remote reply)
                $entrytype = self::getEntryType($importer, $item);
 
@@ -2534,6 +2491,11 @@ class DFRN
                }
 
                if (in_array($entrytype, [DFRN::REPLY, DFRN::REPLY_RC])) {
+                       // Will be overwritten for sharing accounts in Item::insert
+                       if (empty($item['post-type']) && ($entrytype == DFRN::REPLY)) {
+                               $item['post-type'] = Item::PT_COMMENT;
+                       }
+
                        $posted_id = Item::insert($item);
                        if ($posted_id) {
                                Logger::log("Reply from contact ".$item["contact-id"]." was stored with id ".$posted_id, Logger::DEBUG);