$xml = $ret['body'];
$curl_stat = $a->get_curl_code();
- if (!$curl_stat) {
+ if (empty($curl_stat)) {
return -3; // timed out
}
logger('dfrn_deliver: ' . $xml, LOGGER_DATA);
- if (! $xml) {
+ if (empty($xml)) {
return 3;
}
$res = XML::parseString($xml);
if ((intval($res->status) != 0) || (! strlen($res->challenge)) || (! strlen($res->dfrn_id))) {
- return (($res->status) ? $res->status : 3);
+ return ($res->status ? $res->status : 3);
}
$postvars = [];
logger('dfrn_deliver: ' . "RECEIVED: " . $xml, LOGGER_DATA);
$curl_stat = $a->get_curl_code();
- if ((!$curl_stat) || (!strlen($xml))) {
+ if (empty($curl_stat) || empty($xml)) {
return -9; // timed out
}
- if (($curl_stat == 503) && (stristr($a->get_curl_headers(), 'retry-after'))) {
+ if (($curl_stat == 503) && stristr($a->get_curl_headers(), 'retry-after')) {
return -10;
}
return -11;
}
+ // Possibly old servers had returned an empty value when everything was okay
+ if (empty($res->status)) {
+ $res->status = 200;
+ }
+
if (!empty($res->message)) {
logger('Delivery returned status '.$res->status.' - '.$res->message, LOGGER_DEBUG);
}
*
* @return int Deliver status. Negative values mean an error.
*/
- public static function transmit($owner, $contact, $atom)
+ public static function transmit($owner, $contact, $atom, $public_batch = false)
{
$a = get_app();
- // Currently disabled, at first we will not use the batch delivery
- // $public_batch = !$items[0]['private'];
- $public_batch = false;
+ if (empty($contact['addr'])) {
+ logger('Empty contact handle for ' . $contact['id'] . ' - ' . $contact['url'] . ' - trying to update it.');
+ if (Contact::updateFromProbe($contact['id'])) {
+ $new_contact = dba::selectFirst('contact', ['addr'], ['id' => $contact['id']]);
+ $contact['addr'] = $new_contact['addr'];
+ }
+
+ if (empty($contact['addr'])) {
+ logger('Unable to find contact handle for ' . $contact['id'] . ' - ' . $contact['url']);
+ return -21;
+ }
+ }
$fcontact = Diaspora::personByHandle($contact['addr']);
if (empty($fcontact)) {
- logger("unable to find contact details");
- return;
+ logger('Unable to find contact details for ' . $contact['id'] . ' - ' . $contact['addr']);
+ return -22;
}
$envelope = Diaspora::buildMessage($atom, $owner, $contact, $owner['uprvkey'], $fcontact['pubkey'], $public_batch);
$xml = Network::post($dest_url, $envelope, ["Content-Type: ".$content_type]);
$curl_stat = $a->get_curl_code();
- if (!$curl_stat || empty($xml)) {
+ if (empty($curl_stat) || empty($xml)) {
+ logger('Empty answer from ' . $contact['id'] . ' - ' . $dest_url);
return -9; // timed out
}
}
if (strpos($xml, '<?xml') === false) {
- logger('no valid XML returned');
- logger('returned XML: ' . $xml, LOGGER_DATA);
+ logger('No valid XML returned from ' . $contact['id'] . ' - ' . $dest_url);
+ logger('Returned XML: ' . $xml, LOGGER_DATA);
return 3;
}
$res = XML::parseString($xml);
- if (!isset($res->status)) {
- return -11;
+ if (empty($res->status)) {
+ return -23;
}
if (!empty($res->message)) {
- logger('Transmit returned status '.$res->status.' - '.$res->message, LOGGER_DEBUG);
+ logger('Transmit to ' . $dest_url . ' returned status '.$res->status.' - '.$res->message, LOGGER_DEBUG);
}
if ($res->status == 200) {
// Check for duplicates
$r = q(
"SELECT `id` FROM `event` WHERE `uid` = %d AND `cid` = %d AND `start` = '%s' AND `type` = '%s' LIMIT 1",
- intval($contact["uid"]),
- intval($contact["id"]),
+ intval($contact['uid']),
+ intval($contact['id']),
dbesc(DateTimeFormat::utc($birthday)),
- dbesc("birthday")
+ dbesc('birthday')
);
if (DBM::is_result($r)) {
return;
}
- logger("updating birthday: ".$birthday." for contact ".$contact["id"]);
+ logger('updating birthday: ' . $birthday . ' for contact ' . $contact['id']);
- $bdtext = L10n::t("%s\'s birthday", $contact["name"]);
- $bdtext2 = L10n::t("Happy Birthday %s", " [url=".$contact["url"]."]".$contact["name"]."[/url]");
+ $bdtext = L10n::t('%s\'s birthday', $contact['name']);
+ $bdtext2 = L10n::t('Happy Birthday %s', ' [url=' . $contact['url'] . ']' . $contact['name'] . '[/url]');
$r = q(
"INSERT INTO `event` (`uid`,`cid`,`created`,`edited`,`start`,`finish`,`summary`,`desc`,`type`)
VALUES ( %d, %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s') ",
- intval($contact["uid"]),
- intval($contact["id"]),
+ intval($contact['uid']),
+ intval($contact['id']),
dbesc(DateTimeFormat::utcNow()),
dbesc(DateTimeFormat::utcNow()),
dbesc(DateTimeFormat::utc($birthday)),
- dbesc(DateTimeFormat::utc($birthday . " + 1 day ")),
+ dbesc(DateTimeFormat::utc($birthday . ' + 1 day ')),
dbesc($bdtext),
dbesc($bdtext2),
- dbesc("birthday")
+ dbesc('birthday')
);
}
logger("Import DFRN message for user " . $importer["importer_uid"] . " from contact " . $importer["id"], LOGGER_DEBUG);
+ // is it a public forum? Private forums aren't exposed with this method
+ $forum = intval($xpath->evaluate("/atom:feed/dfrn:community/text()")->item(0)->nodeValue);
+
// The account type is new since 3.5.1
if ($xpath->query("/atom:feed/dfrn:account_type")->length > 0) {
$accounttype = intval($xpath->evaluate("/atom:feed/dfrn:account_type/text()")->item(0)->nodeValue);
if ($accounttype != $importer["contact-type"]) {
dba::update('contact', ['contact-type' => $accounttype], ['id' => $importer["id"]]);
}
- }
-
- // is it a public forum? Private forums aren't supported with this method
- // This is deprecated since 3.5.1
- $forum = intval($xpath->evaluate("/atom:feed/dfrn:community/text()")->item(0)->nodeValue);
-
- if ($forum != $importer["forum"]) {
+ // A forum contact can either have set "forum" or "prv" - but not both
+ if (($accounttype == ACCOUNT_TYPE_COMMUNITY) && (($forum != $importer["forum"]) || ($forum == $importer["prv"]))) {
+ $condition = ['(`forum` != ? OR `prv` != ?) AND `id` = ?', $forum, !$forum, $importer["id"]];
+ dba::update('contact', ['forum' => $forum, 'prv' => !$forum], $condition);
+ }
+ } elseif ($forum != $importer["forum"]) { // Deprecated since 3.5.1
$condition = ['`forum` != ? AND `id` = ?', $forum, $importer["id"]];
dba::update('contact', ['forum' => $forum], $condition);
}
+
// We are processing relocations even if we are ignoring a contact
$relocations = $xpath->query("/atom:feed/dfrn:relocate");
foreach ($relocations as $relocation) {
projects / friendica.git / blobdiff