]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/DFRN.php
Merge pull request #6752 from MrPetovan/bug/notices
[friendica.git] / src / Protocol / DFRN.php
index e4269f38ec1782799354cd25118ec6cc9d1a8063..efd3c4aa606a0320ba5da97f8682379801d0e639 100644 (file)
@@ -119,7 +119,9 @@ class DFRN
                        $item["entry:cid"] = defaults($item, "entry:cid", 0);
 
                        $entry = self::entry($doc, "text", $item, $owner, $item["entry:comment-allow"], $item["entry:cid"]);
-                       $root->appendChild($entry);
+                       if (isset($entry)) {
+                               $root->appendChild($entry);
+                       }
                }
 
                return trim($doc->saveXML());
@@ -323,7 +325,9 @@ class DFRN
                        }
 
                        $entry = self::entry($doc, $type, $item, $owner, true);
-                       $root->appendChild($entry);
+                       if (isset($entry)) {
+                               $root->appendChild($entry);
+                       }
                }
 
                $atom = trim($doc->saveXML());
@@ -390,7 +394,9 @@ class DFRN
 
                        foreach ($items as $item) {
                                $entry = self::entry($doc, $type, $item, $owner, true, 0);
-                               $root->appendChild($entry);
+                               if (isset($entry)) {
+                                       $root->appendChild($entry);
+                               }
                        }
                } else {
                        $root = self::entry($doc, $type, $item, $owner, true, 0, true);
@@ -529,17 +535,17 @@ class DFRN
        /**
         * @brief Adds the header elements for the DFRN protocol
         *
-        * @param object $doc           XML document
-        * @param array  $owner         Owner record
-        * @param string $authorelement Element name for the author
-        * @param string $alternatelink link to profile or category
-        * @param bool   $public        Is it a header for public posts?
+        * @param DOMDocument $doc           XML document
+        * @param array       $owner         Owner record
+        * @param string      $authorelement Element name for the author
+        * @param string      $alternatelink link to profile or category
+        * @param bool        $public        Is it a header for public posts?
         *
         * @return object XML root object
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @todo  Find proper type-hints
         */
-       private static function addHeader($doc, $owner, $authorelement, $alternatelink = "", $public = false)
+       private static function addHeader(DOMDocument $doc, $owner, $authorelement, $alternatelink = "", $public = false)
        {
 
                if ($alternatelink == "") {
@@ -587,14 +593,14 @@ class DFRN
                }
 
                // For backward compatibility we keep this element
-               if ($owner['page-flags'] == Contact::PAGE_COMMUNITY) {
+               if ($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY) {
                        XML::addElement($doc, $root, "dfrn:community", 1);
                }
 
                // The former element is replaced by this one
                XML::addElement($doc, $root, "dfrn:account_type", $owner["account-type"]);
 
-               /// @todo We need a way to transmit the different page flags like "Contact::PAGE_PRVGROUP"
+               /// @todo We need a way to transmit the different page flags like "User::PAGE_FLAGS_PRVGROUP"
 
                XML::addElement($doc, $root, "updated", DateTimeFormat::utcNow(DateTimeFormat::ATOM));
 
@@ -607,16 +613,16 @@ class DFRN
        /**
         * @brief Adds the author element in the header for the DFRN protocol
         *
-        * @param object  $doc           XML document
-        * @param array   $owner         Owner record
-        * @param string  $authorelement Element name for the author
-        * @param boolean $public        boolean
+        * @param DOMDocument $doc           XML document
+        * @param array       $owner         Owner record
+        * @param string      $authorelement Element name for the author
+        * @param boolean     $public        boolean
         *
-        * @return object XML author object
+        * @return \DOMElement XML author object
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @todo  Find proper type-hints
         */
-       private static function addAuthor($doc, $owner, $authorelement, $public)
+       private static function addAuthor(DOMDocument $doc, array $owner, $authorelement, $public)
        {
                // Is the profile hidden or shouldn't be published in the net? Then add the "hide" element
                $r = q(
@@ -752,42 +758,44 @@ class DFRN
        /**
         * @brief Adds the author elements in the "entry" elements of the DFRN protocol
         *
-        * @param object $doc         XML document
+        * @param DOMDocument $doc         XML document
         * @param string $element     Element name for the author
         * @param string $contact_url Link of the contact
         * @param array  $item        Item elements
         *
-        * @return object XML author object
+        * @return \DOMElement XML author object
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @todo  Find proper type-hints
         */
-       private static function addEntryAuthor($doc, $element, $contact_url, $item)
+       private static function addEntryAuthor(DOMDocument $doc, $element, $contact_url, $item)
        {
-               $contact = Contact::getDetailsByURL($contact_url, $item["uid"]);
-
                $author = $doc->createElement($element);
-               XML::addElement($doc, $author, "name", $contact["name"]);
-               XML::addElement($doc, $author, "uri", $contact["url"]);
-               XML::addElement($doc, $author, "dfrn:handle", $contact["addr"]);
 
-               /// @Todo
-               /// - Check real image type and image size
-               /// - Check which of these boths elements we should use
-               $attributes = [
+               $contact = Contact::getDetailsByURL($contact_url, $item["uid"]);
+               if (!empty($contact)) {
+                       XML::addElement($doc, $author, "name", $contact["name"]);
+                       XML::addElement($doc, $author, "uri", $contact["url"]);
+                       XML::addElement($doc, $author, "dfrn:handle", $contact["addr"]);
+
+                       /// @Todo
+                       /// - Check real image type and image size
+                       /// - Check which of these boths elements we should use
+                       $attributes = [
                                "rel" => "photo",
                                "type" => "image/jpeg",
                                "media:width" => 80,
                                "media:height" => 80,
                                "href" => $contact["photo"]];
-               XML::addElement($doc, $author, "link", "", $attributes);
+                       XML::addElement($doc, $author, "link", "", $attributes);
 
-               $attributes = [
+                       $attributes = [
                                "rel" => "avatar",
                                "type" => "image/jpeg",
                                "media:width" => 80,
                                "media:height" => 80,
                                "href" => $contact["photo"]];
-               XML::addElement($doc, $author, "link", "", $attributes);
+                       XML::addElement($doc, $author, "link", "", $attributes);
+               }
 
                return $author;
        }
@@ -795,15 +803,15 @@ class DFRN
        /**
         * @brief Adds the activity elements
         *
-        * @param object $doc      XML document
-        * @param string $element  Element name for the activity
-        * @param string $activity activity value
+        * @param DOMDocument $doc      XML document
+        * @param string      $element  Element name for the activity
+        * @param string      $activity activity value
         *
-        * @return object XML activity object
+        * @return \DOMElement XML activity object
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @todo  Find proper type-hints
         */
-       private static function createActivity($doc, $element, $activity)
+       private static function createActivity(DOMDocument $doc, $element, $activity)
        {
                if ($activity) {
                        $entry = $doc->createElement($element);
@@ -898,25 +906,26 @@ class DFRN
        /**
         * @brief Adds the "entry" elements for the DFRN protocol
         *
-        * @param object $doc     XML document
-        * @param string $type    "text" or "html"
-        * @param array  $item    Item element
-        * @param array  $owner   Owner record
-        * @param bool   $comment Trigger the sending of the "comment" element
-        * @param int    $cid     Contact ID of the recipient
-        * @param bool   $single  If set, the entry is created as an XML document with a single "entry" element
+        * @param DOMDocument $doc     XML document
+        * @param string      $type    "text" or "html"
+        * @param array       $item    Item element
+        * @param array       $owner   Owner record
+        * @param bool        $comment Trigger the sending of the "comment" element
+        * @param int         $cid     Contact ID of the recipient
+        * @param bool        $single  If set, the entry is created as an XML document with a single "entry" element
         *
-        * @return object XML entry object
+        * @return null|\DOMElement XML entry object
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         * @todo  Find proper type-hints
         */
-       private static function entry($doc, $type, array $item, array $owner, $comment = false, $cid = 0, $single = false)
+       private static function entry(DOMDocument $doc, $type, array $item, array $owner, $comment = false, $cid = 0, $single = false)
        {
                $mentioned = [];
 
                if (!$item['parent']) {
-                       return;
+                       Logger::notice('Item without parent found.', ['type' => $type, 'item' => $item]);
+                       return null;
                }
 
                if ($item['deleted']) {
@@ -1264,11 +1273,11 @@ class DFRN
                $perm         = (($res->perm) ? $res->perm : null);
                $dfrn_version = (float) (($res->dfrn_version) ? $res->dfrn_version : 2.0);
                $rino_remote_version = intval($res->rino);
-               $page         = (($owner['page-flags'] == Contact::PAGE_COMMUNITY) ? 1 : 0);
+               $page         = (($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? 1 : 0);
 
                Logger::log("Remote rino version: ".$rino_remote_version." for ".$contact["url"], Logger::DEBUG);
 
-               if ($owner['page-flags'] == Contact::PAGE_PRVGROUP) {
+               if ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) {
                        $page = 2;
                }
 
@@ -1285,7 +1294,7 @@ class DFRN
                }
 
                if (($contact['duplex'] && strlen($contact['pubkey']))
-                       || ($owner['page-flags'] == Contact::PAGE_COMMUNITY && strlen($contact['pubkey']))
+                       || ($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY && strlen($contact['pubkey']))
                        || ($contact['rel'] == Contact::SHARING && strlen($contact['pubkey']))
                ) {
                        openssl_public_decrypt($sent_dfrn_id, $final_dfrn_id, $contact['pubkey']);
@@ -1314,7 +1323,7 @@ class DFRN
                        $postvars['dissolve'] = '1';
                }
 
-               if ((($contact['rel']) && ($contact['rel'] != Contact::SHARING) && (! $contact['blocked'])) || ($owner['page-flags'] == Contact::PAGE_COMMUNITY)) {
+               if ((($contact['rel']) && ($contact['rel'] != Contact::SHARING) && (! $contact['blocked'])) || ($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY)) {
                        $postvars['data'] = $atom;
                        $postvars['perm'] = 'rw';
                } else {
@@ -1349,7 +1358,7 @@ class DFRN
 
                        if ($dfrn_version >= 2.1) {
                                if (($contact['duplex'] && strlen($contact['pubkey']))
-                                       || ($owner['page-flags'] == Contact::PAGE_COMMUNITY && strlen($contact['pubkey']))
+                                       || ($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY && strlen($contact['pubkey']))
                                        || ($contact['rel'] == Contact::SHARING && strlen($contact['pubkey']))
                                ) {
                                        openssl_public_encrypt($key, $postvars['key'], $contact['pubkey']);
@@ -1357,7 +1366,7 @@ class DFRN
                                        openssl_private_encrypt($key, $postvars['key'], $contact['prvkey']);
                                }
                        } else {
-                               if (($contact['duplex'] && strlen($contact['prvkey'])) || ($owner['page-flags'] == Contact::PAGE_COMMUNITY)) {
+                               if (($contact['duplex'] && strlen($contact['prvkey'])) || ($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY)) {
                                        openssl_private_encrypt($key, $postvars['key'], $contact['prvkey']);
                                } else {
                                        openssl_public_encrypt($key, $postvars['key'], $contact['pubkey']);
@@ -1546,7 +1555,7 @@ class DFRN
                        $author["network"] = $contact_old["network"];
                } else {
                        if (!$onlyfetch) {
-                               Logger::log("Contact ".$author["link"]." wasn't found for user ".$importer["importer_uid"]." XML: ".$xml, Logger::DEBUG);
+                               Logger::debug("Contact ".$author["link"]." wasn't found for user ".$importer["importer_uid"]." XML: ".$xml);
                        }
 
                        $author["contact-unknown"] = true;
@@ -1596,6 +1605,7 @@ class DFRN
 
                if (empty($author['avatar'])) {
                        Logger::log('Empty author: ' . $xml);
+                       $author['avatar'] = '';
                }
 
                if (DBA::isResult($contact_old) && !$onlyfetch) {
@@ -1963,6 +1973,7 @@ class DFRN
                                DBA::escape($suggest["photo"]),
                                DBA::escape($suggest["request"])
                        );
+                       $fid = $r[0]["id"];
                }
 
                $condition = ['url' => $suggest["url"], 'name' => $suggest["name"], 'request' => $suggest["request"]];
@@ -1977,8 +1988,6 @@ class DFRN
                        exit();
                }
 
-               $fid = $r[0]["id"];
-
                $hash = Strings::getRandomHex();
 
                q(
@@ -2146,7 +2155,7 @@ class DFRN
                if ($item["parent-uri"] != $item["uri"]) {
                        $community = false;
 
-                       if ($importer["page-flags"] == Contact::PAGE_COMMUNITY || $importer["page-flags"] == Contact::PAGE_PRVGROUP) {
+                       if ($importer["page-flags"] == User::PAGE_FLAGS_COMMUNITY || $importer["page-flags"] == User::PAGE_FLAGS_PRVGROUP) {
                                $sql_extra = "";
                                $community = true;
                                Logger::log("possible community action");
@@ -2219,6 +2228,7 @@ class DFRN
 
                if (($xo->type == ACTIVITY_OBJ_PERSON) && ($xo->id)) {
                        // somebody was poked/prodded. Was it me?
+                       $Blink = '';
                        foreach ($xo->link as $l) {
                                $atts = $l->attributes();
                                switch ($atts["rel"]) {
@@ -2414,7 +2424,7 @@ class DFRN
         * @param object $xpath    XPath object
         * @param object $entry    entry elements
         * @param array  $importer Record of the importer user mixed with contact of the content
-        * @param object $xml      xml
+        * @param string $xml      xml
         * @return void
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
@@ -2878,7 +2888,7 @@ class DFRN
                                DBA::update('contact', ['contact-type' => $accounttype], ['uid' => 0, 'nurl' => $importer['nurl']]);
                        }
                        // A forum contact can either have set "forum" or "prv" - but not both
-                       if ($accounttype == Contact::ACCOUNT_TYPE_COMMUNITY) {
+                       if ($accounttype == User::ACCOUNT_TYPE_COMMUNITY) {
                                // It's a forum, so either set the public or private forum flag
                                $condition = ['(`forum` != ? OR `prv` != ?) AND `id` = ?', $forum, !$forum, $importer['id']];
                                DBA::update('contact', ['forum' => $forum, 'prv' => !$forum], $condition);
@@ -3073,8 +3083,8 @@ class DFRN
                        return false;
                }
 
-               $community_page = ($user['page-flags'] == Contact::PAGE_COMMUNITY);
-               $prvgroup = ($user['page-flags'] == Contact::PAGE_PRVGROUP);
+               $community_page = ($user['page-flags'] == User::PAGE_FLAGS_COMMUNITY);
+               $prvgroup = ($user['page-flags'] == User::PAGE_FLAGS_PRVGROUP);
 
                $link = Strings::normaliseLink(System::baseUrl() . '/profile/' . $user['nickname']);