]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Diaspora.php
Merge branch 'friendica:develop' into bug-noLocalPosts
[friendica.git] / src / Protocol / Diaspora.php
index b3108c8ff321abdf2c868cf2821f07925f767d96..54f09e9d970c8ce209249a39a609b17d2c989b90 100644 (file)
@@ -54,7 +54,8 @@ use GuzzleHttp\Psr7\Uri;
 use SimpleXMLElement;
 
 /**
- * This class contain functions to create and send Diaspora XML files
+ * This class contains functions to communicate via the Diaspora protocol
+ * @see https://diaspora.github.io/diaspora_federation/
  */
 class Diaspora
 {
@@ -223,14 +224,34 @@ class Diaspora
 
                // Is it a private post? Then decrypt the outer Salmon
                if (is_object($data)) {
-                       $encrypted_aes_key_bundle = base64_decode($data->aes_key);
-                       $ciphertext = base64_decode($data->encrypted_magic_envelope);
+                       try {
+                               if (!isset($data->aes_key) || !isset($data->encrypted_magic_envelope)) {
+                                       Logger::info('Missing keys "aes_key" and/or "encrypted_magic_envelope"', ['data' => $data]);
+                                       throw new \RuntimeException('Missing keys "aes_key" and/or "encrypted_magic_envelope"');
+                               }
 
-                       $outer_key_bundle = '';
-                       @openssl_private_decrypt($encrypted_aes_key_bundle, $outer_key_bundle, $privKey);
-                       $j_outer_key_bundle = json_decode($outer_key_bundle);
+                               $encrypted_aes_key_bundle = base64_decode($data->aes_key);
+                               $ciphertext = base64_decode($data->encrypted_magic_envelope);
+
+                               $outer_key_bundle = '';
+                               @openssl_private_decrypt($encrypted_aes_key_bundle, $outer_key_bundle, $privKey);
+                               $j_outer_key_bundle = json_decode($outer_key_bundle);
+
+                               if (!is_object($j_outer_key_bundle)) {
+                                       Logger::info('Unable to decode outer key bundle', ['outer_key_bundle' => $outer_key_bundle]);
+                                       throw new \RuntimeException('Unable to decode outer key bundle');
+                               }
+
+                               if (!isset($j_outer_key_bundle->iv) || !isset($j_outer_key_bundle->key)) {
+                                       Logger::info('Missing keys "iv" and/or "key" from outer Salmon', ['j_outer_key_bundle' => $j_outer_key_bundle]);
+                                       throw new \RuntimeException('Missing keys "iv" and/or "key" from outer Salmon');
+                               }
 
-                       if (!is_object($j_outer_key_bundle)) {
+                               $outer_iv = base64_decode($j_outer_key_bundle->iv);
+                               $outer_key = base64_decode($j_outer_key_bundle->key);
+
+                               $xml = self::aesDecrypt($outer_key, $outer_iv, $ciphertext);
+                       } catch (\Throwable $e) {
                                Logger::notice('Outer Salmon did not verify. Discarding.');
                                if ($no_exit) {
                                        return false;
@@ -238,11 +259,6 @@ class Diaspora
                                        throw new \Friendica\Network\HTTPException\BadRequestException();
                                }
                        }
-
-                       $outer_iv = base64_decode($j_outer_key_bundle->iv);
-                       $outer_key = base64_decode($j_outer_key_bundle->key);
-
-                       $xml = self::aesDecrypt($outer_key, $outer_iv, $ciphertext);
                } else {
                        $xml = $raw;
                }
@@ -2364,13 +2380,13 @@ class Diaspora
 
                $datarray = self::setDirection($datarray, $direction);
 
-               $datarray['body'] = DI::contentItem()->createSharedPostByGuid($root_guid, $importer['uid'], $original_person['url']);
-               $datarray['body'] = Diaspora::replacePeopleGuid($datarray['body'], $datarray['author-link']);
-
-               /// @todo Copy tag data from original post
-               Tag::storeFromBody($datarray['uri-id'], $datarray['body']);
+               $datarray['quote-uri-id'] = self::getQuoteUriId($root_guid, $importer['uid'], $original_person['url']);
+               if (empty($datarray['quote-uri-id'])) {
+                       return false;
+               }
 
-               $datarray['plink'] = self::plink($author, $guid);
+               $datarray['body']    = '';
+               $datarray['plink']   = self::plink($author, $guid);
                $datarray['private'] = (($public == 'false') ? Item::PRIVATE : Item::PUBLIC);
                $datarray['changed'] = $datarray['created'] = $datarray['edited'] = $created_at;
 
@@ -2401,6 +2417,25 @@ class Diaspora
                }
        }
 
+       private static function getQuoteUriId(string $guid, int $uid, string $host): int
+       {
+               $shared_item = Post::selectFirst(['uri-id'], ['guid' => $guid, 'uid' => [$uid, 0], 'private' => [Item::PUBLIC, Item::UNLISTED]]);
+
+               if (!DBA::isResult($shared_item) && !empty($host) && Diaspora::storeByGuid($guid, $host, true)) {
+                       Logger::debug('Fetched post', ['guid' => $guid, 'host' => $host, 'uid' => $uid]);
+                       $shared_item = Post::selectFirst(['uri-id'], ['guid' => $guid, 'uid' => [$uid, 0], 'private' => [Item::PUBLIC, Item::UNLISTED]]);
+               } elseif (DBA::isResult($shared_item)) {
+                       Logger::debug('Found existing post', ['guid' => $guid, 'host' => $host, 'uid' => $uid]);
+               }
+
+               if (!DBA::isResult($shared_item)) {
+                       Logger::notice('Post does not exist.', ['guid' => $guid, 'host' => $host, 'uid' => $uid]);
+                       return 0;
+               }
+
+               return $shared_item['uri-id'];
+       }
+
        /**
         * Processes retractions
         *
@@ -3171,37 +3206,30 @@ class Diaspora
        }
 
        /**
-        * Checks a message body if it is a reshare
+        * Fetch reshare details
         *
         * @param array $item The message body that is to be check
         *
-        * @return array Reshare details or "false" if no reshare
+        * @return array Reshare details (empty if the item is no reshare)
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       public static function isReshare(array $item): array
+       public static function getReshareDetails(array $item): array
        {
-               $reshared = Item::getShareArray($item);
+               $reshared = DI::contentItem()->getSharedPost($item, ['guid', 'network', 'author-addr']);
                if (empty($reshared)) {
                        return [];
                }
 
                // Skip if it isn't a pure repeated messages or not a real reshare
-               if (!empty($reshared['comment']) || empty($reshared['guid'])) {
+               if (!empty($reshared['comment']) || !in_array($reshared['post']['network'], [Protocol::DFRN, Protocol::DIASPORA])) {
                        return [];
                }
 
-               $condition = ['guid' => $reshared['guid'], 'network' => [Protocol::DFRN, Protocol::DIASPORA]];
-               $item = Post::selectFirst(['author-addr'], $condition);
-               if (DBA::isResult($item)) {
-                       return [
-                               'root_handle' => strtolower($item['author-addr']),
-                               'root_guid'   => $reshared['guid']
-                       ];
-               }
-
-               // We are resharing something that isn't a DFRN or Diaspora post.
-               return [];
+               return [
+                       'root_handle' => strtolower($reshared['post']['author-addr']),
+                       'root_guid'   => $reshared['post']['guid'],
+               ];
        }
 
        /**
@@ -3298,7 +3326,7 @@ class Diaspora
                $edited = DateTimeFormat::utc($item['edited'] ?? $item['created'], DateTimeFormat::ATOM);
 
                // Detect a share element and do a reshare
-               if (($item['private'] != Item::PRIVATE) && ($ret = self::isReshare($item))) {
+               if (($item['private'] != Item::PRIVATE) && ($ret = self::getReshareDetails($item))) {
                        $message = [
                                'author'                => $myaddr,
                                'guid'                  => $item['guid'],
@@ -3312,7 +3340,7 @@ class Diaspora
                        $type = 'reshare';
                } else {
                        $title = $item['title'];
-                       $body = Post\Media::addAttachmentsToBody($item['uri-id'], $item['body']);
+                       $body  = Post\Media::addAttachmentsToBody($item['uri-id'], DI::contentItem()->addSharedPost($item));
 
                        // Fetch the title from an attached link - if there is one
                        if (empty($item['title']) && DI::pConfig()->get($owner['uid'], 'system', 'attach_link_title')) {
@@ -3322,11 +3350,6 @@ class Diaspora
                                }
                        }
 
-                       // @todo Check if this is obsolete and if we are still using different owners. (Possibly a fragment from the forum functionality)
-                       if ($item['author-link'] != $item['owner-link']) {
-                               $body = DI::contentItem()->createSharedBlockByArray($item);
-                       }
-
                        // convert to markdown
                        $body = html_entity_decode(BBCode::toMarkdown($body));
 
@@ -3534,7 +3557,7 @@ class Diaspora
                        $thread_parent_item = Post::selectFirst(['guid', 'author-id', 'author-link', 'gravity'], ['uri' => $item['thr-parent'], 'uid' => $item['uid']]);
                }
 
-               $body = Post\Media::addAttachmentsToBody($item['uri-id'], $item['body']);
+               $body = Post\Media::addAttachmentsToBody($item['uri-id'], DI::contentItem()->addSharedPost($item));
 
                // The replied to autor mention is prepended for clarity if:
                // - Item replied isn't yours
@@ -3630,7 +3653,7 @@ class Diaspora
 
                Logger::info('Got relayable data ' . $type . ' for item ' . $item['guid'] . ' (' . $item['id'] . ')');
 
-               $msg = json_decode($item['signed_text'], true);
+               $msg = json_decode($item['signed_text'] ?? '', true);
 
                $message = [];
                if (is_array($msg)) {
@@ -4029,25 +4052,21 @@ class Diaspora
 
        public static function performReshare(int $UriId, int $uid): int
        {
-               $post = DI::contentItem()->createSharedPostByUriId($UriId, $uid);
-               if (empty($post)) {
-                       return 0;
-               }
-
                $owner  = User::getOwnerDataById($uid);
                $author = Contact::getPublicIdByUserId($uid);
 
                $item = [
-                       'uid'        => $uid,
-                       'verb'       => Activity::POST,
-                       'contact-id' => $owner['id'],
-                       'author-id'  => $author,
-                       'owner-id'   => $author,
-                       'body'       => $post,
-                       'allow_cid'  => $owner['allow_cid'] ?? '',
-                       'allow_gid'  => $owner['allow_gid']?? '',
-                       'deny_cid'   => $owner['deny_cid'] ?? '',
-                       'deny_gid'   => $owner['deny_gid'] ?? '',
+                       'uid'          => $uid,
+                       'verb'         => Activity::POST,
+                       'contact-id'   => $owner['id'],
+                       'author-id'    => $author,
+                       'owner-id'     => $author,
+                       'body'         => '',
+                       'quote-uri-id' => $UriId,
+                       'allow_cid'    => $owner['allow_cid'] ?? '',
+                       'allow_gid'    => $owner['allow_gid']?? '',
+                       'deny_cid'     => $owner['deny_cid'] ?? '',
+                       'deny_gid'     => $owner['deny_gid'] ?? '',
                ];
 
                if (!empty($item['allow_cid'] . $item['allow_gid'] . $item['deny_cid'] . $item['deny_gid'])) {