]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Diaspora.php
Merge remote-tracking branch 'upstream/develop' into term2tag
[friendica.git] / src / Protocol / Diaspora.php
index 2dda8db5b5b9d96947cb0369467065f0944bd95c..a6369a2bfa43c5ca67a4d4d8fa9f7d5894f13776 100644 (file)
@@ -1,11 +1,22 @@
 <?php
 /**
- * @file src/Protocol/diaspora.php
- * The implementation of the diaspora protocol
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  *
- * The new protocol is described here: http://diaspora.github.io/diaspora_federation/index.html
- * This implementation here interprets the old and the new protocol and sends the new one.
- * In the future we will remove most stuff from "validPosting" and interpret only the new protocol.
  */
 
 namespace Friendica\Protocol;
@@ -14,7 +25,6 @@ use Friendica\Content\Feature;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\Markdown;
 use Friendica\Core\Cache\Duration;
-use Friendica\Core\Config;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
@@ -25,9 +35,11 @@ use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\GContact;
 use Friendica\Model\Item;
+use Friendica\Model\ItemURI;
 use Friendica\Model\ItemDeliveryData;
 use Friendica\Model\Mail;
 use Friendica\Model\Profile;
+use Friendica\Model\Term;
 use Friendica\Model\User;
 use Friendica\Network\Probe;
 use Friendica\Util\Crypto;
@@ -41,7 +53,6 @@ use SimpleXMLElement;
 
 /**
  * This class contain functions to create and send Diaspora XML files
- *
  */
 class Diaspora
 {
@@ -91,7 +102,7 @@ class Diaspora
                $serverlist = [];
 
                // Fetching relay servers
-               $serverdata = Config::get("system", "relay_server");
+               $serverdata = DI::config()->get("system", "relay_server");
 
                if (!empty($serverdata)) {
                        $servers = explode(",", $serverdata);
@@ -100,7 +111,7 @@ class Diaspora
                        }
                }
 
-               if (Config::get("system", "relay_directly", false)) {
+               if (DI::config()->get("system", "relay_directly", false)) {
                        // We distribute our stuff based on the parent to ensure that the thread will be complete
                        $parent = Item::selectFirst(['parent'], ['id' => $item_id]);
                        if (!DBA::isResult($parent)) {
@@ -114,7 +125,7 @@ class Diaspora
                        }
 
                        // All tags of the current post
-                       $condition = ['otype' => TERM_OBJ_POST, 'type' => TERM_HASHTAG, 'oid' => $parent['parent']];
+                       $condition = ['otype' => Term::OBJECT_TYPE_POST, 'type' => Term::HASHTAG, 'oid' => $parent['parent']];
                        $tags = DBA::select('term', ['term'], $condition);
                        $taglist = [];
                        while ($tag = DBA::fetch($tags)) {
@@ -409,7 +420,7 @@ class Diaspora
        }
 
        /**
-        * @brief: Decodes incoming Diaspora message in the new format
+        * Decodes incoming Diaspora message in the new format
         *
         * @param string  $raw      raw post message
         * @param string  $privKey   The private key of the importer
@@ -515,7 +526,7 @@ class Diaspora
        }
 
        /**
-        * @brief: Decodes incoming Diaspora message in the deprecated format
+        * Decodes incoming Diaspora message in the deprecated format
         *
         * @param string $xml      urldecoded Diaspora salmon
         * @param string $privKey  The private key of the importer
@@ -668,7 +679,7 @@ class Diaspora
         */
        public static function dispatchPublic($msg)
        {
-               $enabled = intval(Config::get("system", "diaspora_enabled"));
+               $enabled = intval(DI::config()->get("system", "diaspora_enabled"));
                if (!$enabled) {
                        Logger::log("diaspora is disabled");
                        return false;
@@ -1467,7 +1478,8 @@ class Diaspora
        public static function fetchByURL($url, $uid = 0)
        {
                // Check for Diaspora (and Friendica) typical paths
-               if (!preg_match("=(https?://.+)/(?:posts|display)/([a-zA-Z0-9-_@.:%]+[a-zA-Z0-9])=i", $url, $matches)) {
+               if (!preg_match("=(https?://.+)/(?:posts|display|objects)/([a-zA-Z0-9-_@.:%]+[a-zA-Z0-9])=i", $url, $matches)) {
+                       Logger::info('Invalid url', ['url' => $url]);
                        return false;
                }
 
@@ -1475,15 +1487,20 @@ class Diaspora
 
                $item = Item::selectFirst(['id'], ['guid' => $guid, 'uid' => $uid]);
                if (DBA::isResult($item)) {
+                       Logger::info('Found', ['id' => $item['id']]);
                        return $item['id'];
                }
 
-               self::storeByGuid($guid, $matches[1], $uid);
+               Logger::info('Fetch GUID from origin', ['guid' => $guid, 'server' => $matches[1]]);
+               $ret = self::storeByGuid($guid, $matches[1], $uid);
+               Logger::info('Result', ['ret' => $ret]);
 
                $item = Item::selectFirst(['id'], ['guid' => $guid, 'uid' => $uid]);
                if (DBA::isResult($item)) {
+                       Logger::info('Found', ['id' => $item['id']]);
                        return $item['id'];
                } else {
+                       Logger::info('Not found', ['guid' => $guid, 'uid' => $uid]);
                        return false;
                }
        }
@@ -1566,9 +1583,9 @@ class Diaspora
         *
         * @return bool is it a hubzilla server?
         */
-       public static function isRedmatrix($url)
+       private static function isHubzilla($url)
        {
-               return(strstr($url, "/channel/"));
+               return(strstr($url, '/channel/'));
        }
 
        /**
@@ -1585,28 +1602,54 @@ class Diaspora
        private static function plink($addr, $guid, $parent_guid = '')
        {
                $contact = Contact::getDetailsByAddr($addr);
+               if (empty($contact)) {
+                       Logger::info('No contact data for address', ['addr' => $addr]);
+                       return '';
+               }
 
-               // Fallback
-               if (!$contact) {
-                       if ($parent_guid != '') {
-                               return "https://" . substr($addr, strpos($addr, "@") + 1) . "/posts/" . $parent_guid . "#" . $guid;
-                       } else {
-                               return "https://" . substr($addr, strpos($addr, "@") + 1) . "/posts/" . $guid;
+               if (empty($contact['baseurl'])) {
+                       $contact['baseurl'] = 'https://' . substr($addr, strpos($addr, '@') + 1);
+                       Logger::info('Create baseurl from address', ['baseurl' => $contact['baseurl'], 'url' => $contact['url']]);
+               }
+
+               $platform = '';
+               $gserver = DBA::selectFirst('gserver', ['platform'], ['nurl' => Strings::normaliseLink($contact['baseurl'])]);
+               if (!empty($gserver['platform'])) {
+                       $platform = strtolower($gserver['platform']);
+                       Logger::info('Detected platform', ['platform' => $platform, 'url' => $contact['url']]);
+               }
+
+               if (!in_array($platform, ['diaspora', 'friendica', 'hubzilla', 'socialhome'])) {
+                       if (self::isHubzilla($contact['url'])) {
+                               Logger::info('Detected unknown platform as Hubzilla', ['platform' => $platform, 'url' => $contact['url']]);
+                               $platform = 'hubzilla';
+                       } elseif ($contact['network'] == Protocol::DFRN) {
+                               Logger::info('Detected unknown platform as Friendica', ['platform' => $platform, 'url' => $contact['url']]);
+                               $platform = 'friendica';
                        }
                }
 
-               if ($contact["network"] == Protocol::DFRN) {
-                       return str_replace("/profile/" . $contact["nick"] . "/", "/display/" . $guid, $contact["url"] . "/");
+               if ($platform == 'friendica') {
+                       return str_replace('/profile/' . $contact['nick'] . '/', '/display/' . $guid, $contact['url'] . '/');
+               }
+
+               if ($platform == 'hubzilla') {
+                       return $contact['baseurl'] . '/item/' . $guid;
+               }
+
+               if ($platform == 'socialhome') {
+                       return $contact['baseurl'] . '/content/' . $guid;
                }
 
-               if (self::isRedmatrix($contact["url"])) {
-                       return $contact["url"] . "/?mid=" . $guid;
+               if ($platform != 'diaspora') {
+                       Logger::info('Unknown platform', ['platform' => $platform, 'url' => $contact['url']]);
+                       return '';
                }
 
                if ($parent_guid != '') {
-                       return "https://" . substr($addr, strpos($addr, "@") + 1) . "/posts/" . $parent_guid . "#" . $guid;
+                       return $contact['baseurl'] . '/posts/' . $parent_guid . '#' . $guid;
                } else {
-                       return "https://" . substr($addr, strpos($addr, "@") + 1) . "/posts/" . $guid;
+                       return $contact['baseurl'] . '/posts/' . $guid;
                }
        }
 
@@ -1766,6 +1809,66 @@ class Diaspora
                return false;
        }
 
+       private static function storeMentions(int $uriid, string $text)
+       {
+               preg_match_all('/([@!]){(?:([^}]+?); ?)?([^} ]+)}/', $text, $matches, PREG_SET_ORDER);
+               if (empty($matches)) {
+                       return;
+               }
+
+               /*
+                * Matching values for the preg match
+                * [1] = mention type (@ or !)
+                * [2] = name (optional)
+                * [3] = profile URL
+                */
+
+               foreach ($matches as $match) {
+                       if (empty($match)) {
+                               continue;
+                       }
+
+                       $person = self::personByHandle($match[3]);
+                       if (empty($person)) {
+                               continue;
+                       }
+
+                       $fields = ['uri-id' => $uriid, 'name' => substr($person['addr'], 0, 64), 'url' => $person['url']];
+
+                       if ($match[1] == Term::TAG_CHARACTER[Term::MENTION]) {
+                               $fields['type'] = Term::MENTION;
+                       } elseif ($match[1] == Term::TAG_CHARACTER[Term::EXCLUSIVE_MENTION]) {
+                               $fields['type'] = Term::EXCLUSIVE_MENTION;
+                       } elseif ($match[1] == Term::TAG_CHARACTER[Term::IMPLICIT_MENTION]) {
+                               $fields['type'] = Term::IMPLICIT_MENTION;
+                       } else {
+                               continue;
+                       }
+
+                       DBA::insert('tag', $fields, true);
+                       Logger::info('Stored mention', ['uriid' => $uriid, 'match' => $match, 'fields' => $fields]);
+               }
+       }
+
+       private static function storeTags(int $uriid, string $body)
+       {
+               $tags = BBCode::getTags($body);
+               if (empty($tags)) {
+                       return;
+               }
+
+               foreach ($tags as $tag) {
+                       if ((substr($tag, 0, 1) != Term::TAG_CHARACTER[Term::HASHTAG]) || (strlen($tag) <= 1)) {
+                               Logger::info('Skip tag', ['uriid' => $uriid, 'tag' => $tag]);
+                               continue;
+                       }
+
+                       $fields = ['uri-id' => $uriid, 'name' => substr($tag, 1, 64), 'type' => Term::HASHTAG];
+                       DBA::insert('tag', $fields, true);
+                       Logger::info('Stored tag', ['uriid' => $uriid, 'tag' => $tag, 'fields' => $fields]);
+               }
+       }
+
        /**
         * Processes an incoming comment
         *
@@ -1836,6 +1939,7 @@ class Diaspora
 
                $datarray["guid"] = $guid;
                $datarray["uri"] = self::getUriFromGuid($author, $guid);
+               $datarray['uri-id'] = ItemURI::insert(['uri' => $datarray['uri'], 'guid' => $datarray['guid']]);
 
                $datarray["verb"] = Activity::POST;
                $datarray["gravity"] = GRAVITY_COMMENT;
@@ -1854,11 +1958,14 @@ class Diaspora
                $datarray["changed"] = $datarray["created"] = $datarray["edited"] = $created_at;
 
                $datarray["plink"] = self::plink($author, $guid, $parent_item['guid']);
-
+       
                $body = Markdown::toBBCode($text);
 
                $datarray["body"] = self::replacePeopleGuid($body, $person["url"]);
 
+               self::storeMentions($datarray['uri-id'], $text);
+               self::storeTags($datarray['uri-id'], $datarray["body"]);
+
                self::fetchGuid($datarray);
 
                // If we are the origin of the parent we store the original data.
@@ -2202,7 +2309,7 @@ class Diaspora
                        return false;
                }
 
-               $item = Item::selectFirst(['id'], ['guid' => $parent_guid, 'origin' => true, 'private' => false]);
+               $item = Item::selectFirst(['id'], ['guid' => $parent_guid, 'origin' => true, 'private' => [Item::PUBLIC, Item::UNLISTED]]);
                if (!DBA::isResult($item)) {
                        Logger::log('Item not found, no origin or private: '.$parent_guid);
                        return false;
@@ -2290,7 +2397,6 @@ class Diaspora
                $name = XML::unescape($data->first_name).((strlen($data->last_name)) ? " ".XML::unescape($data->last_name) : "");
                $image_url = XML::unescape($data->image_url);
                $birthday = XML::unescape($data->birthday);
-               $gender = XML::unescape($data->gender);
                $about = Markdown::toBBCode(XML::unescape($data->bio));
                $location = Markdown::toBBCode(XML::unescape($data->location));
                $searchable = (XML::unescape($data->searchable) == "true");
@@ -2338,8 +2444,7 @@ class Diaspora
                }
 
                $fields = ['name' => $name, 'location' => $location,
-                       'name-date' => DateTimeFormat::utcNow(),
-                       'about' => $about, 'gender' => $gender,
+                       'name-date' => DateTimeFormat::utcNow(), 'about' => $about,
                        'addr' => $author, 'nick' => $nick, 'keywords' => $keywords,
                        'unsearchable' => !$searchable, 'sensitive' => $nsfw];
 
@@ -2353,7 +2458,7 @@ class Diaspora
 
                $gcontact = ["url" => $contact["url"], "network" => Protocol::DIASPORA, "generation" => 2,
                                        "photo" => $image_url, "name" => $name, "location" => $location,
-                                       "about" => $about, "birthday" => $birthday, "gender" => $gender,
+                                       "about" => $about, "birthday" => $birthday,
                                        "addr" => $author, "nick" => $nick, "keywords" => $keywords,
                                        "hide" => !$searchable, "nsfw" => $nsfw];
 
@@ -2516,7 +2621,7 @@ class Diaspora
                // Do we already have this item?
                $fields = ['body', 'title', 'attach', 'tag', 'app', 'created', 'object-type', 'uri', 'guid',
                        'author-name', 'author-link', 'author-avatar'];
-               $condition = ['guid' => $guid, 'visible' => true, 'deleted' => false, 'private' => false];
+               $condition = ['guid' => $guid, 'visible' => true, 'deleted' => false, 'private' => [Item::PUBLIC, Item::UNLISTED]];
                $item = Item::selectFirst($fields, $condition);
 
                if (DBA::isResult($item)) {
@@ -2560,7 +2665,7 @@ class Diaspora
                        if ($stored) {
                                $fields = ['body', 'title', 'attach', 'tag', 'app', 'created', 'object-type', 'uri', 'guid',
                                        'author-name', 'author-link', 'author-avatar'];
-                               $condition = ['guid' => $guid, 'visible' => true, 'deleted' => false, 'private' => false];
+                               $condition = ['guid' => $guid, 'visible' => true, 'deleted' => false, 'private' => [Item::PUBLIC, Item::UNLISTED]];
                                $item = Item::selectFirst($fields, $condition);
 
                                if (DBA::isResult($item)) {
@@ -2603,6 +2708,7 @@ class Diaspora
 
                $datarray['guid'] = $parent['guid'] . '-' . $guid;
                $datarray['uri'] = self::getUriFromGuid($author, $datarray['guid']);
+
                $datarray['parent-uri'] = $parent['uri'];
 
                $datarray['verb'] = $datarray['body'] = Activity::ANNOUNCE;
@@ -2677,6 +2783,7 @@ class Diaspora
 
                $datarray["guid"] = $guid;
                $datarray["uri"] = $datarray["parent-uri"] = self::getUriFromGuid($author, $guid);
+               $datarray['uri-id'] = ItemURI::insert(['uri' => $datarray['uri'], 'guid' => $datarray['guid']]);
 
                $datarray["verb"] = Activity::POST;
                $datarray["gravity"] = GRAVITY_PARENT;
@@ -2684,6 +2791,8 @@ class Diaspora
                $datarray["protocol"] = Conversation::PARCEL_DIASPORA;
                $datarray["source"] = $xml;
 
+               /// @todo Copy tag data from original post
+
                $prefix = share_header(
                        $original_item["author-name"],
                        $original_item["author-link"],
@@ -2704,7 +2813,7 @@ class Diaspora
                $datarray["app"]  = $original_item["app"];
 
                $datarray["plink"] = self::plink($author, $guid);
-               $datarray["private"] = (($public == "false") ? 1 : 0);
+               $datarray["private"] = (($public == "false") ? Item::PRIVATE : Item::PUBLIC);
                $datarray["changed"] = $datarray["created"] = $datarray["edited"] = $created_at;
 
                $datarray["object-type"] = $original_item["object-type"];
@@ -2787,7 +2896,7 @@ class Diaspora
                                continue;
                        }
 
-                       Item::delete(['id' => $item['id']]);
+                       Item::markForDeletion(['id' => $item['id']]);
 
                        Logger::log("Deleted target ".$target_guid." (".$item["id"].") from user ".$item["uid"]." parent: ".$item["parent"], Logger::DEBUG);
                }
@@ -2894,7 +3003,7 @@ class Diaspora
                        $datarray["object-type"] = Activity\ObjectType::NOTE;
 
                        // Add OEmbed and other information to the body
-                       if (!self::isRedmatrix($contact["url"])) {
+                       if (!self::isHubzilla($contact["url"])) {
                                $body = add_page_info_to_body($body, false, true);
                        }
                }
@@ -2920,6 +3029,7 @@ class Diaspora
 
                $datarray["guid"] = $guid;
                $datarray["uri"] = $datarray["parent-uri"] = self::getUriFromGuid($author, $guid);
+               $datarray['uri-id'] = ItemURI::insert(['uri' => $datarray['uri'], 'guid' => $datarray['guid']]);
 
                $datarray["verb"] = Activity::POST;
                $datarray["gravity"] = GRAVITY_PARENT;
@@ -2929,12 +3039,15 @@ class Diaspora
 
                $datarray["body"] = self::replacePeopleGuid($body, $contact["url"]);
 
+               self::storeMentions($datarray['uri-id'], $text);
+               self::storeTags($datarray['uri-id'], $datarray["body"]);
+
                if ($provider_display_name != "") {
                        $datarray["app"] = $provider_display_name;
                }
 
                $datarray["plink"] = self::plink($author, $guid);
-               $datarray["private"] = (($public == "false") ? 1 : 0);
+               $datarray["private"] = (($public == "false") ? Item::PRIVATE : Item::PUBLIC);
                $datarray["changed"] = $datarray["created"] = $datarray["edited"] = $created_at;
 
                if (isset($address["address"])) {
@@ -3133,7 +3246,7 @@ class Diaspora
         */
        private static function transmit(array $owner, array $contact, $envelope, $public_batch, $guid = "")
        {
-               $enabled = intval(Config::get("system", "diaspora_enabled"));
+               $enabled = intval(DI::config()->get("system", "diaspora_enabled"));
                if (!$enabled) {
                        return 200;
                }
@@ -3160,7 +3273,7 @@ class Diaspora
 
                Logger::log("transmit: ".$logid."-".$guid." ".$dest_url);
 
-               if (!intval(Config::get("system", "diaspora_test"))) {
+               if (!intval(DI::config()->get("system", "diaspora_test"))) {
                        $content_type = (($public_batch) ? "application/magic-envelope+xml" : "application/json");
 
                        $postResult = Network::post($dest_url."/", $envelope, ["Content-Type: ".$content_type]);
@@ -3238,7 +3351,7 @@ class Diaspora
        private static function sendParticipation(array $contact, array $item)
        {
                // Don't send notifications for private postings
-               if ($item['private']) {
+               if ($item['private'] == Item::PRIVATE) {
                        return;
                }
 
@@ -3529,12 +3642,12 @@ class Diaspora
 
                $myaddr = self::myHandle($owner);
 
-               $public = ($item["private"] ? "false" : "true");
+               $public = ($item["private"] == Item::PRIVATE ? "false" : "true");
                $created = DateTimeFormat::utc($item['received'], DateTimeFormat::ATOM);
                $edited = DateTimeFormat::utc($item["edited"] ?? $item["created"], DateTimeFormat::ATOM);
 
                // Detect a share element and do a reshare
-               if (!$item['private'] && ($ret = self::isReshare($item["body"]))) {
+               if (($item['private'] != Item::PRIVATE) && ($ret = self::isReshare($item["body"]))) {
                        $message = ["author" => $myaddr,
                                        "guid" => $item["guid"],
                                        "created_at" => $created,
@@ -3772,7 +3885,7 @@ class Diaspora
                if (
                        $item['author-id'] != $thread_parent_item['author-id']
                        && (empty($item['uid']) || !Feature::isEnabled($item['uid'], 'explicit_mentions'))
-                       && !Config::get('system', 'disable_implicit_mentions')
+                       && !DI::config()->get('system', 'disable_implicit_mentions')
                ) {
                        $body = self::prependParentAuthorMention($body, $thread_parent_item['author-link']);
                }
@@ -3903,30 +4016,24 @@ class Diaspora
 
                Logger::log("Got relayable data ".$type." for item ".$item["guid"]." (".$item["id"].")", Logger::DEBUG);
 
-               // Old way - is used by the internal Friendica functions
-               /// @todo Change all signatur storing functions to the new format
-               if ($item['signed_text'] && $item['signature'] && $item['signer']) {
-                       $message = self::messageFromSignature($item);
-               } else {// New way
-                       $msg = json_decode($item['signed_text'], true);
-
-                       $message = [];
-                       if (is_array($msg)) {
-                               foreach ($msg as $field => $data) {
-                                       if (!$item["deleted"]) {
-                                               if ($field == "diaspora_handle") {
-                                                       $field = "author";
-                                               }
-                                               if ($field == "target_type") {
-                                                       $field = "parent_type";
-                                               }
-                                       }
+               $msg = json_decode($item['signed_text'], true);
 
-                                       $message[$field] = $data;
+               $message = [];
+               if (is_array($msg)) {
+                       foreach ($msg as $field => $data) {
+                               if (!$item["deleted"]) {
+                                       if ($field == "diaspora_handle") {
+                                               $field = "author";
+                                       }
+                                       if ($field == "target_type") {
+                                               $field = "parent_type";
+                                       }
                                }
-                       } else {
-                               Logger::log("Signature text for item ".$item["guid"]." (".$item["id"].") couldn't be extracted: ".$item['signed_text'], Logger::DEBUG);
+
+                               $message[$field] = $data;
                        }
+               } else {
+                       Logger::log("Signature text for item ".$item["guid"]." (".$item["id"].") couldn't be extracted: ".$item['signed_text'], Logger::DEBUG);
                }
 
                $message["parent_author_signature"] = self::signature($owner, $message);
@@ -4093,7 +4200,7 @@ class Diaspora
                        FROM `profile`
                        INNER JOIN `user` ON `profile`.`uid` = `user`.`uid`
                        INNER JOIN `contact` ON `profile`.`uid` = `contact`.`uid`
-                       WHERE `user`.`uid` = %d AND `profile`.`is-default` AND `contact`.`self` LIMIT 1",
+                       WHERE `user`.`uid` = %d AND `contact`.`self` LIMIT 1",
                        intval($uid)
                );
 
@@ -4111,7 +4218,7 @@ class Diaspora
                $large = DI::baseUrl().'/photo/custom/300/'.$profile['uid'].'.jpg';
                $medium = DI::baseUrl().'/photo/custom/100/'.$profile['uid'].'.jpg';
                $small = DI::baseUrl().'/photo/custom/50/'  .$profile['uid'].'.jpg';
-               $searchable = (($profile['publish'] && $profile['net-publish']) ? 'true' : 'false');
+               $searchable = ($profile['net-publish'] ? 'true' : 'false');
 
                $dob = null;
                $about = null;
@@ -4128,8 +4235,7 @@ class Diaspora
                                $dob = DateTimeFormat::utc($year . '-' . $month . '-'. $day, 'Y-m-d');
                        }
 
-                       $about = $profile['about'];
-                       $about = strip_tags(BBCode::convert($about));
+                       $about = BBCode::toMarkdown($profile['about']);
 
                        $location = Profile::formatLocation($profile);
                        $tags = '';
@@ -4155,7 +4261,6 @@ class Diaspora
                                "image_url_medium" => $medium,
                                "image_url_small" => $small,
                                "birthday" => $dob,
-                               "gender" => $profile['gender'],
                                "bio" => $about,
                                "location" => $location,
                                "searchable" => $searchable,