]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Diaspora.php
Merge pull request #8629 from annando/item-insert
[friendica.git] / src / Protocol / Diaspora.php
index fe6c328d9f6da63f76ea147606cced05f4c48ae1..dd1f678d58945a22f3651f9001ab04f845b7af3a 100644 (file)
@@ -36,11 +36,9 @@ use Friendica\Model\Conversation;
 use Friendica\Model\GContact;
 use Friendica\Model\Item;
 use Friendica\Model\ItemURI;
-use Friendica\Model\ItemDeliveryData;
 use Friendica\Model\Mail;
-use Friendica\Model\Profile;
+use Friendica\Model\Post;
 use Friendica\Model\Tag;
-use Friendica\Model\Term;
 use Friendica\Model\User;
 use Friendica\Network\Probe;
 use Friendica\Util\Crypto;
@@ -114,7 +112,7 @@ class Diaspora
 
                if (DI::config()->get("system", "relay_directly", false)) {
                        // We distribute our stuff based on the parent to ensure that the thread will be complete
-                       $parent = Item::selectFirst(['parent'], ['id' => $item_id]);
+                       $parent = Item::selectFirst(['uri-id'], ['id' => $item_id]);
                        if (!DBA::isResult($parent)) {
                                return;
                        }
@@ -124,14 +122,15 @@ class Diaspora
                        while ($server = DBA::fetch($servers)) {
                                $serverlist[$server['url']] = $server['url'];
                        }
+                       DBA::close($servers);
 
                        // All tags of the current post
-                       $condition = ['otype' => Term::OBJECT_TYPE_POST, 'type' => Term::HASHTAG, 'oid' => $parent['parent']];
-                       $tags = DBA::select('term', ['term'], $condition);
+                       $tags = DBA::select('tag-view', ['name'], ['uri-id' => $parent['uri-id'], 'type' => Tag::HASHTAG]);
                        $taglist = [];
                        while ($tag = DBA::fetch($tags)) {
-                               $taglist[] = $tag['term'];
+                               $taglist[] = $tag['name'];
                        }
+                       DBA::close($tags);
 
                        // All servers who wants content with this tag
                        $tagserverlist = [];
@@ -140,6 +139,7 @@ class Diaspora
                                while ($server = DBA::fetch($tagserver)) {
                                        $tagserverlist[] = $server['gserver-id'];
                                }
+                               DBA::close($tagserver);
                        }
 
                        // All adresses with the given id
@@ -148,6 +148,7 @@ class Diaspora
                                while ($server = DBA::fetch($servers)) {
                                        $serverlist[$server['url']] = $server['url'];
                                }
+                               DBA::close($servers);
                        }
                }
 
@@ -251,19 +252,28 @@ class Diaspora
         * One of the parameters is a contact array.
         * This is done to avoid duplicates.
         *
-        * @param integer $thread   The id of the thread
-        * @param array   $contacts The previously fetched contacts
+        * @param array $item     Item that is about to be delivered
+        * @param array $contacts The previously fetched contacts
         *
         * @return array of relay servers
         * @throws \Exception
         */
-       public static function participantsForThread($thread, array $contacts)
+       public static function participantsForThread(array $item, array $contacts)
        {
-               $participation = DBA::select('participation-view', [], ['iid' => $thread]);
-
-               while ($contact = DBA::fetch($participation)) { 
-                       if (empty($contact['protocol'])) {
-                               $contact['protocol'] = $contact['network'];
+               if (!in_array($item['private'], [Item::PUBLIC, Item::UNLISTED]) || in_array($item["verb"], [Activity::FOLLOW, Activity::TAG])) {
+                       Logger::info('Item is private or a participation request. It will not be relayed', ['guid' => $item['guid'], 'private' => $item['private'], 'verb' => $item['verb']]);
+                       return $contacts;
+               }
+
+               $items = Item::select(['author-id', 'author-link', 'parent-author-link', 'parent-guid', 'guid'],
+                       ['parent' => $item['parent'], 'gravity' => [GRAVITY_COMMENT, GRAVITY_ACTIVITY]]);
+               while ($item = DBA::fetch($items)) {
+                       $contact = DBA::selectFirst('contact', ['id', 'url', 'name', 'protocol', 'batch', 'network'],
+                               ['id' => $item['author-id']]);
+                       if (!DBA::isResult($contact) || empty($contact['batch']) ||
+                               ($contact['network'] != Protocol::DIASPORA) ||
+                               Strings::compareLink($item['parent-author-link'], $item['author-link'])) {
+                               continue;
                        }
 
                        $exists = false;
@@ -274,11 +284,11 @@ class Diaspora
                        }
 
                        if (!$exists) {
+                               Logger::info('Add participant to receiver list', ['parent' => $item['parent-guid'], 'item' => $item['guid'], 'participant' => $contact['url']]);
                                $contacts[] = $contact;
                        }
                }
-
-               DBA::close($participation);
+               DBA::close($items);
 
                return $contacts;
        }
@@ -325,7 +335,7 @@ class Diaspora
         */
        private static function verifyMagicEnvelope($envelope)
        {
-               $basedom = XML::parseString($envelope);
+               $basedom = XML::parseString($envelope, true);
 
                if (!is_object($basedom)) {
                        Logger::log("Envelope is no XML file");
@@ -451,7 +461,7 @@ class Diaspora
                        $xml = $raw;
                }
 
-               $basedom = XML::parseString($xml);
+               $basedom = XML::parseString($xml, true);
 
                if (!is_object($basedom)) {
                        Logger::log('Received data does not seem to be an XML. Discarding. '.$xml);
@@ -1720,6 +1730,7 @@ class Diaspora
                while ($contact = DBA::fetch($contacts)) {
                        Contact::remove($contact["id"]);
                }
+               DBA::close($contacts);
 
                DBA::delete('gcontact', ['addr' => $author]);
 
@@ -2249,57 +2260,88 @@ class Diaspora
         * @param array  $importer Array of the importer user
         * @param object $data     The message object
         *
-        * @return bool always true
+        * @return bool success
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
        private static function receiveParticipation(array $importer, $data)
        {
                $author = strtolower(Strings::escapeTags(XML::unescape($data->author)));
+               $guid = Strings::escapeTags(XML::unescape($data->guid));
                $parent_guid = Strings::escapeTags(XML::unescape($data->parent_guid));
 
-               $contact_id = Contact::getIdForURL($author);
-               if (!$contact_id) {
-                       Logger::log('Contact not found: '.$author);
+               $contact = self::allowedContactByHandle($importer, $author, true);
+               if (!$contact) {
                        return false;
                }
 
-               $person = self::personByHandle($author);
-               if (!is_array($person)) {
-                       Logger::log("Person not found: ".$author);
-                       return false;
+               if (self::messageExists($importer["uid"], $guid)) {
+                       return true;
                }
 
-               $item = Item::selectFirst(['id'], ['guid' => $parent_guid, 'origin' => true, 'private' => [Item::PUBLIC, Item::UNLISTED]]);
-               if (!DBA::isResult($item)) {
-                       Logger::log('Item not found, no origin or private: '.$parent_guid);
+               $parent_item = self::parentItem($importer["uid"], $parent_guid, $author, $contact);
+               if (!$parent_item) {
                        return false;
                }
 
-               $author_parts = explode('@', $author);
-               if (isset($author_parts[1])) {
-                       $server = $author_parts[1];
-               } else {
-                       // Should never happen
-                       $server = $author;
+               if (!$parent_item['origin']) {
+                       Logger::info('Not our origin. Participation is ignored', ['parent_guid' => $parent_guid, 'guid' => $guid, 'author' => $author]);
                }
 
-               Logger::log('Received participation for ID: '.$item['id'].' - Contact: '.$contact_id.' - Server: '.$server, Logger::DEBUG);
+               if (!in_array($parent_item['private'], [Item::PUBLIC, Item::UNLISTED])) {
+                       Logger::info('Item is not public, participation is ignored', ['parent_guid' => $parent_guid, 'guid' => $guid, 'author' => $author]);
+                       return false;
+               }
 
-               if (!DBA::exists('participation', ['iid' => $item['id'], 'server' => $server])) {
-                       DBA::insert('participation', ['iid' => $item['id'], 'cid' => $contact_id, 'fid' => $person['id'], 'server' => $server]);
+               $person = self::personByHandle($author);
+               if (!is_array($person)) {
+                       Logger::log("Person not found: ".$author);
+                       return false;
                }
 
+               $author_contact = self::authorContactByUrl($contact, $person, $importer["uid"]);
+
+               // Store participation
+               $datarray = [];
+
+               $datarray["protocol"] = Conversation::PARCEL_DIASPORA;
+
+               $datarray["uid"] = $importer["uid"];
+               $datarray["contact-id"] = $author_contact["cid"];
+               $datarray["network"]  = $author_contact["network"];
+
+               $datarray["owner-link"] = $datarray["author-link"] = $person["url"];
+               $datarray["owner-id"] = $datarray["author-id"] = Contact::getIdForURL($person["url"], 0);
+
+               $datarray["guid"] = $guid;
+               $datarray["uri"] = self::getUriFromGuid($author, $guid);
+
+               $datarray["verb"] = Activity::FOLLOW;
+               $datarray["gravity"] = GRAVITY_ACTIVITY;
+               $datarray["parent-uri"] = $parent_item["uri"];
+
+               $datarray["object-type"] = Activity\ObjectType::NOTE;
+
+               $datarray["body"] = Activity::FOLLOW;
+
+               // Diaspora doesn't provide a date for a participation
+               $datarray["changed"] = $datarray["created"] = $datarray["edited"] = DateTimeFormat::utcNow();
+
+               $message_id = Item::insert($datarray);
+
+               Logger::info('Participation stored', ['id' => $message_id, 'guid' => $guid, 'parent_guid' => $parent_guid, 'author' => $author]);
+
                // Send all existing comments and likes to the requesting server
-               $comments = Item::select(['id', 'parent', 'verb', 'self'], ['parent' => $item['id']]);
+               $comments = Item::select(['id', 'uri-id', 'parent', 'verb'], ['parent' => $parent_item['id'], 'gravity' => [GRAVITY_COMMENT, GRAVITY_ACTIVITY]]);
                while ($comment = Item::fetch($comments)) {
-                       if ($comment['id'] == $comment['parent']) {
+                       if (in_array($comment["verb"], [Activity::FOLLOW, Activity::TAG])) {
+                               Logger::info('participation messages are not relayed', ['item' => $comment['id']]);
                                continue;
                        }
 
-                       Logger::info('Deliver participation', ['item' => $comment['id'], 'contact' => $contact_id]);
-                       if (Worker::add(PRIORITY_HIGH, 'Delivery', Delivery::POST, $comment['id'], $contact_id)) {
-                               ItemDeliveryData::incrementQueueCount($comment['id'], 1);
+                       Logger::info('Deliver participation', ['item' => $comment['id'], 'contact' => $author_contact["cid"]]);
+                       if (Worker::add(PRIORITY_HIGH, 'Delivery', Delivery::POST, $comment['id'], $author_contact["cid"])) {
+                               Post\DeliveryData::incrementQueueCount($comment['uri-id'], 1);
                        }
                }
                DBA::close($comments);
@@ -2580,7 +2622,7 @@ class Diaspora
                }
 
                // Do we already have this item?
-               $fields = ['body', 'title', 'attach', 'tag', 'app', 'created', 'object-type', 'uri', 'guid',
+               $fields = ['body', 'title', 'attach', 'app', 'created', 'object-type', 'uri', 'guid',
                        'author-name', 'author-link', 'author-avatar'];
                $condition = ['guid' => $guid, 'visible' => true, 'deleted' => false, 'private' => [Item::PUBLIC, Item::UNLISTED]];
                $item = Item::selectFirst($fields, $condition);
@@ -2624,7 +2666,7 @@ class Diaspora
                        }
 
                        if ($stored) {
-                               $fields = ['body', 'title', 'attach', 'tag', 'app', 'created', 'object-type', 'uri', 'guid',
+                               $fields = ['body', 'title', 'attach', 'app', 'created', 'object-type', 'uri', 'guid',
                                        'author-name', 'author-link', 'author-avatar'];
                                $condition = ['guid' => $guid, 'visible' => true, 'deleted' => false, 'private' => [Item::PUBLIC, Item::UNLISTED]];
                                $item = Item::selectFirst($fields, $condition);
@@ -2770,7 +2812,6 @@ class Diaspora
 
                Tag::storeFromBody($datarray['uri-id'], $datarray["body"]);
 
-               $datarray["tag"] = $original_item["tag"];
                $datarray["attach"] = $original_item["attach"];
                $datarray["app"]  = $original_item["app"];