]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Feed.php
Avoid local network communication / invalid url requests
[friendica.git] / src / Protocol / Feed.php
index 048e9974ce4f10bf2969951dc361185a14be4d31..0abd49c4627e7e234114f152066ee5f103086332 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
 namespace Friendica\Protocol;
 
 use DOMDocument;
+use DOMElement;
 use DOMXPath;
+use Friendica\App;
 use Friendica\Content\PageInfo;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
 use Friendica\Core\Cache\Enum\Duration;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
+use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Contact;
+use Friendica\Model\Conversation;
 use Friendica\Model\Item;
 use Friendica\Model\Post;
 use Friendica\Model\Tag;
 use Friendica\Model\User;
+use Friendica\Network\HTTPException;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 use Friendica\Util\ParseUrl;
@@ -59,14 +64,14 @@ class Feed
         * @return array Returns the header and the first item in dry run mode
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       public static function import($xml, array $importer = [], array $contact = [])
+       public static function import(string $xml, array $importer = [], array $contact = []): array
        {
                $dryRun = empty($importer) && empty($contact);
 
                if ($dryRun) {
                        Logger::info("Test Atom/RSS feed");
                } else {
-                       Logger::info("Import Atom/RSS feed '" . $contact["name"] . "' (Contact " . $contact["id"] . ") for user " . $importer["uid"]);
+                       Logger::info('Import Atom/RSS feed "' . $contact['name'] . '" (Contact ' . $contact['id'] . ') for user ' . $importer['uid']);
                }
 
                $xml = trim($xml);
@@ -88,158 +93,183 @@ class Feed
                @$doc->loadXML($xml);
                $xpath = new DOMXPath($doc);
                $xpath->registerNamespace('atom', ActivityNamespace::ATOM1);
-               $xpath->registerNamespace('dc', "http://purl.org/dc/elements/1.1/");
-               $xpath->registerNamespace('content', "http://purl.org/rss/1.0/modules/content/");
-               $xpath->registerNamespace('rdf', "http://www.w3.org/1999/02/22-rdf-syntax-ns#");
-               $xpath->registerNamespace('rss', "http://purl.org/rss/1.0/");
-               $xpath->registerNamespace('media', "http://search.yahoo.com/mrss/");
+               $xpath->registerNamespace('dc', 'http://purl.org/dc/elements/1.1/');
+               $xpath->registerNamespace('content', 'http://purl.org/rss/1.0/modules/content/');
+               $xpath->registerNamespace('rdf', 'http://www.w3.org/1999/02/22-rdf-syntax-ns#');
+               $xpath->registerNamespace('rss', 'http://purl.org/rss/1.0/');
+               $xpath->registerNamespace('media', 'http://search.yahoo.com/mrss/');
                $xpath->registerNamespace('poco', ActivityNamespace::POCO);
 
                $author = [];
                $entries = null;
+               $protocol = Conversation::PARCEL_UNKNOWN;
 
                // Is it RDF?
                if ($xpath->query('/rdf:RDF/rss:channel')->length > 0) {
-                       $author["author-link"] = XML::getFirstNodeValue($xpath, '/rdf:RDF/rss:channel/rss:link/text()');
-                       $author["author-name"] = XML::getFirstNodeValue($xpath, '/rdf:RDF/rss:channel/rss:title/text()');
+                       $protocol = Conversation::PARCEL_RDF;
+                       $author['author-link'] = XML::getFirstNodeValue($xpath, '/rdf:RDF/rss:channel/rss:link/text()');
+                       $author['author-name'] = XML::getFirstNodeValue($xpath, '/rdf:RDF/rss:channel/rss:title/text()');
 
-                       if (empty($author["author-name"])) {
-                               $author["author-name"] = XML::getFirstNodeValue($xpath, '/rdf:RDF/rss:channel/rss:description/text()');
+                       if (empty($author['author-name'])) {
+                               $author['author-name'] = XML::getFirstNodeValue($xpath, '/rdf:RDF/rss:channel/rss:description/text()');
                        }
                        $entries = $xpath->query('/rdf:RDF/rss:item');
                }
 
                // Is it Atom?
                if ($xpath->query('/atom:feed')->length > 0) {
+                       $protocol = Conversation::PARCEL_ATOM;
                        $alternate = XML::getFirstAttributes($xpath, "atom:link[@rel='alternate']");
                        if (is_object($alternate)) {
                                foreach ($alternate as $attribute) {
-                                       if ($attribute->name == "href") {
-                                               $author["author-link"] = $attribute->textContent;
+                                       if ($attribute->name == 'href') {
+                                               $author['author-link'] = $attribute->textContent;
                                        }
                                }
                        }
 
-                       if (empty($author["author-link"])) {
+                       if (empty($author['author-link'])) {
                                $self = XML::getFirstAttributes($xpath, "atom:link[@rel='self']");
                                if (is_object($self)) {
                                        foreach ($self as $attribute) {
-                                               if ($attribute->name == "href") {
-                                                       $author["author-link"] = $attribute->textContent;
+                                               if ($attribute->name == 'href') {
+                                                       $author['author-link'] = $attribute->textContent;
                                                }
                                        }
                                }
                        }
 
-                       if (empty($author["author-link"])) {
-                               $author["author-link"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:id/text()');
+                       if (empty($author['author-link'])) {
+                               $author['author-link'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:id/text()');
                        }
-                       $author["author-avatar"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:logo/text()');
+                       $author['author-avatar'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:logo/text()');
 
-                       $author["author-name"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:title/text()');
+                       $author['author-name'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:title/text()');
 
-                       if (empty($author["author-name"])) {
-                               $author["author-name"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:subtitle/text()');
+                       if (empty($author['author-name'])) {
+                               $author['author-name'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:subtitle/text()');
                        }
 
-                       if (empty($author["author-name"])) {
-                               $author["author-name"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:author/atom:name/text()');
+                       if (empty($author['author-name'])) {
+                               $author['author-name'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:author/atom:name/text()');
                        }
 
                        $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:displayName/text()');
-                       if ($value != "") {
-                               $author["author-name"] = $value;
+                       if ($value != '') {
+                               $author['author-name'] = $value;
                        }
 
                        if ($dryRun) {
-                               $author["author-id"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:author/atom:id/text()');
+                               $author['author-id'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:author/atom:id/text()');
 
                                // See https://tools.ietf.org/html/rfc4287#section-3.2.2
                                $value = XML::getFirstNodeValue($xpath, 'atom:author/atom:uri/text()');
-                               if ($value != "") {
-                                       $author["author-link"] = $value;
+                               if ($value != '') {
+                                       $author['author-link'] = $value;
                                }
 
                                $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:preferredUsername/text()');
-                               if ($value != "") {
-                                       $author["author-nick"] = $value;
+                               if ($value != '') {
+                                       $author['author-nick'] = $value;
                                }
 
                                $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:address/poco:formatted/text()');
-                               if ($value != "") {
-                                       $author["author-location"] = $value;
+                               if ($value != '') {
+                                       $author['author-location'] = $value;
                                }
 
                                $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:note/text()');
-                               if ($value != "") {
-                                       $author["author-about"] = $value;
+                               if ($value != '') {
+                                       $author['author-about'] = $value;
                                }
 
                                $avatar = XML::getFirstAttributes($xpath, "atom:author/atom:link[@rel='avatar']");
                                if (is_object($avatar)) {
                                        foreach ($avatar as $attribute) {
-                                               if ($attribute->name == "href") {
-                                                       $author["author-avatar"] = $attribute->textContent;
+                                               if ($attribute->name == 'href') {
+                                                       $author['author-avatar'] = $attribute->textContent;
                                                }
                                        }
                                }
                        }
 
-                       $author["edited"] = $author["created"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:updated/text()');
+                       $author['edited'] = $author['created'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:updated/text()');
 
-                       $author["app"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:generator/text()');
+                       $author['app'] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:generator/text()');
 
                        $entries = $xpath->query('/atom:feed/atom:entry');
                }
 
                // Is it RSS?
                if ($xpath->query('/rss/channel')->length > 0) {
-                       $author["author-link"] = XML::getFirstNodeValue($xpath, '/rss/channel/link/text()');
+                       $protocol = Conversation::PARCEL_RSS;
+                       $author['author-link'] = XML::getFirstNodeValue($xpath, '/rss/channel/link/text()');
 
-                       $author["author-name"] = XML::getFirstNodeValue($xpath, '/rss/channel/title/text()');
-                       $author["author-avatar"] = XML::getFirstNodeValue($xpath, '/rss/channel/image/url/text()');
+                       $author['author-name'] = XML::getFirstNodeValue($xpath, '/rss/channel/title/text()');
 
-                       if (empty($author["author-name"])) {
-                               $author["author-name"] = XML::getFirstNodeValue($xpath, '/rss/channel/copyright/text()');
+                       if (empty($author['author-name'])) {
+                               $author['author-name'] = XML::getFirstNodeValue($xpath, '/rss/channel/copyright/text()');
                        }
 
-                       if (empty($author["author-name"])) {
-                               $author["author-name"] = XML::getFirstNodeValue($xpath, '/rss/channel/description/text()');
+                       if (empty($author['author-name'])) {
+                               $author['author-name'] = XML::getFirstNodeValue($xpath, '/rss/channel/description/text()');
                        }
 
-                       $author["edited"] = $author["created"] = XML::getFirstNodeValue($xpath, '/rss/channel/pubDate/text()');
+                       $author['author-avatar'] = XML::getFirstNodeValue($xpath, '/rss/channel/image/url/text()');
 
-                       $author["app"] = XML::getFirstNodeValue($xpath, '/rss/channel/generator/text()');
+                       if (empty($author['author-avatar'])) {
+                               $avatar = XML::getFirstAttributes($xpath, '/rss/channel/itunes:image');
+                               if (is_object($avatar)) {
+                                       foreach ($avatar as $attribute) {
+                                               if ($attribute->name == 'href') {
+                                                       $author['author-avatar'] = $attribute->textContent;
+                                               }
+                                       }
+                               }
+                       }
+
+                       $author['author-about'] = HTML::toBBCode(XML::getFirstNodeValue($xpath, '/rss/channel/description/text()'), $basepath);
+
+                       if (empty($author['author-about'])) {
+                               $author['author-about'] = XML::getFirstNodeValue($xpath, '/rss/channel/itunes:summary/text()');
+                       }
+
+                       $author['edited'] = $author['created'] = XML::getFirstNodeValue($xpath, '/rss/channel/pubDate/text()');
+
+                       $author['app'] = XML::getFirstNodeValue($xpath, '/rss/channel/generator/text()');
 
                        $entries = $xpath->query('/rss/channel/item');
                }
 
                if (!$dryRun) {
-                       $author["author-link"] = $contact["url"];
+                       $author['author-link'] = $contact['url'];
 
-                       if (empty($author["author-name"])) {
-                               $author["author-name"] = $contact["name"];
+                       if (empty($author['author-name'])) {
+                               $author['author-name'] = $contact['name'];
                        }
 
-                       $author["author-avatar"] = $contact["thumb"];
+                       $author['author-avatar'] = $contact['thumb'];
 
-                       $author["owner-link"] = $contact["url"];
-                       $author["owner-name"] = $contact["name"];
-                       $author["owner-avatar"] = $contact["thumb"];
+                       $author['owner-link'] = $contact['url'];
+                       $author['owner-name'] = $contact['name'];
+                       $author['owner-avatar'] = $contact['thumb'];
                }
 
-               $header = [];
-               $header["uid"] = $importer["uid"] ?? 0;
-               $header["network"] = Protocol::FEED;
-               $header["wall"] = 0;
-               $header["origin"] = 0;
-               $header["gravity"] = GRAVITY_PARENT;
-               $header["private"] = Item::PUBLIC;
-               $header["verb"] = Activity::POST;
-               $header["object-type"] = Activity\ObjectType::NOTE;
-               $header["post-type"] = Item::PT_ARTICLE;
-
-               $header["contact-id"] = $contact["id"] ?? 0;
+               $header = [
+                       'uid'         => $importer['uid'] ?? 0,
+                       'network'     => Protocol::FEED,
+                       'wall'        => 0,
+                       'origin'      => 0,
+                       'gravity'     => Item::GRAVITY_PARENT,
+                       'private'     => Item::PUBLIC,
+                       'verb'        => Activity::POST,
+                       'object-type' => Activity\ObjectType::NOTE,
+                       'post-type'   => Item::PT_ARTICLE,
+                       'contact-id'  => $contact['id'] ?? 0,
+               ];
+
+               $datarray['protocol'] = $protocol;
+               $datarray['direction'] = Conversation::PULL;
 
                if (!is_object($entries)) {
                        Logger::info("There are no entries in this feed.");
@@ -266,56 +296,64 @@ class Feed
 
                        $alternate = XML::getFirstAttributes($xpath, "atom:link[@rel='alternate']", $entry);
                        if (!is_object($alternate)) {
-                               $alternate = XML::getFirstAttributes($xpath, "atom:link", $entry);
+                               $alternate = XML::getFirstAttributes($xpath, 'atom:link', $entry);
                        }
                        if (is_object($alternate)) {
                                foreach ($alternate as $attribute) {
-                                       if ($attribute->name == "href") {
-                                               $item["plink"] = $attribute->textContent;
+                                       if ($attribute->name == 'href') {
+                                               $item['plink'] = $attribute->textContent;
                                        }
                                }
                        }
 
-                       if (empty($item["plink"])) {
-                               $item["plink"] = XML::getFirstNodeValue($xpath, 'link/text()', $entry);
+                       if (empty($item['plink'])) {
+                               $item['plink'] = XML::getFirstNodeValue($xpath, 'link/text()', $entry);
                        }
 
-                       if (empty($item["plink"])) {
-                               $item["plink"] = XML::getFirstNodeValue($xpath, 'rss:link/text()', $entry);
+                       if (empty($item['plink'])) {
+                               $item['plink'] = XML::getFirstNodeValue($xpath, 'rss:link/text()', $entry);
                        }
 
-                       $item["uri"] = XML::getFirstNodeValue($xpath, 'atom:id/text()', $entry);
+                       // Add the base path if missing
+                       $item['plink'] = Network::addBasePath($item['plink'], $basepath);
 
-                       if (empty($item["uri"])) {
-                               $item["uri"] = XML::getFirstNodeValue($xpath, 'guid/text()', $entry);
-                       }
+                       $item['uri'] = XML::getFirstNodeValue($xpath, 'atom:id/text()', $entry);
+
+                       $guid = XML::getFirstNodeValue($xpath, 'guid/text()', $entry);
+                       if (!empty($guid)) {
+                               $item['uri'] = $guid;
 
-                       if (empty($item["uri"])) {
-                               $item["uri"] = $item["plink"];
+                               // Don't use the GUID value directly but instead use it as a basis for the GUID
+                               $item['guid'] = Item::guidFromUri($guid, parse_url($guid, PHP_URL_HOST) ?? parse_url($item['plink'], PHP_URL_HOST));
                        }
 
-                       // Add the base path if missing
-                       $item["uri"] = Network::addBasePath($item["uri"], $basepath);
-                       $item["plink"] = Network::addBasePath($item["plink"], $basepath);
+                       if (empty($item['uri'])) {
+                               $item['uri'] = $item['plink'];
+                       }
 
-                       $orig_plink = $item["plink"];
+                       $orig_plink = $item['plink'];
 
                        try {
-                               $item["plink"] = DI::httpClient()->finalUrl($item["plink"]);
+                               $item['plink'] = DI::httpClient()->finalUrl($item['plink']);
                        } catch (TransferException $exception) {
-                               Logger::notice('Item URL couldn\'t get expanded', ['url' => $item["plink"], 'exception' => $exception]);
+                               Logger::notice('Item URL couldn\'t get expanded', ['url' => $item['plink'], 'exception' => $exception]);
                        }
 
-                       $item["title"] = XML::getFirstNodeValue($xpath, 'atom:title/text()', $entry);
+                       $item['title'] = XML::getFirstNodeValue($xpath, 'atom:title/text()', $entry);
+
+                       if (empty($item['title'])) {
+                               $item['title'] = XML::getFirstNodeValue($xpath, 'title/text()', $entry);
+                       }
 
-                       if (empty($item["title"])) {
-                               $item["title"] = XML::getFirstNodeValue($xpath, 'title/text()', $entry);
+                       if (empty($item['title'])) {
+                               $item['title'] = XML::getFirstNodeValue($xpath, 'rss:title/text()', $entry);
                        }
-                       if (empty($item["title"])) {
-                               $item["title"] = XML::getFirstNodeValue($xpath, 'rss:title/text()', $entry);
+
+                       if (empty($item['title'])) {
+                               $item['title'] = XML::getFirstNodeValue($xpath, 'itunes:title/text()', $entry);
                        }
 
-                       $item["title"] = html_entity_decode($item["title"], ENT_QUOTES, 'UTF-8');
+                       $item['title'] = html_entity_decode($item['title'], ENT_QUOTES, 'UTF-8');
 
                        $published = XML::getFirstNodeValue($xpath, 'atom:published/text()', $entry);
 
@@ -337,22 +375,22 @@ class Feed
                                $published = $updated;
                        }
 
-                       if ($published != "") {
-                               $item["created"] = $published;
+                       if ($published != '') {
+                               $item['created'] = trim($published);
                        }
 
-                       if ($updated != "") {
-                               $item["edited"] = $updated;
+                       if ($updated != '') {
+                               $item['edited'] = trim($updated);
                        }
 
                        if (!$dryRun) {
                                $condition = ["`uid` = ? AND `uri` = ? AND `network` IN (?, ?)",
-                                       $importer["uid"], $item["uri"], Protocol::FEED, Protocol::DFRN];
+                                       $importer['uid'], $item['uri'], Protocol::FEED, Protocol::DFRN];
                                $previous = Post::selectFirst(['id', 'created'], $condition);
                                if (DBA::isResult($previous)) {
                                        // Use the creation date when the post had been stored. It can happen this date changes in the feed.
                                        $creation_dates[] = $previous['created'];
-                                       Logger::info("Item with uri " . $item["uri"] . " for user " . $importer["uid"] . " already existed under id " . $previous["id"]);
+                                       Logger::info('Item with URI ' . $item['uri'] . ' for user ' . $importer['uid'] . ' already existed under id ' . $previous['id']);
                                        continue;
                                }
                                $creation_dates[] = DateTimeFormat::utc($item['created']);
@@ -368,14 +406,14 @@ class Feed
                                $creator = XML::getFirstNodeValue($xpath, 'dc:creator/text()', $entry);
                        }
 
-                       if ($creator != "") {
-                               $item["author-name"] = $creator;
+                       if ($creator != '') {
+                               $item['author-name'] = $creator;
                        }
 
                        $creator = XML::getFirstNodeValue($xpath, 'dc:creator/text()', $entry);
 
-                       if ($creator != "") {
-                               $item["author-name"] = $creator;
+                       if ($creator != '') {
+                               $item['author-name'] = $creator;
                        }
 
                        /// @TODO ?
@@ -386,22 +424,22 @@ class Feed
 
                        $enclosures = $xpath->query("enclosure|atom:link[@rel='enclosure']", $entry);
                        foreach ($enclosures as $enclosure) {
-                               $href = "";
+                               $href = '';
                                $length = null;
                                $type = null;
 
                                foreach ($enclosure->attributes as $attribute) {
-                                       if (in_array($attribute->name, ["url", "href"])) {
+                                       if (in_array($attribute->name, ['url', 'href'])) {
                                                $href = $attribute->textContent;
-                                       } elseif ($attribute->name == "length") {
+                                       } elseif ($attribute->name == 'length') {
                                                $length = (int)$attribute->textContent;
-                                       } elseif ($attribute->name == "type") {
+                                       } elseif ($attribute->name == 'type') {
                                                $type = $attribute->textContent;
                                        }
                                }
 
                                if (!empty($href)) {
-                                       $attachment = ['type' => Post\Media::UNKNOWN, 'url' => $href, 'mimetype' => $type, 'size' => $length];
+                                       $attachment = ['uri-id' => -1, 'type' => Post\Media::UNKNOWN, 'url' => $href, 'mimetype' => $type, 'size' => $length];
 
                                        $attachment = Post\Media::fetchAdditionalData($attachment);
 
@@ -415,7 +453,7 @@ class Feed
                        }
 
                        $taglist = [];
-                       $categories = $xpath->query("category", $entry);
+                       $categories = $xpath->query('category', $entry);
                        foreach ($categories as $category) {
                                $taglist[] = $category->nodeValue;
                        }
@@ -443,20 +481,21 @@ class Feed
 
                        // remove the content of the title if it is identically to the body
                        // This helps with auto generated titles e.g. from tumblr
-                       if (self::titleIsBody($item["title"], $body)) {
-                               $item["title"] = "";
+                       if (self::titleIsBody($item['title'], $body)) {
+                               $item['title'] = '';
                        }
-                       $item["body"] = HTML::toBBCode($body, $basepath);
+                       $item['body'] = HTML::toBBCode($body, $basepath);
 
                        // Remove tracking pixels
-                       $item["body"] = preg_replace("/\[img=1x1\]([^\[\]]*)\[\/img\]/Usi", '', $item["body"]);
+                       $item['body'] = preg_replace("/\[img=1x1\]([^\[\]]*)\[\/img\]/Usi", '', $item['body']);
 
-                       if (($item["body"] == '') && ($item["title"] != '')) {
-                               $item["body"] = $item["title"];
-                               $item["title"] = '';
+                       if (($item['body'] == '') && ($item['title'] != '')) {
+                               $item['body'] = $item['title'];
+                               $item['title'] = '';
                        }
 
                        if ($dryRun) {
+                               $item['attachments'] = $attachments;
                                $items[] = $item;
                                break;
                        } elseif (!Item::isValid($item)) {
@@ -468,36 +507,36 @@ class Feed
                        }
 
                        $preview = '';
-                       if (!empty($contact["fetch_further_information"]) && ($contact["fetch_further_information"] < 3)) {
+                       if (!empty($contact['fetch_further_information']) && ($contact['fetch_further_information'] < 3)) {
                                // Handle enclosures and treat them as preview picture
                                foreach ($attachments as $attachment) {
-                                       if ($attachment["mimetype"] == "image/jpeg") {
-                                               $preview = $attachment["url"];
+                                       if ($attachment['mimetype'] == 'image/jpeg') {
+                                               $preview = $attachment['url'];
                                        }
                                }
 
                                // Remove a possible link to the item itself
-                               $item["body"] = str_replace($item["plink"], '', $item["body"]);
-                               $item["body"] = trim(preg_replace('/\[url\=\](\w+.*?)\[\/url\]/i', '', $item["body"]));
+                               $item['body'] = str_replace($item['plink'], '', $item['body']);
+                               $item['body'] = trim(preg_replace('/\[url\=\](\w+.*?)\[\/url\]/i', '', $item['body']));
 
                                // Replace the content when the title is longer than the body
-                               $replace = (strlen($item["title"]) > strlen($item["body"]));
+                               $replace = (strlen($item['title']) > strlen($item['body']));
 
                                // Replace it, when there is an image in the body
-                               if (strstr($item["body"], '[/img]')) {
+                               if (strstr($item['body'], '[/img]')) {
                                        $replace = true;
                                }
 
                                // Replace it, when there is a link in the body
-                               if (strstr($item["body"], '[/url]')) {
+                               if (strstr($item['body'], '[/url]')) {
                                        $replace = true;
                                }
 
-                               $saved_body = $item["body"];
-                               $saved_title = $item["title"];
+                               $saved_body = $item['body'];
+                               $saved_title = $item['title'];
 
                                if ($replace) {
-                                       $item["body"] = trim($item["title"]);
+                                       $item['body'] = trim($item['title']);
                                }
 
                                $data = ParseUrl::getSiteinfoCached($item['plink']);
@@ -512,13 +551,13 @@ class Feed
                                        }
                                }
 
-                               $data = PageInfo::queryUrl($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_denylist"] ?? '');
+                               $data = PageInfo::queryUrl($item['plink'], false, $preview, ($contact['fetch_further_information'] == 2), $contact['ffi_keyword_denylist'] ?? '');
 
                                if (!empty($data)) {
                                        // Take the data that was provided by the feed if the query is empty
                                        if (($data['type'] == 'link') && empty($data['title']) && empty($data['text'])) {
                                                $data['title'] = $saved_title;
-                                               $item["body"] = $saved_body;
+                                               $item['body'] = $saved_body;
                                        }
 
                                        $data_text = strip_tags(trim($data['text'] ?? ''));
@@ -529,10 +568,10 @@ class Feed
                                        }
 
                                        // We always strip the title since it will be added in the page information
-                                       $item["title"] = "";
-                                       $item["body"] = $item["body"] . "\n" . PageInfo::getFooterFromData($data, false);
-                                       $taglist = $contact["fetch_further_information"] == 2 ? PageInfo::getTagsFromUrl($item["plink"], $preview, $contact["ffi_keyword_denylist"] ?? '') : [];
-                                       $item["object-type"] = Activity\ObjectType::BOOKMARK;
+                                       $item['title'] = '';
+                                       $item['body'] = $item['body'] . "\n" . PageInfo::getFooterFromData($data, false);
+                                       $taglist = $contact['fetch_further_information'] == 2 ? PageInfo::getTagsFromUrl($item['plink'], $preview, $contact['ffi_keyword_denylist'] ?? '') : [];
+                                       $item['object-type'] = Activity\ObjectType::BOOKMARK;
                                        $attachments = [];
 
                                        foreach (['audio', 'video'] as $elementname) {
@@ -560,21 +599,21 @@ class Feed
                                }
                        } else {
                                if (!empty($summary)) {
-                                       $item["body"] = '[abstract]' . HTML::toBBCode($summary, $basepath) . "[/abstract]\n" . $item["body"];
+                                       $item['body'] = '[abstract]' . HTML::toBBCode($summary, $basepath) . "[/abstract]\n" . $item['body'];
                                }
 
-                               if (!empty($contact["fetch_further_information"]) && ($contact["fetch_further_information"] == 3)) {
+                               if (!empty($contact['fetch_further_information']) && ($contact['fetch_further_information'] == 3)) {
                                        if (empty($taglist)) {
-                                               $taglist = PageInfo::getTagsFromUrl($item["plink"], $preview, $contact["ffi_keyword_denylist"] ?? '');
+                                               $taglist = PageInfo::getTagsFromUrl($item['plink'], $preview, $contact['ffi_keyword_denylist'] ?? '');
                                        }
-                                       $item["body"] .= "\n" . self::tagToString($taglist);
+                                       $item['body'] .= "\n" . self::tagToString($taglist);
                                } else {
                                        $taglist = [];
                                }
 
                                // Add the link to the original feed entry if not present in feed
-                               if (($item['plink'] != '') && !strstr($item["body"], $item['plink']) && !in_array($item['plink'], array_column($attachments, 'url'))) {
-                                       $item["body"] .= "[hr][url]" . $item['plink'] . "[/url]";
+                               if (($item['plink'] != '') && !strstr($item['body'], $item['plink']) && !in_array($item['plink'], array_column($attachments, 'url'))) {
+                                       $item['body'] .= '[hr][url]' . $item['plink'] . '[/url]';
                                }
                        }
 
@@ -585,21 +624,22 @@ class Feed
                        Logger::info('Stored feed', ['item' => $item]);
 
                        $notify = Item::isRemoteSelf($contact, $item);
+                       $item['wall'] = (bool)$notify;
 
-                       // Distributed items should have a well formatted URI.
-                       // Additionally we have to avoid conflicts with identical URI between imported feeds and these items.
+                       // Distributed items should have a well-formatted URI.
+                       // Additionally, we have to avoid conflicts with identical URI between imported feeds and these items.
                        if ($notify) {
                                $item['guid'] = Item::guidFromUri($orig_plink, DI::baseUrl()->getHostname());
-                               $item['uri'] = Item::newURI($item['uid'], $item['guid']);
+                               $item['uri'] = Item::newURI($item['guid']);
                                unset($item['thr-parent']);
                                unset($item['parent-uri']);
 
                                // Set the delivery priority for "remote self" to "medium"
-                               $notify = PRIORITY_MEDIUM;
+                               $notify = Worker::PRIORITY_MEDIUM;
                        }
 
                        $condition = ['uid' => $item['uid'], 'uri' => $item['uri']];
-                       if (!Post::exists($condition) && !Post\Delayed::exists($item["uri"], $item['uid'])) {
+                       if (!Post::exists($condition) && !Post\Delayed::exists($item['uri'], $item['uid'])) {
                                if (!$notify) {
                                        Post\Delayed::publish($item, $notify, $taglist, $attachments);
                                } else {
@@ -607,7 +647,7 @@ class Feed
                                                'taglist' => $taglist, 'attachments' => $attachments];
                                }
                        } else {
-                               Logger::info('Post already created or exists in the delayed posts queue', ['uid' => $item['uid'], 'uri' => $item["uri"]]);
+                               Logger::info('Post already created or exists in the delayed posts queue', ['uid' => $item['uid'], 'uri' => $item['uri']]);
                        }
                }
 
@@ -650,13 +690,13 @@ class Feed
                        self::adjustPollFrequency($contact, $creation_dates);
                }
 
-               return ["header" => $author, "items" => $items];
+               return ['header' => $author, 'items' => $items];
        }
 
        /**
         * Automatically adjust the poll frequency according to the post frequency
         *
-        * @param array $contact
+        * @param array $contact Contact array
         * @param array $creation_dates
         * @return void
         */
@@ -776,7 +816,7 @@ class Feed
         * @param array $contact
         * @return int Poll interval in minutes
         */
-       public static function getPollInterval(array $contact)
+       public static function getPollInterval(array $contact): int
        {
                if (in_array($contact['network'], [Protocol::MAIL, Protocol::FEED])) {
                        $ratings = [0, 3, 7, 8, 9, 10];
@@ -825,39 +865,39 @@ class Feed
         * @param array $tags
         * @return string tag string
         */
-       private static function tagToString(array $tags)
+       private static function tagToString(array $tags): string
        {
                $tagstr = '';
 
                foreach ($tags as $tag) {
-                       if ($tagstr != "") {
-                               $tagstr .= ", ";
+                       if ($tagstr != '') {
+                               $tagstr .= ', ';
                        }
 
-                       $tagstr .= "#[url=" . DI::baseUrl() . "/search?tag=" . urlencode($tag) . "]" . $tag . "[/url]";
+                       $tagstr .= '#[url=' . DI::baseUrl() . '/search?tag=' . urlencode($tag) . ']' . $tag . '[/url]';
                }
 
                return $tagstr;
        }
 
-       private static function titleIsBody($title, $body)
+       private static function titleIsBody(string $title, string $body): bool
        {
                $title = strip_tags($title);
                $title = trim($title);
                $title = html_entity_decode($title, ENT_QUOTES, 'UTF-8');
-               $title = str_replace(["\n", "\r", "\t", " "], ["", "", "", ""], $title);
+               $title = str_replace(["\n", "\r", "\t", " "], ['', '', '', ''], $title);
 
                $body = strip_tags($body);
                $body = trim($body);
                $body = html_entity_decode($body, ENT_QUOTES, 'UTF-8');
-               $body = str_replace(["\n", "\r", "\t", " "], ["", "", "", ""], $body);
+               $body = str_replace(["\n", "\r", "\t", " "], ['', '', '', ''], $body);
 
                if (strlen($title) < strlen($body)) {
                        $body = substr($body, 0, strlen($title));
                }
 
-               if (($title != $body) && (substr($title, -3) == "...")) {
-                       $pos = strrpos($title, "...");
+               if (($title != $body) && (substr($title, -3) == '...')) {
+                       $pos = strrpos($title, '...');
                        if ($pos > 0) {
                                $title = substr($title, 0, $pos);
                                $body = substr($body, 0, $pos);
@@ -877,28 +917,23 @@ class Feed
         * Updates the provided last_update parameter if the result comes from the
         * cache or it is empty
         *
-        * @param string  $owner_nick  Nickname of the feed owner
+        * @param array   $owner       owner-view record of the feed owner
         * @param string  $last_update Date of the last update
         * @param integer $max_items   Number of maximum items to fetch
         * @param string  $filter      Feed items filter (activity, posts or comments)
         * @param boolean $nocache     Wether to bypass caching
         *
         * @return string Atom feed
-        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       public static function atom($owner_nick, $last_update, $max_items = 300, $filter = 'activity', $nocache = false)
+       public static function atom(array $owner, string $last_update, int $max_items = 300, string $filter = 'activity', bool $nocache = false)
        {
                $stamp = microtime(true);
 
-               $owner = User::getOwnerDataByNick($owner_nick);
-               if (!$owner) {
-                       return;
-               }
+               $cachekey = 'feed:feed:' . $owner['nickname'] . ':' . $filter . ':' . $last_update;
 
-               $cachekey = "feed:feed:" . $owner_nick . ":" . $filter . ":" . $last_update;
-
-               // Display events in the users's timezone
+               // Display events in the user's timezone
                if (strlen($owner['timezone'])) {
                        DI::app()->setTimeZone($owner['timezone']);
                }
@@ -909,28 +944,28 @@ class Feed
                if ((time() - strtotime($owner['last-item'])) < 15*60) {
                        $result = DI::cache()->get($cachekey);
                        if (!$nocache && !is_null($result)) {
-                               Logger::info('Cached feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner_nick, 'filter' => $filter, 'created' => $previous_created]);
+                               Logger::info('Cached feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner['nickname'], 'filter' => $filter, 'created' => $previous_created]);
                                return $result['feed'];
                        }
                }
 
                $check_date = empty($last_update) ? '' : DateTimeFormat::utc($last_update);
-               $authorid = Contact::getIdForURL($owner["url"]);
+               $authorid = Contact::getIdForURL($owner['url']);
 
                $condition = ["`uid` = ? AND `received` > ? AND NOT `deleted` AND `gravity` IN (?, ?)
                        AND `private` != ? AND `visible` AND `wall` AND `parent-network` IN (?, ?, ?, ?)",
-                       $owner["uid"], $check_date, GRAVITY_PARENT, GRAVITY_COMMENT,
+                       $owner['uid'], $check_date, Item::GRAVITY_PARENT, Item::GRAVITY_COMMENT,
                        Item::PRIVATE, Protocol::ACTIVITYPUB,
                        Protocol::OSTATUS, Protocol::DFRN, Protocol::DIASPORA];
 
                if ($filter === 'comments') {
                        $condition[0] .= " AND `gravity` = ? ";
-                       $condition[] = GRAVITY_COMMENT;
+                       $condition[] = Item::GRAVITY_COMMENT;
                }
 
                if ($owner['account-type'] != User::ACCOUNT_TYPE_COMMUNITY) {
                        $condition[0] .= " AND `contact-id` = ? AND `author-id` = ?";
-                       $condition[] = $owner["id"];
+                       $condition[] = $owner['id'];
                        $condition[] = $authorid;
                }
 
@@ -963,7 +998,7 @@ class Feed
                $msg = ['feed' => $feeddata, 'last_update' => $last_update];
                DI::cache()->set($cachekey, $msg, Duration::QUARTER_HOUR);
 
-               Logger::info('Feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner_nick, 'filter' => $filter, 'created' => $previous_created]);
+               Logger::info('Feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner['nickname'], 'filter' => $filter, 'created' => $previous_created]);
 
                return $feeddata;
        }
@@ -975,16 +1010,16 @@ class Feed
         * @param array       $owner     Contact data of the poster
         * @param string      $filter    The related feed filter (activity, posts or comments)
         *
-        * @return object header root element
+        * @return DOMElement Header root element
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       private static function addHeader(DOMDocument $doc, array $owner, $filter)
+       private static function addHeader(DOMDocument $doc, array $owner, string $filter): DOMElement
        {
                $root = $doc->createElementNS(ActivityNamespace::ATOM1, 'feed');
                $doc->appendChild($root);
 
                $title = '';
-               $selfUri = '/feed/' . $owner["nick"] . '/';
+               $selfUri = '/feed/' . $owner['nick'] . '/';
                switch ($filter) {
                        case 'activity':
                                $title = DI::l10n()->t('%s\'s timeline', $owner['name']);
@@ -999,24 +1034,24 @@ class Feed
                                break;
                }
 
-               $attributes = ["uri" => "https://friendi.ca", "version" => FRIENDICA_VERSION . "-" . DB_UPDATE_VERSION];
-               XML::addElement($doc, $root, "generator", FRIENDICA_PLATFORM, $attributes);
-               XML::addElement($doc, $root, "id", DI::baseUrl() . "/profile/" . $owner["nick"]);
-               XML::addElement($doc, $root, "title", $title);
-               XML::addElement($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], DI::config()->get('config', 'sitename')));
-               XML::addElement($doc, $root, "logo", User::getAvatarUrl($owner, Proxy::SIZE_SMALL));
-               XML::addElement($doc, $root, "updated", DateTimeFormat::utcNow(DateTimeFormat::ATOM));
+               $attributes = ['uri' => 'https://friendi.ca', 'version' => App::VERSION . '-' . DB_UPDATE_VERSION];
+               XML::addElement($doc, $root, 'generator', App::PLATFORM, $attributes);
+               XML::addElement($doc, $root, 'id', DI::baseUrl() . '/profile/' . $owner['nick']);
+               XML::addElement($doc, $root, 'title', $title);
+               XML::addElement($doc, $root, 'subtitle', sprintf("Updates from %s on %s", $owner['name'], DI::config()->get('config', 'sitename')));
+               XML::addElement($doc, $root, 'logo', User::getAvatarUrl($owner, Proxy::SIZE_SMALL));
+               XML::addElement($doc, $root, 'updated', DateTimeFormat::utcNow(DateTimeFormat::ATOM));
 
                $author = self::addAuthor($doc, $owner);
                $root->appendChild($author);
 
-               $attributes = ["href" => $owner["url"], "rel" => "alternate", "type" => "text/html"];
-               XML::addElement($doc, $root, "link", "", $attributes);
+               $attributes = ['href' => $owner['url'], 'rel' => 'alternate', 'type' => 'text/html'];
+               XML::addElement($doc, $root, 'link', '', $attributes);
 
-               OStatus::hublinks($doc, $root, $owner["nick"]);
+               OStatus::addHubLink($doc, $root, $owner['nick']);
 
-               $attributes = ["href" => DI::baseUrl() . $selfUri, "rel" => "self", "type" => "application/atom+xml"];
-               XML::addElement($doc, $root, "link", "", $attributes);
+               $attributes = ['href' => DI::baseUrl() . $selfUri, 'rel' => 'self', 'type' => 'application/atom+xml'];
+               XML::addElement($doc, $root, 'link', '', $attributes);
 
                return $root;
        }
@@ -1026,16 +1061,15 @@ class Feed
         *
         * @param DOMDocument $doc          XML document
         * @param array       $owner        Contact data of the poster
-        *
-        * @return \DOMElement author element
+        * @return DOMElement author element
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       private static function addAuthor(DOMDocument $doc, array $owner)
+       private static function addAuthor(DOMDocument $doc, array $owner): DOMElement
        {
-               $author = $doc->createElement("author");
-               XML::addElement($doc, $author, "uri", $owner["url"]);
-               XML::addElement($doc, $author, "name", $owner["nick"]);
-               XML::addElement($doc, $author, "email", $owner["addr"]);
+               $author = $doc->createElement('author');
+               XML::addElement($doc, $author, 'uri', $owner['url']);
+               XML::addElement($doc, $author, 'name', $owner['nick']);
+               XML::addElement($doc, $author, 'email', $owner['addr']);
 
                return $author;
        }
@@ -1047,15 +1081,14 @@ class Feed
         * @param array       $item      Data of the item that is to be posted
         * @param array       $owner     Contact data of the poster
         * @param bool        $toplevel  Is it for en entry element (false) or a feed entry (true)?
-        *
-        * @return \DOMElement Entry element
+        * @return DOMElement Entry element
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       private static function noteEntry(DOMDocument $doc, array $item, array $owner)
+       private static function noteEntry(DOMDocument $doc, array $item, array $owner): DOMElement
        {
-               if (($item['gravity'] != GRAVITY_PARENT) && (Strings::normaliseLink($item["author-link"]) != Strings::normaliseLink($owner["url"]))) {
-                       Logger::info('Feed entry author does not match feed owner', ['owner' => $owner["url"], 'author' => $item["author-link"]]);
+               if (($item['gravity'] != Item::GRAVITY_PARENT) && (Strings::normaliseLink($item['author-link']) != Strings::normaliseLink($owner['url']))) {
+                       Logger::info('Feed entry author does not match feed owner', ['owner' => $owner['url'], 'author' => $item['author-link']]);
                }
 
                $entry = OStatus::entryHeader($doc, $owner, $item, false);
@@ -1077,31 +1110,30 @@ class Feed
         * @param string      $title     Title for the post
         * @param string      $verb      The activity verb
         * @param bool        $complete  Add the "status_net" element?
-        * @param bool        $feed_mode Behave like a regular feed for users if true
         * @return void
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       private static function entryContent(DOMDocument $doc, \DOMElement $entry, array $item, $title, $verb = "", $complete = true)
+       private static function entryContent(DOMDocument $doc, DOMElement $entry, array $item, $title, string $verb = '', bool $complete = true)
        {
-               if ($verb == "") {
+               if ($verb == '') {
                        $verb = OStatus::constructVerb($item);
                }
 
-               XML::addElement($doc, $entry, "id", $item["uri"]);
-               XML::addElement($doc, $entry, "title", html_entity_decode($title, ENT_QUOTES, 'UTF-8'));
+               XML::addElement($doc, $entry, 'id', $item['uri']);
+               XML::addElement($doc, $entry, 'title', html_entity_decode($title, ENT_QUOTES, 'UTF-8'));
 
-               $body = OStatus::formatPicturePost($item['body'], $item['uri-id']);
+               $body = Post\Media::addAttachmentsToBody($item['uri-id'], DI::contentItem()->addSharedPost($item));
 
                $body = BBCode::convertForUriId($item['uri-id'], $body, BBCode::ACTIVITYPUB);
 
-               XML::addElement($doc, $entry, "content", $body, ["type" => "html"]);
+               XML::addElement($doc, $entry, 'content', $body, ['type' => 'html']);
 
-               XML::addElement($doc, $entry, "link", "", ["rel" => "alternate", "type" => "text/html",
-                                                               "href" => DI::baseUrl()."/display/".$item["guid"]]
+               XML::addElement($doc, $entry, 'link', '', ['rel' => 'alternate', 'type' => 'text/html',
+                                                               'href' => DI::baseUrl() . '/display/' . $item['guid']]
                );
 
-               XML::addElement($doc, $entry, "published", DateTimeFormat::utc($item["created"]."+00:00", DateTimeFormat::ATOM));
-               XML::addElement($doc, $entry, "updated", DateTimeFormat::utc($item["edited"]."+00:00", DateTimeFormat::ATOM));
+               XML::addElement($doc, $entry, 'published', DateTimeFormat::utc($item['created'] . '+00:00', DateTimeFormat::ATOM));
+               XML::addElement($doc, $entry, 'updated', DateTimeFormat::utc($item['edited'] . '+00:00', DateTimeFormat::ATOM));
        }
 
        /**
@@ -1119,7 +1151,7 @@ class Feed
        {
                $mentioned = [];
 
-               if ($item['gravity'] != GRAVITY_PARENT) {
+               if ($item['gravity'] != Item::GRAVITY_PARENT) {
                        $parent = Post::selectFirst(['guid', 'author-link', 'owner-link'], ['id' => $item['parent']]);
 
                        $thrparent = Post::selectFirst(['guid', 'author-link', 'owner-link', 'plink'], ['uid' => $owner['uid'], 'uri' => $item['thr-parent']]);
@@ -1170,28 +1202,28 @@ class Feed
         * @param array $item
         * @return string title
         */
-       private static function getTitle(array $item)
+       private static function getTitle(array $item): string
        {
                if ($item['title'] != '') {
                        return BBCode::convertForUriId($item['uri-id'], $item['title'], BBCode::ACTIVITYPUB);
                }
 
                // Fetch information about the post
-               $siteinfo = BBCode::getAttachedData($item["body"]);
-               if (isset($siteinfo["title"])) {
-                       return $siteinfo["title"];
+               $siteinfo = BBCode::getAttachedData($item['body']);
+               if (isset($siteinfo['title'])) {
+                       return $siteinfo['title'];
                }
 
                // If no bookmark is found then take the first line
                // Remove the share element before fetching the first line
-               $title = trim(preg_replace("/\[share.*?\](.*?)\[\/share\]/ism","\n$1\n",$item['body']));
+               $title = trim(preg_replace("/\[share.*?\](.*?)\[\/share\]/ism", "\n$1\n", $item['body']));
 
                $title = BBCode::toPlaintext($title)."\n";
                $pos = strpos($title, "\n");
-               $trailer = "";
+               $trailer = '';
                if (($pos == 0) || ($pos > 100)) {
                        $pos = 100;
-                       $trailer = "...";
+                       $trailer = '...';
                }
 
                return substr($title, 0, $pos) . $trailer;