]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Feed.php
Merge pull request #8549 from annando/suppress-xml-log
[friendica.git] / src / Protocol / Feed.php
index 5939e5ce1a929b96c00f0fc21b642acab4856106..14a3c28ab9b002dd1446841dd848a376c4715cdb 100644 (file)
@@ -1,9 +1,24 @@
 <?php
 /**
- * @file src/Protocol/Feed.php
- * @brief Imports RSS/RDF/Atom feeds
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  *
  */
+
 namespace Friendica\Protocol;
 
 use DOMDocument;
@@ -11,43 +26,41 @@ use DOMXPath;
 use Friendica\Content\Text\HTML;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
-use Friendica\Core\System;
 use Friendica\Database\DBA;
+use Friendica\DI;
 use Friendica\Model\Item;
+use Friendica\Model\Tag;
 use Friendica\Util\Network;
+use Friendica\Util\ParseUrl;
 use Friendica\Util\XML;
 
-require_once 'include/dba.php';
-require_once 'include/items.php';
-
 /**
- * @brief This class contain functions to import feeds
- *
+ * This class contain functions to import feeds (RSS/RDF/Atom)
  */
 class Feed {
        /**
-        * @brief Read a RSS/RDF/Atom feed and create an item entry for it
+        * Read a RSS/RDF/Atom feed and create an item entry for it
         *
-        * @param string $xml The feed data
-        * @param array $importer The user record of the importer
-        * @param array $contact The contact record of the feed
-        * @param string $hub Unused dummy value for compatibility reasons
-        * @param bool $simulate If enabled, no data is imported
+        * @param string $xml      The feed data
+        * @param array  $importer The user record of the importer
+        * @param array  $contact  The contact record of the feed
         *
-        * @return array In simulation mode it returns the header and the first item
+        * @return array Returns the header and the first item in dry run mode
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       public static function import($xml, $importer, &$contact, &$hub, $simulate = false) {
-
-               $a = get_app();
+       public static function import($xml, array $importer = [], array $contact = [])
+       {
+               $dryRun = empty($importer) && empty($contact);
 
-               if (!$simulate) {
-                       Logger::log("Import Atom/RSS feed '".$contact["name"]."' (Contact ".$contact["id"].") for user ".$importer["uid"], Logger::DEBUG);
+               if ($dryRun) {
+                       Logger::info("Test Atom/RSS feed");
                } else {
-                       Logger::log("Test Atom/RSS feed", Logger::DEBUG);
+                       Logger::info("Import Atom/RSS feed '" . $contact["name"] . "' (Contact " . $contact["id"] . ") for user " . $importer["uid"]);
                }
+
                if (empty($xml)) {
-                       Logger::log('XML is empty.', Logger::DEBUG);
-                       return;
+                       Logger::info('XML is empty.');
+                       return [];
                }
 
                if (!empty($contact['poll'])) {
@@ -61,13 +74,13 @@ class Feed {
                $doc = new DOMDocument();
                @$doc->loadXML(trim($xml));
                $xpath = new DOMXPath($doc);
-               $xpath->registerNamespace('atom', NAMESPACE_ATOM1);
+               $xpath->registerNamespace('atom', ActivityNamespace::ATOM1);
                $xpath->registerNamespace('dc', "http://purl.org/dc/elements/1.1/");
                $xpath->registerNamespace('content', "http://purl.org/rss/1.0/modules/content/");
                $xpath->registerNamespace('rdf', "http://www.w3.org/1999/02/22-rdf-syntax-ns#");
                $xpath->registerNamespace('rss', "http://purl.org/rss/1.0/");
                $xpath->registerNamespace('media', "http://search.yahoo.com/mrss/");
-               $xpath->registerNamespace('poco', NAMESPACE_POCO);
+               $xpath->registerNamespace('poco', ActivityNamespace::POCO);
 
                $author = [];
                $entries = null;
@@ -115,14 +128,17 @@ class Feed {
                        if (empty($author["author-name"])) {
                                $author["author-name"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:subtitle/text()');
                        }
+
                        if (empty($author["author-name"])) {
                                $author["author-name"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:author/atom:name/text()');
                        }
+
                        $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:displayName/text()');
                        if ($value != "") {
                                $author["author-name"] = $value;
                        }
-                       if ($simulate) {
+
+                       if ($dryRun) {
                                $author["author-id"] = XML::getFirstNodeValue($xpath, '/atom:feed/atom:author/atom:id/text()');
 
                                // See https://tools.ietf.org/html/rfc4287#section-3.2.2
@@ -135,14 +151,17 @@ class Feed {
                                if ($value != "") {
                                        $author["author-nick"] = $value;
                                }
+
                                $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:address/poco:formatted/text()');
                                if ($value != "") {
                                        $author["author-location"] = $value;
                                }
+
                                $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:note/text()');
                                if ($value != "") {
                                        $author["author-about"] = $value;
                                }
+
                                $avatar = XML::getFirstAttributes($xpath, "atom:author/atom:link[@rel='avatar']");
                                if (is_object($avatar)) {
                                        foreach ($avatar AS $attribute) {
@@ -170,9 +189,11 @@ class Feed {
                        if (empty($author["author-name"])) {
                                $author["author-name"] = XML::getFirstNodeValue($xpath, '/rss/channel/copyright/text()');
                        }
+
                        if (empty($author["author-name"])) {
                                $author["author-name"] = XML::getFirstNodeValue($xpath, '/rss/channel/description/text()');
                        }
+
                        $author["edited"] = $author["created"] = XML::getFirstNodeValue($xpath, '/rss/channel/pubDate/text()');
 
                        $author["app"] = XML::getFirstNodeValue($xpath, '/rss/channel/generator/text()');
@@ -180,12 +201,13 @@ class Feed {
                        $entries = $xpath->query('/rss/channel/item');
                }
 
-               if (!$simulate) {
+               if (!$dryRun) {
                        $author["author-link"] = $contact["url"];
 
                        if (empty($author["author-name"])) {
                                $author["author-name"] = $contact["name"];
                        }
+
                        $author["author-avatar"] = $contact["thumb"];
 
                        $author["owner-link"] = $contact["url"];
@@ -194,25 +216,33 @@ class Feed {
                }
 
                $header = [];
-               $header["uid"] = $importer["uid"];
+               $header["uid"] = $importer["uid"] ?? 0;
                $header["network"] = Protocol::FEED;
                $header["wall"] = 0;
                $header["origin"] = 0;
                $header["gravity"] = GRAVITY_PARENT;
-               $header["private"] = 2;
-               $header["verb"] = ACTIVITY_POST;
-               $header["object-type"] = ACTIVITY_OBJ_NOTE;
+               $header["private"] = Item::PUBLIC;
+               $header["verb"] = Activity::POST;
+               $header["object-type"] = Activity\ObjectType::NOTE;
 
-               $header["contact-id"] = $contact["id"];
+               $header["contact-id"] = $contact["id"] ?? 0;
 
                if (!is_object($entries)) {
-                       Logger::log("There are no entries in this feed.", Logger::DEBUG);
-                       return;
+                       Logger::info("There are no entries in this feed.");
+                       return [];
                }
 
                $items = [];
+
+               // Limit the number of items that are about to be fetched
+               $total_items = ($entries->length - 1);
+               $max_items = DI::config()->get('system', 'max_feed_items');
+               if (($max_items > 0) && ($total_items > $max_items)) {
+                       $total_items = $max_items;
+               }
+
                // Importing older entries first
-               for($i = $entries->length - 1; $i >= 0;--$i) {
+               for ($i = $total_items; $i >= 0; --$i) {
                        $entry = $entries->item($i);
 
                        $item = array_merge($header, $author);
@@ -228,9 +258,11 @@ class Feed {
                                        }
                                }
                        }
+
                        if (empty($item["plink"])) {
                                $item["plink"] = XML::getFirstNodeValue($xpath, 'link/text()', $entry);
                        }
+
                        if (empty($item["plink"])) {
                                $item["plink"] = XML::getFirstNodeValue($xpath, 'rss:link/text()', $entry);
                        }
@@ -240,6 +272,7 @@ class Feed {
                        if (empty($item["uri"])) {
                                $item["uri"] = XML::getFirstNodeValue($xpath, 'guid/text()', $entry);
                        }
+
                        if (empty($item["uri"])) {
                                $item["uri"] = $item["plink"];
                        }
@@ -250,12 +283,12 @@ class Feed {
 
                        $item["parent-uri"] = $item["uri"];
 
-                       if (!$simulate) {
+                       if (!$dryRun) {
                                $condition = ["`uid` = ? AND `uri` = ? AND `network` IN (?, ?)",
                                        $importer["uid"], $item["uri"], Protocol::FEED, Protocol::DFRN];
                                $previous = Item::selectFirst(['id'], $condition);
                                if (DBA::isResult($previous)) {
-                                       Logger::log("Item with uri ".$item["uri"]." for user ".$importer["uid"]." already existed under id ".$previous["id"], Logger::DEBUG);
+                                       Logger::info("Item with uri " . $item["uri"] . " for user " . $importer["uid"] . " already existed under id " . $previous["id"]);
                                        continue;
                                }
                        }
@@ -268,14 +301,19 @@ class Feed {
                        if (empty($item["title"])) {
                                $item["title"] = XML::getFirstNodeValue($xpath, 'rss:title/text()', $entry);
                        }
+
+                       $item["title"] = html_entity_decode($item["title"], ENT_QUOTES, 'UTF-8');
+
                        $published = XML::getFirstNodeValue($xpath, 'atom:published/text()', $entry);
 
                        if (empty($published)) {
                                $published = XML::getFirstNodeValue($xpath, 'pubDate/text()', $entry);
                        }
+
                        if (empty($published)) {
                                $published = XML::getFirstNodeValue($xpath, 'dc:date/text()', $entry);
                        }
+
                        $updated = XML::getFirstNodeValue($xpath, 'atom:updated/text()', $entry);
 
                        if (empty($updated) && !empty($published)) {
@@ -289,20 +327,25 @@ class Feed {
                        if ($published != "") {
                                $item["created"] = $published;
                        }
+
                        if ($updated != "") {
                                $item["edited"] = $updated;
                        }
+
                        $creator = XML::getFirstNodeValue($xpath, 'author/text()', $entry);
 
                        if (empty($creator)) {
                                $creator = XML::getFirstNodeValue($xpath, 'atom:author/atom:name/text()', $entry);
                        }
+
                        if (empty($creator)) {
                                $creator = XML::getFirstNodeValue($xpath, 'dc:creator/text()', $entry);
                        }
+
                        if ($creator != "") {
                                $item["author-name"] = $creator;
                        }
+
                        $creator = XML::getFirstNodeValue($xpath, 'dc:creator/text()', $entry);
 
                        if ($creator != "") {
@@ -320,7 +363,6 @@ class Feed {
                                $href = "";
                                $length = "";
                                $type = "";
-                               $title = "";
 
                                foreach ($enclosure->attributes AS $attribute) {
                                        if (in_array($attribute->name, ["url", "href"])) {
@@ -331,6 +373,7 @@ class Feed {
                                                $type = $attribute->textContent;
                                        }
                                }
+
                                if (!empty($item["attach"])) {
                                        $item["attach"] .= ',';
                                } else {
@@ -339,10 +382,11 @@ class Feed {
 
                                $attachments[] = ["link" => $href, "type" => $type, "length" => $length];
 
-                               $item["attach"] .= '[attach]href="'.$href.'" length="'.$length.'" type="'.$type.'"[/attach]';
+                               $item["attach"] .= '[attach]href="' . $href . '" length="' . $length . '" type="' . $type . '"[/attach]';
                        }
 
                        $tags = '';
+                       $taglist = [];
                        $categories = $xpath->query("category", $entry);
                        foreach ($categories AS $category) {
                                $hashtag = $category->nodeValue;
@@ -350,8 +394,9 @@ class Feed {
                                        $tags .= ', ';
                                }
 
-                               $taglink = "#[url=" . System::baseUrl() . "/search?tag=" . $hashtag . "]" . $hashtag . "[/url]";
+                               $taglink = "#[url=" . DI::baseUrl() . "/search?tag=" . $hashtag . "]" . $hashtag . "[/url]";
                                $tags .= $taglink;
+                               $taglist[] = $hashtag;
                        }
 
                        $body = trim(XML::getFirstNodeValue($xpath, 'atom:content/text()', $entry));
@@ -359,11 +404,20 @@ class Feed {
                        if (empty($body)) {
                                $body = trim(XML::getFirstNodeValue($xpath, 'content:encoded/text()', $entry));
                        }
-                       if (empty($body)) {
-                               $body = trim(XML::getFirstNodeValue($xpath, 'description/text()', $entry));
+
+                       $summary = trim(XML::getFirstNodeValue($xpath, 'atom:summary/text()', $entry));
+
+                       if (empty($summary)) {
+                               $summary = trim(XML::getFirstNodeValue($xpath, 'description/text()', $entry));
                        }
+
                        if (empty($body)) {
-                               $body = trim(XML::getFirstNodeValue($xpath, 'atom:summary/text()', $entry));
+                               $body = $summary;
+                               $summary = '';
+                       }
+
+                       if ($body == $summary) {
+                               $summary = '';
                        }
 
                        // remove the content of the title if it is identically to the body
@@ -389,7 +443,7 @@ class Feed {
 
                                // Remove a possible link to the item itself
                                $item["body"] = str_replace($item["plink"], '', $item["body"]);
-                               $item["body"] = preg_replace('/\[url\=\](\w+.*?)\[\/url\]/i', '', $item["body"]);
+                               $item["body"] = trim(preg_replace('/\[url\=\](\w+.*?)\[\/url\]/i', '', $item["body"]));
 
                                // Replace the content when the title is longer than the body
                                $replace = (strlen($item["title"]) > strlen($item["body"]));
@@ -405,39 +459,64 @@ class Feed {
                                }
 
                                if ($replace) {
-                                       $item["body"] = $item["title"];
+                                       $item["body"] = trim($item["title"]);
+                               }
+
+                               $data = ParseUrl::getSiteinfoCached($item['plink'], true);
+                               if (!empty($data['text']) && !empty($data['title']) && (mb_strlen($item['body']) < mb_strlen($data['text']))) {
+                                       // When the fetched page info text is longer than the body, we do try to enhance the body
+                                       if (!empty($item['body']) && (strpos($data['title'], $item['body']) === false) && (strpos($data['text'], $item['body']) === false)) {
+                                               // The body is not part of the fetched page info title or page info text. So we add the text to the body
+                                               $item['body'] .= "\n\n" . $data['text'];
+                                       } else {
+                                               // Else we replace the body with the page info text
+                                               $item['body'] = $data['text'];
+                                       }
                                }
+
                                // We always strip the title since it will be added in the page information
                                $item["title"] = "";
-                               $item["body"] = $item["body"].add_page_info($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_blacklist"]);
+                               $item["body"] = $item["body"] . add_page_info($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_blacklist"]);
                                $item["tag"] = add_page_keywords($item["plink"], $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_blacklist"]);
-                               $item["object-type"] = ACTIVITY_OBJ_BOOKMARK;
+                               $taglist = get_page_keywords($item["plink"], $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_blacklist"]);
+                               $item["object-type"] = Activity\ObjectType::BOOKMARK;
                                unset($item["attach"]);
                        } else {
-                               if ($contact["fetch_further_information"] == 3) {
+                               if (!empty($summary)) {
+                                       $item["body"] = '[abstract]' . HTML::toBBCode($summary, $basepath) . "[/abstract]\n" . $item["body"];
+                               }
+
+                               if (!empty($contact["fetch_further_information"]) && ($contact["fetch_further_information"] == 3)) {
                                        if (!empty($tags)) {
                                                $item["tag"] = $tags;
                                        } else {
                                                // @todo $preview is never set in this case, is it intended? - @MrPetovan 2018-02-13
                                                $item["tag"] = add_page_keywords($item["plink"], $preview, true, $contact["ffi_keyword_blacklist"]);
+                                               $taglist = get_page_keywords($item["plink"], $preview, true, $contact["ffi_keyword_blacklist"]);
                                        }
-                                       $item["body"] .= "\n".$item['tag'];
+                                       $item["body"] .= "\n" . $item['tag'];
+                               } else {
+                                       $taglist = [];
                                }
+
                                // Add the link to the original feed entry if not present in feed
                                if (($item['plink'] != '') && !strstr($item["body"], $item['plink'])) {
-                                       $item["body"] .= "[hr][url]".$item['plink']."[/url]";
+                                       $item["body"] .= "[hr][url]" . $item['plink'] . "[/url]";
                                }
                        }
 
-                       if (!$simulate) {
-                               Logger::log("Stored feed: ".print_r($item, true), Logger::DEBUG);
+                       if ($dryRun) {
+                               $items[] = $item;
+                               break;
+                       } else {
+                               Logger::info("Stored feed: " . print_r($item, true));
 
                                $notify = Item::isRemoteSelf($contact, $item);
 
                                // Distributed items should have a well formatted URI.
                                // Additionally we have to avoid conflicts with identical URI between imported feeds and these items.
                                if ($notify) {
-                                       $item['guid'] = Item::guidFromUri($orig_plink, $a->getHostName());
+                                       $item['guid'] = Item::guidFromUri($orig_plink, DI::baseUrl()->getHostname());
                                        unset($item['uri']);
                                        unset($item['parent-uri']);
 
@@ -447,18 +526,18 @@ class Feed {
 
                                $id = Item::insert($item, false, $notify);
 
-                               Logger::log("Feed for contact ".$contact["url"]." stored under id ".$id);
-                       } else {
-                               $items[] = $item;
-                       }
-                       if ($simulate) {
-                               break;
+                               Logger::info("Feed for contact " . $contact["url"] . " stored under id " . $id);
+
+                               if (!empty($id) && !empty($taglist)) {
+                                       $feeditem = Item::selectFirst(['uri-id'], ['id' => $id]);
+                                       foreach ($taglist as $tag) {
+                                               Tag::store($feeditem['uri-id'], Tag::HASHTAG, $tag);
+                                       }                                       
+                               }
                        }
                }
 
-               if ($simulate) {
-                       return ["header" => $author, "items" => $items];
-               }
+               return ["header" => $author, "items" => $items];
        }
 
        private static function titleIsBody($title, $body)