]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Feed.php
Merge pull request #9146 from tobiasd/2020.09-CHANGELOG
[friendica.git] / src / Protocol / Feed.php
index ba0adb8347aef89c8a4c422ed9aeca102c8a3e4d..67baf4b2aebf6412945579c7d3ca8e3cdf654bd2 100644 (file)
@@ -300,6 +300,7 @@ class Feed
                }
 
                $items = [];
+               $creation_dates = [];
 
                // Limit the number of items that are about to be fetched
                $total_items = ($entries->length - 1);
@@ -354,16 +355,6 @@ class Feed
 
                        $item["parent-uri"] = $item["uri"];
 
-                       if (!$dryRun) {
-                               $condition = ["`uid` = ? AND `uri` = ? AND `network` IN (?, ?)",
-                                       $importer["uid"], $item["uri"], Protocol::FEED, Protocol::DFRN];
-                               $previous = Item::selectFirst(['id'], $condition);
-                               if (DBA::isResult($previous)) {
-                                       Logger::info("Item with uri " . $item["uri"] . " for user " . $importer["uid"] . " already existed under id " . $previous["id"]);
-                                       continue;
-                               }
-                       }
-
                        $item["title"] = XML::getFirstNodeValue($xpath, 'atom:title/text()', $entry);
 
                        if (empty($item["title"])) {
@@ -403,6 +394,19 @@ class Feed
                                $item["edited"] = $updated;
                        }
 
+                       if (!$dryRun) {
+                               $condition = ["`uid` = ? AND `uri` = ? AND `network` IN (?, ?)",
+                                       $importer["uid"], $item["uri"], Protocol::FEED, Protocol::DFRN];
+                               $previous = Item::selectFirst(['id', 'created'], $condition);
+                               if (DBA::isResult($previous)) {
+                                       // Use the creation date when the post had been stored. It can happen this date changes in the feed.
+                                       $creation_dates[] = $previous['created'];
+                                       Logger::info("Item with uri " . $item["uri"] . " for user " . $importer["uid"] . " already existed under id " . $previous["id"]);
+                                       continue;
+                               }
+                               $creation_dates[] = DateTimeFormat::utc($item['created']);
+                       }
+
                        $creator = XML::getFirstNodeValue($xpath, 'author/text()', $entry);
 
                        if (empty($creator)) {
@@ -490,6 +494,9 @@ class Feed
                        }
                        $item["body"] = HTML::toBBCode($body, $basepath);
 
+                       // Remove tracking pixels
+                       $item["body"] = preg_replace("/\[img=1x1\]([^\[\]]*)\[\/img\]/Usi", '', $item["body"]);
+
                        if (($item["body"] == '') && ($item["title"] != '')) {
                                $item["body"] = $item["title"];
                                $item["title"] = '';
@@ -529,6 +536,9 @@ class Feed
                                        $replace = true;
                                }
 
+                               $saved_body = $item["body"];
+                               $saved_title = $item["title"];
+
                                if ($replace) {
                                        $item["body"] = trim($item["title"]);
                                }
@@ -545,9 +555,24 @@ class Feed
                                        }
                                }
 
+                               $data = PageInfo::queryUrl($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_denylist"] ?? '');
+
+                               // Take the data that was provided by the feed if the query is empty
+                               if (($data['type'] == 'link') && empty($data['title']) && empty($data['text'])) {
+                                       $data['title'] = $saved_title;
+                                       $item["body"] = $saved_body;
+                               }
+
+                               $data_text = strip_tags(trim($data['text'] ?? ''));
+                               $item_body = strip_tags(trim($item['body'] ?? ''));
+
+                               if (!empty($data_text) && (($data_text == $item_body) || strstr($item_body, $data_text))) {
+                                       $data['text'] = '';
+                               }
+
                                // We always strip the title since it will be added in the page information
                                $item["title"] = "";
-                               $item["body"] = $item["body"] . "\n" . PageInfo::getFooterFromUrl($item["plink"], false, $preview, ($contact["fetch_further_information"] == 2), $contact["ffi_keyword_denylist"] ?? '');
+                               $item["body"] = $item["body"] . "\n" . PageInfo::getFooterFromData($data, false);
                                $taglist = $contact["fetch_further_information"] == 2 ? PageInfo::getTagsFromUrl($item["plink"], $preview, $contact["ffi_keyword_denylist"] ?? '') : [];
                                $item["object-type"] = Activity\ObjectType::BOOKMARK;
                                unset($item["attach"]);
@@ -598,9 +623,130 @@ class Feed
                        }
                }
 
+               if (!$dryRun && DI::config()->get('system', 'adjust_poll_frequency')) {
+                       self::adjustPollFrequency($contact, $creation_dates);
+               }
+
                return ["header" => $author, "items" => $items];
        }
 
+       /**
+        * Automatically adjust the poll frequency according to the post frequency
+        *
+        * @param array $contact
+        * @param array $creation_dates
+        * @return void
+        */
+       private static function adjustPollFrequency(array $contact, array $creation_dates)
+       {
+               if ($contact['network'] != Protocol::FEED) {
+                       Logger::info('Contact is no feed, skip.', ['id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url'], 'network' => $contact['network']]);
+                       return;
+               }
+
+               if (!empty($creation_dates)) {
+                       // Count the post frequency and the earliest and latest post date
+                       $frequency = [];
+                       $oldest = time();
+                       $newest = 0;
+                       $oldest_date = $newest_date = '';
+
+                       foreach ($creation_dates as $date) {
+                               $timestamp = strtotime($date);
+                               $day = intdiv($timestamp, 86400);
+                               $hour = $timestamp % 86400;
+
+                               // Only have a look at values from the last seven days
+                               if (((time() / 86400) - $day) < 7) {
+                                       if (empty($frequency[$day])) {
+                                               $frequency[$day] = ['count' => 1, 'low' => $hour, 'high' => $hour];
+                                       } else {
+                                               ++$frequency[$day]['count'];
+                                               if ($frequency[$day]['low'] > $hour) {
+                                                       $frequency[$day]['low'] = $hour;
+                                               }
+                                               if ($frequency[$day]['high'] < $hour) {
+                                                       $frequency[$day]['high'] = $hour;
+                                               }
+                                       }
+                               }
+                               if ($oldest > $day) {
+                                       $oldest = $day;
+                                       $oldest_date = $date;
+                               }
+                       
+                               if ($newest < $day) {
+                                       $newest = $day;
+                                       $newest_date = $date;
+                               }
+                       }
+
+                       if (count($creation_dates) == 1) {
+                               Logger::info('Feed had posted a single time, switching to daily polling', ['newest' => $newest_date, 'id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                               $priority = 8; // Poll once a day
+                       }
+
+                       if (empty($priority) && (((time() / 86400) - $newest) > 730)) {
+                               Logger::info('Feed had not posted for two years, switching to monthly polling', ['newest' => $newest_date, 'id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                               $priority = 10; // Poll every month
+                       }
+
+                       if (empty($priority) && (((time() / 86400) - $newest) > 365)) {
+                               Logger::info('Feed had not posted for a year, switching to weekly polling', ['newest' => $newest_date, 'id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                               $priority = 9; // Poll every week
+                       }
+
+                       if (empty($priority) && empty($frequency)) {
+                               Logger::info('Feed had not posted for at least a week, switching to daily polling', ['newest' => $newest_date, 'id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                               $priority = 8; // Poll once a day
+                       }
+
+                       if (empty($priority)) {
+                               // Calculate the highest "posts per day" value
+                               $max = 0;
+                               foreach ($frequency as $entry) {
+                                       if (($entry['count'] == 1) || ($entry['high'] == $entry['low'])) {
+                                               continue;
+                                       }
+
+                                       // We take the earliest and latest post day and interpolate the number of post per day
+                                       // that would had been created with this post frequency
+
+                                       // Assume at least four hours between oldest and newest post per day - should be okay for news outlets
+                                       $duration = max($entry['high'] - $entry['low'], 14400);
+                                       $ppd = (86400 / $duration) * $entry['count'];
+                                       if ($ppd > $max) {
+                                               $max = $ppd;
+                                       }
+                               }
+                               if ($max > 48) {
+                                       $priority = 1; // Poll every quarter hour
+                               } elseif ($max > 24) {
+                                       $priority = 2; // Poll half an hour
+                               } elseif ($max > 12) {
+                                       $priority = 3; // Poll hourly
+                               } elseif ($max > 8) {
+                                       $priority = 4; // Poll every two hours
+                               } elseif ($max > 4) {
+                                       $priority = 5; // Poll every three hours
+                               } elseif ($max > 2) {
+                                       $priority = 6; // Poll every six hours
+                               } else {
+                                       $priority = 7; // Poll twice a day
+                               }
+                               Logger::info('Calculated priority by the posts per day', ['priority' => $priority, 'max' => round($max, 2), 'id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                       }
+               } else {
+                       Logger::info('No posts, switching to daily polling', ['id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                       $priority = 8; // Poll once a day
+               }
+
+               if ($contact['rating'] != $priority) {
+                       Logger::notice('Adjusting priority', ['old' => $contact['rating'], 'new' => $priority, 'id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $contact['url']]);
+                       DBA::update('contact', ['rating' => $priority], ['id' => $contact['id']]);
+               }
+       }
+
        /**
         * Convert a tag array to a tag string
         *