]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/Feed.php
Fix missing attached links in posts
[friendica.git] / src / Protocol / Feed.php
index 907dfd8b99763dcd49626a0e19c3487e5ddce098..cbffd810c1d03b444faeedac9cd9ae201b2d623c 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -40,6 +40,7 @@ use Friendica\Model\Item;
 use Friendica\Model\Post;
 use Friendica\Model\Tag;
 use Friendica\Model\User;
+use Friendica\Network\HTTPException;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 use Friendica\Util\ParseUrl;
@@ -254,20 +255,21 @@ class Feed
                        $author['owner-avatar'] = $contact['thumb'];
                }
 
-               $header = [];
-               $header['uid'] = $importer['uid'] ?? 0;
-               $header['network'] = Protocol::FEED;
+               $header = [
+                       'uid'         => $importer['uid'] ?? 0,
+                       'network'     => Protocol::FEED,
+                       'wall'        => 0,
+                       'origin'      => 0,
+                       'gravity'     => Item::GRAVITY_PARENT,
+                       'private'     => Item::PUBLIC,
+                       'verb'        => Activity::POST,
+                       'object-type' => Activity\ObjectType::NOTE,
+                       'post-type'   => Item::PT_ARTICLE,
+                       'contact-id'  => $contact['id'] ?? 0,
+               ];
+
                $datarray['protocol'] = $protocol;
                $datarray['direction'] = Conversation::PULL;
-               $header['wall'] = 0;
-               $header['origin'] = 0;
-               $header['gravity'] = GRAVITY_PARENT;
-               $header['private'] = Item::PUBLIC;
-               $header['verb'] = Activity::POST;
-               $header['object-type'] = Activity\ObjectType::NOTE;
-               $header['post-type'] = Item::PT_ARTICLE;
-
-               $header['contact-id'] = $contact['id'] ?? 0;
 
                if (!is_object($entries)) {
                        Logger::info("There are no entries in this feed.");
@@ -374,11 +376,11 @@ class Feed
                        }
 
                        if ($published != '') {
-                               $item['created'] = $published;
+                               $item['created'] = trim($published);
                        }
 
                        if ($updated != '') {
-                               $item['edited'] = $updated;
+                               $item['edited'] = trim($updated);
                        }
 
                        if (!$dryRun) {
@@ -437,7 +439,7 @@ class Feed
                                }
 
                                if (!empty($href)) {
-                                       $attachment = ['type' => Post\Media::UNKNOWN, 'url' => $href, 'mimetype' => $type, 'size' => $length];
+                                       $attachment = ['uri-id' => -1, 'type' => Post\Media::UNKNOWN, 'url' => $href, 'mimetype' => $type, 'size' => $length];
 
                                        $attachment = Post\Media::fetchAdditionalData($attachment);
 
@@ -622,12 +624,14 @@ class Feed
                        Logger::info('Stored feed', ['item' => $item]);
 
                        $notify = Item::isRemoteSelf($contact, $item);
+                       $item['wall'] = (bool)$notify;
 
-                       // Distributed items should have a well formatted URI.
-                       // Additionally we have to avoid conflicts with identical URI between imported feeds and these items.
+                       // Distributed items should have a well-formatted URI.
+                       // Additionally, we have to avoid conflicts with identical URI between imported feeds and these items.
                        if ($notify) {
-                               $item['guid'] = Item::guidFromUri($orig_plink, DI::baseUrl()->getHostname());
-                               $item['uri'] = Item::newURI($item['guid']);
+                               $item['guid'] = Item::guidFromUri($orig_plink, DI::baseUrl()->getHost());
+                               $item['uri']  = Item::newURI($item['guid']);
+                               unset($item['plink']);
                                unset($item['thr-parent']);
                                unset($item['parent-uri']);
 
@@ -914,28 +918,23 @@ class Feed
         * Updates the provided last_update parameter if the result comes from the
         * cache or it is empty
         *
-        * @param string  $owner_nick  Nickname of the feed owner
+        * @param array   $owner       owner-view record of the feed owner
         * @param string  $last_update Date of the last update
         * @param integer $max_items   Number of maximum items to fetch
         * @param string  $filter      Feed items filter (activity, posts or comments)
         * @param boolean $nocache     Wether to bypass caching
         *
         * @return string Atom feed
-        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       public static function atom(string $owner_nick, string $last_update, int $max_items = 300, string $filter = 'activity', bool $nocache = false)
+       public static function atom(array $owner, string $last_update, int $max_items = 300, string $filter = 'activity', bool $nocache = false)
        {
                $stamp = microtime(true);
 
-               $owner = User::getOwnerDataByNick($owner_nick);
-               if (!$owner) {
-                       return;
-               }
-
-               $cachekey = 'feed:feed:' . $owner_nick . ':' . $filter . ':' . $last_update;
+               $cachekey = 'feed:feed:' . $owner['nickname'] . ':' . $filter . ':' . $last_update;
 
-               // Display events in the users's timezone
+               // Display events in the user's timezone
                if (strlen($owner['timezone'])) {
                        DI::app()->setTimeZone($owner['timezone']);
                }
@@ -946,7 +945,7 @@ class Feed
                if ((time() - strtotime($owner['last-item'])) < 15*60) {
                        $result = DI::cache()->get($cachekey);
                        if (!$nocache && !is_null($result)) {
-                               Logger::info('Cached feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner_nick, 'filter' => $filter, 'created' => $previous_created]);
+                               Logger::info('Cached feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner['nickname'], 'filter' => $filter, 'created' => $previous_created]);
                                return $result['feed'];
                        }
                }
@@ -956,13 +955,13 @@ class Feed
 
                $condition = ["`uid` = ? AND `received` > ? AND NOT `deleted` AND `gravity` IN (?, ?)
                        AND `private` != ? AND `visible` AND `wall` AND `parent-network` IN (?, ?, ?, ?)",
-                       $owner['uid'], $check_date, GRAVITY_PARENT, GRAVITY_COMMENT,
+                       $owner['uid'], $check_date, Item::GRAVITY_PARENT, Item::GRAVITY_COMMENT,
                        Item::PRIVATE, Protocol::ACTIVITYPUB,
                        Protocol::OSTATUS, Protocol::DFRN, Protocol::DIASPORA];
 
                if ($filter === 'comments') {
                        $condition[0] .= " AND `gravity` = ? ";
-                       $condition[] = GRAVITY_COMMENT;
+                       $condition[] = Item::GRAVITY_COMMENT;
                }
 
                if ($owner['account-type'] != User::ACCOUNT_TYPE_COMMUNITY) {
@@ -1000,7 +999,7 @@ class Feed
                $msg = ['feed' => $feeddata, 'last_update' => $last_update];
                DI::cache()->set($cachekey, $msg, Duration::QUARTER_HOUR);
 
-               Logger::info('Feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner_nick, 'filter' => $filter, 'created' => $previous_created]);
+               Logger::info('Feed duration', ['seconds' => number_format(microtime(true) - $stamp, 3), 'nick' => $owner['nickname'], 'filter' => $filter, 'created' => $previous_created]);
 
                return $feeddata;
        }
@@ -1089,7 +1088,7 @@ class Feed
         */
        private static function noteEntry(DOMDocument $doc, array $item, array $owner): DOMElement
        {
-               if (($item['gravity'] != GRAVITY_PARENT) && (Strings::normaliseLink($item['author-link']) != Strings::normaliseLink($owner['url']))) {
+               if (($item['gravity'] != Item::GRAVITY_PARENT) && (Strings::normaliseLink($item['author-link']) != Strings::normaliseLink($owner['url']))) {
                        Logger::info('Feed entry author does not match feed owner', ['owner' => $owner['url'], 'author' => $item['author-link']]);
                }
 
@@ -1124,7 +1123,8 @@ class Feed
                XML::addElement($doc, $entry, 'id', $item['uri']);
                XML::addElement($doc, $entry, 'title', html_entity_decode($title, ENT_QUOTES, 'UTF-8'));
 
-               $body = OStatus::formatPicturePost($item['body'], $item['uri-id']);
+               $body = Post\Media::addAttachmentsToBody($item['uri-id'], DI::contentItem()->addSharedPost($item));
+               $body = Post\Media::addHTMLAttachmentToBody($item['uri-id'], $body);
 
                $body = BBCode::convertForUriId($item['uri-id'], $body, BBCode::ACTIVITYPUB);
 
@@ -1153,7 +1153,7 @@ class Feed
        {
                $mentioned = [];
 
-               if ($item['gravity'] != GRAVITY_PARENT) {
+               if ($item['gravity'] != Item::GRAVITY_PARENT) {
                        $parent = Post::selectFirst(['guid', 'author-link', 'owner-link'], ['id' => $item['parent']]);
 
                        $thrparent = Post::selectFirst(['guid', 'author-link', 'owner-link', 'plink'], ['uid' => $owner['uid'], 'uri' => $item['thr-parent']]);