]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/OStatus.php
Bugfix: Calls to a renamed function had been changed
[friendica.git] / src / Protocol / OStatus.php
index 4c0503ce69698fa031d4d1193163d681e71d2d5f..2a021c89e9a3dac70fdb5cd42d857c1b6725a697 100644 (file)
@@ -9,23 +9,22 @@ use Friendica\Core\Cache;
 use Friendica\Core\Config;
 use Friendica\Core\System;
 use Friendica\Database\DBM;
-use Friendica\Model\GlobalContact;
+use Friendica\Model\Contact;
+use Friendica\Model\GContact;
 use Friendica\Network\Probe;
-use Friendica\Object\Contact;
+use Friendica\Object\Image;
 use Friendica\Util\Lock;
 use Friendica\Util\XML;
 use dba;
 use DOMDocument;
 use DomXPath;
 
-require_once 'include/Contact.php';
 require_once 'include/threads.php';
 require_once 'include/html2bbcode.php';
 require_once 'include/bbcode.php';
 require_once 'include/items.php';
 require_once 'mod/share.php';
 require_once 'include/enotify.php';
-require_once 'include/Photo.php';
 require_once 'include/follow.php';
 require_once 'include/api.php';
 require_once 'mod/proxy.php';
@@ -152,11 +151,8 @@ class OStatus
 
                // Only update the contacts if it is an OStatus contact
                if ($r && ($r['id'] > 0) && !$onlyfetch && ($contact["network"] == NETWORK_OSTATUS)) {
-                       // This contact is vital, so we awake it from the dead
-                       unmark_for_death($contact);
 
                        // Update contact data
-
                        $current = $contact;
                        unset($current['name-date']);
 
@@ -204,11 +200,11 @@ class OStatus
 
                        if (!empty($author["author-avatar"]) && ($author["author-avatar"] != $current['avatar'])) {
                                logger("Update profile picture for contact ".$contact["id"], LOGGER_DEBUG);
-                               update_contact_avatar($author["author-avatar"], $importer["uid"], $contact["id"]);
+                               Contact::updateAvatar($author["author-avatar"], $importer["uid"], $contact["id"]);
                        }
 
                        // Ensure that we are having this contact (with uid=0)
-                       $cid = get_contact($aliaslink, 0);
+                       $cid = Contact::getIdForURL($aliaslink, 0);
 
                        if ($cid) {
                                $fields = array('url', 'nurl', 'name', 'nick', 'alias', 'about', 'location');
@@ -224,15 +220,15 @@ class OStatus
                                dba::update('contact', $fields, array('id' => $cid), $old_contact);
 
                                // Update the avatar
-                               update_contact_avatar($author["author-avatar"], 0, $cid);
+                               Contact::updateAvatar($author["author-avatar"], 0, $cid);
                        }
 
                        $contact["generation"] = 2;
                        $contact["hide"] = false; // OStatus contacts are never hidden
                        $contact["photo"] = $author["author-avatar"];
-                       $gcid = GlobalContact::update($contact);
+                       $gcid = GContact::update($contact);
 
-                       GlobalContact::link($gcid, $contact["uid"], $contact["id"]);
+                       GContact::link($gcid, $contact["uid"], $contact["id"]);
                }
 
                return $author;
@@ -299,6 +295,7 @@ class OStatus
         * @param array  $importer user record of the importing user
         * @param array  $contact  contact
         * @param string $hub      Called by reference, returns the fetched hub data
+        * @return void
         */
        public static function import($xml, $importer, &$contact, &$hub)
        {
@@ -310,7 +307,7 @@ class OStatus
         *
         * @param string  $xml        The XML
         * @param array   $importer   user record of the importing user
-        * @param array   $contact
+        * @param array   $contact    contact
         * @param string  $hub        Called by reference, returns the fetched hub data
         * @param boolean $stored     Is the post fresh imported or from the database?
         * @param boolean $initialize Is it the leading post so that data has to be initialized?
@@ -538,6 +535,10 @@ class OStatus
                return true;
        }
 
+       /**
+        * @param object $item item
+        * @return void
+        */
        private static function deleteNotice($item)
        {
                $condition = array('uid' => $item['uid'], 'author-link' => $item['author-link'], 'uri' => $item['uri']);
@@ -568,6 +569,7 @@ class OStatus
         * @param object $entry    The xml entry that is processed
         * @param array  $item     The item array
         * @param array  $importer user record of the importing user
+        * @return void
         */
        private static function processPost($xpath, $entry, &$item, $importer)
        {
@@ -709,6 +711,7 @@ class OStatus
         *
         * @param string $conversation     The link to the conversation
         * @param string $conversation_uri The conversation in "uri" format
+        * @return void
         */
        private static function fetchConversation($conversation, $conversation_uri)
        {
@@ -769,6 +772,7 @@ class OStatus
         * @param string $xml              The feed
         * @param string $conversation     conversation
         * @param string $conversation_uri conversation uri
+        * @return void
         */
        private static function storeConversation($xml, $conversation = '', $conversation_uri = '')
        {
@@ -845,13 +849,14 @@ class OStatus
 
        /**
         * @brief Fetch the own post so that it can be stored later
-        * @param array  $item The item array
         *
         * We want to store the original data for later processing.
         * This function is meant for cases where we process a feed with multiple entries.
         * In that case we need to fetch the single posts here.
         *
         * @param string $self The link to the self item
+        * @param array  $item The item array
+        * @return void
         */
        private static function fetchSelf($self, &$item)
        {
@@ -886,6 +891,7 @@ class OStatus
         * @param string $related     The link to the related item
         * @param string $related_uri The related item in "uri" format
         * @param array  $importer    user record of the importing user
+        * @return void
         */
        private static function fetchRelated($related, $related_uri, $importer)
        {
@@ -1251,39 +1257,39 @@ class OStatus
                $root->setAttribute("xmlns:mastodon", NAMESPACE_MASTODON);
 
                $attributes = array("uri" => "https://friendi.ca", "version" => FRIENDICA_VERSION."-".DB_UPDATE_VERSION);
-               XML::add_element($doc, $root, "generator", FRIENDICA_PLATFORM, $attributes);
-               XML::add_element($doc, $root, "id", System::baseUrl()."/profile/".$owner["nick"]);
-               XML::add_element($doc, $root, "title", sprintf("%s timeline", $owner["name"]));
-               XML::add_element($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], $a->config["sitename"]));
-               XML::add_element($doc, $root, "logo", $owner["photo"]);
-               XML::add_element($doc, $root, "updated", datetime_convert("UTC", "UTC", "now", ATOM_TIME));
+               XML::addElement($doc, $root, "generator", FRIENDICA_PLATFORM, $attributes);
+               XML::addElement($doc, $root, "id", System::baseUrl()."/profile/".$owner["nick"]);
+               XML::addElement($doc, $root, "title", sprintf("%s timeline", $owner["name"]));
+               XML::addElement($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], $a->config["sitename"]));
+               XML::addElement($doc, $root, "logo", $owner["photo"]);
+               XML::addElement($doc, $root, "updated", datetime_convert("UTC", "UTC", "now", ATOM_TIME));
 
                $author = self::addAuthor($doc, $owner);
                $root->appendChild($author);
 
                $attributes = array("href" => $owner["url"], "rel" => "alternate", "type" => "text/html");
-               XML::add_element($doc, $root, "link", "", $attributes);
+               XML::addElement($doc, $root, "link", "", $attributes);
 
                /// @TODO We have to find out what this is
                /// $attributes = array("href" => System::baseUrl()."/sup",
                ///             "rel" => "http://api.friendfeed.com/2008/03#sup",
                ///             "type" => "application/json");
-               /// XML::add_element($doc, $root, "link", "", $attributes);
+               /// XML::addElement($doc, $root, "link", "", $attributes);
 
                self::hublinks($doc, $root, $owner["nick"]);
 
                $attributes = array("href" => System::baseUrl()."/salmon/".$owner["nick"], "rel" => "salmon");
-               XML::add_element($doc, $root, "link", "", $attributes);
+               XML::addElement($doc, $root, "link", "", $attributes);
 
                $attributes = array("href" => System::baseUrl()."/salmon/".$owner["nick"], "rel" => "http://salmon-protocol.org/ns/salmon-replies");
-               XML::add_element($doc, $root, "link", "", $attributes);
+               XML::addElement($doc, $root, "link", "", $attributes);
 
                $attributes = array("href" => System::baseUrl()."/salmon/".$owner["nick"], "rel" => "http://salmon-protocol.org/ns/salmon-mention");
-               XML::add_element($doc, $root, "link", "", $attributes);
+               XML::addElement($doc, $root, "link", "", $attributes);
 
                $attributes = array("href" => System::baseUrl()."/api/statuses/user_timeline/".$owner["nick"].".atom",
                                "rel" => "self", "type" => "application/atom+xml");
-               XML::add_element($doc, $root, "link", "", $attributes);
+               XML::addElement($doc, $root, "link", "", $attributes);
 
                return $root;
        }
@@ -1294,11 +1300,12 @@ class OStatus
         * @param object $doc  XML document
         * @param object $root XML root element where the hub links are added
         * @param object $nick nick
+        * @return void
         */
        public static function hublinks($doc, $root, $nick)
        {
                $h = System::baseUrl() . '/pubsubhubbub/'.$nick;
-               XML::add_element($doc, $root, "link", "", array("href" => $h, "rel" => "hub"));
+               XML::addElement($doc, $root, "link", "", array("href" => $h, "rel" => "hub"));
        }
 
        /**
@@ -1307,6 +1314,7 @@ class OStatus
         * @param object $doc  XML document
         * @param object $root XML root element where the hub links are added
         * @param array  $item Data of the item that is to be posted
+        * @return void
         */
        private static function getAttachment($doc, $root, $item)
        {
@@ -1315,12 +1323,12 @@ class OStatus
 
                switch ($siteinfo["type"]) {
                        case 'photo':
-                               $imgdata = get_photo_info($siteinfo["image"]);
+                               $imgdata = Image::getInfoFromURL($siteinfo["image"]);
                                $attributes = array("rel" => "enclosure",
                                                "href" => $siteinfo["image"],
                                                "type" => $imgdata["mime"],
                                                "length" => intval($imgdata["size"]));
-                               XML::add_element($doc, $root, "link", "", $attributes);
+                               XML::addElement($doc, $root, "link", "", $attributes);
                                break;
                        case 'video':
                                $attributes = array("rel" => "enclosure",
@@ -1328,20 +1336,20 @@ class OStatus
                                                "type" => "text/html; charset=UTF-8",
                                                "length" => "",
                                                "title" => $siteinfo["title"]);
-                               XML::add_element($doc, $root, "link", "", $attributes);
+                               XML::addElement($doc, $root, "link", "", $attributes);
                                break;
                        default:
                                break;
                }
 
                if (!Config::get('system', 'ostatus_not_attach_preview') && ($siteinfo["type"] != "photo") && isset($siteinfo["image"])) {
-                       $imgdata = get_photo_info($siteinfo["image"]);
+                       $imgdata = Image::getInfoFromURL($siteinfo["image"]);
                        $attributes = array("rel" => "enclosure",
                                        "href" => $siteinfo["image"],
                                        "type" => $imgdata["mime"],
                                        "length" => intval($imgdata["size"]));
 
-                       XML::add_element($doc, $root, "link", "", $attributes);
+                       XML::addElement($doc, $root, "link", "", $attributes);
                }
 
                $arr = explode('[/attach],', $item['attach']);
@@ -1360,7 +1368,7 @@ class OStatus
                                        if (trim($matches[4]) != "") {
                                                $attributes["title"] = trim($matches[4]);
                                        }
-                                       XML::add_element($doc, $root, "link", "", $attributes);
+                                       XML::addElement($doc, $root, "link", "", $attributes);
                                }
                        }
                }
@@ -1381,15 +1389,15 @@ class OStatus
                        $profile = $r[0];
                }
                $author = $doc->createElement("author");
-               XML::add_element($doc, $author, "id", $owner["url"]);
-               XML::add_element($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
-               XML::add_element($doc, $author, "uri", $owner["url"]);
-               XML::add_element($doc, $author, "name", $owner["nick"]);
-               XML::add_element($doc, $author, "email", $owner["addr"]);
-               XML::add_element($doc, $author, "summary", bbcode($owner["about"], false, false, 7));
+               XML::addElement($doc, $author, "id", $owner["url"]);
+               XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
+               XML::addElement($doc, $author, "uri", $owner["url"]);
+               XML::addElement($doc, $author, "name", $owner["nick"]);
+               XML::addElement($doc, $author, "email", $owner["addr"]);
+               XML::addElement($doc, $author, "summary", bbcode($owner["about"], false, false, 7));
 
                $attributes = array("rel" => "alternate", "type" => "text/html", "href" => $owner["url"]);
-               XML::add_element($doc, $author, "link", "", $attributes);
+               XML::addElement($doc, $author, "link", "", $attributes);
 
                $attributes = array(
                                "rel" => "avatar",
@@ -1397,7 +1405,7 @@ class OStatus
                                "media:width" => 175,
                                "media:height" => 175,
                                "href" => $owner["photo"]);
-               XML::add_element($doc, $author, "link", "", $attributes);
+               XML::addElement($doc, $author, "link", "", $attributes);
 
                if (isset($owner["thumb"])) {
                        $attributes = array(
@@ -1406,34 +1414,34 @@ class OStatus
                                        "media:width" => 80,
                                        "media:height" => 80,
                                        "href" => $owner["thumb"]);
-                       XML::add_element($doc, $author, "link", "", $attributes);
+                       XML::addElement($doc, $author, "link", "", $attributes);
                }
 
-               XML::add_element($doc, $author, "poco:preferredUsername", $owner["nick"]);
-               XML::add_element($doc, $author, "poco:displayName", $owner["name"]);
-               XML::add_element($doc, $author, "poco:note", bbcode($owner["about"], false, false, 7));
+               XML::addElement($doc, $author, "poco:preferredUsername", $owner["nick"]);
+               XML::addElement($doc, $author, "poco:displayName", $owner["name"]);
+               XML::addElement($doc, $author, "poco:note", bbcode($owner["about"], false, false, 7));
 
                if (trim($owner["location"]) != "") {
                        $element = $doc->createElement("poco:address");
-                       XML::add_element($doc, $element, "poco:formatted", $owner["location"]);
+                       XML::addElement($doc, $element, "poco:formatted", $owner["location"]);
                        $author->appendChild($element);
                }
 
                if (trim($profile["homepage"]) != "") {
                        $urls = $doc->createElement("poco:urls");
-                       XML::add_element($doc, $urls, "poco:type", "homepage");
-                       XML::add_element($doc, $urls, "poco:value", $profile["homepage"]);
-                       XML::add_element($doc, $urls, "poco:primary", "true");
+                       XML::addElement($doc, $urls, "poco:type", "homepage");
+                       XML::addElement($doc, $urls, "poco:value", $profile["homepage"]);
+                       XML::addElement($doc, $urls, "poco:primary", "true");
                        $author->appendChild($urls);
                }
 
                if (count($profile)) {
-                       XML::add_element($doc, $author, "followers", "", array("url" => System::baseUrl()."/viewcontacts/".$owner["nick"]));
-                       XML::add_element($doc, $author, "statusnet:profile_info", "", array("local_id" => $owner["uid"]));
+                       XML::addElement($doc, $author, "followers", "", array("url" => System::baseUrl()."/viewcontacts/".$owner["nick"]));
+                       XML::addElement($doc, $author, "statusnet:profile_info", "", array("local_id" => $owner["uid"]));
                }
 
                if ($profile["publish"]) {
-                       XML::add_element($doc, $author, "mastodon:scope", "public");
+                       XML::addElement($doc, $author, "mastodon:scope", "public");
                }
                return $author;
        }
@@ -1515,12 +1523,12 @@ class OStatus
        private static function sourceEntry($doc, $contact)
        {
                $source = $doc->createElement("source");
-               XML::add_element($doc, $source, "id", $contact["poll"]);
-               XML::add_element($doc, $source, "title", $contact["name"]);
-               XML::add_element($doc, $source, "link", "", array("rel" => "alternate", "type" => "text/html", "href" => $contact["alias"]));
-               XML::add_element($doc, $source, "link", "", array("rel" => "self", "type" => "application/atom+xml", "href" => $contact["poll"]));
-               XML::add_element($doc, $source, "icon", $contact["photo"]);
-               XML::add_element($doc, $source, "updated", datetime_convert("UTC", "UTC", $contact["success_update"]."+00:00", ATOM_TIME));
+               XML::addElement($doc, $source, "id", $contact["poll"]);
+               XML::addElement($doc, $source, "title", $contact["name"]);
+               XML::addElement($doc, $source, "link", "", array("rel" => "alternate", "type" => "text/html", "href" => $contact["alias"]));
+               XML::addElement($doc, $source, "link", "", array("rel" => "self", "type" => "application/atom+xml", "href" => $contact["poll"]));
+               XML::addElement($doc, $source, "icon", $contact["photo"]);
+               XML::addElement($doc, $source, "updated", datetime_convert("UTC", "UTC", $contact["success_update"]."+00:00", ATOM_TIME));
 
                return $source;
        }
@@ -1583,7 +1591,7 @@ class OStatus
         * @param object $doc           XML document
         * @param array  $item          Data of the item that is to be posted
         * @param array  $owner         Contact data of the poster
-        * @param        $repeated_guid
+        * @param string $repeated_guid guid
         * @param bool   $toplevel      Is it for en entry element (false) or a feed entry (true)?
         *
         * @return object Entry element
@@ -1619,7 +1627,7 @@ class OStatus
 
                $as_object = $doc->createElement("activity:object");
 
-               XML::add_element($doc, $as_object, "activity:object-type", NAMESPACE_ACTIVITY_SCHEMA."activity");
+               XML::addElement($doc, $as_object, "activity:object-type", NAMESPACE_ACTIVITY_SCHEMA."activity");
 
                self::entryContent($doc, $as_object, $repeated_item, $owner, "", "", false);
 
@@ -1628,7 +1636,7 @@ class OStatus
 
                $as_object2 = $doc->createElement("activity:object");
 
-               XML::add_element($doc, $as_object2, "activity:object-type", self::constructObjecttype($repeated_item));
+               XML::addElement($doc, $as_object2, "activity:object-type", self::constructObjecttype($repeated_item));
 
                $title = sprintf("New comment by %s", $contact["nick"]);
 
@@ -1679,7 +1687,7 @@ class OStatus
                );
                $parent_item = (($item['thr-parent']) ? $item['thr-parent'] : $item['parent-uri']);
 
-               XML::add_element($doc, $as_object, "activity:object-type", self::constructObjecttype($parent[0]));
+               XML::addElement($doc, $as_object, "activity:object-type", self::constructObjecttype($parent[0]));
 
                self::entryContent($doc, $as_object, $parent[0], $owner, "New entry");
 
@@ -1702,18 +1710,18 @@ class OStatus
        private static function addPersonObject($doc, $owner, $contact)
        {
                $object = $doc->createElement("activity:object");
-               XML::add_element($doc, $object, "activity:object-type", ACTIVITY_OBJ_PERSON);
+               XML::addElement($doc, $object, "activity:object-type", ACTIVITY_OBJ_PERSON);
 
                if ($contact['network'] == NETWORK_PHANTOM) {
-                       XML::add_element($doc, $object, "id", $contact['url']);
+                       XML::addElement($doc, $object, "id", $contact['url']);
                        return $object;
                }
 
-               XML::add_element($doc, $object, "id", $contact["alias"]);
-               XML::add_element($doc, $object, "title", $contact["nick"]);
+               XML::addElement($doc, $object, "id", $contact["alias"]);
+               XML::addElement($doc, $object, "title", $contact["nick"]);
 
                $attributes = array("rel" => "alternate", "type" => "text/html", "href" => $contact["url"]);
-               XML::add_element($doc, $object, "link", "", $attributes);
+               XML::addElement($doc, $object, "link", "", $attributes);
 
                $attributes = array(
                                "rel" => "avatar",
@@ -1721,14 +1729,14 @@ class OStatus
                                "media:width" => 175,
                                "media:height" => 175,
                                "href" => $contact["photo"]);
-               XML::add_element($doc, $object, "link", "", $attributes);
+               XML::addElement($doc, $object, "link", "", $attributes);
 
-               XML::add_element($doc, $object, "poco:preferredUsername", $contact["nick"]);
-               XML::add_element($doc, $object, "poco:displayName", $contact["name"]);
+               XML::addElement($doc, $object, "poco:preferredUsername", $contact["nick"]);
+               XML::addElement($doc, $object, "poco:displayName", $contact["name"]);
 
                if (trim($contact["location"]) != "") {
                        $element = $doc->createElement("poco:address");
-                       XML::add_element($doc, $element, "poco:formatted", $contact["location"]);
+                       XML::addElement($doc, $element, "poco:formatted", $contact["location"]);
                        $object->appendChild($element);
                }
 
@@ -1818,7 +1826,7 @@ class OStatus
 
                $title = self::entryHeader($doc, $entry, $owner, $toplevel);
 
-               XML::add_element($doc, $entry, "activity:object-type", ACTIVITY_OBJ_NOTE);
+               XML::addElement($doc, $entry, "activity:object-type", ACTIVITY_OBJ_NOTE);
 
                self::entryContent($doc, $entry, $item, $owner, $title);
 
@@ -1873,6 +1881,7 @@ class OStatus
         * @param string $title    Title for the post
         * @param string $verb     The activity verb
         * @param bool   $complete Add the "status_net" element?
+        * @return void
         */
        private static function entryContent($doc, $entry, $item, $owner, $title, $verb = "", $complete = true)
        {
@@ -1880,8 +1889,8 @@ class OStatus
                        $verb = self::constructVerb($item);
                }
 
-               XML::add_element($doc, $entry, "id", $item["uri"]);
-               XML::add_element($doc, $entry, "title", $title);
+               XML::addElement($doc, $entry, "id", $item["uri"]);
+               XML::addElement($doc, $entry, "title", $title);
 
                $body = self::formatPicturePost($item['body']);
 
@@ -1891,20 +1900,20 @@ class OStatus
 
                $body = bbcode($body, false, false, 7);
 
-               XML::add_element($doc, $entry, "content", $body, array("type" => "html"));
+               XML::addElement($doc, $entry, "content", $body, array("type" => "html"));
 
-               XML::add_element($doc, $entry, "link", "", array("rel" => "alternate", "type" => "text/html",
-                       "href" => System::baseUrl()."/display/".$item["guid"])
+               XML::addElement($doc, $entry, "link", "", array("rel" => "alternate", "type" => "text/html",
+                                                               "href" => System::baseUrl()."/display/".$item["guid"])
                );
 
                if ($complete && ($item["id"] > 0)) {
-                       XML::add_element($doc, $entry, "status_net", "", array("notice_id" => $item["id"]));
+                       XML::addElement($doc, $entry, "status_net", "", array("notice_id" => $item["id"]));
                }
 
-               XML::add_element($doc, $entry, "activity:verb", $verb);
+               XML::addElement($doc, $entry, "activity:verb", $verb);
 
-               XML::add_element($doc, $entry, "published", datetime_convert("UTC", "UTC", $item["created"]."+00:00", ATOM_TIME));
-               XML::add_element($doc, $entry, "updated", datetime_convert("UTC", "UTC", $item["edited"]."+00:00", ATOM_TIME));
+               XML::addElement($doc, $entry, "published", datetime_convert("UTC", "UTC", $item["created"]."+00:00", ATOM_TIME));
+               XML::addElement($doc, $entry, "updated", datetime_convert("UTC", "UTC", $item["edited"]."+00:00", ATOM_TIME));
        }
 
        /**
@@ -1915,6 +1924,7 @@ class OStatus
         * @param array  $item     Data of the item that is to be posted
         * @param array  $owner    Contact data of the poster
         * @param bool   $complete default true
+        * @return void
         */
        private static function entryFooter($doc, $entry, $item, $owner, $complete = true)
        {
@@ -1942,12 +1952,12 @@ class OStatus
                        $attributes = array(
                                        "ref" => $parent_item,
                                        "href" => $parent_plink);
-                       XML::add_element($doc, $entry, "thr:in-reply-to", "", $attributes);
+                       XML::addElement($doc, $entry, "thr:in-reply-to", "", $attributes);
 
                        $attributes = array(
                                        "rel" => "related",
                                        "href" => $parent_plink);
-                       XML::add_element($doc, $entry, "link", "", $attributes);
+                       XML::addElement($doc, $entry, "link", "", $attributes);
                }
 
                if (intval($item["parent"]) > 0) {
@@ -1966,14 +1976,14 @@ class OStatus
                                }
                        }
 
-                       XML::add_element($doc, $entry, "link", "", array("rel" => "ostatus:conversation", "href" => $conversation_href));
+                       XML::addElement($doc, $entry, "link", "", array("rel" => "ostatus:conversation", "href" => $conversation_href));
 
                        $attributes = array(
                                        "href" => $conversation_href,
                                        "local_id" => $item["parent"],
                                        "ref" => $conversation_uri);
 
-                       XML::add_element($doc, $entry, "ostatus:conversation", $conversation_uri, $attributes);
+                       XML::addElement($doc, $entry, "ostatus:conversation", $conversation_uri, $attributes);
                }
 
                $tags = item_getfeedtags($item);
@@ -2001,14 +2011,14 @@ class OStatus
                                dbesc(normalise_link($mention))
                        );
                        if ($r[0]["forum"] || $r[0]["prv"]) {
-                               XML::add_element($doc, $entry, "link", "",
+                               XML::addElement($doc, $entry, "link", "",
                                        array(
                                                "rel" => "mentioned",
                                                "ostatus:object-type" => ACTIVITY_OBJ_GROUP,
                                                "href" => $mention)
                                );
                        } else {
-                               XML::add_element($doc, $entry, "link", "",
+                               XML::addElement($doc, $entry, "link", "",
                                        array(
                                                "rel" => "mentioned",
                                                "ostatus:object-type" => ACTIVITY_OBJ_PERSON,
@@ -2018,18 +2028,18 @@ class OStatus
                }
 
                if (!$item["private"]) {
-                       XML::add_element($doc, $entry, "link", "", array("rel" => "ostatus:attention",
+                       XML::addElement($doc, $entry, "link", "", array("rel" => "ostatus:attention",
                                                                        "href" => "http://activityschema.org/collection/public"));
-                       XML::add_element($doc, $entry, "link", "", array("rel" => "mentioned",
+                       XML::addElement($doc, $entry, "link", "", array("rel" => "mentioned",
                                                                        "ostatus:object-type" => "http://activitystrea.ms/schema/1.0/collection",
                                                                        "href" => "http://activityschema.org/collection/public"));
-                       XML::add_element($doc, $entry, "mastodon:scope", "public");
+                       XML::addElement($doc, $entry, "mastodon:scope", "public");
                }
 
                if (count($tags)) {
                        foreach ($tags as $t) {
                                if ($t[0] != "@") {
-                                       XML::add_element($doc, $entry, "category", "", array("term" => $t[2]));
+                                       XML::addElement($doc, $entry, "category", "", array("term" => $t[2]));
                                }
                        }
                }
@@ -2049,10 +2059,10 @@ class OStatus
                        }
 
                        if ($item["coord"] != "") {
-                               XML::add_element($doc, $entry, "georss:point", $item["coord"]);
+                               XML::addElement($doc, $entry, "georss:point", $item["coord"]);
                        }
 
-                       XML::add_element($doc, $entry, "statusnet:notice_info", "", $attributes);
+                       XML::addElement($doc, $entry, "statusnet:notice_info", "", $attributes);
                }
        }
 
@@ -2098,7 +2108,7 @@ class OStatus
                }
 
                $check_date = datetime_convert('UTC', 'UTC', $last_update, 'Y-m-d H:i:s');
-               $authorid = get_contact($owner["url"], 0);
+               $authorid = Contact::getIdForURL($owner["url"], 0);
 
                $items = q(
                        "SELECT `item`.*, `item`.`id` AS `item_id` FROM `item` USE INDEX (`uid_contactid_created`)