]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/OStatus.php
Stopped using deprecated constants NETWORK_* (#5537)
[friendica.git] / src / Protocol / OStatus.php
index 8661c3e17b86bf6f1cf11716205453be064feb9a..80c6edbe9f2b8614fe884b875f811f1aeda8a531 100644 (file)
@@ -12,9 +12,9 @@ use Friendica\Core\Cache;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
 use Friendica\Core\Lock;
+use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
-use Friendica\Database\DBM;
 use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\GContact;
@@ -24,6 +24,7 @@ use Friendica\Network\Probe;
 use Friendica\Object\Image;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
+use Friendica\Util\Proxy as ProxyUtils;
 use Friendica\Util\XML;
 
 require_once 'include/dba.php';
@@ -31,7 +32,6 @@ require_once 'include/items.php';
 require_once 'mod/share.php';
 require_once 'include/enotify.php';
 require_once 'include/api.php';
-require_once 'mod/proxy.php';
 
 /**
  * @brief This class contain functions for the OStatus protocol
@@ -52,7 +52,7 @@ class OStatus
         *
         * @return array Array of author related entries for the item
         */
-       private static function fetchAuthor($xpath, $context, $importer, &$contact, $onlyfetch)
+       private static function fetchAuthor(DOMXPath $xpath, $context, array $importer, array &$contact = null, $onlyfetch)
        {
                $author = [];
                $author["author-link"] = XML::getFirstNodeValue($xpath, 'atom:author/atom:uri/text()', $context);
@@ -76,30 +76,30 @@ class OStatus
                $contact = null;
                if ($aliaslink != '') {
                        $condition = ["`uid` = ? AND `alias` = ? AND `network` != ? AND `rel` IN (?, ?)",
-                                       $importer["uid"], $aliaslink, NETWORK_STATUSNET,
-                                       CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
+                                       $importer["uid"], $aliaslink, Protocol::STATUSNET,
+                                       Contact::SHARING, Contact::FRIEND];
                        $contact = DBA::selectFirst('contact', [], $condition);
                }
 
-               if (!DBM::is_result($contact) && $author["author-link"] != '') {
+               if (!DBA::isResult($contact) && $author["author-link"] != '') {
                        if ($aliaslink == "") {
                                $aliaslink = $author["author-link"];
                        }
 
                        $condition = ["`uid` = ? AND `nurl` IN (?, ?) AND `network` != ? AND `rel` IN (?, ?)",
                                        $importer["uid"], normalise_link($author["author-link"]), normalise_link($aliaslink),
-                                       NETWORK_STATUSNET, CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
+                                       Protocol::STATUSNET, Contact::SHARING, Contact::FRIEND];
                        $contact = DBA::selectFirst('contact', [], $condition);
                }
 
-               if (!DBM::is_result($contact) && ($addr != '')) {
+               if (!DBA::isResult($contact) && ($addr != '')) {
                        $condition = ["`uid` = ? AND `addr` = ? AND `network` != ? AND `rel` IN (?, ?)",
-                                       $importer["uid"], $addr, NETWORK_STATUSNET,
-                                       CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
+                                       $importer["uid"], $addr, Protocol::STATUSNET,
+                                       Contact::SHARING, Contact::FRIEND];
                        $contact = DBA::selectFirst('contact', [], $condition);
                }
 
-               if (DBM::is_result($contact)) {
+               if (DBA::isResult($contact)) {
                        if ($contact['blocked']) {
                                $contact['id'] = -1;
                        }
@@ -136,7 +136,7 @@ class OStatus
                $author["owner-id"] = $author["author-id"];
 
                // Only update the contacts if it is an OStatus contact
-               if (DBM::is_result($contact) && ($contact['id'] > 0) && !$onlyfetch && ($contact["network"] == NETWORK_OSTATUS)) {
+               if (DBA::isResult($contact) && ($contact['id'] > 0) && !$onlyfetch && ($contact["network"] == Protocol::OSTATUS)) {
 
                        // Update contact data
                        $current = $contact;
@@ -219,6 +219,8 @@ class OStatus
                        $gcid = GContact::update($contact);
 
                        GContact::link($gcid, $contact["uid"], $contact["id"]);
+               } else {
+                       $contact = null;
                }
 
                return $author;
@@ -232,7 +234,7 @@ class OStatus
         *
         * @return array Array of author related entries for the item
         */
-       public static function salmonAuthor($xml, $importer)
+       public static function salmonAuthor($xml, array $importer)
        {
                if ($xml == "") {
                        return;
@@ -286,7 +288,7 @@ class OStatus
         * @param string $hub      Called by reference, returns the fetched hub data
         * @return void
         */
-       public static function import($xml, $importer, &$contact, &$hub)
+       public static function import($xml, array $importer, array &$contact = null, &$hub)
        {
                self::process($xml, $importer, $contact, $hub);
        }
@@ -303,7 +305,7 @@ class OStatus
         *
         * @return boolean Could the XML be processed?
         */
-       private static function process($xml, $importer, &$contact, &$hub, $stored = false, $initialize = true)
+       private static function process($xml, array $importer, array &$contact = null, &$hub, $stored = false, $initialize = true)
        {
                if ($initialize) {
                        self::$itemlist = [];
@@ -344,11 +346,15 @@ class OStatus
 
                $header = [];
                $header["uid"] = $importer["uid"];
-               $header["network"] = NETWORK_OSTATUS;
+               $header["network"] = Protocol::OSTATUS;
                $header["wall"] = 0;
                $header["origin"] = 0;
                $header["gravity"] = GRAVITY_COMMENT;
 
+               if (!is_object($doc->firstChild)) {
+                       return false;
+               }
+
                $first_child = $doc->firstChild->tagName;
 
                if ($first_child == "feed") {
@@ -365,7 +371,7 @@ class OStatus
                        $doc2->formatOutput = true;
                        $xml2 = $doc2->saveXML();
 
-                       $header["protocol"] = PROTOCOL_OSTATUS_SALMON;
+                       $header["protocol"] = Conversation::PARCEL_SALMON;
                        $header["source"] = $xml2;
                } elseif (!$initialize) {
                        return false;
@@ -540,10 +546,11 @@ class OStatus
        }
 
        /**
-        * @param object $item item
+        * Removes notice item from database
+        * @param array $item item
         * @return void
         */
-       private static function deleteNotice($item)
+       private static function deleteNotice(array $item)
        {
                $condition = ['uid' => $item['uid'], 'author-id' => $item['author-id'], 'uri' => $item['uri']];
                if (!Item::exists($condition)) {
@@ -565,7 +572,7 @@ class OStatus
         * @param array  $importer user record of the importing user
         * @return void
         */
-       private static function processPost($xpath, $entry, &$item, $importer)
+       private static function processPost(DOMXPath $xpath, $entry, array &$item, array $importer)
        {
                $item["body"] = HTML::toBBCode(XML::getFirstNodeValue($xpath, 'atom:content/text()', $entry));
                $item["object-type"] = XML::getFirstNodeValue($xpath, 'activity:object-type/text()', $entry);
@@ -792,8 +799,8 @@ class OStatus
 
                        $conv_data = [];
 
-                       $conv_data['protocol'] = PROTOCOL_SPLITTED_CONV;
-                       $conv_data['network'] = NETWORK_OSTATUS;
+                       $conv_data['protocol'] = Conversation::PARCEL_SPLIT_CONVERSATION;
+                       $conv_data['network'] = Protocol::OSTATUS;
                        $conv_data['uri'] = XML::getFirstNodeValue($xpath, 'atom:id/text()', $entry);
 
                        $inreplyto = $xpath->query('thr:in-reply-to', $entry);
@@ -833,7 +840,7 @@ class OStatus
 
                        $conv_data['source'] = $doc2->saveXML();
 
-                       $condition = ['item-uri' => $conv_data['uri'],'protocol' => PROTOCOL_OSTATUS_FEED];
+                       $condition = ['item-uri' => $conv_data['uri'],'protocol' => Conversation::PARCEL_FEED];
                        if (DBA::exists('conversation', $condition)) {
                                logger('Delete deprecated entry for URI '.$conv_data['uri'], LOGGER_DEBUG);
                                DBA::delete('conversation', ['item-uri' => $conv_data['uri']]);
@@ -855,9 +862,9 @@ class OStatus
         * @param array  $item The item array
         * @return void
         */
-       private static function fetchSelf($self, &$item)
+       private static function fetchSelf($self, array &$item)
        {
-               $condition = ['`item-uri` = ? AND `protocol` IN (?, ?)', $self, PROTOCOL_DFRN, PROTOCOL_OSTATUS_SALMON];
+               $condition = ['`item-uri` = ? AND `protocol` IN (?, ?)', $self, Conversation::PARCEL_DFRN, Conversation::PARCEL_SALMON];
                if (DBA::exists('conversation', $condition)) {
                        logger('Conversation '.$item['uri'].' is already stored.', LOGGER_DEBUG);
                        return;
@@ -876,7 +883,7 @@ class OStatus
                $doc->formatOutput = true;
                $xml = $doc->saveXML();
 
-               $item["protocol"] = PROTOCOL_OSTATUS_SALMON;
+               $item["protocol"] = Conversation::PARCEL_SALMON;
                $item["source"] = $xml;
 
                logger('Conversation '.$item['uri'].' is now fetched.', LOGGER_DEBUG);
@@ -892,16 +899,16 @@ class OStatus
         */
        private static function fetchRelated($related, $related_uri, $importer)
        {
-               $condition = ['`item-uri` = ? AND `protocol` IN (?, ?)', $related_uri, PROTOCOL_DFRN, PROTOCOL_OSTATUS_SALMON];
+               $condition = ['`item-uri` = ? AND `protocol` IN (?, ?)', $related_uri, Conversation::PARCEL_DFRN, Conversation::PARCEL_SALMON];
                $conversation = DBA::selectFirst('conversation', ['source', 'protocol'], $condition);
-               if (DBM::is_result($conversation)) {
+               if (DBA::isResult($conversation)) {
                        $stored = true;
                        $xml = $conversation['source'];
                        if (self::process($xml, $importer, $contact, $hub, $stored, false)) {
                                logger('Got valid cached XML for URI '.$related_uri, LOGGER_DEBUG);
                                return;
                        }
-                       if ($conversation['protocol'] == PROTOCOL_OSTATUS_SALMON) {
+                       if ($conversation['protocol'] == Conversation::PARCEL_SALMON) {
                                logger('Delete invalid cached XML for URI '.$related_uri, LOGGER_DEBUG);
                                DBA::delete('conversation', ['item-uri' => $related_uri]);
                        }
@@ -972,9 +979,9 @@ class OStatus
 
                // Finally we take the data that we fetched from "ostatus:conversation"
                if ($xml == '') {
-                       $condition = ['item-uri' => $related_uri, 'protocol' => PROTOCOL_SPLITTED_CONV];
+                       $condition = ['item-uri' => $related_uri, 'protocol' => Conversation::PARCEL_SPLIT_CONVERSATION];
                        $conversation = DBA::selectFirst('conversation', ['source'], $condition);
-                       if (DBM::is_result($conversation)) {
+                       if (DBA::isResult($conversation)) {
                                $stored = true;
                                logger('Got cached XML from conversation for URI '.$related_uri, LOGGER_DEBUG);
                                $xml = $conversation['source'];
@@ -999,28 +1006,28 @@ class OStatus
         *
         * @return array with data from links
         */
-       private static function processRepeatedItem($xpath, $entry, &$item, $importer)
+       private static function processRepeatedItem(DOMXPath $xpath, $entry, array &$item, array $importer)
        {
-               $activityobjects = $xpath->query('activity:object', $entry)->item(0);
+               $activityobject = $xpath->query('activity:object', $entry)->item(0);
 
-               if (!is_object($activityobjects)) {
+               if (!is_object($activityobject)) {
                        return [];
                }
 
                $link_data = [];
 
-               $orig_uri = XML::getFirstNodeValue($xpath, 'atom:id/text()', $activityobjects);
+               $orig_uri = XML::getFirstNodeValue($xpath, 'atom:id/text()', $activityobject);
 
-               $links = $xpath->query("atom:link", $activityobjects);
+               $links = $xpath->query("atom:link", $activityobject);
                if ($links) {
                        $link_data = self::processLinks($links, $item);
                }
 
-               $orig_body = XML::getFirstNodeValue($xpath, 'atom:content/text()', $activityobjects);
-               $orig_created = XML::getFirstNodeValue($xpath, 'atom:published/text()', $activityobjects);
-               $orig_edited = XML::getFirstNodeValue($xpath, 'atom:updated/text()', $activityobjects);
+               $orig_body = XML::getFirstNodeValue($xpath, 'atom:content/text()', $activityobject);
+               $orig_created = XML::getFirstNodeValue($xpath, 'atom:published/text()', $activityobject);
+               $orig_edited = XML::getFirstNodeValue($xpath, 'atom:updated/text()', $activityobject);
 
-               $orig_author = self::fetchAuthor($xpath, $activityobjects, $importer, $dummy, false);
+               $orig_author = self::fetchAuthor($xpath, $activityobject, $importer, $dummy, false);
 
                $item["author-name"] = $orig_author["author-name"];
                $item["author-link"] = $orig_author["author-link"];
@@ -1032,11 +1039,19 @@ class OStatus
 
                $item["uri"] = $orig_uri;
 
-               $item["verb"] = XML::getFirstNodeValue($xpath, 'activity:verb/text()', $activityobjects);
+               $item["verb"] = XML::getFirstNodeValue($xpath, 'activity:verb/text()', $activityobject);
 
-               $item["object-type"] = XML::getFirstNodeValue($xpath, 'activity:object-type/text()', $activityobjects);
+               $item["object-type"] = XML::getFirstNodeValue($xpath, 'activity:object-type/text()', $activityobject);
 
-               $inreplyto = $xpath->query('thr:in-reply-to', $activityobjects);
+               // Mastodon Content Warning
+               if (($item["verb"] == ACTIVITY_POST) && $xpath->evaluate('boolean(atom:summary)', $activityobject)) {
+                       $clear_text = XML::getFirstNodeValue($xpath, 'atom:summary/text()', $activityobject);
+                       if (!empty($clear_text)) {
+                               $item['content-warning'] = HTML::toBBCode($clear_text);
+                       }
+               }
+
+               $inreplyto = $xpath->query('thr:in-reply-to', $activityobject);
                if (is_object($inreplyto->item(0))) {
                        foreach ($inreplyto->item(0)->attributes as $attributes) {
                                if ($attributes->name == "ref") {
@@ -1056,7 +1071,7 @@ class OStatus
         *
         * @return array with data from the links
         */
-       private static function processLinks($links, &$item)
+       private static function processLinks($links, array &$item)
        {
                $link_data = ['add_body' => '', 'self' => ''];
 
@@ -1158,7 +1173,7 @@ class OStatus
         *
         * @return string The guid if the post is a reshare
         */
-       private static function getResharedGuid($item)
+       private static function getResharedGuid(array $item)
        {
                $body = trim($item["body"]);
 
@@ -1212,7 +1227,7 @@ class OStatus
                        }
 
                        // Is it a remote picture? Then make a smaller preview here
-                       $preview = proxy_url($preview, false, PROXY_SIZE_SMALL);
+                       $preview = ProxyUtils::proxifyUrl($preview, false, ProxyUtils::SIZE_SMALL);
 
                        // Is it a local picture? Then make it smaller here
                        $preview = str_replace(["-0.jpg", "-0.png"], ["-2.jpg", "-2.png"], $preview);
@@ -1239,7 +1254,7 @@ class OStatus
         *
         * @return object header root element
         */
-       private static function addHeader($doc, $owner, $filter)
+       private static function addHeader(DOMDocument $doc, array $owner, $filter)
        {
                $a = get_app();
 
@@ -1297,7 +1312,7 @@ class OStatus
                        "rel" => "self", "type" => "application/atom+xml"];
                XML::addElement($doc, $root, "link", "", $attributes);
 
-               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+               if ($owner['account-type'] == Contact::ACCOUNT_TYPE_COMMUNITY) {
                        $condition = ['uid' => $owner['uid'], 'self' => false, 'pending' => false,
                                        'archive' => false, 'hidden' => false, 'blocked' => false];
                        $members = DBA::count('contact', $condition);
@@ -1315,7 +1330,7 @@ class OStatus
         * @param object $nick nick
         * @return void
         */
-       public static function hublinks($doc, $root, $nick)
+       public static function hublinks(DOMDocument $doc, $root, $nick)
        {
                $h = System::baseUrl() . '/pubsubhubbub/'.$nick;
                XML::addElement($doc, $root, "link", "", ["href" => $h, "rel" => "hub"]);
@@ -1329,7 +1344,7 @@ class OStatus
         * @param array  $item Data of the item that is to be posted
         * @return void
         */
-       private static function getAttachment($doc, $root, $item)
+       private static function getAttachment(DOMDocument $doc, $root, $item)
        {
                $o = "";
                $siteinfo = BBCode::getAttachedData($item["body"]);
@@ -1350,7 +1365,7 @@ class OStatus
                                                "href" => $siteinfo["url"],
                                                "type" => "text/html; charset=UTF-8",
                                                "length" => "",
-                                               "title" => $siteinfo["title"]];
+                                               "title" => defaults($siteinfo, "title", $siteinfo["url"])];
                                XML::addElement($doc, $root, "link", "", $attributes);
                                break;
                        default:
@@ -1396,15 +1411,16 @@ class OStatus
         *
         * @param object $doc   XML document
         * @param array  $owner Contact data of the poster
+        * @param bool   $show_profile Whether to show profile
         *
         * @return object author element
         */
-       private static function addAuthor($doc, $owner, $show_profile = true)
+       private static function addAuthor(DOMDocument $doc, array $owner, $show_profile = true)
        {
                $profile = DBA::selectFirst('profile', ['homepage', 'publish'], ['uid' => $owner['uid'], 'is-default' => true]);
                $author = $doc->createElement("author");
                XML::addElement($doc, $author, "id", $owner["url"]);
-               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+               if ($owner['account-type'] == Contact::ACCOUNT_TYPE_COMMUNITY) {
                        XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_GROUP);
                } else {
                        XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
@@ -1449,7 +1465,7 @@ class OStatus
                        }
                }
 
-               if (DBM::is_result($profile) && !$show_profile) {
+               if (DBA::isResult($profile) && !$show_profile) {
                        if (trim($profile["homepage"]) != "") {
                                $urls = $doc->createElement("poco:urls");
                                XML::addElement($doc, $urls, "poco:type", "homepage");
@@ -1482,9 +1498,9 @@ class OStatus
         *
         * @return string activity
         */
-       private static function constructVerb($item)
+       private static function constructVerb(array $item)
        {
-               if ($item['verb']) {
+               if (!empty($item['verb'])) {
                        return $item['verb'];
                }
 
@@ -1498,7 +1514,7 @@ class OStatus
         *
         * @return string Object type
         */
-       private static function constructObjecttype($item)
+       private static function constructObjecttype(array $item)
        {
                if (in_array($item['object-type'], [ACTIVITY_OBJ_NOTE, ACTIVITY_OBJ_COMMENT]))
                        return $item['object-type'];
@@ -1515,7 +1531,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function entry($doc, $item, $owner, $toplevel = false)
+       private static function entry(DOMDocument $doc, array $item, array $owner, $toplevel = false)
        {
                $xml = null;
 
@@ -1545,7 +1561,7 @@ class OStatus
         *
         * @return object Source element
         */
-       private static function sourceEntry($doc, $contact)
+       private static function sourceEntry(DOMDocument $doc, array $contact)
        {
                $source = $doc->createElement("source");
                XML::addElement($doc, $source, "id", $contact["poll"]);
@@ -1566,31 +1582,31 @@ class OStatus
         *
         * @return array Contact array
         */
-       private static function contactEntry($url, $owner)
+       private static function contactEntry($url, array $owner)
        {
                $r = q(
                        "SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` IN (0, %d) ORDER BY `uid` DESC LIMIT 1",
-                       dbesc(normalise_link($url)),
+                       DBA::escape(normalise_link($url)),
                        intval($owner["uid"])
                );
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $contact = $r[0];
                        $contact["uid"] = -1;
                }
 
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        $r = q(
                                "SELECT * FROM `gcontact` WHERE `nurl` = '%s' LIMIT 1",
-                               dbesc(normalise_link($url))
+                               DBA::escape(normalise_link($url))
                        );
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $contact = $r[0];
                                $contact["uid"] = -1;
                                $contact["success_update"] = $contact["updated"];
                        }
                }
 
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        $contact = owner;
                }
 
@@ -1607,6 +1623,8 @@ class OStatus
                        $contact["alias"] = $contact["url"];
                }
 
+               $contact['account-type'] = $owner['account-type'];
+
                return $contact;
        }
 
@@ -1621,7 +1639,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function reshareEntry($doc, $item, $owner, $repeated_guid, $toplevel)
+       private static function reshareEntry(DOMDocument $doc, array $item, array $owner, $repeated_guid, $toplevel)
        {
                if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
@@ -1630,14 +1648,13 @@ class OStatus
                $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                $condition = ['uid' => $owner["uid"], 'guid' => $repeated_guid, 'private' => false,
-                       'network' => [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS]];
+                       'network' => [Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS]];
                $repeated_item = Item::selectFirst([], $condition);
-               if (!DBM::is_result($repeated_item)) {
+               if (!DBA::isResult($repeated_item)) {
                        return false;
                }
 
                $contact = self::contactEntry($repeated_item['author-link'], $owner);
-               $contact['account-type'] = $contact['contact-type'];
 
                $title = $owner["nick"]." repeated a notice by ".$contact["nick"];
 
@@ -1685,7 +1702,7 @@ class OStatus
         *
         * @return object Entry element with "like"
         */
-       private static function likeEntry($doc, $item, $owner, $toplevel)
+       private static function likeEntry(DOMDocument $doc, array $item, array $owner, $toplevel)
        {
                if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
@@ -1700,6 +1717,10 @@ class OStatus
 
                $parent = Item::selectFirst([], ['uri' => $item["thr-parent"], 'uid' => $item["uid"]]);
 
+               if (!$parent) {
+                       $parent = [];
+               }
+
                XML::addElement($doc, $as_object, "activity:object-type", self::constructObjecttype($parent));
 
                self::entryContent($doc, $as_object, $parent, $owner, "New entry");
@@ -1720,12 +1741,12 @@ class OStatus
         *
         * @return object author element
         */
-       private static function addPersonObject($doc, $owner, $contact)
+       private static function addPersonObject(DOMDocument $doc, array $owner, array $contact)
        {
                $object = $doc->createElement("activity:object");
                XML::addElement($doc, $object, "activity:object-type", ACTIVITY_OBJ_PERSON);
 
-               if ($contact['network'] == NETWORK_PHANTOM) {
+               if ($contact['network'] == Protocol::PHANTOM) {
                        XML::addElement($doc, $object, "id", $contact['url']);
                        return $object;
                }
@@ -1766,7 +1787,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function followEntry($doc, $item, $owner, $toplevel)
+       private static function followEntry(DOMDocument $doc, array $item, array $owner, $toplevel)
        {
                $item["id"] = $item["parent"] = 0;
                $item["created"] = $item["edited"] = date("c");
@@ -1783,10 +1804,10 @@ class OStatus
                $r = q(
                        "SELECT `id` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s'",
                        intval($owner['uid']),
-                       dbesc(normalise_link($contact["url"]))
+                       DBA::escape(normalise_link($contact["url"]))
                );
 
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $connect_id = $r[0]['id'];
                } else {
                        $connect_id = 0;
@@ -1831,7 +1852,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function noteEntry($doc, $item, $owner, $toplevel)
+       private static function noteEntry(DOMDocument $doc, array $item, array $owner, $toplevel)
        {
                if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
@@ -1858,14 +1879,14 @@ class OStatus
         *
         * @return string The title for the element
         */
-       private static function entryHeader($doc, &$entry, $owner, $item, $toplevel)
+       private static function entryHeader(DOMDocument $doc, &$entry, array $owner, array $item, $toplevel)
        {
                /// @todo Check if this title stuff is really needed (I guess not)
                if (!$toplevel) {
                        $entry = $doc->createElement("entry");
                        $title = sprintf("New note by %s", $owner["nick"]);
 
-                       if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       if ($owner['account-type'] == Contact::ACCOUNT_TYPE_COMMUNITY) {
                                $contact = self::contactEntry($item['author-link'], $owner);
                                $author = self::addAuthor($doc, $contact, false);
                                $entry->appendChild($author);
@@ -1902,7 +1923,7 @@ class OStatus
         * @param bool   $complete Add the "status_net" element?
         * @return void
         */
-       private static function entryContent($doc, $entry, $item, $owner, $title, $verb = "", $complete = true)
+       private static function entryContent(DOMDocument $doc, $entry, array $item, array $owner, $title, $verb = "", $complete = true)
        {
                if ($verb == "") {
                        $verb = self::constructVerb($item);
@@ -1945,7 +1966,7 @@ class OStatus
         * @param bool   $complete default true
         * @return void
         */
-       private static function entryFooter($doc, $entry, array $item, array $owner, $complete = true)
+       private static function entryFooter(DOMDocument $doc, $entry, array $item, array $owner, $complete = true)
        {
                $mentioned = [];
 
@@ -1955,7 +1976,7 @@ class OStatus
 
                        $thrparent = Item::selectFirst(['guid', 'author-link', 'owner-link', 'plink'], ['uid' => $owner["uid"], 'uri' => $parent_item]);
 
-                       if (DBM::is_result($thrparent)) {
+                       if (DBA::isResult($thrparent)) {
                                $mentioned[$thrparent["author-link"]] = $thrparent["author-link"];
                                $mentioned[$thrparent["owner-link"]] = $thrparent["owner-link"];
                                $parent_plink = $thrparent["plink"];
@@ -1982,7 +2003,7 @@ class OStatus
 
                        if (isset($parent_item)) {
                                $conversation = DBA::selectFirst('conversation', ['conversation-uri', 'conversation-href'], ['item-uri' => $parent_item]);
-                               if (DBM::is_result($conversation)) {
+                               if (DBA::isResult($conversation)) {
                                        if ($conversation['conversation-uri'] != '') {
                                                $conversation_uri = $conversation['conversation-uri'];
                                        }
@@ -2023,8 +2044,8 @@ class OStatus
                foreach ($mentioned as $mention) {
                        $condition = ['uid' => $owner['uid'], 'nurl' => normalise_link($mention)];
                        $contact = DBA::selectFirst('contact', ['forum', 'prv', 'self', 'contact-type'], $condition);
-                       if ($contact["forum"] || $contact["prv"] || ($owner['contact-type'] == ACCOUNT_TYPE_COMMUNITY) ||
-                               ($contact['self'] && ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY))) {
+                       if ($contact["forum"] || $contact["prv"] || ($owner['contact-type'] == Contact::ACCOUNT_TYPE_COMMUNITY) ||
+                               ($contact['self'] && ($owner['account-type'] == Contact::ACCOUNT_TYPE_COMMUNITY))) {
                                XML::addElement($doc, $entry, "link", "",
                                        [
                                                "rel" => "mentioned",
@@ -2041,7 +2062,7 @@ class OStatus
                        }
                }
 
-               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+               if ($owner['account-type'] == Contact::ACCOUNT_TYPE_COMMUNITY) {
                        XML::addElement($doc, $entry, "link", "", [
                                "rel" => "mentioned",
                                "ostatus:object-type" => "http://activitystrea.ms/schema/1.0/group",
@@ -2141,14 +2162,14 @@ class OStatus
 
                $condition = ["`uid` = ? AND `created` > ? AND NOT `deleted`
                        AND NOT `private` AND `visible` AND `wall` AND `parent-network` IN (?, ?)",
-                       $owner["uid"], $check_date, NETWORK_OSTATUS, NETWORK_DFRN];
+                       $owner["uid"], $check_date, Protocol::OSTATUS, Protocol::DFRN];
 
                if ($filter === 'comments') {
                        $condition[0] .= " AND `object-type` = ? ";
                        $condition[] = ACTIVITY_OBJ_COMMENT;
                }
 
-               if ($owner['account-type'] != ACCOUNT_TYPE_COMMUNITY) {
+               if ($owner['account-type'] != Contact::ACCOUNT_TYPE_COMMUNITY) {
                        $condition[0] .= " AND `contact-id` = ? AND `author-id` = ?";
                        $condition[] = $owner["id"];
                        $condition[] = $authorid;
@@ -2199,7 +2220,7 @@ class OStatus
         *
         * @return string XML for the salmon
         */
-       public static function salmon($item, $owner)
+       public static function salmon(array $item, array $owner)
        {
                $doc = new DOMDocument('1.0', 'utf-8');
                $doc->formatOutput = true;