]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/OStatus.php
Fix: Groups can now be deleted again
[friendica.git] / src / Protocol / OStatus.php
index c6f840a66e0b60150f9d57b0574e26df51b88527..bf0cca90c21e91adcf233adcf1d668eeedb632c0 100644 (file)
@@ -72,8 +72,9 @@ class OStatus
 
                $contact = null;
                if ($aliaslink != '') {
-                       $condition = ["`uid` = ? AND `alias` = ? AND `network` != ?",
-                                       $importer["uid"], $aliaslink, NETWORK_STATUSNET];
+                       $condition = ["`uid` = ? AND `alias` = ? AND `network` != ? AND `rel` IN (?, ?)",
+                                       $importer["uid"], $aliaslink, NETWORK_STATUSNET,
+                                       CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
                        $contact = dba::selectFirst('contact', [], $condition);
                }
 
@@ -82,14 +83,16 @@ class OStatus
                                $aliaslink = $author["author-link"];
                        }
 
-                       $condition = ["`uid` = ? AND `nurl` IN (?, ?) AND `network` != ?", $importer["uid"],
-                                       normalise_link($author["author-link"]), normalise_link($aliaslink), NETWORK_STATUSNET];
+                       $condition = ["`uid` = ? AND `nurl` IN (?, ?) AND `network` != ? AND `rel` IN (?, ?)",
+                                       $importer["uid"], normalise_link($author["author-link"]), normalise_link($aliaslink),
+                                       NETWORK_STATUSNET, CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
                        $contact = dba::selectFirst('contact', [], $condition);
                }
 
                if (!DBM::is_result($contact) && ($addr != '')) {
-                       $condition = ["`uid` = ? AND `addr` = ? AND `network` != ?",
-                                       $importer["uid"], $addr, NETWORK_STATUSNET];
+                       $condition = ["`uid` = ? AND `addr` = ? AND `network` != ? AND `rel` IN (?, ?)",
+                                       $importer["uid"], $addr, NETWORK_STATUSNET,
+                                       CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
                        $contact = dba::selectFirst('contact', [], $condition);
                }
 
@@ -243,13 +246,12 @@ class OStatus
                $xpath->registerNamespace('ostatus', NAMESPACE_OSTATUS);
                $xpath->registerNamespace('statusnet', NAMESPACE_STATUSNET);
 
-               $entries = $xpath->query('/atom:entry');
+               $contact = ["id" => 0];
 
-               foreach ($entries as $entry) {
-                       // fetch the author
-                       $author = self::fetchAuthor($xpath, $entry, $importer, $contact, true);
-                       return $author;
-               }
+               // Fetch the first author
+               $authordata = $xpath->query('//author')->item(0);
+               $author = self::fetchAuthor($xpath, $authordata, $importer, $contact, true);
+               return $author;
        }
 
        /**
@@ -658,8 +660,9 @@ class OStatus
                // Mastodon Content Warning
                if (($item["verb"] == ACTIVITY_POST) && $xpath->evaluate('boolean(atom:summary)', $entry)) {
                        $clear_text = $xpath->query('atom:summary/text()', $entry)->item(0)->nodeValue;
-
-                       $item["body"] = html2bbcode($clear_text) . '[spoiler]' . $item["body"] . '[/spoiler]';
+                       if (!empty($clear_text)) {
+                               $item['content-warning'] = html2bbcode($clear_text);
+                       }
                }
 
                if (($self != '') && empty($item['protocol'])) {
@@ -670,9 +673,11 @@ class OStatus
                        self::fetchConversation($item['conversation-href'], $item['conversation-uri']);
                }
 
-               if (isset($item["parent-uri"]) && ($related != '')) {
+               if (isset($item["parent-uri"])) {
                        if (!dba::exists('item', ['uid' => $importer["uid"], 'uri' => $item['parent-uri']])) {
-                               self::fetchRelated($related, $item["parent-uri"], $importer);
+                               if ($related != '') {
+                                       self::fetchRelated($related, $item["parent-uri"], $importer);
+                               }
                        } else {
                                logger('Reply with URI '.$item["uri"].' already existed for user '.$importer["uid"].'.', LOGGER_DEBUG);
                        }
@@ -1283,6 +1288,13 @@ class OStatus
                        "rel" => "self", "type" => "application/atom+xml"];
                XML::addElement($doc, $root, "link", "", $attributes);
 
+               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       $condition = ['uid' => $owner['uid'], 'self' => false, 'pending' => false,
+                                       'archive' => false, 'hidden' => false, 'blocked' => false];
+                       $members = dba::count('contact', $condition);
+                       XML::addElement($doc, $root, "statusnet:group_info", "", ["member_count" => $members]);
+               }
+
                return $root;
        }
 
@@ -1374,16 +1386,22 @@ class OStatus
         *
         * @return object author element
         */
-       private static function addAuthor($doc, $owner)
+       private static function addAuthor($doc, $owner, $show_profile = true)
        {
                $profile = dba::selectFirst('profile', ['homepage', 'publish'], ['uid' => $owner['uid'], 'is-default' => true]);
                $author = $doc->createElement("author");
                XML::addElement($doc, $author, "id", $owner["url"]);
-               XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
+               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_GROUP);
+               } else {
+                       XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
+               }
                XML::addElement($doc, $author, "uri", $owner["url"]);
                XML::addElement($doc, $author, "name", $owner["nick"]);
                XML::addElement($doc, $author, "email", $owner["addr"]);
-               XML::addElement($doc, $author, "summary", BBCode::convert($owner["about"], false, 7));
+               if ($show_profile) {
+                       XML::addElement($doc, $author, "summary", BBCode::convert($owner["about"], false, 7));
+               }
 
                $attributes = ["rel" => "alternate", "type" => "text/html", "href" => $owner["url"]];
                XML::addElement($doc, $author, "link", "", $attributes);
@@ -1408,15 +1426,17 @@ class OStatus
 
                XML::addElement($doc, $author, "poco:preferredUsername", $owner["nick"]);
                XML::addElement($doc, $author, "poco:displayName", $owner["name"]);
-               XML::addElement($doc, $author, "poco:note", BBCode::convert($owner["about"], false, 7));
+               if ($show_profile) {
+                       XML::addElement($doc, $author, "poco:note", BBCode::convert($owner["about"], false, 7));
 
-               if (trim($owner["location"]) != "") {
-                       $element = $doc->createElement("poco:address");
-                       XML::addElement($doc, $element, "poco:formatted", $owner["location"]);
-                       $author->appendChild($element);
+                       if (trim($owner["location"]) != "") {
+                               $element = $doc->createElement("poco:address");
+                               XML::addElement($doc, $element, "poco:formatted", $owner["location"]);
+                               $author->appendChild($element);
+                       }
                }
 
-               if (DBM::is_result($profile)) {
+               if (DBM::is_result($profile) && !$show_profile) {
                        if (trim($profile["homepage"]) != "") {
                                $urls = $doc->createElement("poco:urls");
                                XML::addElement($doc, $urls, "poco:type", "homepage");
@@ -1427,11 +1447,12 @@ class OStatus
 
                        XML::addElement($doc, $author, "followers", "", ["url" => System::baseUrl()."/viewcontacts/".$owner["nick"]]);
                        XML::addElement($doc, $author, "statusnet:profile_info", "", ["local_id" => $owner["uid"]]);
-               }
 
-               if ($profile["publish"]) {
-                       XML::addElement($doc, $author, "mastodon:scope", "public");
+                       if ($profile["publish"]) {
+                               XML::addElement($doc, $author, "mastodon:scope", "public");
+                       }
                }
+
                return $author;
        }
 
@@ -1593,7 +1614,7 @@ class OStatus
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
-               $title = self::entryHeader($doc, $entry, $owner, $toplevel);
+               $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                $r = q(
                        "SELECT * FROM `item` WHERE `uid` = %d AND `guid` = '%s' AND NOT `private` AND `network` IN ('%s', '%s', '%s') LIMIT 1",
@@ -1622,7 +1643,7 @@ class OStatus
 
                self::entryContent($doc, $as_object, $repeated_item, $owner, "", "", false);
 
-               $author = self::addAuthor($doc, $contact);
+               $author = self::addAuthor($doc, $contact, false);
                $as_object->appendChild($author);
 
                $as_object2 = $doc->createElement("activity:object");
@@ -1664,7 +1685,7 @@ class OStatus
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
-               $title = self::entryHeader($doc, $entry, $owner, $toplevel);
+               $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                $verb = NAMESPACE_ACTIVITY_SCHEMA."favorite";
                self::entryContent($doc, $entry, $item, $owner, "Favorite", $verb, false);
@@ -1787,7 +1808,7 @@ class OStatus
 
                $item["body"] = sprintf($message, $owner["nick"], $contact["nick"]);
 
-               self::entryHeader($doc, $entry, $owner, $toplevel);
+               self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                self::entryContent($doc, $entry, $item, $owner, $title);
 
@@ -1815,7 +1836,7 @@ class OStatus
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
-               $title = self::entryHeader($doc, $entry, $owner, $toplevel);
+               $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                XML::addElement($doc, $entry, "activity:object-type", ACTIVITY_OBJ_NOTE);
 
@@ -1836,12 +1857,18 @@ class OStatus
         *
         * @return string The title for the element
         */
-       private static function entryHeader($doc, &$entry, $owner, $toplevel)
+       private static function entryHeader($doc, &$entry, $owner, $item, $toplevel)
        {
                /// @todo Check if this title stuff is really needed (I guess not)
                if (!$toplevel) {
                        $entry = $doc->createElement("entry");
                        $title = sprintf("New note by %s", $owner["nick"]);
+
+                       if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                               $contact = self::contactEntry($item['author-link'], $owner);
+                               $author = self::addAuthor($doc, $contact, false);
+                               $entry->appendChild($author);
+                       }
                } else {
                        $entry = $doc->createElementNS(NAMESPACE_ATOM1, "entry");
 
@@ -1996,12 +2023,10 @@ class OStatus
                $mentioned = $newmentions;
 
                foreach ($mentioned as $mention) {
-                       $r = q(
-                               "SELECT `forum`, `prv` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s'",
-                               intval($owner["uid"]),
-                               dbesc(normalise_link($mention))
-                       );
-                       if ($r[0]["forum"] || $r[0]["prv"]) {
+                       $condition = ['uid' => $owner['uid'], 'nurl' => normalise_link($mention)];
+                       $contact = dba::selectFirst('contact', ['forum', 'prv', 'self', 'contact-type'], $condition);
+                       if ($contact["forum"] || $contact["prv"] || ($owner['contact-type'] == ACCOUNT_TYPE_COMMUNITY) ||
+                               ($contact['self'] && ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY))) {
                                XML::addElement($doc, $entry, "link", "",
                                        [
                                                "rel" => "mentioned",
@@ -2018,6 +2043,12 @@ class OStatus
                        }
                }
 
+               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       XML::addElement($doc, $entry, "link", "", ["rel" => "mentioned",
+                                                                       "ostatus:object-type" => "http://activitystrea.ms/schema/1.0/group",
+                                                                       "href" => $owner['url']]);
+               }
+
                if (!$item["private"]) {
                        XML::addElement($doc, $entry, "link", "", ["rel" => "ostatus:attention",
                                                                        "href" => "http://activityschema.org/collection/public"]);
@@ -2094,7 +2125,7 @@ class OStatus
                }
 
                $owner = dba::fetch_first(
-                       "SELECT `contact`.*, `user`.`nickname`, `user`.`timezone`, `user`.`page-flags`
+                       "SELECT `contact`.*, `user`.`nickname`, `user`.`timezone`, `user`.`page-flags`, `user`.`account-type`
                                FROM `contact` INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
                                WHERE `contact`.`self` AND `user`.`nickname` = ? LIMIT 1",
                        $owner_nick
@@ -2119,22 +2150,23 @@ class OStatus
                        $sql_extra .= sprintf(" AND `item`.`object-type` = '%s' ", dbesc(ACTIVITY_OBJ_COMMENT));
                }
 
+               if ($owner['account-type'] != ACCOUNT_TYPE_COMMUNITY) {
+                       $sql_extra .= sprintf(" AND `item`.`contact-id` = %d AND `item`.`author-id` = %d ", intval($owner["id"]), intval($authorid));
+               }
+
                $items = q(
                        "SELECT `item`.*, `item`.`id` AS `item_id` FROM `item` USE INDEX (`uid_contactid_created`)
                                STRAIGHT_JOIN `thread` ON `thread`.`iid` = `item`.`parent`
                                WHERE `item`.`uid` = %d
-                               AND `item`.`contact-id` = %d
-                               AND `item`.`author-id` = %d
                                AND `item`.`created` > '%s'
                                AND NOT `item`.`deleted`
                                AND NOT `item`.`private`
                                AND `item`.`visible`
+                               AND `item`.`wall`
                                AND `thread`.`network` IN ('%s', '%s')
                                $sql_extra
                                ORDER BY `item`.`created` DESC LIMIT %d",
                        intval($owner["uid"]),
-                       intval($owner["id"]),
-                       intval($authorid),
                        dbesc($check_date),
                        dbesc(NETWORK_OSTATUS),
                        dbesc(NETWORK_DFRN),