]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/OStatus.php
Merge branch 'master' into develop
[friendica.git] / src / Protocol / OStatus.php
index c98b8ddec023025739762edf34a7ecfba3f737d3..ce9e6642edec4edab337907fdc57bbbbd3bcda6c 100644 (file)
@@ -5,6 +5,7 @@
 namespace Friendica\Protocol;
 
 use Friendica\Content\Text\BBCode;
+use Friendica\Content\Text\HTML;
 use Friendica\Core\Cache;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
@@ -16,18 +17,15 @@ use Friendica\Model\GContact;
 use Friendica\Model\Item;
 use Friendica\Network\Probe;
 use Friendica\Object\Image;
+use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Lock;
 use Friendica\Util\Network;
-use Friendica\Util\Temporal;
 use Friendica\Util\XML;
 use dba;
 use DOMDocument;
 use DOMXPath;
 
 require_once 'include/dba.php';
-require_once 'include/threads.php';
-require_once 'include/html2bbcode.php';
-require_once 'include/bbcode.php';
 require_once 'include/items.php';
 require_once 'mod/share.php';
 require_once 'include/enotify.php';
@@ -72,55 +70,37 @@ class OStatus
                }
                $author["contact-id"] = $contact["id"];
 
-               $found = false;
-
+               $contact = null;
                if ($aliaslink != '') {
-                       $condition = ["`uid` = ? AND `alias` = ? AND `network` != ?",
-                                       $importer["uid"], $aliaslink, NETWORK_STATUSNET];
-                       $r = dba::selectFirst('contact', [], $condition);
-
-                       if (DBM::is_result($r)) {
-                               $found = true;
-                               if ($r['blocked']) {
-                                       $r['id'] = -1;
-                               }
-                               $contact = $r;
-                               $author["contact-id"] = $r["id"];
-                       }
+                       $condition = ["`uid` = ? AND `alias` = ? AND `network` != ? AND `rel` IN (?, ?)",
+                                       $importer["uid"], $aliaslink, NETWORK_STATUSNET,
+                                       CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
+                       $contact = dba::selectFirst('contact', [], $condition);
                }
 
-               if (!$found && ($author["author-link"] != "")) {
+               if (!DBM::is_result($contact) && $author["author-link"] != '') {
                        if ($aliaslink == "") {
                                $aliaslink = $author["author-link"];
                        }
 
-                       $condition = ["`uid` = ? AND `nurl` IN (?, ?) AND `network` != ?", $importer["uid"],
-                                       normalise_link($author["author-link"]), normalise_link($aliaslink), NETWORK_STATUSNET];
-                       $r = dba::selectFirst('contact', [], $condition);
-
-                       if (DBM::is_result($r)) {
-                               $found = true;
-                               if ($r['blocked']) {
-                                       $r['id'] = -1;
-                               }
-                               $contact = $r;
-                               $author["contact-id"] = $r["id"];
-                       }
+                       $condition = ["`uid` = ? AND `nurl` IN (?, ?) AND `network` != ? AND `rel` IN (?, ?)",
+                                       $importer["uid"], normalise_link($author["author-link"]), normalise_link($aliaslink),
+                                       NETWORK_STATUSNET, CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
+                       $contact = dba::selectFirst('contact', [], $condition);
                }
 
-               if (!$found && ($addr != "")) {
-                       $condition = ["`uid` = ? AND `addr` = ? AND `network` != ?",
-                                       $importer["uid"], $addr, NETWORK_STATUSNET];
-                       $r = dba::selectFirst('contact', [], $condition);
+               if (!DBM::is_result($contact) && ($addr != '')) {
+                       $condition = ["`uid` = ? AND `addr` = ? AND `network` != ? AND `rel` IN (?, ?)",
+                                       $importer["uid"], $addr, NETWORK_STATUSNET,
+                                       CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
+                       $contact = dba::selectFirst('contact', [], $condition);
+               }
 
-                       if (DBM::is_result($r)) {
-                               $found = true;
-                               if ($r['blocked']) {
-                                       $r['id'] = -1;
-                               }
-                               $contact = $r;
-                               $author["contact-id"] = $r["id"];
+               if (DBM::is_result($contact)) {
+                       if ($contact['blocked']) {
+                               $contact['id'] = -1;
                        }
+                       $author["contact-id"] = $contact["id"];
                }
 
                $avatarlist = [];
@@ -155,7 +135,7 @@ class OStatus
                $author["owner-avatar"] = $author["author-avatar"];
 
                // Only update the contacts if it is an OStatus contact
-               if ($r && ($r['id'] > 0) && !$onlyfetch && ($contact["network"] == NETWORK_OSTATUS)) {
+               if (DBM::is_result($contact) && ($contact['id'] > 0) && !$onlyfetch && ($contact["network"] == NETWORK_OSTATUS)) {
 
                        // Update contact data
                        $current = $contact;
@@ -191,7 +171,7 @@ class OStatus
 
                        $value = $xpath->evaluate('atom:author/poco:note/text()', $context)->item(0)->nodeValue;
                        if ($value != "") {
-                               $contact["about"] = html2bbcode($value);
+                               $contact["about"] = HTML::toBBCode($value);
                        }
 
                        $value = $xpath->evaluate('atom:author/poco:address/poco:formatted/text()', $context)->item(0)->nodeValue;
@@ -199,7 +179,7 @@ class OStatus
                                $contact["location"] = $value;
                        }
 
-                       $contact['name-date'] = Temporal::utcNow();
+                       $contact['name-date'] = DateTimeFormat::utcNow();
 
                        dba::update('contact', $contact, ['id' => $contact["id"]], $current);
 
@@ -209,7 +189,7 @@ class OStatus
                        }
 
                        // Ensure that we are having this contact (with uid=0)
-                       $cid = Contact::getIdForURL($aliaslink, 0);
+                       $cid = Contact::getIdForURL($aliaslink, 0, true);
 
                        if ($cid) {
                                $fields = ['url', 'nurl', 'name', 'nick', 'alias', 'about', 'location'];
@@ -220,7 +200,7 @@ class OStatus
                                                'nurl' => normalise_link($author["author-link"]),
                                                'nick' => $contact["nick"], 'alias' => $contact["alias"],
                                                'about' => $contact["about"], 'location' => $contact["location"],
-                                               'success_update' => Temporal::utcNow(), 'last-update' => Temporal::utcNow()];
+                                               'success_update' => DateTimeFormat::utcNow(), 'last-update' => DateTimeFormat::utcNow()];
 
                                dba::update('contact', $fields, ['id' => $cid], $old_contact);
 
@@ -266,13 +246,12 @@ class OStatus
                $xpath->registerNamespace('ostatus', NAMESPACE_OSTATUS);
                $xpath->registerNamespace('statusnet', NAMESPACE_STATUSNET);
 
-               $entries = $xpath->query('/atom:entry');
+               $contact = ["id" => 0];
 
-               foreach ($entries as $entry) {
-                       // fetch the author
-                       $author = self::fetchAuthor($xpath, $entry, $importer, $contact, true);
-                       return $author;
-               }
+               // Fetch the first author
+               $authordata = $xpath->query('//author')->item(0);
+               $author = self::fetchAuthor($xpath, $authordata, $importer, $contact, true);
+               return $author;
        }
 
        /**
@@ -488,6 +467,11 @@ class OStatus
                                        if (!$valid) {
                                                // If not, then it depends on this setting
                                                $valid = !Config::get('system', 'ostatus_full_threads');
+                                               if ($valid) {
+                                                       logger("Item with uri ".self::$itemlist[0]['uri']." will be imported due to the system settings.", LOGGER_DEBUG);
+                                               }
+                                       } else {
+                                               logger("Item with uri ".self::$itemlist[0]['uri']." belongs to a contact (".self::$itemlist[0]['contact-id']."). It will be imported.", LOGGER_DEBUG);
                                        }
                                        if ($valid) {
                                                // Never post a thread when the only interaction by our contact was a like
@@ -498,10 +482,16 @@ class OStatus
                                                                $valid = true;
                                                        }
                                                }
+                                               if ($valid) {
+                                                       logger("Item with uri ".self::$itemlist[0]['uri']." will be imported since the thread contains posts or shares.", LOGGER_DEBUG);
+                                               }
                                        }
                                } else {
                                        // But we will only import complete threads
                                        $valid = dba::exists('item', ['uid' => $importer["uid"], 'uri' => self::$itemlist[0]['parent-uri']]);
+                                       if ($valid) {
+                                               logger("Item with uri ".self::$itemlist[0]["uri"]." belongs to parent ".self::$itemlist[0]['parent-uri']." of user ".$importer["uid"].". It will be imported.", LOGGER_DEBUG);
+                                       }
                                }
 
                                if ($valid) {
@@ -547,22 +537,12 @@ class OStatus
        private static function deleteNotice($item)
        {
                $condition = ['uid' => $item['uid'], 'author-link' => $item['author-link'], 'uri' => $item['uri']];
-               $deleted = dba::selectFirst('item', ['id', 'parent-uri'], $condition);
-               if (!DBM::is_result($deleted)) {
-                       logger('Item from '.$item['author-link'].' with uri '.$item['uri'].' for user '.$item['uid']." wasn't found. We don't delete it. ");
+               if (!dba::exists('item', $condition)) {
+                       logger('Item from '.$item['author-link'].' with uri '.$item['uri'].' for user '.$item['uid']." wasn't found. We don't delete it.");
                        return;
                }
 
-               // Currently we don't have a central deletion function that we could use in this case
-               // The function "item_drop" doesn't work for that case
-               dba::update(
-                       'item',
-                       ['deleted' => true, 'title' => '', 'body' => '',
-                                       'edited' => Temporal::utcNow(), 'changed' => Temporal::utcNow()],
-                       ['id' => $deleted["id"]]
-               );
-
-               delete_thread($deleted["id"], $deleted["parent-uri"]);
+               Item::delete($condition);
 
                logger('Deleted item with uri '.$item['uri'].' for user '.$item['uid']);
        }
@@ -578,7 +558,7 @@ class OStatus
         */
        private static function processPost($xpath, $entry, &$item, $importer)
        {
-               $item["body"] = html2bbcode($xpath->query('atom:content/text()', $entry)->item(0)->nodeValue);
+               $item["body"] = HTML::toBBCode($xpath->query('atom:content/text()', $entry)->item(0)->nodeValue);
                $item["object-type"] = $xpath->query('activity:object-type/text()', $entry)->item(0)->nodeValue;
                if (($item["object-type"] == ACTIVITY_OBJ_BOOKMARK) || ($item["object-type"] == ACTIVITY_OBJ_EVENT)) {
                        $item["title"] = $xpath->query('atom:title/text()', $entry)->item(0)->nodeValue;
@@ -679,8 +659,9 @@ class OStatus
                // Mastodon Content Warning
                if (($item["verb"] == ACTIVITY_POST) && $xpath->evaluate('boolean(atom:summary)', $entry)) {
                        $clear_text = $xpath->query('atom:summary/text()', $entry)->item(0)->nodeValue;
-
-                       $item["body"] = html2bbcode($clear_text) . '[spoiler]' . $item["body"] . '[/spoiler]';
+                       if (!empty($clear_text)) {
+                               $item['content-warning'] = HTML::toBBCode($clear_text);
+                       }
                }
 
                if (($self != '') && empty($item['protocol'])) {
@@ -691,9 +672,11 @@ class OStatus
                        self::fetchConversation($item['conversation-href'], $item['conversation-uri']);
                }
 
-               if (isset($item["parent-uri"]) && ($related != '')) {
+               if (isset($item["parent-uri"])) {
                        if (!dba::exists('item', ['uid' => $importer["uid"], 'uri' => $item['parent-uri']])) {
-                               self::fetchRelated($related, $item["parent-uri"], $importer);
+                               if ($related != '') {
+                                       self::fetchRelated($related, $item["parent-uri"], $importer);
+                               }
                        } else {
                                logger('Reply with URI '.$item["uri"].' already existed for user '.$importer["uid"].'.', LOGGER_DEBUG);
                        }
@@ -748,6 +731,7 @@ class OStatus
 
                        $links = $xpath->query('//link');
                        if ($links) {
+                               $file = '';
                                foreach ($links as $link) {
                                        $attribute = self::readAttributes($link);
                                        if (($attribute['rel'] == 'alternate') && ($attribute['type'] == 'application/atom+xml')) {
@@ -1034,7 +1018,7 @@ class OStatus
                $item["author-link"] = $orig_author["author-link"];
                $item["author-avatar"] = $orig_author["author-avatar"];
 
-               $item["body"] = html2bbcode($orig_body);
+               $item["body"] = HTML::toBBCode($orig_body);
                $item["created"] = $orig_created;
                $item["edited"] = $orig_edited;
 
@@ -1261,6 +1245,7 @@ class OStatus
                $root->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
                $root->setAttribute("xmlns:mastodon", NAMESPACE_MASTODON);
 
+               $title = '';
                switch ($filter) {
                        case 'activity': $title = L10n::t('%s\'s timeline', $owner['name']); break;
                        case 'posts'   : $title = L10n::t('%s\'s posts'   , $owner['name']); break;
@@ -1273,7 +1258,7 @@ class OStatus
                XML::addElement($doc, $root, "title", $title);
                XML::addElement($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], $a->config["sitename"]));
                XML::addElement($doc, $root, "logo", $owner["photo"]);
-               XML::addElement($doc, $root, "updated", Temporal::convert("now", "UTC", "UTC", Temporal::ATOM));
+               XML::addElement($doc, $root, "updated", DateTimeFormat::utcNow(DateTimeFormat::ATOM));
 
                $author = self::addAuthor($doc, $owner);
                $root->appendChild($author);
@@ -1302,6 +1287,13 @@ class OStatus
                        "rel" => "self", "type" => "application/atom+xml"];
                XML::addElement($doc, $root, "link", "", $attributes);
 
+               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       $condition = ['uid' => $owner['uid'], 'self' => false, 'pending' => false,
+                                       'archive' => false, 'hidden' => false, 'blocked' => false];
+                       $members = dba::count('contact', $condition);
+                       XML::addElement($doc, $root, "statusnet:group_info", "", ["member_count" => $members]);
+               }
+
                return $root;
        }
 
@@ -1320,7 +1312,7 @@ class OStatus
        }
 
        /**
-        * @brief Adds attachement data to the XML document
+        * @brief Adds attachment data to the XML document
         *
         * @param object $doc  XML document
         * @param object $root XML root element where the hub links are added
@@ -1335,11 +1327,13 @@ class OStatus
                switch ($siteinfo["type"]) {
                        case 'photo':
                                $imgdata = Image::getInfoFromURL($siteinfo["image"]);
-                               $attributes = ["rel" => "enclosure",
-                                               "href" => $siteinfo["image"],
-                                               "type" => $imgdata["mime"],
-                                               "length" => intval($imgdata["size"])];
-                               XML::addElement($doc, $root, "link", "", $attributes);
+                               if ($imgdata) {
+                                       $attributes = ["rel" => "enclosure",
+                                                       "href" => $siteinfo["image"],
+                                                       "type" => $imgdata["mime"],
+                                                       "length" => intval($imgdata["size"])];
+                                       XML::addElement($doc, $root, "link", "", $attributes);
+                               }
                                break;
                        case 'video':
                                $attributes = ["rel" => "enclosure",
@@ -1355,12 +1349,14 @@ class OStatus
 
                if (!Config::get('system', 'ostatus_not_attach_preview') && ($siteinfo["type"] != "photo") && isset($siteinfo["image"])) {
                        $imgdata = Image::getInfoFromURL($siteinfo["image"]);
-                       $attributes = ["rel" => "enclosure",
-                                       "href" => $siteinfo["image"],
-                                       "type" => $imgdata["mime"],
-                                       "length" => intval($imgdata["size"])];
+                       if ($imgdata) {
+                               $attributes = ["rel" => "enclosure",
+                                               "href" => $siteinfo["image"],
+                                               "type" => $imgdata["mime"],
+                                               "length" => intval($imgdata["size"])];
 
-                       XML::addElement($doc, $root, "link", "", $attributes);
+                               XML::addElement($doc, $root, "link", "", $attributes);
+                       }
                }
 
                $arr = explode('[/attach],', $item['attach']);
@@ -1393,19 +1389,22 @@ class OStatus
         *
         * @return object author element
         */
-       private static function addAuthor($doc, $owner)
+       private static function addAuthor($doc, $owner, $show_profile = true)
        {
-               $r = q("SELECT `homepage`, `publish` FROM `profile` WHERE `uid` = %d AND `is-default` LIMIT 1", intval($owner["uid"]));
-               if (DBM::is_result($r)) {
-                       $profile = $r[0];
-               }
+               $profile = dba::selectFirst('profile', ['homepage', 'publish'], ['uid' => $owner['uid'], 'is-default' => true]);
                $author = $doc->createElement("author");
                XML::addElement($doc, $author, "id", $owner["url"]);
-               XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
+               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_GROUP);
+               } else {
+                       XML::addElement($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
+               }
                XML::addElement($doc, $author, "uri", $owner["url"]);
                XML::addElement($doc, $author, "name", $owner["nick"]);
                XML::addElement($doc, $author, "email", $owner["addr"]);
-               XML::addElement($doc, $author, "summary", bbcode($owner["about"], false, false, 7));
+               if ($show_profile) {
+                       XML::addElement($doc, $author, "summary", BBCode::convert($owner["about"], false, 7));
+               }
 
                $attributes = ["rel" => "alternate", "type" => "text/html", "href" => $owner["url"]];
                XML::addElement($doc, $author, "link", "", $attributes);
@@ -1430,30 +1429,33 @@ class OStatus
 
                XML::addElement($doc, $author, "poco:preferredUsername", $owner["nick"]);
                XML::addElement($doc, $author, "poco:displayName", $owner["name"]);
-               XML::addElement($doc, $author, "poco:note", bbcode($owner["about"], false, false, 7));
+               if ($show_profile) {
+                       XML::addElement($doc, $author, "poco:note", BBCode::convert($owner["about"], false, 7));
 
-               if (trim($owner["location"]) != "") {
-                       $element = $doc->createElement("poco:address");
-                       XML::addElement($doc, $element, "poco:formatted", $owner["location"]);
-                       $author->appendChild($element);
+                       if (trim($owner["location"]) != "") {
+                               $element = $doc->createElement("poco:address");
+                               XML::addElement($doc, $element, "poco:formatted", $owner["location"]);
+                               $author->appendChild($element);
+                       }
                }
 
-               if (trim($profile["homepage"]) != "") {
-                       $urls = $doc->createElement("poco:urls");
-                       XML::addElement($doc, $urls, "poco:type", "homepage");
-                       XML::addElement($doc, $urls, "poco:value", $profile["homepage"]);
-                       XML::addElement($doc, $urls, "poco:primary", "true");
-                       $author->appendChild($urls);
-               }
+               if (DBM::is_result($profile) && !$show_profile) {
+                       if (trim($profile["homepage"]) != "") {
+                               $urls = $doc->createElement("poco:urls");
+                               XML::addElement($doc, $urls, "poco:type", "homepage");
+                               XML::addElement($doc, $urls, "poco:value", $profile["homepage"]);
+                               XML::addElement($doc, $urls, "poco:primary", "true");
+                               $author->appendChild($urls);
+                       }
 
-               if (count($profile)) {
                        XML::addElement($doc, $author, "followers", "", ["url" => System::baseUrl()."/viewcontacts/".$owner["nick"]]);
                        XML::addElement($doc, $author, "statusnet:profile_info", "", ["local_id" => $owner["uid"]]);
-               }
 
-               if ($profile["publish"]) {
-                       XML::addElement($doc, $author, "mastodon:scope", "public");
+                       if ($profile["publish"]) {
+                               XML::addElement($doc, $author, "mastodon:scope", "public");
+                       }
                }
+
                return $author;
        }
 
@@ -1505,6 +1507,8 @@ class OStatus
         */
        private static function entry($doc, $item, $owner, $toplevel = false)
        {
+               $xml = null;
+
                $repeated_guid = self::getResharedGuid($item);
                if ($repeated_guid != "") {
                        $xml = self::reshareEntry($doc, $item, $owner, $repeated_guid, $toplevel);
@@ -1539,7 +1543,7 @@ class OStatus
                XML::addElement($doc, $source, "link", "", ["rel" => "alternate", "type" => "text/html", "href" => $contact["alias"]]);
                XML::addElement($doc, $source, "link", "", ["rel" => "self", "type" => "application/atom+xml", "href" => $contact["poll"]]);
                XML::addElement($doc, $source, "icon", $contact["photo"]);
-               XML::addElement($doc, $source, "updated", Temporal::convert($contact["success_update"]."+00:00", "UTC", "UTC", Temporal::ATOM));
+               XML::addElement($doc, $source, "updated", DateTimeFormat::utc($contact["success_update"]."+00:00", DateTimeFormat::ATOM));
 
                return $source;
        }
@@ -1613,7 +1617,7 @@ class OStatus
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
-               $title = self::entryHeader($doc, $entry, $owner, $toplevel);
+               $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                $r = q(
                        "SELECT * FROM `item` WHERE `uid` = %d AND `guid` = '%s' AND NOT `private` AND `network` IN ('%s', '%s', '%s') LIMIT 1",
@@ -1642,7 +1646,7 @@ class OStatus
 
                self::entryContent($doc, $as_object, $repeated_item, $owner, "", "", false);
 
-               $author = self::addAuthor($doc, $contact);
+               $author = self::addAuthor($doc, $contact, false);
                $as_object->appendChild($author);
 
                $as_object2 = $doc->createElement("activity:object");
@@ -1684,7 +1688,7 @@ class OStatus
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
-               $title = self::entryHeader($doc, $entry, $owner, $toplevel);
+               $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                $verb = NAMESPACE_ACTIVITY_SCHEMA."favorite";
                self::entryContent($doc, $entry, $item, $owner, "Favorite", $verb, false);
@@ -1807,7 +1811,7 @@ class OStatus
 
                $item["body"] = sprintf($message, $owner["nick"], $contact["nick"]);
 
-               self::entryHeader($doc, $entry, $owner, $toplevel);
+               self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                self::entryContent($doc, $entry, $item, $owner, $title);
 
@@ -1835,7 +1839,7 @@ class OStatus
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
-               $title = self::entryHeader($doc, $entry, $owner, $toplevel);
+               $title = self::entryHeader($doc, $entry, $owner, $item, $toplevel);
 
                XML::addElement($doc, $entry, "activity:object-type", ACTIVITY_OBJ_NOTE);
 
@@ -1856,12 +1860,18 @@ class OStatus
         *
         * @return string The title for the element
         */
-       private static function entryHeader($doc, &$entry, $owner, $toplevel)
+       private static function entryHeader($doc, &$entry, $owner, $item, $toplevel)
        {
                /// @todo Check if this title stuff is really needed (I guess not)
                if (!$toplevel) {
                        $entry = $doc->createElement("entry");
                        $title = sprintf("New note by %s", $owner["nick"]);
+
+                       if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                               $contact = self::contactEntry($item['author-link'], $owner);
+                               $author = self::addAuthor($doc, $contact, false);
+                               $entry->appendChild($author);
+                       }
                } else {
                        $entry = $doc->createElementNS(NAMESPACE_ATOM1, "entry");
 
@@ -1909,7 +1919,7 @@ class OStatus
                        $body = "[b]".$item['title']."[/b]\n\n".$body;
                }
 
-               $body = bbcode($body, false, false, 7);
+               $body = BBCode::convert($body, false, 7);
 
                XML::addElement($doc, $entry, "content", $body, ["type" => "html"]);
 
@@ -1923,8 +1933,8 @@ class OStatus
 
                XML::addElement($doc, $entry, "activity:verb", $verb);
 
-               XML::addElement($doc, $entry, "published", Temporal::convert($item["created"]."+00:00", "UTC", "UTC", Temporal::ATOM));
-               XML::addElement($doc, $entry, "updated", Temporal::convert($item["edited"]."+00:00", "UTC", "UTC", Temporal::ATOM));
+               XML::addElement($doc, $entry, "published", DateTimeFormat::utc($item["created"]."+00:00", DateTimeFormat::ATOM));
+               XML::addElement($doc, $entry, "updated", DateTimeFormat::utc($item["edited"]."+00:00", DateTimeFormat::ATOM));
        }
 
        /**
@@ -1937,7 +1947,7 @@ class OStatus
         * @param bool   $complete default true
         * @return void
         */
-       private static function entryFooter($doc, $entry, $item, $owner, $complete = true)
+       private static function entryFooter($doc, $entry, array $item, array $owner, $complete = true)
        {
                $mentioned = [];
 
@@ -1977,6 +1987,7 @@ class OStatus
 
                        if (isset($parent_item)) {
                                $r = dba::fetch_first("SELECT `conversation-uri`, `conversation-href` FROM `conversation` WHERE `item-uri` = ?", $parent_item);
+
                                if (DBM::is_result($r)) {
                                        if ($r['conversation-uri'] != '') {
                                                $conversation_uri = $r['conversation-uri'];
@@ -2016,12 +2027,10 @@ class OStatus
                $mentioned = $newmentions;
 
                foreach ($mentioned as $mention) {
-                       $r = q(
-                               "SELECT `forum`, `prv` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s'",
-                               intval($owner["uid"]),
-                               dbesc(normalise_link($mention))
-                       );
-                       if ($r[0]["forum"] || $r[0]["prv"]) {
+                       $condition = ['uid' => $owner['uid'], 'nurl' => normalise_link($mention)];
+                       $contact = dba::selectFirst('contact', ['forum', 'prv', 'self', 'contact-type'], $condition);
+                       if ($contact["forum"] || $contact["prv"] || ($owner['contact-type'] == ACCOUNT_TYPE_COMMUNITY) ||
+                               ($contact['self'] && ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY))) {
                                XML::addElement($doc, $entry, "link", "",
                                        [
                                                "rel" => "mentioned",
@@ -2038,6 +2047,14 @@ class OStatus
                        }
                }
 
+               if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
+                       XML::addElement($doc, $entry, "link", "", [
+                               "rel" => "mentioned",
+                               "ostatus:object-type" => "http://activitystrea.ms/schema/1.0/group",
+                               "href" => $owner['url']
+                       ]);
+               }
+
                if (!$item["private"]) {
                        XML::addElement($doc, $entry, "link", "", ["rel" => "ostatus:attention",
                                                                        "href" => "http://activityschema.org/collection/public"]);
@@ -2114,7 +2131,7 @@ class OStatus
                }
 
                $owner = dba::fetch_first(
-                       "SELECT `contact`.*, `user`.`nickname`, `user`.`timezone`, `user`.`page-flags`
+                       "SELECT `contact`.*, `user`.`nickname`, `user`.`timezone`, `user`.`page-flags`, `user`.`account-type`
                                FROM `contact` INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
                                WHERE `contact`.`self` AND `user`.`nickname` = ? LIMIT 1",
                        $owner_nick
@@ -2127,8 +2144,8 @@ class OStatus
                        $last_update = 'now -30 days';
                }
 
-               $check_date = Temporal::convert($last_update);
-               $authorid = Contact::getIdForURL($owner["url"], 0);
+               $check_date = DateTimeFormat::utc($last_update);
+               $authorid = Contact::getIdForURL($owner["url"], 0, true);
 
                $sql_extra = '';
                if ($filter === 'posts') {
@@ -2139,21 +2156,23 @@ class OStatus
                        $sql_extra .= sprintf(" AND `item`.`object-type` = '%s' ", dbesc(ACTIVITY_OBJ_COMMENT));
                }
 
+               if ($owner['account-type'] != ACCOUNT_TYPE_COMMUNITY) {
+                       $sql_extra .= sprintf(" AND `item`.`contact-id` = %d AND `item`.`author-id` = %d ", intval($owner["id"]), intval($authorid));
+               }
+
                $items = q(
                        "SELECT `item`.*, `item`.`id` AS `item_id` FROM `item` USE INDEX (`uid_contactid_created`)
                                STRAIGHT_JOIN `thread` ON `thread`.`iid` = `item`.`parent`
                                WHERE `item`.`uid` = %d
-                               AND `item`.`contact-id` = %d
-                               AND `item`.`author-id` = %d
                                AND `item`.`created` > '%s'
                                AND NOT `item`.`deleted`
                                AND NOT `item`.`private`
+                               AND `item`.`visible`
+                               AND `item`.`wall`
                                AND `thread`.`network` IN ('%s', '%s')
                                $sql_extra
                                ORDER BY `item`.`created` DESC LIMIT %d",
                        intval($owner["uid"]),
-                       intval($owner["id"]),
-                       intval($authorid),
                        dbesc($check_date),
                        dbesc(NETWORK_OSTATUS),
                        dbesc(NETWORK_DFRN),