]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/OStatus.php
Fixes/tye-hints
[friendica.git] / src / Protocol / OStatus.php
index 4538d36dfa11676844c858661493d1ddf81c0c89..f30add32b7ab701a98b4496d8be38e0e73721ba1 100644 (file)
@@ -4,12 +4,16 @@
  */
 namespace Friendica\Protocol;
 
+use DOMDocument;
+use DOMXPath;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
 use Friendica\Core\Cache;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
+use Friendica\Core\Lock;
 use Friendica\Core\System;
+use Friendica\Database\DBA;
 use Friendica\Database\DBM;
 use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
@@ -19,12 +23,8 @@ use Friendica\Model\User;
 use Friendica\Network\Probe;
 use Friendica\Object\Image;
 use Friendica\Util\DateTimeFormat;
-use Friendica\Util\Lock;
 use Friendica\Util\Network;
 use Friendica\Util\XML;
-use dba;
-use DOMDocument;
-use DOMXPath;
 
 require_once 'include/dba.php';
 require_once 'include/items.php';
@@ -52,23 +52,25 @@ class OStatus
         *
         * @return array Array of author related entries for the item
         */
-       private static function fetchAuthor($xpath, $context, $importer, &$contact, $onlyfetch)
+       private static function fetchAuthor(DOMXPath $xpath, $context, array $importer, array &$contact, $onlyfetch)
        {
                $author = [];
-               $author["author-link"] = $xpath->evaluate('atom:author/atom:uri/text()', $context)->item(0)->nodeValue;
-               $author["author-name"] = $xpath->evaluate('atom:author/atom:name/text()', $context)->item(0)->nodeValue;
-               $addr = $xpath->evaluate('atom:author/atom:email/text()', $context)->item(0)->nodeValue;
+               $author["author-link"] = XML::getFirstNodeValue($xpath, 'atom:author/atom:uri/text()', $context);
+               $author["author-name"] = XML::getFirstNodeValue($xpath, 'atom:author/atom:name/text()', $context);
+               $addr = XML::getFirstNodeValue($xpath, 'atom:author/atom:email/text()', $context);
 
                $aliaslink = $author["author-link"];
 
-               $alternate = $xpath->query("atom:author/atom:link[@rel='alternate']", $context)->item(0)->attributes;
-               if (is_object($alternate)) {
-                       foreach ($alternate as $attributes) {
+               $alternate_item = $xpath->query("atom:author/atom:link[@rel='alternate']", $context)->item(0);
+               if (is_object($alternate_item)) {
+                       foreach ($alternate_item->attributes as $attributes) {
                                if (($attributes->name == "href") && ($attributes->textContent != "")) {
                                        $author["author-link"] = $attributes->textContent;
                                }
                        }
                }
+               $author["author-id"] = Contact::getIdForURL($author["author-link"]);
+
                $author["contact-id"] = $contact["id"];
 
                $contact = null;
@@ -76,7 +78,7 @@ class OStatus
                        $condition = ["`uid` = ? AND `alias` = ? AND `network` != ? AND `rel` IN (?, ?)",
                                        $importer["uid"], $aliaslink, NETWORK_STATUSNET,
                                        CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
-                       $contact = dba::selectFirst('contact', [], $condition);
+                       $contact = DBA::selectFirst('contact', [], $condition);
                }
 
                if (!DBM::is_result($contact) && $author["author-link"] != '') {
@@ -87,14 +89,14 @@ class OStatus
                        $condition = ["`uid` = ? AND `nurl` IN (?, ?) AND `network` != ? AND `rel` IN (?, ?)",
                                        $importer["uid"], normalise_link($author["author-link"]), normalise_link($aliaslink),
                                        NETWORK_STATUSNET, CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
-                       $contact = dba::selectFirst('contact', [], $condition);
+                       $contact = DBA::selectFirst('contact', [], $condition);
                }
 
                if (!DBM::is_result($contact) && ($addr != '')) {
                        $condition = ["`uid` = ? AND `addr` = ? AND `network` != ? AND `rel` IN (?, ?)",
                                        $importer["uid"], $addr, NETWORK_STATUSNET,
                                        CONTACT_IS_SHARING, CONTACT_IS_FRIEND];
-                       $contact = dba::selectFirst('contact', [], $condition);
+                       $contact = DBA::selectFirst('contact', [], $condition);
                }
 
                if (DBM::is_result($contact)) {
@@ -126,14 +128,12 @@ class OStatus
                        $author["author-avatar"] = Probe::fixAvatar(current($avatarlist), $author["author-link"]);
                }
 
-               $displayname = $xpath->evaluate('atom:author/poco:displayName/text()', $context)->item(0)->nodeValue;
+               $displayname = XML::getFirstNodeValue($xpath, 'atom:author/poco:displayName/text()', $context);
                if ($displayname != "") {
                        $author["author-name"] = $displayname;
                }
 
-               $author["owner-name"] = $author["author-name"];
-               $author["owner-link"] = $author["author-link"];
-               $author["owner-avatar"] = $author["author-avatar"];
+               $author["owner-id"] = $author["author-id"];
 
                // Only update the contacts if it is an OStatus contact
                if (DBM::is_result($contact) && ($contact['id'] > 0) && !$onlyfetch && ($contact["network"] == NETWORK_OSTATUS)) {
@@ -155,34 +155,34 @@ class OStatus
                        $contact['url'] = $author["author-link"];
                        $contact['nurl'] = normalise_link($contact['url']);
 
-                       $value = $xpath->evaluate('atom:author/atom:uri/text()', $context)->item(0)->nodeValue;
+                       $value = XML::getFirstNodeValue($xpath, 'atom:author/atom:uri/text()', $context);
                        if ($value != "") {
                                $contact["alias"] = $value;
                        }
 
-                       $value = $xpath->evaluate('atom:author/poco:displayName/text()', $context)->item(0)->nodeValue;
+                       $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:displayName/text()', $context);
                        if ($value != "") {
                                $contact["name"] = $value;
                        }
 
-                       $value = $xpath->evaluate('atom:author/poco:preferredUsername/text()', $context)->item(0)->nodeValue;
+                       $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:preferredUsername/text()', $context);
                        if ($value != "") {
                                $contact["nick"] = $value;
                        }
 
-                       $value = $xpath->evaluate('atom:author/poco:note/text()', $context)->item(0)->nodeValue;
+                       $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:note/text()', $context);
                        if ($value != "") {
                                $contact["about"] = HTML::toBBCode($value);
                        }
 
-                       $value = $xpath->evaluate('atom:author/poco:address/poco:formatted/text()', $context)->item(0)->nodeValue;
+                       $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:address/poco:formatted/text()', $context);
                        if ($value != "") {
                                $contact["location"] = $value;
                        }
 
                        $contact['name-date'] = DateTimeFormat::utcNow();
 
-                       dba::update('contact', $contact, ['id' => $contact["id"]], $current);
+                       DBA::update('contact', $contact, ['id' => $contact["id"]], $current);
 
                        if (!empty($author["author-avatar"]) && ($author["author-avatar"] != $current['avatar'])) {
                                logger("Update profile picture for contact ".$contact["id"], LOGGER_DEBUG);
@@ -194,7 +194,7 @@ class OStatus
 
                        if ($cid) {
                                $fields = ['url', 'nurl', 'name', 'nick', 'alias', 'about', 'location'];
-                               $old_contact = dba::selectFirst('contact', $fields, ['id' => $cid]);
+                               $old_contact = DBA::selectFirst('contact', $fields, ['id' => $cid]);
 
                                // Update it with the current values
                                $fields = ['url' => $author["author-link"], 'name' => $contact["name"],
@@ -203,15 +203,19 @@ class OStatus
                                                'about' => $contact["about"], 'location' => $contact["location"],
                                                'success_update' => DateTimeFormat::utcNow(), 'last-update' => DateTimeFormat::utcNow()];
 
-                               dba::update('contact', $fields, ['id' => $cid], $old_contact);
+                               DBA::update('contact', $fields, ['id' => $cid], $old_contact);
 
                                // Update the avatar
-                               Contact::updateAvatar($author["author-avatar"], 0, $cid);
+                               if (!empty($author["author-avatar"])) {
+                                       Contact::updateAvatar($author["author-avatar"], 0, $cid);
+                               }
                        }
 
                        $contact["generation"] = 2;
                        $contact["hide"] = false; // OStatus contacts are never hidden
-                       $contact["photo"] = $author["author-avatar"];
+                       if (!empty($author["author-avatar"])) {
+                               $contact["photo"] = $author["author-avatar"];
+                       }
                        $gcid = GContact::update($contact);
 
                        GContact::link($gcid, $contact["uid"], $contact["id"]);
@@ -228,7 +232,7 @@ class OStatus
         *
         * @return array Array of author related entries for the item
         */
-       public static function salmonAuthor($xml, $importer)
+       public static function salmonAuthor($xml, array $importer)
        {
                if ($xml == "") {
                        return;
@@ -282,7 +286,7 @@ class OStatus
         * @param string $hub      Called by reference, returns the fetched hub data
         * @return void
         */
-       public static function import($xml, $importer, &$contact, &$hub)
+       public static function import($xml, array $importer, array &$contact, &$hub)
        {
                self::process($xml, $importer, $contact, $hub);
        }
@@ -299,7 +303,7 @@ class OStatus
         *
         * @return boolean Could the XML be processed?
         */
-       private static function process($xml, $importer, &$contact, &$hub, $stored = false, $initialize = true)
+       private static function process($xml, array $importer, array &$contact, &$hub, $stored = false, $initialize = true)
        {
                if ($initialize) {
                        self::$itemlist = [];
@@ -325,12 +329,15 @@ class OStatus
                $xpath->registerNamespace('statusnet', NAMESPACE_STATUSNET);
 
                $hub = "";
-               $hub_attributes = $xpath->query("/atom:feed/atom:link[@rel='hub']")->item(0)->attributes;
-               if (is_object($hub_attributes)) {
-                       foreach ($hub_attributes as $hub_attribute) {
-                               if ($hub_attribute->name == "href") {
-                                       $hub = $hub_attribute->textContent;
-                                       logger("Found hub ".$hub, LOGGER_DEBUG);
+               $hub_items = $xpath->query("/atom:feed/atom:link[@rel='hub']")->item(0);
+               if (is_object($hub_items)) {
+                       $hub_attributes = $hub_items->attributes;
+                       if (is_object($hub_attributes)) {
+                               foreach ($hub_attributes as $hub_attribute) {
+                                       if ($hub_attribute->name == "href") {
+                                               $hub = $hub_attribute->textContent;
+                                               logger("Found hub ".$hub, LOGGER_DEBUG);
+                                       }
                                }
                        }
                }
@@ -338,10 +345,9 @@ class OStatus
                $header = [];
                $header["uid"] = $importer["uid"];
                $header["network"] = NETWORK_OSTATUS;
-               $header["type"] = "remote";
                $header["wall"] = 0;
                $header["origin"] = 0;
-               $header["gravity"] = GRAVITY_PARENT;
+               $header["gravity"] = GRAVITY_COMMENT;
 
                $first_child = $doc->firstChild->tagName;
 
@@ -390,7 +396,7 @@ class OStatus
                                $author = self::fetchAuthor($xpath, $entry, $importer, $contact, $stored);
                        }
 
-                       $value = $xpath->evaluate('atom:author/poco:preferredUsername/text()', $entry)->item(0)->nodeValue;
+                       $value = XML::getFirstNodeValue($xpath, 'atom:author/poco:preferredUsername/text()', $entry);
                        if ($value != "") {
                                $nickname = $value;
                        } else {
@@ -399,9 +405,9 @@ class OStatus
 
                        $item = array_merge($header, $author);
 
-                       $item["uri"] = $xpath->query('atom:id/text()', $entry)->item(0)->nodeValue;
+                       $item["uri"] = XML::getFirstNodeValue($xpath, 'atom:id/text()', $entry);
 
-                       $item["verb"] = $xpath->query('activity:verb/text()', $entry)->item(0)->nodeValue;
+                       $item["verb"] = XML::getFirstNodeValue($xpath, 'activity:verb/text()', $entry);
 
                        // Delete a message
                        if (in_array($item["verb"], ['qvitter-delete-notice', ACTIVITY_DELETE, 'delete'])) {
@@ -441,6 +447,7 @@ class OStatus
                        }
 
                        if ($item["verb"] == NAMESPACE_OSTATUS."/unfollow") {
+                               $dummy = null;
                                Contact::removeFollower($importer, $contact, $item, $dummy);
                                continue;
                        }
@@ -452,6 +459,7 @@ class OStatus
                                $item["verb"] = ACTIVITY_LIKE;
                                $item["parent-uri"] = $orig_uri;
                                $item["gravity"] = GRAVITY_ACTIVITY;
+                               $item["object-type"] = ACTIVITY_OBJ_NOTE;
                        }
 
                        // http://activitystrea.ms/schema/1.0/rsvp-yes
@@ -513,9 +521,9 @@ class OStatus
                                                        logger("Item with uri ".$item["uri"]." is from a blocked contact.", LOGGER_DEBUG);
                                                } else {
                                                        // We are having duplicated entries. Hopefully this solves it.
-                                                       if (Lock::set('ostatus_process_item_insert')) {
+                                                       if (Lock::acquire('ostatus_process_item_insert')) {
                                                                $ret = Item::insert($item);
-                                                               Lock::remove('ostatus_process_item_insert');
+                                                               Lock::release('ostatus_process_item_insert');
                                                                logger("Item with uri ".$item["uri"]." for user ".$importer["uid"].' stored. Return value: '.$ret);
                                                        } else {
                                                                $ret = Item::insert($item);
@@ -532,10 +540,11 @@ class OStatus
        }
 
        /**
-        * @param object $item item
+        * Removes notice item from database
+        * @param array $item item
         * @return void
         */
-       private static function deleteNotice($item)
+       private static function deleteNotice(array $item)
        {
                $condition = ['uid' => $item['uid'], 'author-id' => $item['author-id'], 'uri' => $item['uri']];
                if (!Item::exists($condition)) {
@@ -557,21 +566,20 @@ class OStatus
         * @param array  $importer user record of the importing user
         * @return void
         */
-       private static function processPost($xpath, $entry, &$item, $importer)
+       private static function processPost(DOMXPath $xpath, $entry, array &$item, array $importer)
        {
-               $item["body"] = HTML::toBBCode($xpath->query('atom:content/text()', $entry)->item(0)->nodeValue);
-               $item["object-type"] = $xpath->query('activity:object-type/text()', $entry)->item(0)->nodeValue;
+               $item["body"] = HTML::toBBCode(XML::getFirstNodeValue($xpath, 'atom:content/text()', $entry));
+               $item["object-type"] = XML::getFirstNodeValue($xpath, 'activity:object-type/text()', $entry);
                if (($item["object-type"] == ACTIVITY_OBJ_BOOKMARK) || ($item["object-type"] == ACTIVITY_OBJ_EVENT)) {
-                       $item["title"] = $xpath->query('atom:title/text()', $entry)->item(0)->nodeValue;
-                       $item["body"] = $xpath->query('atom:summary/text()', $entry)->item(0)->nodeValue;
+                       $item["title"] = XML::getFirstNodeValue($xpath, 'atom:title/text()', $entry);
+                       $item["body"] = XML::getFirstNodeValue($xpath, 'atom:summary/text()', $entry);
                } elseif ($item["object-type"] == ACTIVITY_OBJ_QUESTION) {
-                       $item["title"] = $xpath->query('atom:title/text()', $entry)->item(0)->nodeValue;
+                       $item["title"] = XML::getFirstNodeValue($xpath, 'atom:title/text()', $entry);
                }
 
-               $item["created"] = $xpath->query('atom:published/text()', $entry)->item(0)->nodeValue;
-               $item["edited"] = $xpath->query('atom:updated/text()', $entry)->item(0)->nodeValue;
-               $conversation = $xpath->query('ostatus:conversation/text()', $entry)->item(0)->nodeValue;
-               $item['conversation-uri'] = $conversation;
+               $item["created"] = XML::getFirstNodeValue($xpath, 'atom:published/text()', $entry);
+               $item["edited"] = XML::getFirstNodeValue($xpath, 'atom:updated/text()', $entry);
+               $item['conversation-uri'] = XML::getFirstNodeValue($xpath, 'ostatus:conversation/text()', $entry);
 
                $conv = $xpath->query('ostatus:conversation', $entry);
                if (is_object($conv->item(0))) {
@@ -610,9 +618,12 @@ class OStatus
                                foreach ($category->attributes as $attributes) {
                                        if ($attributes->name == "term") {
                                                $term = $attributes->textContent;
-                                               if (strlen($item["tag"])) {
+                                               if (!empty($item["tag"])) {
                                                        $item["tag"] .= ',';
+                                               } else {
+                                                       $item["tag"] = '';
                                                }
+
                                                $item["tag"] .= "#[url=".System::baseUrl()."/search?tag=".$term."]".$term."[/url]";
                                        }
                                }
@@ -659,7 +670,7 @@ class OStatus
 
                // Mastodon Content Warning
                if (($item["verb"] == ACTIVITY_POST) && $xpath->evaluate('boolean(atom:summary)', $entry)) {
-                       $clear_text = $xpath->query('atom:summary/text()', $entry)->item(0)->nodeValue;
+                       $clear_text = XML::getFirstNodeValue($xpath, 'atom:summary/text()', $entry);
                        if (!empty($clear_text)) {
                                $item['content-warning'] = HTML::toBBCode($clear_text);
                        }
@@ -681,11 +692,9 @@ class OStatus
                        } else {
                                logger('Reply with URI '.$item["uri"].' already existed for user '.$importer["uid"].'.', LOGGER_DEBUG);
                        }
-
-                       $item["type"] = 'remote-comment';
-                       $item["gravity"] = GRAVITY_COMMENT;
                } else {
                        $item["parent-uri"] = $item["uri"];
+                       $item["gravity"] = GRAVITY_PARENT;
                }
 
                if (($item['author-link'] != '') && !empty($item['protocol'])) {
@@ -786,7 +795,7 @@ class OStatus
 
                        $conv_data['protocol'] = PROTOCOL_SPLITTED_CONV;
                        $conv_data['network'] = NETWORK_OSTATUS;
-                       $conv_data['uri'] = $xpath->query('atom:id/text()', $entry)->item(0)->nodeValue;
+                       $conv_data['uri'] = XML::getFirstNodeValue($xpath, 'atom:id/text()', $entry);
 
                        $inreplyto = $xpath->query('thr:in-reply-to', $entry);
                        if (is_object($inreplyto->item(0))) {
@@ -797,8 +806,7 @@ class OStatus
                                }
                        }
 
-                       $conv = $xpath->query('ostatus:conversation/text()', $entry)->item(0)->nodeValue;
-                       $conv_data['conversation-uri'] = $conv;
+                       $conv_data['conversation-uri'] = XML::getFirstNodeValue($xpath, 'ostatus:conversation/text()', $entry);
 
                        $conv = $xpath->query('ostatus:conversation', $entry);
                        if (is_object($conv->item(0))) {
@@ -827,9 +835,9 @@ class OStatus
                        $conv_data['source'] = $doc2->saveXML();
 
                        $condition = ['item-uri' => $conv_data['uri'],'protocol' => PROTOCOL_OSTATUS_FEED];
-                       if (dba::exists('conversation', $condition)) {
+                       if (DBA::exists('conversation', $condition)) {
                                logger('Delete deprecated entry for URI '.$conv_data['uri'], LOGGER_DEBUG);
-                               dba::delete('conversation', ['item-uri' => $conv_data['uri']]);
+                               DBA::delete('conversation', ['item-uri' => $conv_data['uri']]);
                        }
 
                        logger('Store conversation data for uri '.$conv_data['uri'], LOGGER_DEBUG);
@@ -848,10 +856,10 @@ class OStatus
         * @param array  $item The item array
         * @return void
         */
-       private static function fetchSelf($self, &$item)
+       private static function fetchSelf($self, array &$item)
        {
                $condition = ['`item-uri` = ? AND `protocol` IN (?, ?)', $self, PROTOCOL_DFRN, PROTOCOL_OSTATUS_SALMON];
-               if (dba::exists('conversation', $condition)) {
+               if (DBA::exists('conversation', $condition)) {
                        logger('Conversation '.$item['uri'].' is already stored.', LOGGER_DEBUG);
                        return;
                }
@@ -886,7 +894,7 @@ class OStatus
        private static function fetchRelated($related, $related_uri, $importer)
        {
                $condition = ['`item-uri` = ? AND `protocol` IN (?, ?)', $related_uri, PROTOCOL_DFRN, PROTOCOL_OSTATUS_SALMON];
-               $conversation = dba::selectFirst('conversation', ['source', 'protocol'], $condition);
+               $conversation = DBA::selectFirst('conversation', ['source', 'protocol'], $condition);
                if (DBM::is_result($conversation)) {
                        $stored = true;
                        $xml = $conversation['source'];
@@ -896,7 +904,7 @@ class OStatus
                        }
                        if ($conversation['protocol'] == PROTOCOL_OSTATUS_SALMON) {
                                logger('Delete invalid cached XML for URI '.$related_uri, LOGGER_DEBUG);
-                               dba::delete('conversation', ['item-uri' => $related_uri]);
+                               DBA::delete('conversation', ['item-uri' => $related_uri]);
                        }
                }
 
@@ -966,7 +974,7 @@ class OStatus
                // Finally we take the data that we fetched from "ostatus:conversation"
                if ($xml == '') {
                        $condition = ['item-uri' => $related_uri, 'protocol' => PROTOCOL_SPLITTED_CONV];
-                       $conversation = dba::selectFirst('conversation', ['source'], $condition);
+                       $conversation = DBA::selectFirst('conversation', ['source'], $condition);
                        if (DBM::is_result($conversation)) {
                                $stored = true;
                                logger('Got cached XML from conversation for URI '.$related_uri, LOGGER_DEBUG);
@@ -992,7 +1000,7 @@ class OStatus
         *
         * @return array with data from links
         */
-       private static function processRepeatedItem($xpath, $entry, &$item, $importer)
+       private static function processRepeatedItem(DOMXPath $xpath, $entry, array &$item, array $importer)
        {
                $activityobjects = $xpath->query('activity:object', $entry)->item(0);
 
@@ -1002,22 +1010,22 @@ class OStatus
 
                $link_data = [];
 
-               $orig_uri = $xpath->query('atom:id/text()', $activityobjects)->item(0)->nodeValue;
+               $orig_uri = XML::getFirstNodeValue($xpath, 'atom:id/text()', $activityobjects);
 
                $links = $xpath->query("atom:link", $activityobjects);
                if ($links) {
                        $link_data = self::processLinks($links, $item);
                }
 
-               $orig_body = $xpath->query('atom:content/text()', $activityobjects)->item(0)->nodeValue;
-               $orig_created = $xpath->query('atom:published/text()', $activityobjects)->item(0)->nodeValue;
-               $orig_edited = $xpath->query('atom:updated/text()', $activityobjects)->item(0)->nodeValue;
+               $orig_body = XML::getFirstNodeValue($xpath, 'atom:content/text()', $activityobjects);
+               $orig_created = XML::getFirstNodeValue($xpath, 'atom:published/text()', $activityobjects);
+               $orig_edited = XML::getFirstNodeValue($xpath, 'atom:updated/text()', $activityobjects);
 
                $orig_author = self::fetchAuthor($xpath, $activityobjects, $importer, $dummy, false);
 
                $item["author-name"] = $orig_author["author-name"];
                $item["author-link"] = $orig_author["author-link"];
-               $item["author-avatar"] = $orig_author["author-avatar"];
+               $item["author-id"] = $orig_author["author-id"];
 
                $item["body"] = HTML::toBBCode($orig_body);
                $item["created"] = $orig_created;
@@ -1025,9 +1033,9 @@ class OStatus
 
                $item["uri"] = $orig_uri;
 
-               $item["verb"] = $xpath->query('activity:verb/text()', $activityobjects)->item(0)->nodeValue;
+               $item["verb"] = XML::getFirstNodeValue($xpath, 'activity:verb/text()', $activityobjects);
 
-               $item["object-type"] = $xpath->query('activity:object-type/text()', $activityobjects)->item(0)->nodeValue;
+               $item["object-type"] = XML::getFirstNodeValue($xpath, 'activity:object-type/text()', $activityobjects);
 
                $inreplyto = $xpath->query('thr:in-reply-to', $activityobjects);
                if (is_object($inreplyto->item(0))) {
@@ -1049,14 +1057,14 @@ class OStatus
         *
         * @return array with data from the links
         */
-       private static function processLinks($links, &$item)
+       private static function processLinks($links, array &$item)
        {
                $link_data = ['add_body' => '', 'self' => ''];
 
                foreach ($links as $link) {
                        $attribute = self::readAttributes($link);
 
-                       if (($attribute['rel'] != "") && ($attribute['href'] != "")) {
+                       if (!empty($attribute['rel']) && !empty($attribute['href'])) {
                                switch ($attribute['rel']) {
                                        case "alternate":
                                                $item["plink"] = $attribute['href'];
@@ -1078,13 +1086,15 @@ class OStatus
                                                if ($filetype == 'image') {
                                                        $link_data['add_body'] .= "\n[img]".$attribute['href'].'[/img]';
                                                } else {
-                                                       if (strlen($item["attach"])) {
+                                                       if (!empty($item["attach"])) {
                                                                $item["attach"] .= ',';
+                                                       } else {
+                                                               $item["attach"] = '';
                                                        }
                                                        if (!isset($attribute['length'])) {
                                                                $attribute['length'] = "0";
                                                        }
-                                                       $item["attach"] .= '[attach]href="'.$attribute['href'].'" length="'.$attribute['length'].'" type="'.$attribute['type'].'" title="'.$attribute['title'].'"[/attach]';
+                                                       $item["attach"] .= '[attach]href="'.$attribute['href'].'" length="'.$attribute['length'].'" type="'.$attribute['type'].'" title="'.defaults($attribute, 'title', '').'"[/attach]';
                                                }
                                                break;
                                        case "related":
@@ -1098,7 +1108,7 @@ class OStatus
                                                }
                                                break;
                                        case "self":
-                                               if ($item["plink"] == '') {
+                                               if (empty($item["plink"])) {
                                                        $item["plink"] = $attribute['href'];
                                                }
                                                $link_data['self'] = $attribute['href'];
@@ -1149,7 +1159,7 @@ class OStatus
         *
         * @return string The guid if the post is a reshare
         */
-       private static function getResharedGuid($item)
+       private static function getResharedGuid(array $item)
        {
                $body = trim($item["body"]);
 
@@ -1172,12 +1182,12 @@ class OStatus
 
                $guid = "";
                preg_match("/guid='(.*?)'/ism", $attributes, $matches);
-               if ($matches[1] != "") {
+               if (!empty($matches[1])) {
                        $guid = $matches[1];
                }
 
                preg_match('/guid="(.*?)"/ism', $attributes, $matches);
-               if ($matches[1] != "") {
+               if (!empty($matches[1])) {
                        $guid = $matches[1];
                }
 
@@ -1230,7 +1240,7 @@ class OStatus
         *
         * @return object header root element
         */
-       private static function addHeader($doc, $owner, $filter)
+       private static function addHeader(DOMDocument $doc, array $owner, $filter)
        {
                $a = get_app();
 
@@ -1257,7 +1267,7 @@ class OStatus
                XML::addElement($doc, $root, "generator", FRIENDICA_PLATFORM, $attributes);
                XML::addElement($doc, $root, "id", System::baseUrl() . "/profile/" . $owner["nick"]);
                XML::addElement($doc, $root, "title", $title);
-               XML::addElement($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], $a->config["sitename"]));
+               XML::addElement($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], Config::get('config', 'sitename')));
                XML::addElement($doc, $root, "logo", $owner["photo"]);
                XML::addElement($doc, $root, "updated", DateTimeFormat::utcNow(DateTimeFormat::ATOM));
 
@@ -1291,7 +1301,7 @@ class OStatus
                if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
                        $condition = ['uid' => $owner['uid'], 'self' => false, 'pending' => false,
                                        'archive' => false, 'hidden' => false, 'blocked' => false];
-                       $members = dba::count('contact', $condition);
+                       $members = DBA::count('contact', $condition);
                        XML::addElement($doc, $root, "statusnet:group_info", "", ["member_count" => $members]);
                }
 
@@ -1306,7 +1316,7 @@ class OStatus
         * @param object $nick nick
         * @return void
         */
-       public static function hublinks($doc, $root, $nick)
+       public static function hublinks(DOMDocument $doc, $root, $nick)
        {
                $h = System::baseUrl() . '/pubsubhubbub/'.$nick;
                XML::addElement($doc, $root, "link", "", ["href" => $h, "rel" => "hub"]);
@@ -1320,7 +1330,7 @@ class OStatus
         * @param array  $item Data of the item that is to be posted
         * @return void
         */
-       private static function getAttachment($doc, $root, $item)
+       private static function getAttachment(DOMDocument $doc, $root, $item)
        {
                $o = "";
                $siteinfo = BBCode::getAttachedData($item["body"]);
@@ -1387,12 +1397,13 @@ class OStatus
         *
         * @param object $doc   XML document
         * @param array  $owner Contact data of the poster
+        * @param bool   $show_profile Whether to show profile
         *
         * @return object author element
         */
-       private static function addAuthor($doc, $owner, $show_profile = true)
+       private static function addAuthor(DOMDocument $doc, array $owner, $show_profile = true)
        {
-               $profile = dba::selectFirst('profile', ['homepage', 'publish'], ['uid' => $owner['uid'], 'is-default' => true]);
+               $profile = DBA::selectFirst('profile', ['homepage', 'publish'], ['uid' => $owner['uid'], 'is-default' => true]);
                $author = $doc->createElement("author");
                XML::addElement($doc, $author, "id", $owner["url"]);
                if ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY) {
@@ -1473,9 +1484,9 @@ class OStatus
         *
         * @return string activity
         */
-       private static function constructVerb($item)
+       private static function constructVerb(array $item)
        {
-               if ($item['verb']) {
+               if (!empty($item['verb'])) {
                        return $item['verb'];
                }
 
@@ -1489,7 +1500,7 @@ class OStatus
         *
         * @return string Object type
         */
-       private static function constructObjecttype($item)
+       private static function constructObjecttype(array $item)
        {
                if (in_array($item['object-type'], [ACTIVITY_OBJ_NOTE, ACTIVITY_OBJ_COMMENT]))
                        return $item['object-type'];
@@ -1506,7 +1517,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function entry($doc, $item, $owner, $toplevel = false)
+       private static function entry(DOMDocument $doc, array $item, array $owner, $toplevel = false)
        {
                $xml = null;
 
@@ -1536,7 +1547,7 @@ class OStatus
         *
         * @return object Source element
         */
-       private static function sourceEntry($doc, $contact)
+       private static function sourceEntry(DOMDocument $doc, array $contact)
        {
                $source = $doc->createElement("source");
                XML::addElement($doc, $source, "id", $contact["poll"]);
@@ -1557,7 +1568,7 @@ class OStatus
         *
         * @return array Contact array
         */
-       private static function contactEntry($url, $owner)
+       private static function contactEntry($url, array $owner)
        {
                $r = q(
                        "SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` IN (0, %d) ORDER BY `uid` DESC LIMIT 1",
@@ -1612,7 +1623,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function reshareEntry($doc, $item, $owner, $repeated_guid, $toplevel)
+       private static function reshareEntry(DOMDocument $doc, array $item, array $owner, $repeated_guid, $toplevel)
        {
                if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
@@ -1628,6 +1639,7 @@ class OStatus
                }
 
                $contact = self::contactEntry($repeated_item['author-link'], $owner);
+               $contact['account-type'] = $contact['contact-type'];
 
                $title = $owner["nick"]." repeated a notice by ".$contact["nick"];
 
@@ -1675,7 +1687,7 @@ class OStatus
         *
         * @return object Entry element with "like"
         */
-       private static function likeEntry($doc, $item, $owner, $toplevel)
+       private static function likeEntry(DOMDocument $doc, array $item, array $owner, $toplevel)
        {
                if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
@@ -1710,7 +1722,7 @@ class OStatus
         *
         * @return object author element
         */
-       private static function addPersonObject($doc, $owner, $contact)
+       private static function addPersonObject(DOMDocument $doc, array $owner, array $contact)
        {
                $object = $doc->createElement("activity:object");
                XML::addElement($doc, $object, "activity:object-type", ACTIVITY_OBJ_PERSON);
@@ -1756,7 +1768,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function followEntry($doc, $item, $owner, $toplevel)
+       private static function followEntry(DOMDocument $doc, array $item, array $owner, $toplevel)
        {
                $item["id"] = $item["parent"] = 0;
                $item["created"] = $item["edited"] = date("c");
@@ -1821,7 +1833,7 @@ class OStatus
         *
         * @return object Entry element
         */
-       private static function noteEntry($doc, $item, $owner, $toplevel)
+       private static function noteEntry(DOMDocument $doc, array $item, array $owner, $toplevel)
        {
                if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
@@ -1848,7 +1860,7 @@ class OStatus
         *
         * @return string The title for the element
         */
-       private static function entryHeader($doc, &$entry, $owner, $item, $toplevel)
+       private static function entryHeader(DOMDocument $doc, &$entry, array $owner, array $item, $toplevel)
        {
                /// @todo Check if this title stuff is really needed (I guess not)
                if (!$toplevel) {
@@ -1892,7 +1904,7 @@ class OStatus
         * @param bool   $complete Add the "status_net" element?
         * @return void
         */
-       private static function entryContent($doc, $entry, $item, $owner, $title, $verb = "", $complete = true)
+       private static function entryContent(DOMDocument $doc, $entry, array $item, array $owner, $title, $verb = "", $complete = true)
        {
                if ($verb == "") {
                        $verb = self::constructVerb($item);
@@ -1935,7 +1947,7 @@ class OStatus
         * @param bool   $complete default true
         * @return void
         */
-       private static function entryFooter($doc, $entry, array $item, array $owner, $complete = true)
+       private static function entryFooter(DOMDocument $doc, $entry, array $item, array $owner, $complete = true)
        {
                $mentioned = [];
 
@@ -1971,12 +1983,12 @@ class OStatus
                        $conversation_uri = $conversation_href;
 
                        if (isset($parent_item)) {
-                               $conversation = dba::selectFirst('conversation', ['conversation-uri', 'conversation-href'], ['item-uri' => $parent_item]);
+                               $conversation = DBA::selectFirst('conversation', ['conversation-uri', 'conversation-href'], ['item-uri' => $parent_item]);
                                if (DBM::is_result($conversation)) {
-                                       if ($r['conversation-uri'] != '') {
+                                       if ($conversation['conversation-uri'] != '') {
                                                $conversation_uri = $conversation['conversation-uri'];
                                        }
-                                       if ($r['conversation-href'] != '') {
+                                       if ($conversation['conversation-href'] != '') {
                                                $conversation_href = $conversation['conversation-href'];
                                        }
                                }
@@ -2012,7 +2024,7 @@ class OStatus
 
                foreach ($mentioned as $mention) {
                        $condition = ['uid' => $owner['uid'], 'nurl' => normalise_link($mention)];
-                       $contact = dba::selectFirst('contact', ['forum', 'prv', 'self', 'contact-type'], $condition);
+                       $contact = DBA::selectFirst('contact', ['forum', 'prv', 'self', 'contact-type'], $condition);
                        if ($contact["forum"] || $contact["prv"] || ($owner['contact-type'] == ACCOUNT_TYPE_COMMUNITY) ||
                                ($contact['self'] && ($owner['account-type'] == ACCOUNT_TYPE_COMMUNITY))) {
                                XML::addElement($doc, $entry, "link", "",
@@ -2189,7 +2201,7 @@ class OStatus
         *
         * @return string XML for the salmon
         */
-       public static function salmon($item, $owner)
+       public static function salmon(array $item, array $owner)
        {
                $doc = new DOMDocument('1.0', 'utf-8');
                $doc->formatOutput = true;