Moved empty post detection

[friendica.git] / src / Protocol / Relay.php

diff --git a/src/Protocol/Relay.php b/src/Protocol/Relay.php
index c4432e59a3817dbd470c751dd4b72fca7b209f77..7d62ba576ea73620739b30b079a7cda7bd184572 100644 (file)
--- a/src/Protocol/Relay.php
+++ b/src/Protocol/Relay.php
@@ -21,7 +21,9 @@
 
 namespace Friendica\Protocol;
 
+use Friendica\Content\Smilies;
 use Friendica\Content\Text\BBCode;
+use Friendica\Core\Cache\Enum\Duration;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Database\DBA;
@@ -33,6 +35,7 @@ use Friendica\Model\Item;
 use Friendica\Model\Post;
 use Friendica\Model\Search;
 use Friendica\Model\Tag;
+use Friendica\Model\User;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Strings;
 
@@ -50,13 +53,16 @@ class Relay
        /**
         * Check if a post is wanted
         *
-        * @param array $tags
+        * @param array  $tags
         * @param string $body
-        * @param int $authorid
+        * @param int    $authorid
         * @param string $url
+        * @param string $network
+        * @param int    $causerid
+        * @param array  $languages
         * @return boolean "true" is the post is wanted by the system
         */
-       public static function isSolicitedPost(array $tags, string $body, int $authorid, string $url, string $network = '', int $causerid = 0): bool
+       public static function isSolicitedPost(array $tags, string $body, int $authorid, string $url, string $network = '', int $causerid = 0, array $languages = []): bool
        {
                $config = DI::config();
 
@@ -125,7 +131,7 @@ class Relay
                        }
                }
 
-               if (!self::isWantedLanguage($body, 0, $authorid)) {
+               if (!self::isWantedLanguage($body, 0, $authorid, $languages)) {
                        Logger::info('Unwanted or Undetected language found - rejected', ['network' => $network, 'url' => $url, 'causer' => $causer, 'tags' => $tags]);
                        return false;
                }
@@ -168,24 +174,46 @@ class Relay
         * @param string $body
         * @param int    $uri_id
         * @param int    $author_id
+        * @param array  $languages
         * @return boolean
         */
-       public static function isWantedLanguage(string $body, int $uri_id = 0, int $author_id = 0)
+       public static function isWantedLanguage(string $body, int $uri_id = 0, int $author_id = 0, array $languages = [])
        {
-               $languages = [];
-               foreach (Item::getLanguageArray($body, 10, $uri_id, $author_id) as $language => $reliability) {
-                       if ($reliability > 0) {
-                               $languages[] = $language;
+               $detected = [];
+               $quality  = DI::config()->get('system', 'relay_language_quality');
+               foreach (Item::getLanguageArray($body, DI::config()->get('system', 'relay_languages'), $uri_id, $author_id) as $language => $reliability) {
+                       if (($reliability >= $quality) && ($quality > 0)) {
+                               $detected[] = $language;
                        }
                }
 
-               Logger::debug('Got languages', ['languages' => $languages, 'body' => $body]);
+               if (empty($languages) && empty($detected) && (empty($body) || Smilies::isEmojiPost($body))) {
+                       Logger::debug('Empty body or only emojis', ['body' => $body]);
+                       return true;
+               }
 
-               if (!empty($languages)) {
-                       if (in_array($languages[0], DI::config()->get('system', 'relay_deny_languages'))) {
-                               Logger::info('Unwanted language found', ['language' => $languages[0]]);
-                               return false;
+               if (!empty($languages) || !empty($detected)) {
+                       $cachekey = 'relay:isWantedLanguage';
+                       $user_languages = DI::cache()->get($cachekey);
+                       if (is_null($user_languages)) {
+                               $user_languages = User::getLanguages();
+                               DI::cache()->set($cachekey, $user_languages);
                        }
+
+                       foreach ($detected as $language) {
+                               if (in_array($language, $user_languages)) {
+                                       Logger::debug('Wanted language found in detected languages', ['language' => $language, 'detected' => $detected, 'userlang' => $user_languages, 'body' => $body]);
+                                       return true;
+                               }
+                       }
+                       foreach ($languages as $language) {
+                               if (in_array($language, $user_languages)) {
+                                       Logger::debug('Wanted language found in defined languages', ['language' => $language, 'languages' => $languages, 'detected' => $detected, 'userlang' => $user_languages, 'body' => $body]);
+                                       return true;
+                               }
+                       }
+                       Logger::debug('No wanted language found', ['languages' => $languages, 'detected' => $detected, 'userlang' => $user_languages, 'body' => $body]);
+                       return false;
                } elseif (DI::config()->get('system', 'relay_deny_undetected_language')) {
                        Logger::info('Undetected language found', ['body' => $body]);
                        return false;