Merge pull request #10976 from nupplaphil/feat/api_tests

[friendica.git] / src / Security / Authentication.php

diff --git a/src/Security/Authentication.php b/src/Security/Authentication.php
index e894c6ddaf776fbe3e925fc7d98b290c53b44f80..0b2fc9f9cf3d15850b7c88cd053b6608fe98cf3b 100644 (file)
--- a/src/Security/Authentication.php
+++ b/src/Security/Authentication.php
@@ -23,10 +23,11 @@ namespace Friendica\Security;
 
 use Exception;
 use Friendica\App;
-use Friendica\Core\Config\IConfig;
-use Friendica\Core\PConfig\IPConfig;
+use Friendica\Core\Config\Capability\IManageConfigValues;
+use Friendica\Core\PConfig\Capability\IManagePersonalConfigValues;
 use Friendica\Core\Hook;
 use Friendica\Core\Session;
+use Friendica\Core\Session\Capability\IHandleSessions;
 use Friendica\Core\System;
 use Friendica\Database\Database;
 use Friendica\Database\DBA;
@@ -36,7 +37,6 @@ use Friendica\Network\HTTPException;
 use Friendica\Security\TwoFactor\Repository\TrustedBrowser;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
-use Friendica\Util\Strings;
 use LightOpenID;
 use Friendica\Core\L10n;
 use Psr\Log\LoggerInterface;
@@ -46,7 +46,7 @@ use Psr\Log\LoggerInterface;
  */
 class Authentication
 {
-       /** @var IConfig */
+       /** @var IManageConfigValues */
        private $config;
        /** @var App\Mode */
        private $mode;
@@ -60,25 +60,37 @@ class Authentication
        private $logger;
        /** @var User\Cookie */
        private $cookie;
-       /** @var Session\ISession */
+       /** @var IHandleSessions */
        private $session;
-       /** @var IPConfig */
+       /** @var IManagePersonalConfigValues */
        private $pConfig;
 
+       /**
+        * Sets the X-Account-Management-Status header
+        *
+        * mainly extracted to make it overridable for tests
+        *
+        * @param array $user_record
+        */
+       protected function setXAccMgmtStatusHeader(array $user_record)
+       {
+               header('X-Account-Management-Status: active; name="' . $user_record['username'] . '"; id="' . $user_record['nickname'] . '"');
+       }
+
        /**
         * Authentication constructor.
         *
-        * @param IConfig          $config
-        * @param App\Mode         $mode
-        * @param App\BaseURL      $baseUrl
-        * @param L10n             $l10n
-        * @param Database         $dba
-        * @param LoggerInterface  $logger
-        * @param User\Cookie      $cookie
-        * @param Session\ISession $session
-        * @param IPConfig         $pConfig
+        * @param IManageConfigValues                                $config
+        * @param App\Mode                                           $mode
+        * @param App\BaseURL                                        $baseUrl
+        * @param L10n                                               $l10n
+        * @param Database                                           $dba
+        * @param LoggerInterface                                    $logger
+        * @param User\Cookie                                        $cookie
+        * @param IHandleSessions $session
+        * @param IManagePersonalConfigValues                        $pConfig
         */
-       public function __construct(IConfig $config, App\Mode $mode, App\BaseURL $baseUrl, L10n $l10n, Database $dba, LoggerInterface $logger, User\Cookie $cookie, Session\ISession $session, IPConfig $pConfig)
+       public function __construct(IManageConfigValues $config, App\Mode $mode, App\BaseURL $baseUrl, L10n $l10n, Database $dba, LoggerInterface $logger, User\Cookie $cookie, IHandleSessions $session, IManagePersonalConfigValues $pConfig)
        {
                $this->config  = $config;
                $this->mode    = $mode;
@@ -246,7 +258,7 @@ class Authentication
                                ['uid' => User::getIdFromPasswordAuthentication($username, $password)]
                        );
                } catch (Exception $e) {
-                       $this->logger->warning('authenticate: failed login attempt', ['action' => 'login', 'username' => Strings::escapeTags($username), 'ip' => $_SERVER['REMOTE_ADDR']]);
+                       $this->logger->warning('authenticate: failed login attempt', ['action' => 'login', 'username' => $username, 'ip' => $_SERVER['REMOTE_ADDR']]);
                        notice($this->l10n->t('Login failed. Please check your credentials.'));
                        $this->baseUrl->redirect();
                }
@@ -305,7 +317,6 @@ class Authentication
                $this->session->set('new_member', time() < ($member_since + (60 * 60 * 24 * 14)));
 
                if (strlen($user_record['timezone'])) {
-                       date_default_timezone_set($user_record['timezone']);
                        $a->setTimeZone($user_record['timezone']);
                }
 
@@ -315,7 +326,7 @@ class Authentication
                        $this->session->set('cid', $contact['id']);
                }
 
-               header('X-Account-Management-Status: active; name="' . $user_record['username'] . '"; id="' . $user_record['nickname'] . '"');
+               $this->setXAccMgmtStatusHeader($user_record);
 
                if ($login_initial || $login_refresh) {
                        $this->dba->update('user', ['login_date' => DateTimeFormat::utcNow()], ['uid' => $user_record['uid']]);