use Friendica\DI;
use Friendica\Model\APContact;
use Friendica\Model\Contact;
+use Friendica\Model\ItemURI;
use Friendica\Model\User;
+use Friendica\Network\HTTPClient\Capability\ICanHandleHttpResponses;
+use Friendica\Network\HTTPClient\Client\HttpClientAccept;
use Friendica\Network\HTTPClient\Client\HttpClientOptions;
/**
*/
/**
- * Transmit given data to a target for a user
+ * Post given data to a target for a user, returns the result class
*
* @param array $data Data that is about to be send
* @param string $target The URL of the inbox
* @param integer $uid User id of the sender
*
- * @return boolean Was the transmission successful?
+ * @return ICanHandleHttpResponses
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function transmit($data, $target, $uid)
+ public static function post(array $data, string $target, int $uid): ICanHandleHttpResponses
{
$owner = User::getOwnerDataById($uid);
if (!$owner) {
- return;
+ return null;
}
$content = json_encode($data, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE);
$headers['Content-Type'] = 'application/activity+json';
- $postResult = DI::httpClient()->post($target, $content, $headers);
+ $postResult = DI::httpClient()->post($target, $content, $headers, DI::config()->get('system', 'curl_timeout'));
$return_code = $postResult->getReturnCode();
Logger::info('Transmit to ' . $target . ' returned ' . $return_code);
- $success = ($return_code >= 200) && ($return_code <= 299);
+ self::setInboxStatus($target, ($return_code >= 200) && ($return_code <= 299));
+
+ return $postResult;
+ }
- self::setInboxStatus($target, $success);
+ /**
+ * Transmit given data to a target for a user
+ *
+ * @param array $data Data that is about to be send
+ * @param string $target The URL of the inbox
+ * @param integer $uid User id of the sender
+ *
+ * @return boolean Was the transmission successful?
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ */
+ public static function transmit(array $data, string $target, int $uid): bool
+ {
+ $postResult = self::post($data, $target, $uid);
+ $return_code = $postResult->getReturnCode();
- return $success;
+ return ($return_code >= 200) && ($return_code <= 299);
}
/**
$status = DBA::selectFirst('inbox-status', [], ['url' => $url]);
if (!DBA::isResult($status)) {
- DBA::insert('inbox-status', ['url' => $url, 'created' => $now, 'shared' => $shared], Database::INSERT_IGNORE);
+ DBA::insert('inbox-status', ['url' => $url, 'uri-id' => ItemURI::getIdByURI($url), 'created' => $now, 'shared' => $shared], Database::INSERT_IGNORE);
$status = DBA::selectFirst('inbox-status', [], ['url' => $url]);
}
$fields['archive'] = false;
}
+ if (empty($status['uri-id'])) {
+ $fields['uri-id'] = ItemURI::getIdByURI($url);
+ }
+
DBA::update('inbox-status', $fields, ['url' => $url]);
}
* @return \Friendica\Network\HTTPClient\Capability\ICanHandleHttpResponses CurlResult
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function fetchRaw($request, $uid = 0, $opts = ['accept_content' => ['application/activity+json, application/ld+json; profile="https://www.w3.org/ns/activitystreams"']])
+ public static function fetchRaw($request, $uid = 0, $opts = [HttpClientOptions::ACCEPT_CONTENT => [HttpClientAccept::JSON_AS]])
{
$header = [];
if (!empty($opts['nobody'])) {
$curlResult = DI::httpClient()->head($request, $curl_opts);
} else {
- $curlResult = DI::httpClient()->get($request, $curl_opts);
+ $curlResult = DI::httpClient()->get($request, HttpClientAccept::JSON_AS, $curl_opts);
}
$return_code = $curlResult->getReturnCode();
$sig_block = self::parseSigHeader($http_headers['HTTP_SIGNATURE']);
+ // Add fields from the signature block to the header. See issue 8845
+ if (!empty($sig_block['created']) && empty($headers['(created)'])) {
+ $headers['(created)'] = $sig_block['created'];
+ }
+
+ if (!empty($sig_block['expires']) && empty($headers['(expires)'])) {
+ $headers['(expires)'] = $sig_block['expires'];
+ }
+
if (empty($sig_block) || empty($sig_block['headers']) || empty($sig_block['keyId'])) {
Logger::info('No headers or keyId');
return false;
foreach ($sig_block['headers'] as $h) {
if (array_key_exists($h, $headers)) {
$signed_data .= $h . ': ' . $headers[$h] . "\n";
+ } else {
+ Logger::info('Requested header field not found', ['field' => $h, 'header' => $headers]);
}
}
$signed_data = rtrim($signed_data, "\n");
}
if (!Crypto::rsaVerify($signed_data, $sig_block['signature'], $key['pubkey'], $algorithm)) {
- Logger::info('Verification failed');
+ Logger::info('Verification failed', ['signed_data' => $signed_data, 'algorithm' => $algorithm, 'header' => $sig_block['headers'], 'http_headers' => $http_headers]);
return false;
}
$hasGoodSignedContent = true;
}
+ if (in_array('date', $sig_block['headers']) && !empty($headers['date'])) {
+ $created = strtotime($headers['date']);
+ } elseif (in_array('(created)', $sig_block['headers']) && !empty($sig_block['created'])) {
+ $created = $sig_block['created'];
+ } else {
+ $created = 0;
+ }
+
+ if (in_array('(expires)', $sig_block['headers']) && !empty($sig_block['expires'])) {
+ $expired = min($sig_block['expires'], $created + 300);
+ } else {
+ $expired = $created + 300;
+ }
+
// Check if the signed date field is in an acceptable range
- if (in_array('date', $sig_block['headers'])) {
- $diff = abs(strtotime($headers['date']) - time());
- if ($diff > 300) {
- Logger::notice("Header date '" . $headers['date'] . "' is with " . $diff . " seconds out of the 300 second frame. The signature is invalid.");
+ if (!empty($created)) {
+ $current = time();
+
+ // Calculate with a grace period of 60 seconds to avoid slight time differences between the servers
+ if (($created - 60) > $current) {
+ Logger::notice('Signature created in the future', ['created' => date(DateTimeFormat::MYSQL, $created), 'expired' => date(DateTimeFormat::MYSQL, $expired), 'current' => date(DateTimeFormat::MYSQL, $current)]);
return false;
}
+
+ if ($current > $expired) {
+ Logger::notice('Signature expired', ['created' => date(DateTimeFormat::MYSQL, $created), 'expired' => date(DateTimeFormat::MYSQL, $expired), 'current' => date(DateTimeFormat::MYSQL, $current)]);
+ return false;
+ }
+
+ Logger::debug('Valid creation date', ['created' => date(DateTimeFormat::MYSQL, $created), 'expired' => date(DateTimeFormat::MYSQL, $expired), 'current' => date(DateTimeFormat::MYSQL, $current)]);
$hasGoodSignedContent = true;
}
projects / friendica.git / blobdiff