Move NULL_DATE from boot.php to DBA::NULL_DATETIME

[friendica.git] / src / Worker / Cron.php

diff --git a/src/Worker/Cron.php b/src/Worker/Cron.php
index e523f75118af8ad0c415f2db2374a33f6ccf3799..9510063337f5da31756ed3a5c1613976c7256a28 100644 (file)
--- a/src/Worker/Cron.php
+++ b/src/Worker/Cron.php
@@ -4,18 +4,23 @@
  */
 namespace Friendica\Worker;
 
+use Friendica\BaseObject;
 use Friendica\Core\Addon;
 use Friendica\Core\Config;
+use Friendica\Core\Hook;
+use Friendica\Core\Protocol;
 use Friendica\Core\Worker;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
+use Friendica\Model\Contact;
 use Friendica\Util\DateTimeFormat;
-use dba;
 
 require_once 'include/dba.php';
 
-Class Cron {
-       public static function execute($parameter = '', $generation = 0) {
-               global $a;
+class Cron
+{
+       public static function execute($parameter = '', $generation = 0)
+       {
+               $a = BaseObject::getApp();
 
                // Poll contacts with specific parameters
                if (!empty($parameter)) {
@@ -41,7 +46,7 @@ Class Cron {
                logger('cron: start');
 
                // Fork the cron jobs in separate parts to avoid problems when one of them is crashing
-               Addon::forkHooks($a->queue['priority'], "cron");
+               Hook::fork($a->queue['priority'], "cron");
 
                // run queue delivery process in the background
                Worker::add(PRIORITY_NEGLIGIBLE, "Queue");
@@ -58,9 +63,6 @@ Class Cron {
                // Call possible post update functions
                Worker::add(PRIORITY_LOW, "CronJobs", "post_update");
 
-               // update nodeinfo data
-               Worker::add(PRIORITY_LOW, "CronJobs", "nodeinfo");
-
                // Clear cache entries
                Worker::add(PRIORITY_LOW, "CronJobs", "clear_cache");
 
@@ -74,27 +76,49 @@ Class Cron {
                $d1 = Config::get('system', 'last_expire_day');
                $d2 = intval(DateTimeFormat::utcNow('d'));
 
+               // Daily cron calls
                if ($d2 != intval($d1)) {
 
                        Worker::add(PRIORITY_LOW, "CronJobs", "update_contact_birthdays");
 
+                       Worker::add(PRIORITY_LOW, "CronJobs", "update_photo_albums");
+
+                       // update nodeinfo data
+                       Worker::add(PRIORITY_LOW, "CronJobs", "nodeinfo");
+
                        Worker::add(PRIORITY_LOW, "DiscoverPoCo", "update_server");
 
                        Worker::add(PRIORITY_LOW, "DiscoverPoCo", "suggestions");
 
-                       Config::set('system', 'last_expire_day', $d2);
-
                        Worker::add(PRIORITY_LOW, 'Expire');
 
                        Worker::add(PRIORITY_MEDIUM, 'DBClean');
 
-                       Worker::add(PRIORITY_LOW, "CronJobs", "update_photo_albums");
+                       // check upstream version?
+                       Worker::add(PRIORITY_LOW, 'CheckVersion');
+
+                       Config::set('system', 'last_expire_day', $d2);
+               }
+
+               // Hourly cron calls
+               if (Config::get('system', 'last_cron_hourly', 0) + 3600 < time()) {
 
                        // Delete all done workerqueue entries
-                       dba::delete('workerqueue', ['`done` AND `executed` < UTC_TIMESTAMP() - INTERVAL 12 HOUR']);
+                       DBA::delete('workerqueue', ['`done` AND `executed` < UTC_TIMESTAMP() - INTERVAL 1 HOUR']);
 
-                       // check upstream version?
-                       Worker::add(PRIORITY_LOW, 'CheckVersion');
+                       // Optimizing this table only last seconds
+                       if (Config::get('system', 'optimize_workerqueue', false)) {
+                               DBA::e("OPTIMIZE TABLE `workerqueue`");
+                       }
+
+                       Config::set('system', 'last_cron_hourly', time());
+               }
+
+               // Ensure to have a .htaccess file.
+               // this is a precaution for systems that update automatically
+               $basepath = $a->getBasePath();
+               if (!file_exists($basepath . '/.htaccess')) {
+                       copy($basepath . '/.htaccess-dist', $basepath . '/.htaccess');
                }
 
                // Poll contacts
@@ -166,29 +190,29 @@ Class Cron {
                                        AND `contact`.`network` IN ('%s', '%s', '%s', '%s', '%s') $sql_extra
                                        AND NOT `contact`.`self` AND NOT `contact`.`blocked`
                                WHERE NOT `user`.`account_expired` AND NOT `user`.`account_removed` $abandon_sql",
-                       dbesc(NETWORK_DFRN),
-                       dbesc(NETWORK_OSTATUS),
-                       dbesc(NETWORK_DIASPORA),
-                       dbesc(NETWORK_FEED),
-                       dbesc(NETWORK_MAIL)
+                       DBA::escape(Protocol::DFRN),
+                       DBA::escape(Protocol::OSTATUS),
+                       DBA::escape(Protocol::DIASPORA),
+                       DBA::escape(Protocol::FEED),
+                       DBA::escape(Protocol::MAIL)
                );
 
-               if (!DBM::is_result($contacts)) {
+               if (!DBA::isResult($contacts)) {
                        return;
                }
 
                foreach ($contacts as $contact) {
 
                        if ($manual_id) {
-                               $contact['last-update'] = NULL_DATE;
+                               $contact['last-update'] = DBA::NULL_DATETIME;
                        }
 
                        // Friendica and OStatus are checked once a day
-                       if (in_array($contact['network'], [NETWORK_DFRN, NETWORK_OSTATUS])) {
+                       if (in_array($contact['network'], [Protocol::DFRN, Protocol::OSTATUS])) {
                                $contact['priority'] = 2;
                        }
 
-                       if ($contact['subhub'] && in_array($contact['network'], [NETWORK_DFRN, NETWORK_OSTATUS])) {
+                       if ($contact['subhub'] && in_array($contact['network'], [Protocol::DFRN, Protocol::OSTATUS])) {
                                /*
                                 * We should be getting everything via a hub. But just to be sure, let's check once a day.
                                 * (You can make this more or less frequent if desired by setting 'pushpoll_frequency' appropriately)
@@ -200,7 +224,7 @@ Class Cron {
                        }
 
                        // Check Diaspora contacts or followers once a week
-                       if (($contact["network"] == NETWORK_DIASPORA) || ($contact["rel"] == CONTACT_IS_FOLLOWER)) {
+                       if (($contact["network"] == Protocol::DIASPORA) || ($contact["rel"] == Contact::FOLLOWER)) {
                                $contact['priority'] = 4;
                        }
 
@@ -255,7 +279,7 @@ Class Cron {
                                }
                        }
 
-                       if (($contact['network'] == NETWORK_FEED) && ($contact['priority'] <= 3)) {
+                       if (($contact['network'] == Protocol::FEED) && ($contact['priority'] <= 3)) {
                                $priority = PRIORITY_MEDIUM;
                        } elseif ($contact['archive']) {
                                $priority = PRIORITY_NEGLIGIBLE;