<?php
/**
- * @file src/Worker/Cron.php
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
*/
+
namespace Friendica\Worker;
-use Friendica\BaseObject;
use Friendica\Core\Addon;
-use Friendica\Core\Config;
use Friendica\Core\Hook;
+use Friendica\Core\Logger;
use Friendica\Core\Protocol;
use Friendica\Core\Worker;
use Friendica\Database\DBA;
+use Friendica\DI;
use Friendica\Model\Contact;
use Friendica\Util\DateTimeFormat;
-require_once 'include/dba.php';
-
class Cron
{
- public static function execute($parameter = '', $generation = 0)
+ public static function execute()
{
- $a = BaseObject::getApp();
-
- // Poll contacts with specific parameters
- if (!empty($parameter)) {
- self::pollContacts($parameter, $generation);
- return;
- }
+ $a = DI::app();
- $last = Config::get('system', 'last_cron');
+ $last = DI::config()->get('system', 'last_cron');
- $poll_interval = intval(Config::get('system', 'cron_interval'));
- if (! $poll_interval) {
- $poll_interval = 10;
- }
+ $poll_interval = intval(DI::config()->get('system', 'cron_interval'));
if ($last) {
$next = $last + ($poll_interval * 60);
if ($next > time()) {
- logger('cron intervall not reached');
+ Logger::log('cron intervall not reached');
return;
}
}
- logger('cron: start');
+ Logger::log('cron: start');
// Fork the cron jobs in separate parts to avoid problems when one of them is crashing
Hook::fork($a->queue['priority'], "cron");
- // run queue delivery process in the background
- Worker::add(PRIORITY_NEGLIGIBLE, "Queue");
-
- // run the process to discover global contacts in the background
- Worker::add(PRIORITY_LOW, "DiscoverPoCo");
+ // run the process to update server directories in the background
+ Worker::add(PRIORITY_LOW, 'UpdateServerDirectories');
// run the process to update locally stored global contacts in the background
- Worker::add(PRIORITY_LOW, "DiscoverPoCo", "checkcontact");
+ Worker::add(PRIORITY_LOW, 'UpdateGContacts');
// Expire and remove user entries
Worker::add(PRIORITY_MEDIUM, "CronJobs", "expire_and_remove_users");
// Clear cache entries
Worker::add(PRIORITY_LOW, "CronJobs", "clear_cache");
- // Repair missing Diaspora values in contacts
- Worker::add(PRIORITY_LOW, "CronJobs", "repair_diaspora");
-
// Repair entries in the database
Worker::add(PRIORITY_LOW, "CronJobs", "repair_database");
// once daily run birthday_updates and then expire in background
- $d1 = Config::get('system', 'last_expire_day');
+ $d1 = DI::config()->get('system', 'last_expire_day');
$d2 = intval(DateTimeFormat::utcNow('d'));
// Daily cron calls
// update nodeinfo data
Worker::add(PRIORITY_LOW, "CronJobs", "nodeinfo");
- Worker::add(PRIORITY_LOW, "DiscoverPoCo", "update_server");
+ Worker::add(PRIORITY_LOW, 'UpdateGServers');
- Worker::add(PRIORITY_LOW, "DiscoverPoCo", "suggestions");
+ Worker::add(PRIORITY_LOW, 'UpdateSuggestions');
Worker::add(PRIORITY_LOW, 'Expire');
// check upstream version?
Worker::add(PRIORITY_LOW, 'CheckVersion');
- Config::set('system', 'last_expire_day', $d2);
+ self::checkdeletedContacts();
+
+ DI::config()->set('system', 'last_expire_day', $d2);
}
// Hourly cron calls
- if (Config::get('system', 'last_cron_hourly', 0) + 3600 < time()) {
+ if (DI::config()->get('system', 'last_cron_hourly', 0) + 3600 < time()) {
// Delete all done workerqueue entries
DBA::delete('workerqueue', ['`done` AND `executed` < UTC_TIMESTAMP() - INTERVAL 1 HOUR']);
// Optimizing this table only last seconds
- if (Config::get('system', 'optimize_workerqueue', false)) {
+ if (DI::config()->get('system', 'optimize_workerqueue', false)) {
DBA::e("OPTIMIZE TABLE `workerqueue`");
}
- Config::set('system', 'last_cron_hourly', time());
+ DI::config()->set('system', 'last_cron_hourly', time());
}
// Ensure to have a .htaccess file.
// this is a precaution for systems that update automatically
$basepath = $a->getBasePath();
- if (!file_exists($basepath . '/.htaccess')) {
+ if (!file_exists($basepath . '/.htaccess') && is_writable($basepath)) {
copy($basepath . '/.htaccess-dist', $basepath . '/.htaccess');
}
// Poll contacts
- self::pollContacts($parameter, $generation);
+ self::pollContacts();
- logger('cron: end');
+ // Update contact information
+ self::updatePublicContacts();
- Config::set('system', 'last_cron', time());
+ Logger::log('cron: end');
+
+ DI::config()->set('system', 'last_cron', time());
return;
}
/**
- * @brief Poll contacts for unreceived messages
- *
- * @todo Currently it seems as if the following parameter aren't used at all ...
- *
- * @param string $parameter Parameter (force, restart, ...) for the contact polling
- * @param integer $generation
+ * Checks for contacts that are about to be deleted and ensures that they are removed.
+ * This should be done automatically in the "remove" function. This here is a cleanup job.
*/
- private static function pollContacts($parameter, $generation) {
- $manual_id = 0;
- $generation = 0;
- $force = false;
- $restart = false;
-
- if ($parameter == 'force') {
- $force = true;
- }
- if ($parameter == 'restart') {
- $restart = true;
- $generation = intval($generation);
- if (!$generation) {
- killme();
- }
+ private static function checkdeletedContacts()
+ {
+ $contacts = DBA::select('contact', ['id'], ['deleted' => true]);
+ while ($contact = DBA::fetch($contacts)) {
+ Worker::add(PRIORITY_MEDIUM, 'RemoveContact', $contact['id']);
}
+ DBA::close($contacts);
+ }
- if (intval($parameter)) {
- $manual_id = intval($parameter);
- $force = true;
+ /**
+ * Update public contacts
+ *
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ */
+ private static function updatePublicContacts() {
+ $count = 0;
+ $last_updated = DateTimeFormat::utc('now - 1 week');
+ $condition = ["`network` IN (?, ?, ?, ?) AND `uid` = ? AND NOT `self` AND `last-update` < ?",
+ Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, 0, $last_updated];
+
+ $total = DBA::count('contact', $condition);
+ $oldest_date = '';
+ $oldest_id = '';
+ $contacts = DBA::select('contact', ['id', 'last-update'], $condition, ['limit' => 100, 'order' => ['last-update']]);
+ while ($contact = DBA::fetch($contacts)) {
+ if (empty($oldest_id)) {
+ $oldest_id = $contact['id'];
+ $oldest_date = $contact['last-update'];
+ }
+ Worker::add(PRIORITY_LOW, "UpdateContact", $contact['id'], 'force');
+ ++$count;
}
+ Logger::info('Initiated update for public contacts', ['interval' => $count, 'total' => $total, 'id' => $oldest_id, 'oldest' => $oldest_date]);
+ DBA::close($contacts);
+ }
- $min_poll_interval = Config::get('system', 'min_poll_interval', 1);
-
- $sql_extra = (($manual_id) ? " AND `id` = $manual_id " : "");
+ /**
+ * Poll contacts for unreceived messages
+ *
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ */
+ private static function pollContacts() {
+ $min_poll_interval = DI::config()->get('system', 'min_poll_interval', 1);
Addon::reload();
- $d = DateTimeFormat::utcNow();
+ $sql = "SELECT `contact`.`id`, `contact`.`nick`, `contact`.`name`, `contact`.`network`, `contact`.`archive`,
+ `contact`.`last-update`, `contact`.`priority`, `contact`.`rel`, `contact`.`subhub`
+ FROM `user`
+ STRAIGHT_JOIN `contact`
+ ON `contact`.`uid` = `user`.`uid` AND `contact`.`poll` != ''
+ AND `contact`.`network` IN (?, ?, ?, ?, ?)
+ AND NOT `contact`.`self` AND NOT `contact`.`blocked`
+ AND `contact`.`rel` != ?
+ WHERE NOT `user`.`account_expired` AND NOT `user`.`account_removed`";
+
+ $parameters = [Protocol::DFRN, Protocol::ACTIVITYPUB, Protocol::OSTATUS, Protocol::FEED, Protocol::MAIL, Contact::FOLLOWER];
// Only poll from those with suitable relationships,
// and which have a polling address and ignore Diaspora since
// we are unable to match those posts with a Diaspora GUID and prevent duplicates.
-
- $abandon_days = intval(Config::get('system', 'account_abandon_days'));
+ $abandon_days = intval(DI::config()->get('system', 'account_abandon_days'));
if ($abandon_days < 1) {
$abandon_days = 0;
}
- $abandon_sql = (($abandon_days)
- ? sprintf(" AND `user`.`login_date` > UTC_TIMESTAMP() - INTERVAL %d DAY ", intval($abandon_days))
- : ''
- );
- $contacts = q("SELECT `contact`.`id`, `contact`.`nick`, `contact`.`name`, `contact`.`network`, `contact`.`archive`,
- `contact`.`last-update`, `contact`.`priority`, `contact`.`rel`, `contact`.`subhub`
- FROM `user`
- STRAIGHT_JOIN `contact`
- ON `contact`.`uid` = `user`.`uid` AND `contact`.`poll` != ''
- AND `contact`.`network` IN ('%s', '%s', '%s', '%s', '%s') $sql_extra
- AND NOT `contact`.`self` AND NOT `contact`.`blocked`
- WHERE NOT `user`.`account_expired` AND NOT `user`.`account_removed` $abandon_sql",
- DBA::escape(Protocol::DFRN),
- DBA::escape(Protocol::OSTATUS),
- DBA::escape(Protocol::DIASPORA),
- DBA::escape(Protocol::FEED),
- DBA::escape(Protocol::MAIL)
- );
+ if (!empty($abandon_days)) {
+ $sql .= " AND `user`.`login_date` > UTC_TIMESTAMP() - INTERVAL ? DAY";
+ $parameters[] = $abandon_days;
+ }
+
+ $contacts = DBA::p($sql, $parameters);
if (!DBA::isResult($contacts)) {
return;
}
- foreach ($contacts as $contact) {
-
- if ($manual_id) {
- $contact['last-update'] = DBA::NULL_DATETIME;
- }
-
+ while ($contact = DBA::fetch($contacts)) {
// Friendica and OStatus are checked once a day
if (in_array($contact['network'], [Protocol::DFRN, Protocol::OSTATUS])) {
- $contact['priority'] = 2;
- }
-
- if ($contact['subhub'] && in_array($contact['network'], [Protocol::DFRN, Protocol::OSTATUS])) {
- /*
- * We should be getting everything via a hub. But just to be sure, let's check once a day.
- * (You can make this more or less frequent if desired by setting 'pushpoll_frequency' appropriately)
- * This also lets us update our subscription to the hub, and add or replace hubs in case it
- * changed. We will only update hubs once a day, regardless of 'pushpoll_frequency'.
- */
- $poll_interval = Config::get('system', 'pushpoll_frequency');
- $contact['priority'] = (!is_null($poll_interval) ? intval($poll_interval) : 3);
+ $contact['priority'] = 3;
}
- // Check Diaspora contacts or followers once a week
- if (($contact["network"] == Protocol::DIASPORA) || ($contact["rel"] == Contact::FOLLOWER)) {
+ // ActivityPub is checked once a week
+ if ($contact['network'] == Protocol::ACTIVITYPUB) {
$contact['priority'] = 4;
}
$contact['priority'] = 5;
}
- if (($contact['priority'] >= 0) && !$force) {
+ if ($contact['priority'] >= 0) {
$update = false;
$t = $contact['last-update'];
break;
case 0:
default:
- if (DateTimeFormat::utcNow() > DateTimeFormat::utc($t . " + ".$min_poll_interval." minute")) {
+ if (DateTimeFormat::utcNow() > DateTimeFormat::utc($t . " + " . $min_poll_interval . " minute")) {
$update = true;
}
break;
}
}
- if (($contact['network'] == Protocol::FEED) && ($contact['priority'] <= 3)) {
+ if ((($contact['network'] == Protocol::FEED) && ($contact['priority'] <= 3)) || ($contact['network'] == Protocol::MAIL)) {
$priority = PRIORITY_MEDIUM;
} elseif ($contact['archive']) {
$priority = PRIORITY_NEGLIGIBLE;
$priority = PRIORITY_LOW;
}
- logger("Polling " . $contact["network"] . " " . $contact["id"] . " " . $contact['priority'] . " " . $contact["nick"] . " " . $contact["name"]);
+ Logger::log("Polling " . $contact["network"] . " " . $contact["id"] . " " . $contact['priority'] . " " . $contact["nick"] . " " . $contact["name"]);
- Worker::add(['priority' => $priority, 'dont_fork' => true], 'OnePoll', (int)$contact['id']);
+ Worker::add(['priority' => $priority, 'dont_fork' => true, 'force_priority' => true], 'OnePoll', (int)$contact['id']);
}
+ DBA::close($contacts);
}
}
projects / friendica.git / blobdiff