]> git.mxchange.org Git - friendica.git/blobdiff - src/Worker/Delivery.php
Merge pull request #11936 from annando/youtube-shorts
[friendica.git] / src / Worker / Delivery.php
index db7b8c26a5352cea62941e6bac699a954dd734fb..32d4887003bc90794eeb21b97ee8246004d381df 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -21,6 +21,8 @@
 
 namespace Friendica\Worker;
 
+use Friendica\Contact\FriendSuggest\Collection\FriendSuggests;
+use Friendica\Contact\FriendSuggest\Exception\FriendSuggestNotFoundException;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Database\DBA;
@@ -30,13 +32,10 @@ use Friendica\Protocol\DFRN;
 use Friendica\Protocol\Diaspora;
 use Friendica\Protocol\Email;
 use Friendica\Protocol\Activity;
-use Friendica\Util\Strings;
 use Friendica\Util\Network;
 use Friendica\Core\Worker;
-use Friendica\Model\Conversation;
 use Friendica\Model\FContact;
 use Friendica\Model\Item;
-use Friendica\Model\Post;
 use Friendica\Protocol\Relay;
 
 class Delivery
@@ -46,8 +45,6 @@ class Delivery
        const RELOCATION    = 'relocate';
        const DELETION      = 'drop';
        const POST          = 'wall-new';
-       const POKE          = 'poke';
-       const UPLINK        = 'uplink';
        const REMOVAL       = 'removeme';
        const PROFILEUPDATE = 'profileupdate';
 
@@ -67,8 +64,10 @@ class Delivery
                        }
                        $uid = $target_item['uid'];
                } elseif ($cmd == self::SUGGESTION) {
-                       $target_item = DBA::selectFirst('fsuggest', [], ['id' => $post_uriid]);
-                       if (!DBA::isResult($target_item)) {
+                       try {
+                               $target_item = DI::fsuggest()->selectOneById($post_uriid)->toArray();
+                       } catch (FriendSuggestNotFoundException $e) {
+                               DI::logger()->info('Cannot find FriendSuggestion', ['id' => $post_uriid]);
                                return;
                        }
                        $uid = $target_item['uid'];
@@ -104,12 +103,12 @@ class Delivery
                        DBA::close($itemdata);
 
                        if (empty($target_item)) {
-                               Logger::log('Item ' . $target_id . "wasn't found. Quitting here.");
+                               Logger::warning("No target item data. Quitting here.", ['id' => $target_id]);
                                return;
                        }
 
                        if (empty($parent)) {
-                               Logger::log('Parent ' . $parent_id . ' for item ' . $target_id . "wasn't found. Quitting here.");
+                               Logger::warning('Parent ' . $parent_id . ' for item ' . $target_id . "wasn't found. Quitting here.");
                                self::setFailedQueue($cmd, $target_item);
                                return;
                        }
@@ -119,7 +118,7 @@ class Delivery
                        } elseif (!empty($target_item['uid'])) {
                                $uid = $target_item['uid'];
                        } else {
-                               Logger::log('Only public users for item ' . $target_id, Logger::DEBUG);
+                               Logger::info('Only public users for item ' . $target_id);
                                self::setFailedQueue($cmd, $target_item);
                                return;
                        }
@@ -168,7 +167,7 @@ class Delivery
                         */
 
                        if (!$top_level && ($parent['wall'] == 0) && stristr($target_item['uri'], $localhost)) {
-                               Logger::log('Followup ' . $target_item["guid"], Logger::DEBUG);
+                               Logger::info('Followup ' . $target_item["guid"]);
                                // local followup to remote post
                                $followup = true;
                        }
@@ -183,7 +182,7 @@ class Delivery
                }
 
                if (empty($items)) {
-                       Logger::notice('No delivery data', ['command' => $cmd, 'uri-id' => $post_uriid, 'cid' => $contact_id]);
+                       Logger::warning('No delivery data', ['command' => $cmd, 'uri-id' => $post_uriid, 'cid' => $contact_id]);
                }
 
                $owner = Model\User::getOwnerDataById($uid);
@@ -212,15 +211,11 @@ class Delivery
                // Also transmit via Diaspora if this is a direct answer to a Diaspora comment.
                // This is done since the uri wouldn't match (Diaspora doesn't transmit it)
                // Also transmit relayed posts from Diaspora contacts via Diaspora.
-               if (!empty($parent) && !empty($thr_parent) && in_array(Protocol::DIASPORA, [$parent['network'], $thr_parent['network'], $target_item['network']])) {
+               if (($contact['network'] != Protocol::DIASPORA) && in_array(Protocol::DIASPORA, [$parent['network'] ?? '', $thr_parent['network'] ?? '', $target_item['network']] ?? '')) {
+                       Logger::info('Enforcing the Diaspora protocol', ['id' => $contact['id'], 'network' => $contact['network'], 'parent' => $parent['network'], 'thread-parent' => $thr_parent['network'], 'post' => $target_item['network']]);
                        $contact['network'] = Protocol::DIASPORA;
                }
 
-               // Ensure that local contacts are delivered locally
-               if (Model\Contact::isLocal($contact['url'])) {
-                       $contact['network'] = Protocol::DFRN;
-               }
-
                Logger::notice('Delivering', ['cmd' => $cmd, 'uri-id' => $post_uriid, 'followup' => $followup, 'network' => $contact['network']]);
 
                switch ($contact['network']) {
@@ -251,7 +246,7 @@ class Delivery
         */
        private static function setFailedQueue(string $cmd, array $item)
        {
-               if (!in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+               if ($cmd != Delivery::POST) {
                        return;
                }
 
@@ -261,22 +256,22 @@ class Delivery
        /**
         * Deliver content via DFRN
         *
-        * @param string  $cmd             Command
-        * @param array   $contact         Contact record of the receiver
-        * @param array   $owner           Owner record of the sender
-        * @param array   $items           Item record of the content and the parent
-        * @param array   $target_item     Item record of the content
-        * @param boolean $public_message  Is the content public?
-        * @param boolean $top_level       Is it a thread starter?
-        * @param boolean $followup        Is it an answer to a remote post?
-        * @param int     $server_protocol The protocol of the server
+        * @param string   $cmd             Command
+        * @param array    $contact         Contact record of the receiver
+        * @param array    $owner           Owner record of the sender
+        * @param array    $items           Item record of the content and the parent
+        * @param array    $target_item     Item record of the content
+        * @param boolean  $public_message  Is the content public?
+        * @param boolean  $top_level       Is it a thread starter?
+        * @param boolean  $followup        Is it an answer to a remote post?
+        * @param int|null $server_protocol The protocol of the server
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       private static function deliverDFRN($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup, $server_protocol)
+       private static function deliverDFRN(string $cmd, array $contact, array $owner, array $items, array $target_item, bool $public_message, bool $top_level, bool $followup, int $server_protocol = null)
        {
                // Transmit Diaspora reshares via Diaspora if the Friendica contact support Diaspora
-               if (Diaspora::isReshare($target_item['body']) && !empty(FContact::getByURL($contact['addr'], false))) {
+               if (Diaspora::isReshare($target_item['body'] ?? '') && !empty(FContact::getByURL($contact['addr'], false))) {
                        Logger::info('Reshare will be transmitted via Diaspora', ['url' => $contact['url'], 'guid' => ($target_item['guid'] ?? '') ?: $target_item['id']]);
                        self::deliverDiaspora($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup);
                        return;
@@ -291,7 +286,7 @@ class Delivery
                } elseif ($cmd == self::SUGGESTION) {
                        $item = $target_item;
                        $atom = DFRN::fsuggest($item, $owner);
-                       DBA::delete('fsuggest', ['id' => $item['id']]);
+                       DI::fsuggest()->delete(new FriendSuggests([DI::fsuggest()->selectOneById($item['id'])]));
                } elseif ($cmd == self::RELOCATION) {
                        $atom = DFRN::relocate($owner, $owner['uid']);
                } elseif ($followup) {
@@ -316,40 +311,6 @@ class Delivery
 
                Logger::debug('Notifier entry: ' . $contact["url"] . ' ' . (($target_item['guid'] ?? '') ?: $target_item['id']) . ' entry: ' . $atom);
 
-               // perform local delivery if we are on the same site
-               if (Model\Contact::isLocal($contact['url'])) {
-                       $condition = ['nurl' => Strings::normaliseLink($contact['url']), 'self' => true];
-                       $target_self = DBA::selectFirst('contact', ['uid'], $condition);
-                       if (!DBA::isResult($target_self)) {
-                               return;
-                       }
-                       $target_uid = $target_self['uid'];
-
-                       // Check if the user has got this contact
-                       $cid = Model\Contact::getIdForURL($owner['url'], $target_uid);
-                       if (!$cid) {
-                               // Otherwise there should be a public contact
-                               $cid = Model\Contact::getIdForURL($owner['url']);
-                               if (!$cid) {
-                                       return;
-                               }
-                       }
-
-                       $target_importer = DFRN::getImporter($cid, $target_uid);
-                       if (empty($target_importer)) {
-                               // This should never happen
-                               return;
-                       }
-
-                       DFRN::import($atom, $target_importer, Conversation::PARCEL_LOCAL_DFRN, Conversation::PUSH);
-
-                       if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
-                               Model\Post\DeliveryData::incrementQueueDone($target_item['uri-id'], Model\Post\DeliveryData::DFRN);
-                       }
-
-                       return;
-               }
-
                $protocol = Model\Post\DeliveryData::DFRN;
 
                // We don't have a relationship with contacts on a public post.
@@ -364,7 +325,7 @@ class Delivery
                        if ($public_dfrn) {
                                Logger::info('Relay delivery to ' . $contact["url"] . ' with guid ' . $target_item["guid"] . ' returns ' . $deliver_status);
 
-                               if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                               if ($cmd == Delivery::POST) {
                                        if (($deliver_status >= 200) && ($deliver_status <= 299)) {
                                                Model\Post\DeliveryData::incrementQueueDone($target_item['uri-id'], $protocol);
 
@@ -381,17 +342,9 @@ class Delivery
                                self::deliverDiaspora($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup);
                                return;
                        }
-               } elseif ($cmd != self::RELOCATION) {
+               } else {
                        // DFRN payload over Diaspora transport layer
                        $deliver_status = DFRN::transmit($owner, $contact, $atom);
-                       if (($deliver_status < 200) && (empty($server_protocol) || ($server_protocol == Model\Post\DeliveryData::LEGACY_DFRN))) {
-                               // Legacy DFRN
-                               $deliver_status = DFRN::deliver($owner, $contact, $atom);
-                               $protocol = Model\Post\DeliveryData::LEGACY_DFRN;
-                       }
-               } else {
-                       $deliver_status = DFRN::deliver($owner, $contact, $atom);
-                       $protocol = Model\Post\DeliveryData::LEGACY_DFRN;
                }
 
                Logger::info('DFRN Delivery', ['cmd' => $cmd, 'url' => $contact['url'], 'guid' => ($target_item['guid'] ?? '') ?: $target_item['id'], 'return' => $deliver_status]);
@@ -402,7 +355,7 @@ class Delivery
 
                        Model\GServer::setProtocol($contact['gsid'] ?? 0, $protocol);
 
-                       if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                       if ($cmd == Delivery::POST) {
                                Model\Post\DeliveryData::incrementQueueDone($target_item['uri-id'], $protocol);
                        }
                } else {
@@ -410,7 +363,7 @@ class Delivery
                        Model\Contact::markForArchival($contact);
 
                        Logger::info('Delivery failed: defer message', ['id' => ($target_item['guid'] ?? '') ?: $target_item['id']]);
-                       if (!Worker::defer() && in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                       if (!Worker::defer() && $cmd == Delivery::POST) {
                                Model\Post\DeliveryData::incrementQueueFailed($target_item['uri-id']);
                        }
                }
@@ -430,7 +383,7 @@ class Delivery
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       private static function deliverDiaspora($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup)
+       private static function deliverDiaspora(string $cmd, array $contact, array $owner, array $items, array $target_item, bool $public_message, bool $top_level, bool $followup)
        {
                // We don't treat Forum posts as "wall-to-wall" to be able to post them via Diaspora
                $walltowall = $top_level && ($owner['id'] != $items[0]['contact-id']) & ($owner['account-type'] != Model\User::ACCOUNT_TYPE_COMMUNITY);
@@ -443,7 +396,7 @@ class Delivery
 
                Logger::notice('Deliver via Diaspora', ['target' => $target_item['id'], 'guid' => $target_item['guid'], 'to' => $loc]);
 
-               if (DI::config()->get('system', 'dfrn_only') || !DI::config()->get('system', 'diaspora_enabled')) {
+               if (!DI::config()->get('system', 'diaspora_enabled')) {
                        return;
                }
 
@@ -464,22 +417,22 @@ class Delivery
                        $deliver_status = Diaspora::sendAccountMigration($owner, $contact, $owner['uid']);
                } elseif ($target_item['deleted'] && (($target_item['uri'] === $target_item['parent-uri']) || $followup)) {
                        // top-level retraction
-                       Logger::log('diaspora retract: ' . $loc);
+                       Logger::notice('diaspora retract: ' . $loc);
                        $deliver_status = Diaspora::sendRetraction($target_item, $owner, $contact, $public_message);
                } elseif ($followup) {
                        // send comments and likes to owner to relay
-                       Logger::log('diaspora followup: ' . $loc);
+                       Logger::notice('diaspora followup: ' . $loc);
                        $deliver_status = Diaspora::sendFollowup($target_item, $owner, $contact, $public_message);
                } elseif ($target_item['uri'] !== $target_item['parent-uri']) {
                        // we are the relay - send comments, likes and relayable_retractions to our conversants
-                       Logger::log('diaspora relay: ' . $loc);
+                       Logger::notice('diaspora relay: ' . $loc);
                        $deliver_status = Diaspora::sendRelay($target_item, $owner, $contact, $public_message);
                } elseif ($top_level && !$walltowall) {
                        // currently no workable solution for sending walltowall
-                       Logger::log('diaspora status: ' . $loc);
+                       Logger::notice('diaspora status: ' . $loc);
                        $deliver_status = Diaspora::sendStatus($target_item, $owner, $contact, $public_message);
                } else {
-                       Logger::log('Unknown mode ' . $cmd . ' for ' . $loc);
+                       Logger::warning('Unknown mode', ['command' => $cmd, 'target' => $loc]);
                        return;
                }
 
@@ -489,7 +442,7 @@ class Delivery
 
                        Model\GServer::setProtocol($contact['gsid'] ?? 0, Model\Post\DeliveryData::DIASPORA);
 
-                       if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                       if ($cmd == Delivery::POST) {
                                Model\Post\DeliveryData::incrementQueueDone($target_item['uri-id'], Model\Post\DeliveryData::DIASPORA);
                        }
                } else {
@@ -504,10 +457,10 @@ class Delivery
                        if (empty($contact['contact-type']) || ($contact['contact-type'] != Model\Contact::TYPE_RELAY)) {
                                Logger::info('Delivery failed: defer message', ['id' => ($target_item['guid'] ?? '') ?: $target_item['id']]);
                                // defer message for redelivery
-                               if (!Worker::defer() && in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                               if (!Worker::defer() && $cmd == Delivery::POST) {
                                        Model\Post\DeliveryData::incrementQueueFailed($target_item['uri-id']);
                                }
-                       } elseif (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                       } elseif ($cmd == Delivery::POST) {
                                Model\Post\DeliveryData::incrementQueueFailed($target_item['uri-id']);
                        }
                }
@@ -521,12 +474,13 @@ class Delivery
         * @param array  $owner       Owner record of the sender
         * @param array  $target_item Item record of the content
         * @param array  $thr_parent  Item record of the direct parent in the thread
+        * @return void
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       private static function deliverMail($cmd, $contact, $owner, $target_item, $thr_parent)
+       private static function deliverMail(string $cmd, array $contact, array $owner, array $target_item, array $thr_parent)
        {
-               if (DI::config()->get('system','dfrn_only')) {
+               if (DI::config()->get('system', 'imap_disabled')) {
                        return;
                }
 
@@ -535,7 +489,7 @@ class Delivery
                        return;
                }
 
-               if (!in_array($cmd, [self::POST, self::POKE])) {
+               if ($cmd != self::POST) {
                        return;
                }
 
@@ -616,10 +570,16 @@ class Delivery
                        }
                }
 
-               Email::send($addr, $subject, $headers, $target_item);
-
-               Model\Post\DeliveryData::incrementQueueDone($target_item['uri-id'], Model\Post\DeliveryData::MAIL);
+               // Try to send email
+               $success = Email::send($addr, $subject, $headers, $target_item);
 
-               Logger::info('Delivered via mail', ['guid' => $target_item['guid'], 'to' => $addr, 'subject' => $subject]);
+               if ($success) {
+                       // Success
+                       Model\Post\DeliveryData::incrementQueueDone($target_item['uri-id'], Model\Post\DeliveryData::MAIL);
+                       Logger::info('Delivered via mail', ['guid' => $target_item['guid'], 'to' => $addr, 'subject' => $subject]);
+               } else {
+                       // Failed
+                       Logger::warning('Delivery of mail has FAILED', ['to' => $addr, 'subject' => $subject, 'guid' => $target_item['guid']]);
+               }
        }
 }