]> git.mxchange.org Git - friendica.git/blobdiff - src/Worker/Delivery.php
Fix searching for contacts
[friendica.git] / src / Worker / Delivery.php
index 49fe47c54c2b2a977a885832ecb5e66fa38460ef..97a0968510c5cf945cfd1d3f8915a5e90d7c86dc 100644 (file)
@@ -11,16 +11,13 @@ use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
-use Friendica\Model\Contact;
-use Friendica\Model\Item;
-use Friendica\Model\ItemDeliveryData;
-use Friendica\Model\Queue;
-use Friendica\Model\User;
+use Friendica\Model;
 use Friendica\Protocol\DFRN;
 use Friendica\Protocol\Diaspora;
 use Friendica\Protocol\Email;
 use Friendica\Util\Strings;
 use Friendica\Util\Network;
+use Friendica\Core\Worker;
 
 class Delivery extends BaseObject
 {
@@ -29,7 +26,8 @@ class Delivery extends BaseObject
        const RELOCATION    = 'relocate';
        const DELETION      = 'drop';
        const POST          = 'wall-new';
-       const COMMENT       = 'comment-new';
+       const POKE          = 'poke';
+       const UPLINK        = 'uplink';
        const REMOVAL       = 'removeme';
        const PROFILEUPDATE = 'profileupdate';
 
@@ -58,17 +56,17 @@ class Delivery extends BaseObject
                        $uid = $target_id;
                        $target_item = [];
                } else {
-                       $item = Item::selectFirst(['parent'], ['id' => $target_id]);
+                       $item = Model\Item::selectFirst(['parent'], ['id' => $target_id]);
                        if (!DBA::isResult($item) || empty($item['parent'])) {
                                return;
                        }
                        $parent_id = intval($item['parent']);
 
-                       $condition = ['id' => [$target_id, $parent_id], 'moderated' => false];
+                       $condition = ['id' => [$target_id, $parent_id], 'visible' => true, 'moderated' => false];
                        $params = ['order' => ['id']];
-                       $itemdata = Item::select([], $condition, $params);
+                       $itemdata = Model\Item::select([], $condition, $params);
 
-                       while ($item = Item::fetch($itemdata)) {
+                       while ($item = Model\Item::fetch($itemdata)) {
                                if ($item['id'] == $parent_id) {
                                        $parent = $item;
                                }
@@ -94,7 +92,7 @@ class Delivery extends BaseObject
                        } elseif (!empty($target_item['uid'])) {
                                $uid = $target_item['uid'];
                        } else {
-                               Logger::log('Only public users for item ' . $item_id, Logger::DEBUG);
+                               Logger::log('Only public users for item ' . $target_id, Logger::DEBUG);
                                return;
                        }
 
@@ -152,7 +150,7 @@ class Delivery extends BaseObject
                        Logger::log('No delivery data for  ' . $cmd . ' - Item ID: ' .$target_id . ' - Contact ID: ' . $contact_id);
                }
 
-               $owner = User::getOwnerDataById($uid);
+               $owner = Model\User::getOwnerDataById($uid);
                if (!DBA::isResult($owner)) {
                        return;
                }
@@ -181,18 +179,10 @@ class Delivery extends BaseObject
 
                        case Protocol::DFRN:
                                self::deliverDFRN($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup);
-
-                               if (in_array($cmd, [Delivery::POST, Delivery::COMMENT])) {
-                                       ItemDeliveryData::incrementQueueDone($target_id);
-                               }
                                break;
 
                        case Protocol::DIASPORA:
                                self::deliverDiaspora($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup);
-
-                               if (in_array($cmd, [Delivery::POST, Delivery::COMMENT])) {
-                                       ItemDeliveryData::incrementQueueDone($target_id);
-                               }
                                break;
 
                        case Protocol::OSTATUS:
@@ -239,7 +229,7 @@ class Delivery extends BaseObject
 
                if ($cmd == self::MAIL) {
                        $item = $target_item;
-                       $item['body'] = Item::fixPrivatePhotos($item['body'], $owner['uid'], null, $item['contact-id']);
+                       $item['body'] = Model\Item::fixPrivatePhotos($item['body'], $owner['uid'], null, $item['contact-id']);
                        $atom = DFRN::mail($item, $owner);
                } elseif ($cmd == self::SUGGESTION) {
                        $item = $target_item;
@@ -278,10 +268,10 @@ class Delivery extends BaseObject
                        $target_uid = $target_self['uid'];
 
                        // Check if the user has got this contact
-                       $cid = Contact::getIdForURL($owner['url'], $target_uid);
+                       $cid = Model\Contact::getIdForURL($owner['url'], $target_uid);
                        if (!$cid) {
                                // Otherwise there should be a public contact
-                               $cid = Contact::getIdForURL($owner['url']);
+                               $cid = Model\Contact::getIdForURL($owner['url']);
                                if (!$cid) {
                                        return;
                                }
@@ -294,6 +284,11 @@ class Delivery extends BaseObject
                        }
 
                        DFRN::import($atom, $target_importer);
+
+                       if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                               Model\ItemDeliveryData::incrementQueueDone($target_item['id']);
+                       }
+
                        return;
                }
 
@@ -301,7 +296,7 @@ class Delivery extends BaseObject
                // Se we transmit with the new method and via Diaspora as a fallback
                if (!empty($items) && (($items[0]['uid'] == 0) || ($contact['uid'] == 0))) {
                        // Transmit in public if it's a relay post
-                       $public_dfrn = ($contact['contact-type'] == Contact::ACCOUNT_TYPE_RELAY);
+                       $public_dfrn = ($contact['contact-type'] == Model\Contact::TYPE_RELAY);
 
                        $deliver_status = DFRN::transmit($owner, $contact, $atom, $public_dfrn);
 
@@ -322,23 +317,21 @@ class Delivery extends BaseObject
                        $deliver_status = DFRN::deliver($owner, $contact, $atom, false, true);
                }
 
-               Logger::log('Delivery to ' . $contact['url'] . ' with guid ' . defaults($target_item, 'guid', $target_item['id']) . ' returns ' . $deliver_status);
-
-               if ($deliver_status < 0) {
-                       Logger::log('Delivery failed: queuing message ' . defaults($target_item, 'guid', $target_item['id']));
-                       Queue::add($contact['id'], Protocol::DFRN, $atom, false, $target_item['guid']);
-               }
+               Logger::info('DFRN Delivery', ['cmd' => $cmd, 'url' => $contact['url'], 'guid' => defaults($target_item, 'guid', $target_item['id']), 'return' => $deliver_status]);
 
                if (($deliver_status >= 200) && ($deliver_status <= 299)) {
                        // We successfully delivered a message, the contact is alive
-                       Contact::unmarkForArchival($contact);
+                       Model\Contact::unmarkForArchival($contact);
+
+                       if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                               Model\ItemDeliveryData::incrementQueueDone($target_item['id']);
+                       }
                } else {
                        // The message could not be delivered. We mark the contact as "dead"
-                       Contact::markForArchival($contact);
+                       Model\Contact::markForArchival($contact);
 
-                       // Transmit via Diaspora when all other methods (legacy DFRN and new one) are failing.
-                       // This is a fallback for systems that don't know the new methods.
-                       self::deliverDiaspora($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup);
+                       Logger::info('Delivery failed: defer message', ['id' => defaults($target_item, 'guid', $target_item['id'])]);
+                       Worker::defer();
                }
        }
 
@@ -359,7 +352,7 @@ class Delivery extends BaseObject
        private static function deliverDiaspora($cmd, $contact, $owner, $items, $target_item, $public_message, $top_level, $followup)
        {
                // We don't treat Forum posts as "wall-to-wall" to be able to post them via Diaspora
-               $walltowall = $top_level && ($owner['id'] != $items[0]['contact-id']) & ($owner['account-type'] != Contact::ACCOUNT_TYPE_COMMUNITY);
+               $walltowall = $top_level && ($owner['id'] != $items[0]['contact-id']) & ($owner['account-type'] != Model\User::ACCOUNT_TYPE_COMMUNITY);
 
                if ($public_message) {
                        $loc = 'public batch ' . $contact['batch'];
@@ -383,32 +376,49 @@ class Delivery extends BaseObject
                if (!$contact['pubkey'] && !$public_message) {
                        return;
                }
+
                if ($cmd == self::RELOCATION) {
-                       Diaspora::sendAccountMigration($owner, $contact, $owner['uid']);
-                       return;
+                       $deliver_status = Diaspora::sendAccountMigration($owner, $contact, $owner['uid']);
                } elseif ($target_item['deleted'] && (($target_item['uri'] === $target_item['parent-uri']) || $followup)) {
                        // top-level retraction
                        Logger::log('diaspora retract: ' . $loc);
-                       Diaspora::sendRetraction($target_item, $owner, $contact, $public_message);
-                       return;
+                       $deliver_status = Diaspora::sendRetraction($target_item, $owner, $contact, $public_message);
                } elseif ($followup) {
                        // send comments and likes to owner to relay
                        Logger::log('diaspora followup: ' . $loc);
-                       Diaspora::sendFollowup($target_item, $owner, $contact, $public_message);
-                       return;
+                       $deliver_status = Diaspora::sendFollowup($target_item, $owner, $contact, $public_message);
                } elseif ($target_item['uri'] !== $target_item['parent-uri']) {
                        // we are the relay - send comments, likes and relayable_retractions to our conversants
                        Logger::log('diaspora relay: ' . $loc);
-                       Diaspora::sendRelay($target_item, $owner, $contact, $public_message);
-                       return;
+                       $deliver_status = Diaspora::sendRelay($target_item, $owner, $contact, $public_message);
                } elseif ($top_level && !$walltowall) {
                        // currently no workable solution for sending walltowall
                        Logger::log('diaspora status: ' . $loc);
-                       Diaspora::sendStatus($target_item, $owner, $contact, $public_message);
+                       $deliver_status = Diaspora::sendStatus($target_item, $owner, $contact, $public_message);
+               } else {
+                       Logger::log('Unknown mode ' . $cmd . ' for ' . $loc);
                        return;
                }
 
-               Logger::log('Unknown mode ' . $cmd . ' for ' . $loc);
+               if (($deliver_status >= 200) && ($deliver_status <= 299)) {
+                       // We successfully delivered a message, the contact is alive
+                       Model\Contact::unmarkForArchival($contact);
+
+                       if (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                               Model\ItemDeliveryData::incrementQueueDone($target_item['id']);
+                       }
+               } else {
+                       // The message could not be delivered. We mark the contact as "dead"
+                       Model\Contact::markForArchival($contact);
+
+                       if (empty($contact['contact-type']) || ($contact['contact-type'] != Model\Contact::TYPE_RELAY)) {
+                               Logger::info('Delivery failed: defer message', ['id' => defaults($target_item, 'guid', $target_item['id'])]);
+                               // defer message for redelivery
+                               Worker::defer();
+                       } elseif (in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+                               Model\ItemDeliveryData::incrementQueueDone($target_item['id']);
+                       }
+               }
        }
 
        /**
@@ -433,7 +443,7 @@ class Delivery extends BaseObject
                        return;
                }
 
-               if (!in_array($cmd, [self::POST, self::COMMENT])) {
+               if (!in_array($cmd, [self::POST, self::POKE])) {
                        return;
                }
 
@@ -454,7 +464,7 @@ class Delivery extends BaseObject
 
                // only expose our real email address to true friends
 
-               if (($contact['rel'] == Contact::FRIEND) && !$contact['blocked']) {
+               if (($contact['rel'] == Model\Contact::FRIEND) && !$contact['blocked']) {
                        if ($reply_to) {
                                $headers  = 'From: ' . Email::encodeHeader($local_user['username'],'UTF-8') . ' <' . $reply_to.'>' . "\n";
                                $headers .= 'Sender: ' . $local_user['email'] . "\n";
@@ -479,13 +489,13 @@ class Delivery extends BaseObject
 
                        if (empty($target_item['title'])) {
                                $condition = ['uri' => $target_item['parent-uri'], 'uid' => $owner['uid']];
-                               $title = Item::selectFirst(['title'], $condition);
+                               $title = Model\Item::selectFirst(['title'], $condition);
 
                                if (DBA::isResult($title) && ($title['title'] != '')) {
                                        $subject = $title['title'];
                                } else {
                                        $condition = ['parent-uri' => $target_item['parent-uri'], 'uid' => $owner['uid']];
-                                       $title = Item::selectFirst(['title'], $condition);
+                                       $title = Model\Item::selectFirst(['title'], $condition);
 
                                        if (DBA::isResult($title) && ($title['title'] != '')) {
                                                $subject = $title['title'];