Remove global $db variable

[friendica.git] / src / Worker / Expire.php

diff --git a/src/Worker/Expire.php b/src/Worker/Expire.php
index 9b2308da374155a02d46fcee8ac1a49138615c9b..685fad49e8f64fc171946f3600203b26c5489d13 100644 (file)
--- a/src/Worker/Expire.php
+++ b/src/Worker/Expire.php
@@ -6,43 +6,65 @@
 
 namespace Friendica\Worker;
 
+use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\Worker;
 use Friendica\Database\DBM;
+use Friendica\Model\Item;
 use dba;
 
 require_once 'include/dba.php';
 
-class Expire {
-       public static function execute($param = '', $hook_name = '') {
-               global $a;
+class Expire
+{
+       public static function execute($param = '', $hook_name = '')
+       {
+               $a = \Friendica\BaseObject::getApp();
 
-               require_once 'include/datetime.php';
                require_once 'include/items.php';
 
-               load_hooks();
+               Addon::loadHooks();
 
                if ($param == 'delete') {
                        logger('Delete expired items', LOGGER_DEBUG);
                        // physically remove anything that has been deleted for more than two months
-                       $r = dba::p("SELECT `id` FROM `item` WHERE `deleted` AND `changed` < UTC_TIMESTAMP() - INTERVAL 60 DAY");
-                       while ($row = dba::fetch($r)) {
-                               dba::delete('item', array('id' => $row['id']));
+                       $condition = ["`deleted` AND `changed` < UTC_TIMESTAMP() - INTERVAL 60 DAY"];
+                       $rows = dba::select('item', ['id', 'iaid', 'icid'],  $condition);
+                       while ($row = dba::fetch($rows)) {
+                               dba::delete('item', ['id' => $row['id']]);
+                               if (!empty($row['iaid']) && !dba::exists('item', ['iaid' => $row['iaid']])) {
+                                       dba::delete('item-activity', ['id' => $row['iaid']]);
+                               }
+                               if (!empty($row['icid']) && !dba::exists('item', ['icid' => $row['icid']])) {
+                                       dba::delete('item-content', ['id' => $row['icid']]);
+                               }
                        }
-                       dba::close($r);
+                       dba::close($rows);
 
-                       logger('Delete expired items - done', LOGGER_DEBUG);
+                       // Normally we shouldn't have orphaned data at all.
+                       // If we do have some, then we have to check why.
+                       logger('Deleting orphaned item activities - start', LOGGER_DEBUG);
+                       $condition = ["NOT EXISTS (SELECT `iaid` FROM `item` WHERE `item`.`iaid` = `item-activity`.`id`)"];
+                       dba::delete('item-activity', $condition);
+                       logger('Orphaned item activities deleted: ' . dba::affected_rows(), LOGGER_DEBUG);
+
+                       logger('Deleting orphaned item content - start', LOGGER_DEBUG);
+                       $condition = ["NOT EXISTS (SELECT `icid` FROM `item` WHERE `item`.`icid` = `item-content`.`id`)"];
+                       dba::delete('item-content', $condition);
+                       logger('Orphaned item content deleted: ' . dba::affected_rows(), LOGGER_DEBUG);
 
                        // make this optional as it could have a performance impact on large sites
                        if (intval(Config::get('system', 'optimize_items'))) {
                                dba::e("OPTIMIZE TABLE `item`");
                        }
+
+                       logger('Delete expired items - done', LOGGER_DEBUG);
                        return;
                } elseif (intval($param) > 0) {
                        $user = dba::selectFirst('user', ['uid', 'username', 'expire'], ['uid' => $param]);
                        if (DBM::is_result($user)) {
                                logger('Expire items for user '.$user['uid'].' ('.$user['username'].') - interval: '.$user['expire'], LOGGER_DEBUG);
-                               item_expire($user['uid'], $user['expire']);
+                               Item::expire($user['uid'], $user['expire']);
                                logger('Expire items for user '.$user['uid'].' ('.$user['username'].') - done ', LOGGER_DEBUG);
                        }
                        return;
@@ -50,7 +72,7 @@ class Expire {
                        foreach ($a->hooks["expire"] as $hook) {
                                if ($hook[1] == $hook_name) {
                                        logger("Calling expire hook '" . $hook[1] . "'", LOGGER_DEBUG);
-                                       call_single_hook($a, $hook_name, $hook, $data);
+                                       Addon::callSingleHook($a, $hook_name, $hook, $data);
                                }
                        }
                        return;
@@ -58,13 +80,13 @@ class Expire {
 
                logger('expire: start');
 
-               Worker::add(array('priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true),
+               Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
                                'Expire', 'delete');
 
                $r = dba::p("SELECT `uid`, `username` FROM `user` WHERE `expire` != 0");
                while ($row = dba::fetch($r)) {
                        logger('Calling expiry for user '.$row['uid'].' ('.$row['username'].')', LOGGER_DEBUG);
-                       Worker::add(array('priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true),
+                       Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
                                        'Expire', (int)$row['uid']);
                }
                dba::close($r);
@@ -74,7 +96,7 @@ class Expire {
                if (is_array($a->hooks) && array_key_exists('expire', $a->hooks)) {
                        foreach ($a->hooks['expire'] as $hook) {
                                logger("Calling expire hook for '" . $hook[1] . "'", LOGGER_DEBUG);
-                               Worker::add(array('priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true),
+                               Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
                                                'Expire', 'hook', $hook[1]);
                        }
                }