]> git.mxchange.org Git - friendica.git/blobdiff - src/Worker/Notifier.php
Merge pull request #11058 from MrPetovan/bug/10955-php-mysql-time
[friendica.git] / src / Worker / Notifier.php
index e31141ea46bcd8bac3237a0b8f4c80f8123561fc..0a77e63868d4f50c0dfc94df9ff10f4fb0bc537c 100644 (file)
@@ -86,15 +86,15 @@ class Notifier
                        foreach ($inboxes as $inbox => $receivers) {
                                $ap_contacts = array_merge($ap_contacts, $receivers);
                                Logger::info('Delivery via ActivityPub', ['cmd' => $cmd, 'target' => $target_id, 'inbox' => $inbox]);
-                               Worker::add(['priority' => PRIORITY_HIGH, 'created' => $a->queue['created'], 'dont_fork' => true],
+                               Worker::add(['priority' => PRIORITY_HIGH, 'created' => $a->getQueueValue('created'), 'dont_fork' => true],
                                        'APDelivery', $cmd, $target_id, $inbox, $uid, $receivers, $post_uriid);
                        }
                } elseif ($cmd == Delivery::SUGGESTION) {
-                       $suggest = DI::fsuggest()->getById($target_id);
+                       $suggest = DI::fsuggest()->selectOneById($target_id);
                        $uid = $suggest->uid;
                        $recipients[] = $suggest->cid;
                } elseif ($cmd == Delivery::REMOVAL) {
-                       return self::notifySelfRemoval($target_id, $a->queue['priority'], $a->queue['created']);
+                       return self::notifySelfRemoval($target_id, $a->getQueueValue('priority'), $a->getQueueValue('created'));
                } elseif ($cmd == Delivery::RELOCATION) {
                        $uid = $target_id;
 
@@ -179,10 +179,10 @@ class Notifier
                                $thr_parent = $parent;
                        }
 
-                       Logger::log('GUID: ' . $target_item["guid"] . ': Parent is ' . $parent['network'] . '. Thread parent is ' . $thr_parent['network'], Logger::DEBUG);
+                       Logger::info('Got post', ['guid' => $target_item['guid'], 'uri-id' => $target_item['uri-id'], 'network' => $target_item['network'], 'parent-network' => $parent['network'], 'thread-parent-network' => $thr_parent['network']]);
 
                        if (!self::isRemovalActivity($cmd, $owner, Protocol::ACTIVITYPUB)) {
-                               $apdelivery = self::activityPubDelivery($cmd, $target_item, $parent, $thr_parent, $a->queue['priority'], $a->queue['created'], $owner);
+                               $apdelivery = self::activityPubDelivery($cmd, $target_item, $parent, $thr_parent, $a->getQueueValue('priority'), $a->getQueueValue('created'), $owner);
                                $ap_contacts = $apdelivery['contacts'];
                                $delivery_queue_count += $apdelivery['count'];
                        }
@@ -296,7 +296,7 @@ class Notifier
                                        $push_notify = false;
                                }
 
-                               Logger::log('Notify ' . $target_item["guid"] .' via PuSH: ' . ($push_notify ? "Yes":"No"), Logger::DEBUG);
+                               Logger::info('Notify ' . $target_item["guid"] .' via PuSH: ' . ($push_notify ? "Yes":"No"));
                        } elseif ($exclusive_delivery) {
                                $followup = true;
 
@@ -315,7 +315,7 @@ class Notifier
                                // don't send deletions onward for other people's stuff
 
                                if ($target_item['deleted'] && !intval($target_item['wall'])) {
-                                       Logger::log('Ignoring delete notification for non-wall item');
+                                       Logger::notice('Ignoring delete notification for non-wall item');
                                        return;
                                }
 
@@ -339,7 +339,7 @@ class Notifier
 
                                if ((intval($parent['forum_mode']) == 1) && !$top_level && ($cmd !== Delivery::UPLINK)
                                        && ($target_item['verb'] != Activity::ANNOUNCE)) {
-                                       Worker::add($a->queue['priority'], 'Notifier', Delivery::UPLINK, $post_uriid, $sender_uid);
+                                       Worker::add($a->getQueueValue('priority'), 'Notifier', Delivery::UPLINK, $post_uriid, $sender_uid);
                                }
 
                                foreach ($items as $item) {
@@ -385,7 +385,7 @@ class Notifier
                        if (($thr_parent && ($thr_parent['network'] == Protocol::OSTATUS)) || ($parent['network'] == Protocol::OSTATUS)) {
                                $diaspora_delivery = false;
 
-                               Logger::log('Some parent is OStatus for '.$target_item["guid"]." - Author: ".$thr_parent['author-id']." - Owner: ".$thr_parent['owner-id'], Logger::DEBUG);
+                               Logger::info('Some parent is OStatus for '.$target_item["guid"]." - Author: ".$thr_parent['author-id']." - Owner: ".$thr_parent['owner-id']);
 
                                // Send a salmon to the parent author
                                $probed_contact = DBA::selectFirst('contact', ['url', 'notify'], ['id' => $thr_parent['author-id']]);
@@ -490,9 +490,9 @@ class Notifier
                $delivery_queue_count += self::deliverOStatus($target_id, $target_item, $owner, $url_recipients, $public_message, $push_notify);
 
                if (!empty($target_item)) {
-                       Logger::log('Calling hooks for ' . $cmd . ' ' . $target_id, Logger::DEBUG);
+                       Logger::info('Calling hooks for ' . $cmd . ' ' . $target_id);
 
-                       Hook::fork($a->queue['priority'], 'notifier_normal', $target_item);
+                       Hook::fork($a->getQueueValue('priority'), 'notifier_normal', $target_item);
 
                        Hook::callAll('notifier_end', $target_item);
 
@@ -534,7 +534,7 @@ class Notifier
 
                foreach ($contacts as $contact) {
                        // Direct delivery of local contacts
-                       if ($target_uid = User::getIdForURL($contact['url'])) {
+                       if (!in_array($cmd, [Delivery::RELOCATION, Delivery::SUGGESTION, Delivery::DELETION, Delivery::MAIL]) && $target_uid = User::getIdForURL($contact['url'])) {
                                Logger::info('Direct delivery', ['uri-id' => $target_item['uri-id'], 'target' => $target_uid]);
                                $fields = ['protocol' => Conversation::PARCEL_LOCAL_DFRN, 'direction' => Conversation::PUSH];
                                Item::storeForUserByUriId($target_item['uri-id'], $target_uid, $fields, $target_item['uid']);
@@ -581,10 +581,10 @@ class Notifier
                        // Situation is that sometimes Friendica servers receive Friendica posts over the Diaspora protocol first.
                        // The conversion in Markdown reduces the formatting, so these posts should arrive after the Friendica posts.
                        // This is only important for high and medium priority tasks and not for Low priority jobs like deletions.
-                       if (($contact['network'] == Protocol::DIASPORA) && in_array($a->queue['priority'], [PRIORITY_HIGH, PRIORITY_MEDIUM])) {
-                               $deliver_options = ['priority' => $a->queue['priority'], 'dont_fork' => true];
+                       if (($contact['network'] == Protocol::DIASPORA) && in_array($a->getQueueValue('priority'), [PRIORITY_HIGH, PRIORITY_MEDIUM])) {
+                               $deliver_options = ['priority' => $a->getQueueValue('priority'), 'dont_fork' => true];
                        } else {
-                               $deliver_options = ['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true];
+                               $deliver_options = ['priority' => $a->getQueueValue('priority'), 'created' => $a->getQueueValue('created'), 'dont_fork' => true];
                        }
 
                        if (Worker::add($deliver_options, 'Delivery', $cmd, $post_uriid, (int)$contact['id'], $sender_uid)) {
@@ -615,7 +615,7 @@ class Notifier
                $url_recipients = array_filter($url_recipients);
                // send salmon slaps to mentioned remote tags (@foo@example.com) in OStatus posts
                // They are especially used for notifications to OStatus users that don't follow us.
-               if (!DI::config()->get('system', 'dfrn_only') && count($url_recipients) && ($public_message || $push_notify) && !empty($target_item)) {
+               if (count($url_recipients) && ($public_message || $push_notify) && !empty($target_item)) {
                        $slap = OStatus::salmon($target_item, $owner);
                        foreach ($url_recipients as $url) {
                                Logger::info('Salmon delivery', ['item' => $target_id, 'to' => $url]);
@@ -631,7 +631,7 @@ class Notifier
                        Logger::info('Activating internal PuSH', ['item' => $target_id]);
 
                        // Handling the pubsubhubbub requests
-                       PushSubscriber::publishFeed($owner['uid'], $a->queue['priority']);
+                       PushSubscriber::publishFeed($owner['uid'], $a->getQueueValue('priority'));
                }
                return $delivery_queue_count;
        }
@@ -693,7 +693,7 @@ class Notifier
        private static function notifySelfRemoval($self_user_id, $priority, $created)
        {
                $owner = User::getOwnerDataById($self_user_id);
-               if (!$owner) {
+               if (empty($self_user_id) || empty($owner)) {
                        return false;
                }
 
@@ -703,7 +703,7 @@ class Notifier
                }
 
                while($contact = DBA::fetch($contacts_stmt)) {
-                       Contact::terminateFriendship($owner, $contact, true);
+                       Protocol::terminateFriendship($owner, $contact, true);
                }
                DBA::close($contacts_stmt);
 
@@ -732,21 +732,25 @@ class Notifier
        {
                // Don't deliver via AP when the starting post isn't from a federated network
                if (!in_array($parent['network'], Protocol::FEDERATED)) {
+                       Logger::info('Parent network is no federated network, so no AP delivery', ['network' => $parent['network']]);
                        return ['count' => 0, 'contacts' => []];
                }
 
                // Don't deliver via AP when the starting post is delivered via Diaspora
                if ($parent['network'] == Protocol::DIASPORA) {
+                       Logger::info('Parent network is Diaspora, so no AP delivery');
                        return ['count' => 0, 'contacts' => []];
                }
 
                // Also don't deliver when the direct thread parent was delivered via Diaspora
                if ($thr_parent['network'] == Protocol::DIASPORA) {
+                       Logger::info('Thread parent network is Diaspora, so no AP delivery');
                        return ['count' => 0, 'contacts' => []];
                }
 
                // Posts from Diaspora contacts are transmitted via Diaspora
                if ($target_item['network'] == Protocol::DIASPORA) {
+                       Logger::info('Post network is Diaspora, so no AP delivery');
                        return ['count' => 0, 'contacts' => []];
                }
 
@@ -763,12 +767,12 @@ class Notifier
                                $relay_inboxes = ActivityPub\Transmitter::addRelayServerInboxes();
                        }
 
-                       Logger::log('Origin item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
+                       Logger::info('Origin item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.');
                } elseif (Item::isForumPost($target_item, $owner)) {
                        $inboxes = ActivityPub\Transmitter::fetchTargetInboxes($target_item, $uid, false, 0, true);
-                       Logger::log('Forum item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
+                       Logger::info('Forum item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.');
                } elseif (!DBA::exists('conversation', ['item-uri' => $target_item['uri'], 'protocol' => Conversation::PARCEL_ACTIVITYPUB])) {
-                       Logger::log('Remote item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' is no AP post. It will not be distributed.', Logger::DEBUG);
+                       Logger::info('Remote item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' is no AP post. It will not be distributed.');
                        return ['count' => 0, 'contacts' => []];
                } elseif ($parent['origin']) {
                        // Remote items are transmitted via the personal inboxes.
@@ -780,11 +784,11 @@ class Notifier
                                $relay_inboxes = ActivityPub\Transmitter::addRelayServerInboxes([]);
                        }
 
-                       Logger::log('Remote item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
+                       Logger::info('Remote item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.');
                }
 
                if (empty($inboxes) && empty($relay_inboxes)) {
-                       Logger::log('No inboxes found for item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . '. It will not be distributed.', Logger::DEBUG);
+                       Logger::info('No inboxes found for item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . '. It will not be distributed.');
                        return ['count' => 0, 'contacts' => []];
                }