]> git.mxchange.org Git - friendica.git/blobdiff - src/Worker/OnePoll.php
Another placed replaced with "failed"
[friendica.git] / src / Worker / OnePoll.php
index 3dbc0cccd1cd06c3ebd8e481862b65d6c8f4fc75..fa8f748334e431a7495a25ebf44c76e633fbf8dd 100644 (file)
@@ -1,22 +1,37 @@
 <?php
 /**
- * @file src/Worker/OnePoll.php
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
+
 namespace Friendica\Worker;
 
-use Friendica\BaseObject;
-use Friendica\Content\Text\BBCode;
-use Friendica\Core\Config;
 use Friendica\Core\Logger;
-use Friendica\Core\PConfig;
 use Friendica\Core\Protocol;
 use Friendica\Database\DBA;
+use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\Item;
 use Friendica\Model\User;
 use Friendica\Protocol\Activity;
 use Friendica\Protocol\ActivityPub;
 use Friendica\Protocol\Email;
+use Friendica\Protocol\Feed;
 use Friendica\Protocol\PortableContact;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
@@ -40,9 +55,6 @@ class OnePoll
                        return;
                }
 
-               if ($force) {
-                       Contact::updateFromProbe($contact_id, '', true);
-               }
 
                $contact = DBA::selectFirst('contact', [], ['id' => $contact_id]);
                if (!DBA::isResult($contact)) {
@@ -50,6 +62,16 @@ class OnePoll
                        return;
                }
 
+               if (($contact['network'] != Protocol::MAIL) || $force) {
+                       Contact::updateFromProbe($contact_id, '', $force);
+               }
+
+               // Special treatment for wrongly detected local contacts
+               if (!$force && ($contact['network'] != Protocol::DFRN) && Contact::isLocalById($contact_id)) {
+                       Contact::updateFromProbe($contact_id, Protocol::DFRN, true);
+                       $contact = DBA::selectFirst('contact', [], ['id' => $contact_id]);
+               }
+
                if (($contact['network'] == Protocol::DFRN) && !Contact::isLegacyDFRNContact($contact)) {
                        $protocol = Protocol::ACTIVITYPUB;
                } else {
@@ -75,14 +97,14 @@ class OnePoll
                }
 
                // load current friends if possible.
-               if (!empty($contact['poco']) && ($contact['success_update'] > $contact['failure_update'])) {
+               if (!empty($contact['poco']) && !$contact['failed']) {
                        if (!DBA::exists('glink', ["`cid` = ? AND updated > UTC_TIMESTAMP() - INTERVAL 1 DAY", $contact['id']])) {
                                PortableContact::loadWorker($contact['id'], $importer_uid, 0, $contact['poco']);
                        }
                }
 
                // Don't poll if polling is deactivated (But we poll feeds and mails anyway)
-               if (!in_array($protocol, [Protocol::FEED, Protocol::MAIL]) && Config::get('system', 'disable_polling')) {
+               if (!in_array($protocol, [Protocol::FEED, Protocol::MAIL]) && DI::config()->get('system', 'disable_polling')) {
                        Logger::log('Polling is disabled');
 
                        // set the last-update so we don't keep polling
@@ -113,7 +135,7 @@ class OnePoll
                $xml = false;
 
                if ($contact['subhub']) {
-                       $poll_interval = Config::get('system', 'pushpoll_frequency', 3);
+                       $poll_interval = DI::config()->get('system', 'pushpoll_frequency', 3);
                        $contact['priority'] = intval($poll_interval);
                        $hub_update = false;
 
@@ -143,7 +165,7 @@ class OnePoll
                        if (!strstr($xml, '<')) {
                                Logger::log('post_handshake: response from ' . $url . ' did not contain XML.');
 
-                               $fields = ['last-update' => $updated, 'failure_update' => $updated];
+                               $fields = ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated];
                                self::updateContact($contact, $fields);
                                Contact::markForArchival($contact);
                                return;
@@ -152,11 +174,11 @@ class OnePoll
 
                        Logger::log("Consume feed of contact ".$contact['id']);
 
-                       consume_feed($xml, $importer, $contact, $hub);
+                       Feed::consume($xml, $importer, $contact, $hub);
 
                        // do it a second time for DFRN so that any children find their parents.
                        if ($protocol === Protocol::DFRN) {
-                               consume_feed($xml, $importer, $contact, $hub);
+                               Feed::consume($xml, $importer, $contact, $hub);
                        }
 
                        $hubmode = 'subscribe';
@@ -186,15 +208,15 @@ class OnePoll
                                                        continue;
                                                }
 
-                                               subscribe_to_hub($h, $importer, $contact, $hubmode);
+                                               self::subscribeToHub($h, $importer, $contact, $hubmode);
                                        }
                                }
                        }
 
-                       self::updateContact($contact, ['last-update' => $updated, 'success_update' => $updated]);
+                       self::updateContact($contact, ['failed' => false, 'last-update' => $updated, 'success_update' => $updated]);
                        Contact::unmarkForArchival($contact);
                } elseif (in_array($contact["network"], [Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, Protocol::FEED])) {
-                       self::updateContact($contact, ['last-update' => $updated, 'failure_update' => $updated]);
+                       self::updateContact($contact, ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated]);
                        Contact::markForArchival($contact);
                } else {
                        self::updateContact($contact, ['last-update' => $updated]);
@@ -214,7 +236,7 @@ class OnePoll
        }
 
        /**
-        * @brief Updates a personal contact entry and the public contact entry
+        * Updates a personal contact entry and the public contact entry
         *
         * @param array $contact The personal contact entry
         * @param array $fields  The fields that are updated
@@ -222,12 +244,18 @@ class OnePoll
         */
        private static function updateContact(array $contact, array $fields)
        {
+               // Update the user's contact
                DBA::update('contact', $fields, ['id' => $contact['id']]);
+
+               // Update the public contact
                DBA::update('contact', $fields, ['uid' => 0, 'nurl' => $contact['nurl']]);
+
+               // Update the rest of the contacts that aren't polled
+               DBA::update('contact', $fields, ['rel' => Contact::FOLLOWER, 'nurl' => $contact['nurl']]);
        }
 
        /**
-        * @brief Poll DFRN contacts
+        * Poll DFRN contacts
         *
         * @param  array  $contact The personal contact entry
         * @param  string $updated The updated date
@@ -267,7 +295,7 @@ class OnePoll
 
                if (!$curlResult->isSuccess() && ($curlResult->getErrorNumber() == CURLE_OPERATION_TIMEDOUT)) {
                        // set the last-update so we don't keep polling
-                       self::updateContact($contact, ['last-update' => $updated]);
+                       self::updateContact($contact, ['failed' => true, 'last-update' => $updated]);
                        Contact::markForArchival($contact);
                        Logger::log('Contact archived');
                        return false;
@@ -285,7 +313,7 @@ class OnePoll
                        Logger::log("$url appears to be dead - marking for death ");
 
                        // set the last-update so we don't keep polling
-                       $fields = ['last-update' => $updated, 'failure_update' => $updated];
+                       $fields = ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated];
                        self::updateContact($contact, $fields);
                        Contact::markForArchival($contact);
                        return false;
@@ -294,7 +322,7 @@ class OnePoll
                if (!strstr($handshake_xml, '<')) {
                        Logger::log('response from ' . $url . ' did not contain XML.');
 
-                       $fields = ['last-update' => $updated, 'failure_update' => $updated];
+                       $fields = ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated];
                        self::updateContact($contact, $fields);
                        Contact::markForArchival($contact);
                        return false;
@@ -305,7 +333,7 @@ class OnePoll
                if (!is_object($res)) {
                        Logger::info('Unparseable response', ['url' => $url]);
 
-                       $fields = ['last-update' => $updated, 'failure_update' => $updated];
+                       $fields = ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated];
                        self::updateContact($contact, $fields);
                        Contact::markForArchival($contact);
                        return false;
@@ -316,7 +344,7 @@ class OnePoll
                        Logger::log("$url replied status 1 - marking for death ");
 
                        // set the last-update so we don't keep polling
-                       $fields = ['last-update' => $updated, 'failure_update' => $updated];
+                       $fields = ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated];
                        self::updateContact($contact, $fields);
                        Contact::markForArchival($contact);
                } elseif ($contact['term-date'] > DBA::NULL_DATETIME) {
@@ -381,7 +409,7 @@ class OnePoll
        }
 
        /**
-        * @brief Poll Feed/OStatus contacts
+        * Poll Feed/OStatus contacts
         *
         * @param  array  $contact The personal contact entry
         * @param  string $protocol The used protocol of the contact
@@ -395,7 +423,7 @@ class OnePoll
                // Will only do this once per notify-enabled OStatus contact
                // or if relationship changes
 
-               $stat_writeable = ((($contact['notify']) && ($contact['rel'] == Contact::FOLLOWER || $contact['rel'] == Contact::FRIEND)) ? 1 : 0);
+               $stat_writeable = $contact['notify'] && ($contact['rel'] == Contact::FOLLOWER || $contact['rel'] == Contact::FRIEND);
 
                // Contacts from OStatus are always writable
                if ($protocol === Protocol::OSTATUS) {
@@ -421,7 +449,7 @@ class OnePoll
 
                if ($curlResult->isTimeout()) {
                        // set the last-update so we don't keep polling
-                       self::updateContact($contact, ['last-update' => $updated]);
+                       self::updateContact($contact, ['failed' => true, 'last-update' => $updated]);
                        Contact::markForArchival($contact);
                        Logger::log('Contact archived');
                        return false;
@@ -431,7 +459,7 @@ class OnePoll
        }
 
        /**
-        * @brief Poll Mail contacts
+        * Poll Mail contacts
         *
         * @param  array   $contact      The personal contact entry
         * @param  integer $importer_uid The UID of the importer
@@ -442,10 +470,10 @@ class OnePoll
        {
                Logger::log("Mail: Fetching for ".$contact['addr'], Logger::DEBUG);
 
-               $mail_disabled = ((function_exists('imap_open') && !Config::get('system', 'imap_disabled')) ? 0 : 1);
+               $mail_disabled = ((function_exists('imap_open') && !DI::config()->get('system', 'imap_disabled')) ? 0 : 1);
                if ($mail_disabled) {
                        // set the last-update so we don't keep polling
-                       self::updateContact($contact, ['last-update' => $updated]);
+                       self::updateContact($contact, ['failed' => true, 'last-update' => $updated]);
                        Contact::markForArchival($contact);
                        Logger::log('Contact archived');
                        return;
@@ -562,7 +590,7 @@ class OnePoll
                                        }
 
                                        // Decoding the header
-                                       $subject = imap_mime_header_decode($meta->subject);
+                                       $subject = imap_mime_header_decode($meta->subject ?? '');
                                        $datarray['title'] = "";
                                        foreach ($subject as $subpart) {
                                                if ($subpart->charset != "default") {
@@ -636,11 +664,11 @@ class OnePoll
                                        $datarray['owner-avatar'] = $contact['photo'];
 
                                        if ($datarray['parent-uri'] === $datarray['uri']) {
-                                               $datarray['private'] = 1;
+                                               $datarray['private'] = Item::PRIVATE;
                                        }
 
-                                       if (!PConfig::get($importer_uid, 'system', 'allow_public_email_replies')) {
-                                               $datarray['private'] = 1;
+                                       if (!DI::pConfig()->get($importer_uid, 'system', 'allow_public_email_replies')) {
+                                               $datarray['private'] = Item::PRIVATE;
                                                $datarray['allow_cid'] = '<' . $contact['id'] . '>';
                                        }
 
@@ -683,4 +711,56 @@ class OnePoll
                Logger::log("Mail: closing connection for ".$mailconf['user']);
                imap_close($mbox);
        }
+
+
+       /**
+        * @param string $url
+        * @param array  $importer
+        * @param array  $contact
+        * @param string $hubmode
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        */
+       private static function subscribeToHub(string $url, array $importer, array $contact, $hubmode = 'subscribe')
+       {
+               /*
+                * Diaspora has different message-ids in feeds than they do
+                * through the direct Diaspora protocol. If we try and use
+                * the feed, we'll get duplicates. So don't.
+                */
+               if ($contact['network'] === Protocol::DIASPORA) {
+                       return;
+               }
+
+               // Without an importer we don't have a user id - so we quit
+               if (empty($importer)) {
+                       return;
+               }
+
+               $user = DBA::selectFirst('user', ['nickname'], ['uid' => $importer['uid']]);
+
+               // No user, no nickname, we quit
+               if (!DBA::isResult($user)) {
+                       return;
+               }
+
+               $push_url = DI::baseUrl() . '/pubsub/' . $user['nickname'] . '/' . $contact['id'];
+
+               // Use a single verify token, even if multiple hubs
+               $verify_token = ((strlen($contact['hub-verify'])) ? $contact['hub-verify'] : Strings::getRandomHex());
+
+               $params = 'hub.mode=' . $hubmode . '&hub.callback=' . urlencode($push_url) . '&hub.topic=' . urlencode($contact['poll']) . '&hub.verify=async&hub.verify_token=' . $verify_token;
+
+               Logger::log('subscribe_to_hub: ' . $hubmode . ' ' . $contact['name'] . ' to hub ' . $url . ' endpoint: ' . $push_url . ' with verifier ' . $verify_token);
+
+               if (!strlen($contact['hub-verify']) || ($contact['hub-verify'] != $verify_token)) {
+                       DBA::update('contact', ['hub-verify' => $verify_token], ['id' => $contact['id']]);
+               }
+
+               $postResult = Network::post($url, $params);
+
+               Logger::log('subscribe_to_hub: returns: ' . $postResult->getReturnCode(), Logger::DEBUG);
+
+               return;
+
+       }
 }