Merge remote-tracking branch 'upstream/develop' into error-handling

[friendica.git] / tests / legacy / ApiTest.php

diff --git a/tests/legacy/ApiTest.php b/tests/legacy/ApiTest.php
index 1f761de2034282f429b62f8b8c9efb742f6751a1..e800f68c80e2c76e1ab2993f9694100f1b38b978 100644 (file)
--- a/tests/legacy/ApiTest.php
+++ b/tests/legacy/ApiTest.php
@@ -6,12 +6,13 @@
 namespace Friendica\Test\legacy;
 
 use Friendica\App;
-use Friendica\Core\Config\IConfig;
-use Friendica\Core\PConfig\IPConfig;
+use Friendica\Core\Config\Capability\IManageConfigValues;
+use Friendica\Core\PConfig\Capability\IManagePersonalConfigValues;
 use Friendica\Core\Protocol;
 use Friendica\DI;
 use Friendica\Network\HTTPException;
 use Friendica\Test\FixtureTest;
+use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Temporal;
 use Monolog\Handler\TestHandler;
 
@@ -44,7 +45,7 @@ class ApiTest extends FixtureTest
        /** @var App */
        protected $app;
 
-       /** @var IConfig */
+       /** @var IManageConfigValues */
        protected $config;
 
        /**
@@ -58,8 +59,8 @@ class ApiTest extends FixtureTest
 
                parent::setUp();
 
-               /** @var IConfig $config */
-               $this->config = $this->dice->create(IConfig::class);
+               /** @var IManageConfigValues $config */
+               $this->config = $this->dice->create(IManageConfigValues::class);
 
                $this->config->set('system', 'url', 'http://localhost');
                $this->config->set('system', 'hostname', 'localhost');
@@ -812,7 +813,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiGetUserWithFrioSchema()
        {
-               $pConfig = $this->dice->create(IPConfig::class);
+               $pConfig = $this->dice->create(IManagePersonalConfigValues::class);
                $pConfig->set($this->selfUser['id'], 'frio', 'schema', 'red');
                $user = api_get_user($this->app);
                self::assertSelfUser($user);
@@ -828,7 +829,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiGetUserWithEmptyFrioSchema()
        {
-               $pConfig = $this->dice->create(IPConfig::class);
+               $pConfig = $this->dice->create(IManagePersonalConfigValues::class);
                $pConfig->set($this->selfUser['id'], 'frio', 'schema', '---');
                $user = api_get_user($this->app);
                self::assertSelfUser($user);
@@ -844,7 +845,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiGetUserWithCustomFrioSchema()
        {
-               $pConfig = $this->dice->create(IPConfig::class);
+               $pConfig = $this->dice->create(IManagePersonalConfigValues::class);
                $pConfig->set($this->selfUser['id'], 'frio', 'schema', '---');
                $pConfig->set($this->selfUser['id'], 'frio', 'nav_bg', '#123456');
                $pConfig->set($this->selfUser['id'], 'frio', 'link_color', '#123456');
@@ -1949,7 +1950,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiStatusesMentions()
        {
-               $this->app->user    = ['nickname' => $this->selfUser['nick']];
+               $this->app->setLoggedInUserNickname($this->selfUser['nick']);
                $_REQUEST['max_id'] = 10;
                $result             = api_statuses_mentions('json');
                self::assertEmpty($result['status']);
@@ -2865,7 +2866,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiDirectMessagesNewWithScreenName()
        {
-               $this->app->user    = ['nickname' => $this->selfUser['nick']];
+               $this->app->setLoggedInUserNickname($this->selfUser['nick']);
                $_POST['text']        = 'message_text';
                $_POST['screen_name'] = $this->friendUser['nick'];
                $result               = api_direct_messages_new('json');
@@ -2881,7 +2882,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiDirectMessagesNewWithTitle()
        {
-               $this->app->user    = ['nickname' => $this->selfUser['nick']];
+               $this->app->setLoggedInUserNickname($this->selfUser['nick']);
                $_POST['text']        = 'message_text';
                $_POST['screen_name'] = $this->friendUser['nick'];
                $_REQUEST['title']    = 'message_title';
@@ -2899,7 +2900,7 @@ class ApiTest extends FixtureTest
         */
        public function testApiDirectMessagesNewWithRss()
        {
-               $this->app->user    = ['nickname' => $this->selfUser['nick']];
+               $this->app->setLoggedInUserNickname($this->selfUser['nick']);
                $_POST['text']        = 'message_text';
                $_POST['screen_name'] = $this->friendUser['nick'];
                $result               = api_direct_messages_new('rss');
@@ -3510,18 +3511,6 @@ class ApiTest extends FixtureTest
                $this->markTestIncomplete();
        }
 
-       /**
-        * Test the api_share_as_retweet() function.
-        *
-        * @return void
-        */
-       public function testApiShareAsRetweet()
-       {
-               $item   = ['body' => '', 'author-id' => 1, 'owner-id' => 1];
-               $result = api_share_as_retweet($item);
-               self::assertFalse($result);
-       }
-
        /**
         * Test the api_share_as_retweet() function with a valid item.
         *
@@ -3726,11 +3715,13 @@ class ApiTest extends FixtureTest
        {
                DI::args()->setArgv(['api', 'friendica', 'notification']);
                $result  = api_friendica_notification('xml');
-               $dateRel = Temporal::getRelativeDate('2020-01-01 12:12:02');
+               $date = DateTimeFormat::local('2020-01-01 12:12:02');
+               $dateRel = Temporal::getRelativeDate('2020-01-01 07:12:02');
+
                $assertXml=<<<XML
 <?xml version="1.0"?>
 <notes>
-  <note id="1" hash="" type="8" name="Reply to" url="http://localhost/display/1" photo="http://localhost/" date="2020-01-01 12:12:02" msg="A test reply from an item" uid="42" uri-id="" link="http://localhost/notification/1" iid="4" parent="" parent-uri-id="" seen="0" verb="" otype="item" name_cache="Reply to" msg_cache="A test reply from an item" timestamp="1577880722" date_rel="{$dateRel}" msg_html="A test reply from an item" msg_plain="A test reply from an item"/>
+  <note date="$date" date_rel="$dateRel" id="1" iid="4" link="http://localhost/notification/1" msg="A test reply from an item" msg_cache="A test reply from an item" msg_html="A test reply from an item" msg_plain="A test reply from an item" name="Reply to" name_cache="Reply to" otype="item" parent="" photo="http://localhost/" seen="false" timestamp="1577880722" type="8" uid="42" url="http://localhost/display/1" verb="http://activitystrea.ms/schema/1.0/post"/>
 </notes>
 XML;
                self::assertXmlStringEqualsXmlString($assertXml, $result);