Just commit config transactions if something changed

[friendica.git] / tests / src / Console / ServerBlockConsoleTest.php

diff --git a/tests/src/Console/ServerBlockConsoleTest.php b/tests/src/Console/ServerBlockConsoleTest.php
index cdd7efef0e1386cd9de88e9980aa71feb8d9336b..2ea1a66696b2762f9ba3d1cf49da88c2f29ccd0e 100644 (file)
--- a/tests/src/Console/ServerBlockConsoleTest.php
+++ b/tests/src/Console/ServerBlockConsoleTest.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -93,25 +93,6 @@ CONS;
                self::assertEquals('The domain pattern \'testme.now\' is now blocked. (Reason: \'I like it!\')' . "\n", $txt);
        }
 
-       /**
-        * Test blockedservers add command with the default reason
-        */
-       public function testAddBlockedServerWithDefaultReason()
-       {
-               $this->blocklistMock
-                       ->shouldReceive('addPattern')
-                       ->with('testme.now', DomainPatternBlocklist::DEFAULT_REASON)
-                       ->andReturn(1)
-                       ->once();
-
-               $console = new ServerBlock($this->blocklistMock, $this->consoleArgv);
-               $console->setArgument(0, 'add');
-               $console->setArgument(1, 'testme.now');
-               $txt = $this->dumpExecute($console);
-
-               self::assertEquals('The domain pattern \'testme.now\' is now blocked. (Reason: \'' . DomainPatternBlocklist::DEFAULT_REASON . '\')' . "\n", $txt);
-       }
-
        /**
         * Test blockedservers add command on existed domain
         */
@@ -170,16 +151,16 @@ CONS;
        {
                $this->blocklistMock
                        ->shouldReceive('removePattern')
-                       ->with('not.exiting')
+                       ->with('not.existing')
                        ->andReturn(1)
                        ->once();
 
                $console = new ServerBlock($this->blocklistMock, $this->consoleArgv);
                $console->setArgument(0, 'remove');
-               $console->setArgument(1, 'not.exiting');
+               $console->setArgument(1, 'not.existing');
                $txt = $this->dumpExecute($console);
 
-               self::assertEquals('The domain pattern \'not.exiting\' wasn\'t blocked.' . "\n", $txt);
+               self::assertEquals('The domain pattern \'not.existing\' wasn\'t blocked.' . "\n", $txt);
        }
 
        /**
@@ -191,7 +172,14 @@ CONS;
                $console->setArgument(0, 'add');
                $txt = $this->dumpExecute($console);
 
-               self::assertStringStartsWith('[Warning] Add needs a domain pattern and optionally a reason.', $txt);
+               self::assertStringStartsWith('[Warning] Add needs a domain pattern and a reason.', $txt);
+
+               $console = new ServerBlock($this->blocklistMock, $this->consoleArgv);
+               $console->setArgument(0, 'add');
+               $console->setArgument(1, 'testme.now');
+               $txt = $this->dumpExecute($console);
+
+               self::assertStringStartsWith('[Warning] Add needs a domain pattern and a reason.', $txt);
        }
 
        /**
@@ -201,13 +189,14 @@ CONS;
        {
                $this->blocklistMock
                        ->shouldReceive('addPattern')
-                       ->with('testme.now', DomainPatternBlocklist::DEFAULT_REASON)
+                       ->with('testme.now', 'I like it!')
                        ->andReturn(0)
                        ->once();
 
                $console = new ServerBlock($this->blocklistMock, $this->consoleArgv);
                $console->setArgument(0, 'add');
                $console->setArgument(1, 'testme.now');
+               $console->setArgument(2, 'I like it!');
                $txt = $this->dumpExecute($console);
 
                self::assertEquals('Couldn\'t save \'testme.now\' as blocked domain pattern' . "\n", $txt);