Merge pull request #8079 from ozero/patch-1

[friendica.git] / tests / src / Core / InstallerTest.php

diff --git a/tests/src/Core/InstallerTest.php b/tests/src/Core/InstallerTest.php
index c1a003bade6d0ba374ca5b61056112afbf404b3e..dd7790e7399154492562bc6a3e1f3443e01c7f8a 100644 (file)
--- a/tests/src/Core/InstallerTest.php
+++ b/tests/src/Core/InstallerTest.php
@@ -3,24 +3,46 @@
 // this is in the same namespace as Install for mocking 'function_exists'
 namespace Friendica\Core;
 
+use Dice\Dice;
+use Friendica\Core\Config\Cache\ConfigCache;
+use Friendica\DI;
+use Friendica\Network\CurlResult;
 use Friendica\Test\MockedTest;
-use Friendica\Test\Util\L10nMockTrait;
 use Friendica\Test\Util\VFSTrait;
+use Friendica\Util\Network;
+use Mockery\MockInterface;
 
-/**
- * @runTestsInSeparateProcesses
- * @preserveGlobalState disabled
- */
 class InstallerTest extends MockedTest
 {
        use VFSTrait;
-       use L10nMockTrait;
+
+       /**
+        * @var \Friendica\Core\L10n\L10n|MockInterface
+        */
+       private $l10nMock;
 
        public function setUp()
        {
                parent::setUp();
 
                $this->setUpVfsDir();
+
+               $this->l10nMock = \Mockery::mock(\Friendica\Core\L10n\L10n::class);
+
+               /** @var Dice|MockInterface $dice */
+               $dice = \Mockery::mock(Dice::class)->makePartial();
+               $dice = $dice->addRules(include __DIR__ . '/../../../static/dependencies.config.php');
+
+               $dice->shouldReceive('create')
+                          ->with(\Friendica\Core\L10n\L10n::class, [])
+                          ->andReturn($this->l10nMock);
+
+               DI::init($dice);
+       }
+
+       private function mockL10nT(string $text, $times = null)
+       {
+               $this->l10nMock->shouldReceive('t')->with($text)->andReturn($text)->times($times);
        }
 
        /**
@@ -51,13 +73,15 @@ class InstallerTest extends MockedTest
 
        private function assertCheckExist($position, $title, $help, $status, $required, $assertionArray)
        {
-               $this->assertArraySubset([$position => [
+               $subSet = [$position => [
                        'title' => $title,
                        'status' => $status,
                        'required' => $required,
                        'error_msg' => null,
                        'help' => $help]
-               ], $assertionArray);
+               ];
+
+               $this->assertArraySubset($subSet, $assertionArray, false, "expected subset: " . PHP_EOL . print_r($subSet, true) . PHP_EOL . "current subset: " . print_r($assertionArray, true));
        }
 
        /**
@@ -101,7 +125,7 @@ class InstallerTest extends MockedTest
         */
        public function testCheckKeys()
        {
-               $this->mockL10nT();
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                $this->setFunctions(['openssl_pkey_new' => false]);
                $install = new Installer();
@@ -225,7 +249,7 @@ class InstallerTest extends MockedTest
         */
        public function testCheckLocalIni()
        {
-               $this->mockL10nT();
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                $this->assertTrue($this->root->hasChild('config/local.config.php'));
 
@@ -242,13 +266,15 @@ class InstallerTest extends MockedTest
 
        /**
         * @small
+        * @runInSeparateProcess
+        * @preserveGlobalState disabled
         */
        public function testCheckHtAccessFail()
        {
-               $this->mockL10nT();
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                // Mocking the CURL Response
-               $curlResult = \Mockery::mock('Friendica\Network\CurlResult');
+               $curlResult = \Mockery::mock(CurlResult::class);
                $curlResult
                        ->shouldReceive('getReturnCode')
                        ->andReturn('404');
@@ -260,7 +286,7 @@ class InstallerTest extends MockedTest
                        ->andReturn('test Error');
 
                // Mocking the CURL Request
-               $networkMock = \Mockery::mock('alias:Friendica\Util\Network');
+               $networkMock = \Mockery::mock('alias:' . Network::class);
                $networkMock
                        ->shouldReceive('fetchUrlFull')
                        ->with('https://test/install/testrewrite')
@@ -281,25 +307,27 @@ class InstallerTest extends MockedTest
 
        /**
         * @small
+        * @runInSeparateProcess
+        * @preserveGlobalState disabled
         */
        public function testCheckHtAccessWork()
        {
-               $this->mockL10nT();
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                // Mocking the failed CURL Response
-               $curlResultF = \Mockery::mock('Friendica\Network\CurlResult');
+               $curlResultF = \Mockery::mock(CurlResult::class);
                $curlResultF
                        ->shouldReceive('getReturnCode')
                        ->andReturn('404');
 
                // Mocking the working CURL Response
-               $curlResultW = \Mockery::mock('Friendica\Network\CurlResult');
+               $curlResultW = \Mockery::mock(CurlResult::class);
                $curlResultW
                        ->shouldReceive('getReturnCode')
                        ->andReturn('204');
 
                // Mocking the CURL Request
-               $networkMock = \Mockery::mock('alias:Friendica\Util\Network');
+               $networkMock = \Mockery::mock('alias:' . Network::class);
                $networkMock
                        ->shouldReceive('fetchUrlFull')
                        ->with('https://test/install/testrewrite')
@@ -312,9 +340,6 @@ class InstallerTest extends MockedTest
                // Mocking that we can use CURL
                $this->setFunctions(['curl_init' => true]);
 
-               // needed because of "normalise_link"
-               require_once __DIR__ . '/../../../include/text.php';
-
                $install = new Installer();
 
                $this->assertTrue($install->checkHtAccess('https://test'));
@@ -322,15 +347,14 @@ class InstallerTest extends MockedTest
 
        /**
         * @small
+        * @runInSeparateProcess
+        * @preserveGlobalState disabled
         */
        public function testImagick()
        {
-               $this->mockL10nT();
+               $this->markTestIncomplete('needs adapted class_exists() mock');
 
-               $imageMock = \Mockery::mock('alias:Friendica\Object\Image');
-               $imageMock
-                       ->shouldReceive('supportedTypes')
-                       ->andReturn(['image/gif' => 'gif']);
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                $this->setClasses(['Imagick' => true]);
 
@@ -340,7 +364,7 @@ class InstallerTest extends MockedTest
                $this->assertTrue($install->checkImagick());
 
                $this->assertCheckExist(1,
-                       L10n::t('ImageMagick supports GIF'),
+                       $this->l10nMock->t('ImageMagick supports GIF'),
                        '',
                        true,
                        false,
@@ -349,15 +373,12 @@ class InstallerTest extends MockedTest
 
        /**
         * @small
+        * @runInSeparateProcess
+        * @preserveGlobalState disabled
         */
        public function testImagickNotFound()
        {
-               $this->mockL10nT();
-
-               $imageMock = \Mockery::mock('alias:Friendica\Object\Image');
-               $imageMock
-                       ->shouldReceive('supportedTypes')
-                       ->andReturn([]);
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
 
                $this->setClasses(['Imagick' => true]);
 
@@ -366,7 +387,7 @@ class InstallerTest extends MockedTest
                // even there is no supported type, Imagick should return true (because it is not required)
                $this->assertTrue($install->checkImagick());
                $this->assertCheckExist(1,
-                       L10n::t('ImageMagick supports GIF'),
+                       $this->l10nMock->t('ImageMagick supports GIF'),
                        '',
                        false,
                        false,
@@ -389,6 +410,21 @@ class InstallerTest extends MockedTest
                        false,
                        $install->getChecks());
        }
+
+       /**
+        * Test the setup of the config cache for installation
+        */
+       public function testSetUpCache()
+       {
+               $this->l10nMock->shouldReceive('t')->andReturnUsing(function ($args) { return $args; });
+
+               $install = new Installer();
+               $configCache = \Mockery::mock(ConfigCache::class);
+               $configCache->shouldReceive('set')->with('config', 'php_path', \Mockery::any())->once();
+               $configCache->shouldReceive('set')->with('system', 'basepath', '/test/')->once();
+
+               $install->setUpCache($configCache, '/test/');
+       }
 }
 
 /**