Merge pull request #10666 from tobiasd/20210905-credits

[friendica.git] / tests / src / Core / Lock / SemaphoreLockTest.php

diff --git a/tests/src/Core/Lock/SemaphoreLockTest.php b/tests/src/Core/Lock/SemaphoreLockTest.php
index 6b4daf88741a8b3af8a087bde2bbfb8e5d6d9124..87d8b2cd2f59595eeed51422037e92a2f5caa01a 100644 (file)
--- a/tests/src/Core/Lock/SemaphoreLockTest.php
+++ b/tests/src/Core/Lock/SemaphoreLockTest.php
@@ -1,32 +1,52 @@
 <?php
+/**
+ * @copyright Copyright (C) 2010-2021, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
 
 namespace Friendica\Test\src\Core\Lock;
 
 use Dice\Dice;
 use Friendica\App;
-use Friendica\Core\Config\IConfiguration;
-use Friendica\Core\Config\JitConfiguration;
+use Friendica\Core\Config\IConfig;
+use Friendica\Core\Config\JitConfig;
 use Friendica\Core\Lock\SemaphoreLock;
 use Friendica\DI;
+use Mockery;
 use Mockery\MockInterface;
 
 class SemaphoreLockTest extends LockTest
 {
-       public function setUp()
+       protected function setUp(): void
        {
                /** @var MockInterface|Dice $dice */
-               $dice = \Mockery::mock(Dice::class)->makePartial();
+               $dice = Mockery::mock(Dice::class)->makePartial();
 
-               $app = \Mockery::mock(App::class);
+               $app = Mockery::mock(App::class);
                $app->shouldReceive('getHostname')->andReturn('friendica.local');
                $dice->shouldReceive('create')->with(App::class)->andReturn($app);
 
-               $configMock = \Mockery::mock(JitConfiguration::class);
+               $configMock = Mockery::mock(JitConfig::class);
                $configMock
                        ->shouldReceive('get')
-                       ->with('system', 'temppath', NULL, false)
+                       ->with('system', 'temppath')
                        ->andReturn('/tmp/');
-               $dice->shouldReceive('create')->with(IConfiguration::class)->andReturn($configMock);
+               $dice->shouldReceive('create')->with(IConfig::class)->andReturn($configMock);
 
                // @todo Because "get_temppath()" is using static methods, we have to initialize the BaseObject
                DI::init($dice);
@@ -39,10 +59,12 @@ class SemaphoreLockTest extends LockTest
                return new SemaphoreLock();
        }
 
-       function testLockTTL()
+       /**
+        * @doesNotPerformAssertions
+        */
+       public function testLockTTL()
        {
-               // Semaphore doesn't work with TTL
-               return true;
+               self::markTestSkipped("Semaphore doesn't work with TTL");
        }
 
        /**
@@ -54,9 +76,9 @@ class SemaphoreLockTest extends LockTest
                $file = get_temppath() . '/test.sem';
                touch($file);
 
-               $this->assertTrue(file_exists($file));
-               $this->assertFalse($this->instance->release('test', false));
-               $this->assertTrue(file_exists($file));
+               self::assertTrue(file_exists($file));
+               self::assertFalse($this->instance->release('test', false));
+               self::assertTrue(file_exists($file));
        }
 
        /**
@@ -64,6 +86,7 @@ class SemaphoreLockTest extends LockTest
         * This test proves that semaphore locks cannot get released by other instances except themselves
         *
         * Check for Bug https://github.com/friendica/friendica/issues/7298#issuecomment-521996540
+        *
         * @see https://github.com/friendica/friendica/issues/7298#issuecomment-521996540
         */
        public function testMissingFileOverriding()
@@ -71,9 +94,9 @@ class SemaphoreLockTest extends LockTest
                $file = get_temppath() . '/test.sem';
                touch($file);
 
-               $this->assertTrue(file_exists($file));
-               $this->assertFalse($this->instance->release('test', true));
-               $this->assertTrue(file_exists($file));
+               self::assertTrue(file_exists($file));
+               self::assertFalse($this->instance->release('test', true));
+               self::assertTrue(file_exists($file));
        }
 
        /**
@@ -84,9 +107,9 @@ class SemaphoreLockTest extends LockTest
                $file = get_temppath() . '/test.sem';
                touch($file);
 
-               $this->assertTrue(file_exists($file));
-               $this->assertTrue($this->instance->acquire('test'));
-               $this->assertTrue($this->instance->isLocked('test'));
-               $this->assertTrue($this->instance->release('test'));
+               self::assertTrue(file_exists($file));
+               self::assertTrue($this->instance->acquire('test'));
+               self::assertTrue($this->instance->isLocked('test'));
+               self::assertTrue($this->instance->release('test'));
        }
 }