Merge pull request #7010 from nupplaphil/task/basepath_hardening

[friendica.git] / tests / src / Util / BaseURLTest.php

diff --git a/tests/src/Util/BaseURLTest.php b/tests/src/Util/BaseURLTest.php
index c819a22e5ff364cdc4ac26834eb0644e63f47dc6..1e74af39fe3937d96811b7d1bd21736830619500 100644 (file)
--- a/tests/src/Util/BaseURLTest.php
+++ b/tests/src/Util/BaseURLTest.php
@@ -179,18 +179,26 @@ class BaseURLTest extends MockedTest
                $configMock->shouldReceive('get')->with('system', 'ssl_policy')->andReturn($input['sslPolicy']);
                $configMock->shouldReceive('get')->with('system', 'url')->andReturn($input['url']);
 
+               // If we don't have an urlPath as an input, we assert it, we will save it to the DB for the next time
                if (!isset($input['urlPath']) && isset($assert['urlPath'])) {
                        $configMock->shouldReceive('set')->with('system', 'urlpath', $assert['urlPath'])->once();
                }
 
+               // If we don't have the ssl_policy as an input, we assert it, we will save it to the DB for the next time
                if (!isset($input['sslPolicy']) && isset($assert['sslPolicy'])) {
                        $configMock->shouldReceive('set')->with('system', 'ssl_policy', $assert['sslPolicy'])->once();
                }
 
-               if (!isset($input['hostname']) && !empty($assert['hostname'])) {
+               // If we don't have the hostname as an input, we assert it, we will save it to the DB for the next time
+               if (empty($input['hostname']) && !empty($assert['hostname'])) {
                        $configMock->shouldReceive('set')->with('config', 'hostname', $assert['hostname'])->once();
                }
 
+               // If we don't have an URL at first, but we assert it, we will save it to the DB for the next time
+               if (empty($input['url']) && !empty($assert['url'])) {
+                       $configMock->shouldReceive('set')->with('system', 'url', $assert['url'])->once();
+               }
+
                $baseUrl = new BaseURL($configMock, $server);
 
                $this->assertEquals($assert['hostname'], $baseUrl->getHostname());
@@ -470,4 +478,65 @@ class BaseURLTest extends MockedTest
 
                $this->assertEquals($redirect, $baseUrl->checkRedirectHttps());
        }
+
+       public function dataWrongSave()
+       {
+               return [
+                       'wrongHostname' => [
+                               'fail' => 'hostname',
+                       ],
+                       'wrongSSLPolicy' => [
+                               'fail' => 'sslPolicy',
+                       ],
+                       'wrongURLPath' => [
+                               'fail' => 'urlPath',
+                       ],
+                       'wrongURL' => [
+                               'fail' => 'url',
+                       ],
+               ];
+       }
+
+       /**
+        * Test the save() method with wrong parameters
+        * @dataProvider dataWrongSave
+        */
+       public function testWrongSave($fail)
+       {
+               $configMock = \Mockery::mock(Configuration::class);
+               $configMock->shouldReceive('get')->with('config', 'hostname')->andReturn('friendica.local');
+               $configMock->shouldReceive('get')->with('system', 'urlpath')->andReturn('new/test');
+               $configMock->shouldReceive('get')->with('system', 'ssl_policy')->andReturn(BaseURL::DEFAULT_SSL_SCHEME);
+               $configMock->shouldReceive('get')->with('system', 'url')->andReturn('http://friendica.local/new/test');
+
+               switch ($fail) {
+                       case 'hostname':
+                               $configMock->shouldReceive('set')->with('config', 'hostname', \Mockery::any())->andReturn(false)->once();
+                               break;
+                       case 'sslPolicy':
+                               $configMock->shouldReceive('set')->with('config', 'hostname', \Mockery::any())->andReturn(true)->twice();
+                               $configMock->shouldReceive('set')->with('system', 'ssl_policy', \Mockery::any())->andReturn(false)->once();
+                               break;
+                       case 'urlPath':
+                               $configMock->shouldReceive('set')->with('config', 'hostname', \Mockery::any())->andReturn(true)->twice();
+                               $configMock->shouldReceive('set')->with('system', 'ssl_policy', \Mockery::any())->andReturn(true)->twice();
+                               $configMock->shouldReceive('set')->with('system', 'urlpath', \Mockery::any())->andReturn(false)->once();
+                               break;
+                       case 'url':
+                               $configMock->shouldReceive('set')->with('config', 'hostname', \Mockery::any())->andReturn(true)->twice();
+                               $configMock->shouldReceive('set')->with('system', 'ssl_policy', \Mockery::any())->andReturn(true)->twice();
+                               $configMock->shouldReceive('set')->with('system', 'urlpath', \Mockery::any())->andReturn(true)->twice();
+                               $configMock->shouldReceive('set')->with('system', 'url', \Mockery::any())->andReturn(false)->once();
+                               break;
+               }
+
+               $baseUrl = new BaseURL($configMock, []);
+               $this->assertFalse($baseUrl->save('test', 10, 'nope'));
+
+               // nothing should have changed because we never successfully saved anything
+               $this->assertEquals($baseUrl->getHostname(), 'friendica.local');
+               $this->assertEquals($baseUrl->getUrlPath(), 'new/test');
+               $this->assertEquals($baseUrl->getSSLPolicy(), BaseURL::DEFAULT_SSL_SCHEME);
+               $this->assertEquals($baseUrl->get(), 'http://friendica.local/new/test');
+       }
 }