]> git.mxchange.org Git - friendica-addons.git/blobdiff - twitter/twitter.php
[global] CR request: Moved proxify*() methods to separate class
[friendica-addons.git] / twitter / twitter.php
index da103aeadd21ca29c0fd6f893d8bcf4a670dddf6..8ac6197bf2f49d1f1ad43efe0ff24798d8a7d669 100644 (file)
  *     we do not need "Twitter as login". When you've registered the app you get the
  *     OAuth Consumer key and secret pair for your application/site.
  *
- *     Add this key pair to your global .htconfig.php or use the admin panel.
+ *     Add this key pair to your global config/addon.ini.php or use the admin panel.
  *
- *     $a->config['twitter']['consumerkey'] = 'your consumer_key here';
- *     $a->config['twitter']['consumersecret'] = 'your consumer_secret here';
+ *     [twitter]
+ *     consumerkey = your consumer_key here
+ *     consumersecret = your consumer_secret here
  *
- *     To activate the addon itself add it to the $a->config['system']['addon']
+ *     To activate the addon itself add it to the [system] addon
  *     setting. After this, your user can configure their Twitter account settings
  *     from "Settings -> Addon Settings".
  *
@@ -70,8 +71,9 @@ use Friendica\Core\Config;
 use Friendica\Core\L10n;
 use Friendica\Core\PConfig;
 use Friendica\Core\Worker;
-use Friendica\Model\GContact;
+use Friendica\Database\DBA;
 use Friendica\Model\Contact;
+use Friendica\Model\GContact;
 use Friendica\Model\Group;
 use Friendica\Model\Item;
 use Friendica\Model\ItemContent;
@@ -80,7 +82,6 @@ use Friendica\Model\User;
 use Friendica\Object\Image;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
-use Friendica\Database\DBM;
 
 require_once 'boot.php';
 require_once 'include/dba.php';
@@ -94,6 +95,7 @@ define('TWITTER_DEFAULT_POLL_INTERVAL', 5); // given in minutes
 function twitter_install()
 {
        //  we need some hooks, for the configuration and for sending tweets
+       Addon::registerHook('load_config', 'addon/twitter/twitter.php', 'twitter_load_config');
        Addon::registerHook('connector_settings', 'addon/twitter/twitter.php', 'twitter_settings');
        Addon::registerHook('connector_settings_post', 'addon/twitter/twitter.php', 'twitter_settings_post');
        Addon::registerHook('post_local', 'addon/twitter/twitter.php', 'twitter_post_local');
@@ -110,6 +112,7 @@ function twitter_install()
 
 function twitter_uninstall()
 {
+       Addon::unregisterHook('load_config', 'addon/twitter/twitter.php', 'twitter_load_config');
        Addon::unregisterHook('connector_settings', 'addon/twitter/twitter.php', 'twitter_settings');
        Addon::unregisterHook('connector_settings_post', 'addon/twitter/twitter.php', 'twitter_settings_post');
        Addon::unregisterHook('post_local', 'addon/twitter/twitter.php', 'twitter_post_local');
@@ -128,13 +131,18 @@ function twitter_uninstall()
        Addon::unregisterHook('addon_settings_post', 'addon/twitter/twitter.php', 'twitter_settings_post');
 }
 
+function twitter_load_config(App $a)
+{
+       $a->loadConfigFile(__DIR__. '/config/twitter.ini.php');
+}
+
 function twitter_check_item_notification(App $a, &$notification_data)
 {
        $own_id = PConfig::get($notification_data["uid"], 'twitter', 'own_id');
 
        $own_user = q("SELECT `url` FROM `contact` WHERE `uid` = %d AND `alias` = '%s' LIMIT 1",
                        intval($notification_data["uid"]),
-                       dbesc("twitter::".$own_id)
+                       DBA::escape("twitter::".$own_id)
        );
 
        if ($own_user) {
@@ -175,8 +183,8 @@ function twitter_follow(App $a, &$contact)
        $r = q("SELECT name,nick,url,addr,batch,notify,poll,request,confirm,poco,photo,priority,network,alias,pubkey
                FROM `contact` WHERE `uid` = %d AND `nick` = '%s'",
                                intval($uid),
-                               dbesc($nickname));
-       if (DBM::is_result($r)) {
+                               DBA::escape($nickname));
+       if (DBA::isResult($r)) {
                $contact["contact"] = $r[0];
        }
 }
@@ -422,6 +430,7 @@ function twitter_action(App $a, $uid, $pid, $action)
        switch ($action) {
                case "delete":
                        // To-Do: $result = $connection->post('statuses/destroy', $post);
+                       $result = [];
                        break;
                case "like":
                        $result = $connection->post('favorites/create', $post);
@@ -429,6 +438,9 @@ function twitter_action(App $a, $uid, $pid, $action)
                case "unlike":
                        $result = $connection->post('favorites/destroy', $post);
                        break;
+               default:
+                       logger('Unhandled action ' . $action, LOGGER_DEBUG);
+                       $result = [];
        }
        logger("twitter_action '" . $action . "' send, result: " . print_r($result, true), LOGGER_DEBUG);
 }
@@ -453,16 +465,13 @@ function twitter_post_hook(App $a, &$b)
                        return;
                }
 
-               $r = q("SELECT * FROM item WHERE item.uri = '%s' AND item.uid = %d LIMIT 1",
-                       dbesc($b["thr-parent"]),
-                       intval($b["uid"]));
-
-               if (!DBM::is_result($r)) {
+               $condition = ['uri' => $b["thr-parent"], 'uid' => $b["uid"]];
+               $orig_post = Item::selectFirst([], $condition);
+               if (!DBA::isResult($orig_post)) {
                        logger("twitter_post_hook: no parent found " . $b["thr-parent"]);
                        return;
                } else {
                        $iscomment = true;
-                       $orig_post = $r[0];
                }
 
 
@@ -485,7 +494,7 @@ function twitter_post_hook(App $a, &$b)
 
                // Dont't post if the post doesn't belong to us.
                // This is a check for forum postings
-               $self = dba::selectFirst('contact', ['id'], ['uid' => $b['uid'], 'self' => true]);
+               $self = DBA::selectFirst('contact', ['id'], ['uid' => $b['uid'], 'self' => true]);
                if ($b['contact-id'] != $self['id']) {
                        return;
                }
@@ -604,15 +613,15 @@ function twitter_post_hook(App $a, &$b)
                $result = $connection->post($url, $post);
                logger('twitter_post send, result: ' . print_r($result, true), LOGGER_DEBUG);
 
-               if ($result->source) {
+               if (!empty($result->source)) {
                        Config::set("twitter", "application_name", strip_tags($result->source));
                }
 
-               if ($result->errors) {
+               if (!empty($result->errors)) {
                        logger('Send to Twitter failed: "' . print_r($result->errors, true) . '"');
 
                        $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", intval($b['uid']));
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $a->contact = $r[0]["id"];
                        }
 
@@ -667,7 +676,7 @@ function twitter_cron(App $a, $b)
        logger('twitter: cron_start');
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'twitter' AND `k` = 'mirror_posts' AND `v` = '1'");
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                foreach ($r as $rr) {
                        logger('twitter: fetching for user ' . $rr['uid']);
                        Worker::add(PRIORITY_MEDIUM, "addon/twitter/twitter_sync.php", 1, (int) $rr['uid']);
@@ -682,11 +691,11 @@ function twitter_cron(App $a, $b)
        $abandon_limit = date(DateTimeFormat::MYSQL, time() - $abandon_days * 86400);
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'twitter' AND `k` = 'import' AND `v` = '1'");
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                foreach ($r as $rr) {
                        if ($abandon_days != 0) {
                                $user = q("SELECT `login_date` FROM `user` WHERE uid=%d AND `login_date` >= '%s'", $rr['uid'], $abandon_limit);
-                               if (!DBM::is_result($user)) {
+                               if (!DBA::isResult($user)) {
                                        logger('abandoned account: timeline from user ' . $rr['uid'] . ' will not be imported');
                                        continue;
                                }
@@ -724,22 +733,24 @@ function twitter_expire(App $a, $b)
                return;
        }
 
-       if (method_exists('dba', 'delete')) {
-               $r = dba::select('item', ['id'], ['deleted' => true, 'network' => NETWORK_TWITTER]);
-               while ($row = dba::fetch($r)) {
-                       dba::delete('item', ['id' => $row['id']]);
+       $r = DBA::select('item', ['id', 'iaid', 'icid'], ['deleted' => true, 'network' => NETWORK_TWITTER]);
+       while ($row = DBA::fetch($r)) {
+               DBA::delete('item', ['id' => $row['id']]);
+               if (!empty($row['iaid']) && !DBA::exists('item', ['iaid' => $row['iaid']])) {
+                       DBA::delete('item-activity', ['id' => $row['iaid']]);
+               }
+               if (!empty($row['icid']) && !DBA::exists('item', ['icid' => $row['icid']])) {
+                       DBA::delete('item-content', ['id' => $row['icid']]);
                }
-               dba::close($r);
-       } else {
-               $r = q("DELETE FROM `item` WHERE `deleted` AND `network` = '%s'", dbesc(NETWORK_TWITTER));
        }
+       DBA::close($r);
 
        require_once "include/items.php";
 
        logger('twitter_expire: expire_start');
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'twitter' AND `k` = 'import' AND `v` = '1' ORDER BY RAND()");
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                foreach ($r as $rr) {
                        logger('twitter_expire: user ' . $rr['uid']);
                        Item::expire($rr['uid'], $days, NETWORK_TWITTER, true);
@@ -760,13 +771,9 @@ function twitter_prepare_body(App $a, &$b)
                $item = $b["item"];
                $item["plink"] = $a->get_baseurl() . "/display/" . $a->user["nickname"] . "/" . $item["parent"];
 
-               $r = q("SELECT `author-link` FROM item WHERE item.uri = '%s' AND item.uid = %d LIMIT 1",
-                       dbesc($item["thr-parent"]),
-                       intval(local_user()));
-
-               if (DBM::is_result($r)) {
-                       $orig_post = $r[0];
-
+               $condition = ['uri' => $item["thr-parent"], 'uid' => local_user()];
+               $orig_post = Item::selectFirst(['author-link'], $condition);
+               if (DBA::isResult($orig_post)) {
                        $nicknameplain = preg_replace("=https?://twitter.com/(.*)=ism", "$1", $orig_post["author-link"]);
                        $nickname = "@[url=" . $orig_post["author-link"] . "]" . $nicknameplain . "[/url]";
                        $nicknameplain = "@" . $nicknameplain;
@@ -802,15 +809,14 @@ function twitter_prepare_body(App $a, &$b)
  */
 function twitter_do_mirrorpost(App $a, $uid, $post)
 {
-       $datarray["type"] = "wall";
        $datarray["api_source"] = true;
        $datarray["profile_uid"] = $uid;
        $datarray["extid"] = NETWORK_TWITTER;
-       $datarray['message_id'] = item_new_uri($a->get_hostname(), $uid, NETWORK_TWITTER . ":" . $post->id);
-       $datarray['object'] = json_encode($post);
+       $datarray['message_id'] = Item::newURI($uid, NETWORK_TWITTER . ":" . $post->id);
+       // $datarray['object'] = json_encode($post); // Activate for debugging
        $datarray["title"] = "";
 
-       if (is_object($post->retweeted_status)) {
+       if (!empty($post->retweeted_status)) {
                // We don't support nested shares, so we mustn't show quotes as shares on retweets
                $item = twitter_createpost($a, $uid, $post->retweeted_status, ['id' => 0], false, false, true);
 
@@ -916,9 +922,9 @@ function twitter_fetchtimeline(App $a, $uid)
 function twitter_queue_hook(App $a, &$b)
 {
        $qi = q("SELECT * FROM `queue` WHERE `network` = '%s'",
-               dbesc(NETWORK_TWITTER)
+               DBA::escape(NETWORK_TWITTER)
        );
-       if (!DBM::is_result($qi)) {
+       if (!DBA::isResult($qi)) {
                return;
        }
 
@@ -933,7 +939,7 @@ function twitter_queue_hook(App $a, &$b)
                        WHERE `contact`.`self` = 1 AND `contact`.`id` = %d LIMIT 1",
                        intval($x['cid'])
                );
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        continue;
                }
 
@@ -1007,34 +1013,34 @@ function twitter_fetch_contact($uid, $data, $create_user)
 
        $cid = Contact::getIdForURL($url, 0, true, $fields);
        if (!empty($cid)) {
-               dba::update('contact', $fields, ['id' => $cid]);
+               DBA::update('contact', $fields, ['id' => $cid]);
                Contact::updateAvatar($avatar, 0, $cid);
        }
 
-       $contact = dba::selectFirst('contact', [], ['uid' => $uid, 'alias' => "twitter::" . $data->id_str]);
-       if (!DBM::is_result($contact) && !$create_user) {
+       $contact = DBA::selectFirst('contact', [], ['uid' => $uid, 'alias' => "twitter::" . $data->id_str]);
+       if (!DBA::isResult($contact) && !$create_user) {
                return 0;
        }
 
-       if (!DBM::is_result($contact)) {
+       if (!DBA::isResult($contact)) {
                // create contact record
                $fields['uid'] = $uid;
                $fields['created'] = DateTimeFormat::utcNow();
                $fields['nurl'] = normalise_link($url);
                $fields['alias'] = 'twitter::' . $data->id_str;
                $fields['poll'] = 'twitter::' . $data->id_str;
-               $fields['rel'] = CONTACT_IS_FRIEND;
+               $fields['rel'] = Contact::FRIEND;
                $fields['priority'] = 1;
                $fields['writable'] = true;
                $fields['blocked'] = false;
                $fields['readonly'] = false;
                $fields['pending'] = false;
 
-               if (!dba::insert('contact', $fields)) {
+               if (!DBA::insert('contact', $fields)) {
                        return false;
                }
 
-               $contact_id = dba::lastInsertId();
+               $contact_id = DBA::lastInsertId();
 
                Group::addMember(User::getDefaultGroup($uid), $contact_id);
 
@@ -1059,7 +1065,7 @@ function twitter_fetch_contact($uid, $data, $create_user)
                        $fields['name-date'] = DateTimeFormat::utcNow();
                        $fields['uri-date'] = DateTimeFormat::utcNow();
 
-                       dba::update('contact', $fields, ['id' => $contact['id']]);
+                       DBA::update('contact', $fields, ['id' => $contact['id']]);
                }
        }
 
@@ -1076,7 +1082,7 @@ function twitter_fetchuser(App $a, $uid, $screen_name = "", $user_id = "")
        $r = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
                intval($uid));
 
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                $self = $r[0];
        } else {
                return;
@@ -1142,6 +1148,10 @@ function twitter_expand_entities(App $a, $body, $item, $picture)
 
                                $oembed_data = OEmbed::fetchURL($expanded_url);
 
+                               if (empty($oembed_data) || empty($oembed_data->type)) {
+                                       continue;
+                               }
+
                                // Quickfix: Workaround for URL with "[" and "]" in it
                                if (strpos($expanded_url, "[") || strpos($expanded_url, "]")) {
                                        $expanded_url = $url->url;
@@ -1265,7 +1275,7 @@ function twitter_expand_entities(App $a, $body, $item, $picture)
 function twitter_media_entities($post, &$postarray)
 {
        // There are no media entities? So we quit.
-       if (!is_array($post->extended_entities->media)) {
+       if (empty($post->extended_entities->media)) {
                return "";
        }
 
@@ -1285,6 +1295,9 @@ function twitter_media_entities($post, &$postarray)
        // This is a pure media post, first search for all media urls
        $media = [];
        foreach ($post->extended_entities->media AS $medium) {
+               if (!isset($media[$medium->url])) {
+                       $media[$medium->url] = '';
+               }
                switch ($medium->type) {
                        case 'photo':
                                $media[$medium->url] .= "\n[img]" . $medium->media_url_https . "[/img]";
@@ -1322,19 +1335,13 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
 {
        $postarray = [];
        $postarray['network'] = NETWORK_TWITTER;
-       $postarray['gravity'] = 0;
        $postarray['uid'] = $uid;
        $postarray['wall'] = 0;
        $postarray['uri'] = "twitter::" . $post->id_str;
-       $postarray['object'] = json_encode($post);
+       // $postarray['object'] = json_encode($post); // Activate for debugging
 
        // Don't import our own comments
-       $r = q("SELECT * FROM `item` WHERE `extid` = '%s' AND `uid` = %d LIMIT 1",
-               dbesc($postarray['uri']),
-               intval($uid)
-       );
-
-       if (DBM::is_result($r)) {
+       if (DBA::exists('item', ['extid' => $postarray['uri'], 'uid' => $uid])) {
                logger("Item with extid " . $postarray['uri'] . " found.", LOGGER_DEBUG);
                return [];
        }
@@ -1344,30 +1351,21 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
        if ($post->in_reply_to_status_id_str != "") {
                $parent = "twitter::" . $post->in_reply_to_status_id_str;
 
-               $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                       dbesc($parent),
-                       intval($uid)
-               );
-               if (DBM::is_result($r)) {
-                       $postarray['thr-parent'] = $r[0]["uri"];
-                       $postarray['parent-uri'] = $r[0]["parent-uri"];
-                       $postarray['parent'] = $r[0]["parent"];
+               $fields = ['uri', 'parent-uri', 'parent'];
+               $parent_item = Item::selectFirst($fields, ['uri' => $parent, 'uid' => $uid]);
+               if (!DBA::isResult($parent_item)) {
+                       $parent_item = Item::selectFirst($fields, ['extid' => $parent, 'uid' => $uid]);
+               }
+
+               if (DBA::isResult($parent_item)) {
+                       $postarray['thr-parent'] = $parent_item['uri'];
+                       $postarray['parent-uri'] = $parent_item['parent-uri'];
+                       $postarray['parent'] = $parent_item['parent'];
                        $postarray['object-type'] = ACTIVITY_OBJ_COMMENT;
                } else {
-                       $r = q("SELECT * FROM `item` WHERE `extid` = '%s' AND `uid` = %d LIMIT 1",
-                               dbesc($parent),
-                               intval($uid)
-                       );
-                       if (DBM::is_result($r)) {
-                               $postarray['thr-parent'] = $r[0]['uri'];
-                               $postarray['parent-uri'] = $r[0]['parent-uri'];
-                               $postarray['parent'] = $r[0]['parent'];
-                               $postarray['object-type'] = ACTIVITY_OBJ_COMMENT;
-                       } else {
-                               $postarray['thr-parent'] = $postarray['uri'];
-                               $postarray['parent-uri'] = $postarray['uri'];
-                               $postarray['object-type'] = ACTIVITY_OBJ_NOTE;
-                       }
+                       $postarray['thr-parent'] = $postarray['uri'];
+                       $postarray['parent-uri'] = $postarray['uri'];
+                       $postarray['object-type'] = ACTIVITY_OBJ_NOTE;
                }
 
                // Is it me?
@@ -1377,7 +1375,7 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
                        $r = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
                                intval($uid));
 
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $contactid = $r[0]["id"];
 
                                $postarray['owner-name']   = $r[0]["name"];
@@ -1422,6 +1420,9 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
        if ($post->user->protected) {
                $postarray['private'] = 1;
                $postarray['allow_cid'] = '<' . $self['id'] . '>';
+       } else {
+               $postarray['private'] = 0;
+               $postarray['allow_cid'] = '';
        }
 
        if (is_string($post->full_text)) {
@@ -1446,22 +1447,22 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
 
        $statustext = $converted["plain"];
 
-       if (is_string($post->place->name)) {
+       if (!empty($post->place->name)) {
                $postarray["location"] = $post->place->name;
        }
-       if (is_string($post->place->full_name)) {
+       if (!empty($post->place->full_name)) {
                $postarray["location"] = $post->place->full_name;
        }
-       if (is_array($post->geo->coordinates)) {
+       if (!empty($post->geo->coordinates)) {
                $postarray["coord"] = $post->geo->coordinates[0] . " " . $post->geo->coordinates[1];
        }
-       if (is_array($post->coordinates->coordinates)) {
+       if (!empty($post->coordinates->coordinates)) {
                $postarray["coord"] = $post->coordinates->coordinates[1] . " " . $post->coordinates->coordinates[0];
        }
-       if (is_object($post->retweeted_status)) {
+       if (!empty($post->retweeted_status)) {
                $retweet = twitter_createpost($a, $uid, $post->retweeted_status, $self, false, false, $noquote);
 
-               $retweet['object'] = $postarray['object'];
+               //$retweet['object'] = $postarray['object']; // Activate for debugging
                $retweet['private'] = $postarray['private'];
                $retweet['allow_cid'] = $postarray['allow_cid'];
                $retweet['contact-id'] = $postarray['contact-id'];
@@ -1472,7 +1473,7 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
                $postarray = $retweet;
        }
 
-       if (is_object($post->quoted_status) && !$noquote) {
+       if (!empty($post->quoted_status) && !$noquote) {
                $quoted = twitter_createpost($a, $uid, $post->quoted_status, $self, false, false, true);
 
                $postarray['body'] = $statustext;
@@ -1492,75 +1493,6 @@ function twitter_createpost(App $a, $uid, $post, $self, $create_user, $only_exis
        return $postarray;
 }
 
-function twitter_checknotification(App $a, $uid, $own_id, $top_item, $postarray)
-{
-       /// TODO: this whole function doesn't seem to work. Needs complete check
-       $user = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1",
-               intval($uid)
-       );
-
-       if (!DBM::is_result($user)) {
-               return;
-       }
-
-       // Is it me?
-       if (link_compare($user[0]["url"], $postarray['author-link'])) {
-               return;
-       }
-
-       $own_user = q("SELECT * FROM `contact` WHERE `uid` = %d AND `alias` = '%s' LIMIT 1",
-               intval($uid),
-               dbesc("twitter::".$own_id)
-       );
-
-       if (!DBM::is_result($own_user)) {
-               return;
-       }
-
-       // Is it me from twitter?
-       if (link_compare($own_user[0]["url"], $postarray['author-link'])) {
-               return;
-       }
-
-       $myconv = q("SELECT `author-link`, `author-avatar`, `parent` FROM `item` WHERE `parent-uri` = '%s' AND `uid` = %d AND `parent` != 0 AND `deleted` = 0",
-               dbesc($postarray['parent-uri']),
-               intval($uid)
-       );
-
-       if (DBM::is_result($myconv)) {
-               foreach ($myconv as $conv) {
-                       // now if we find a match, it means we're in this conversation
-                       if (!link_compare($conv['author-link'], $user[0]["url"]) && !link_compare($conv['author-link'], $own_user[0]["url"])) {
-                               continue;
-                       }
-
-                       require_once 'include/enotify.php';
-
-                       $conv_parent = $conv['parent'];
-
-                       notification([
-                               'type' => NOTIFY_COMMENT,
-                               'notify_flags' => $user[0]['notify-flags'],
-                               'language' => $user[0]['language'],
-                               'to_name' => $user[0]['username'],
-                               'to_email' => $user[0]['email'],
-                               'uid' => $user[0]['uid'],
-                               'item' => $postarray,
-                               'link' => $a->get_baseurl() . '/display/' . urlencode(Item::getGuidById($top_item)),
-                               'source_name' => $postarray['author-name'],
-                               'source_link' => $postarray['author-link'],
-                               'source_photo' => $postarray['author-avatar'],
-                               'verb' => ACTIVITY_POST,
-                               'otype' => 'item',
-                               'parent' => $conv_parent,
-                       ]);
-
-                       // only send one notification
-                       break;
-               }
-       }
-}
-
 function twitter_fetchparentposts(App $a, $uid, $post, TwitterOAuth $connection, $self, $own_id)
 {
        logger("twitter_fetchparentposts: Fetching for user " . $uid . " and post " . $post->id_str, LOGGER_DEBUG);
@@ -1582,12 +1514,7 @@ function twitter_fetchparentposts(App $a, $uid, $post, TwitterOAuth $connection,
                        break;
                }
 
-               $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                       dbesc("twitter::".$post->id_str),
-                       intval($uid)
-               );
-
-               if (DBM::is_result($r)) {
+               if (DBA::exists('item', ['uri' => 'twitter::' . $post->id_str, 'uid' => $uid])) {
                        break;
                }
 
@@ -1598,27 +1525,19 @@ function twitter_fetchparentposts(App $a, $uid, $post, TwitterOAuth $connection,
 
        $posts = array_reverse($posts);
 
-       if (count($posts)) {
+       if (!empty($posts)) {
                foreach ($posts as $post) {
                        $postarray = twitter_createpost($a, $uid, $post, $self, false, false, false);
 
-                       if (trim($postarray['body']) == "") {
+                       if (empty($postarray['body'])) {
                                continue;
                        }
 
                        $item = Item::insert($postarray);
 
-                       if ($notify) {
-                               $item = $notify;
-                       }
-
                        $postarray["id"] = $item;
 
                        logger('twitter_fetchparentpost: User ' . $self["nick"] . ' posted parent timeline item ' . $item);
-
-                       if ($item && !function_exists("check_item_notification")) {
-                               twitter_checknotification($a, $uid, $own_id, $item, $postarray);
-                       }
                }
        }
 }
@@ -1655,7 +1574,7 @@ function twitter_fetchhometimeline(App $a, $uid)
                intval($own_contact),
                intval($uid));
 
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                $own_id = $r[0]["nick"];
        } else {
                logger("twitter_fetchhometimeline: Own twitter contact not found for user " . $uid, LOGGER_DEBUG);
@@ -1665,7 +1584,7 @@ function twitter_fetchhometimeline(App $a, $uid)
        $r = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
                intval($uid));
 
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                $self = $r[0];
        } else {
                logger("twitter_fetchhometimeline: Own contact not found for user " . $uid, LOGGER_DEBUG);
@@ -1674,7 +1593,7 @@ function twitter_fetchhometimeline(App $a, $uid)
 
        $u = q("SELECT * FROM user WHERE uid = %d LIMIT 1",
                intval($uid));
-       if (!DBM::is_result($u)) {
+       if (!DBA::isResult($u)) {
                logger("twitter_fetchhometimeline: Own user not found for user " . $uid, LOGGER_DEBUG);
                return;
        }
@@ -1733,15 +1652,15 @@ function twitter_fetchhometimeline(App $a, $uid)
 
                        $postarray = twitter_createpost($a, $uid, $post, $self, $create_user, true, false);
 
-                       if (trim($postarray['body']) == "") {
+                       if (empty($postarray['body']) || trim($postarray['body']) == "") {
                                continue;
                        }
 
                        $notify = false;
 
                        if ($postarray['uri'] == $postarray['parent-uri']) {
-                               $contact = dba::selectFirst('contact', [], ['id' => $postarray['contact-id'], 'self' => false]);
-                               if (DBM::is_result($contact)) {
+                               $contact = DBA::selectFirst('contact', [], ['id' => $postarray['contact-id'], 'self' => false]);
+                               if (DBA::isResult($contact)) {
                                        $notify = Item::isRemoteSelf($contact, $postarray);
                                }
                        }
@@ -1750,10 +1669,6 @@ function twitter_fetchhometimeline(App $a, $uid)
                        $postarray["id"] = $item;
 
                        logger('twitter_fetchhometimeline: User ' . $self["nick"] . ' posted home timeline item ' . $item);
-
-                       if ($item && !function_exists("check_item_notification")) {
-                               twitter_checknotification($a, $uid, $own_id, $item, $postarray);
-                       }
                }
        }
        PConfig::set($uid, 'twitter', 'lasthometimelineid', $lastid);
@@ -1804,50 +1719,8 @@ function twitter_fetchhometimeline(App $a, $uid)
                        }
 
                        $item = Item::insert($postarray);
-                       $postarray["id"] = $item;
-
-                       if ($item && function_exists("check_item_notification")) {
-                               check_item_notification($item, $uid, NOTIFY_TAGSELF);
-                       }
-
-                       if (!isset($postarray["parent"]) || ($postarray["parent"] == 0)) {
-                               $postarray["parent"] = $item;
-                       }
 
                        logger('twitter_fetchhometimeline: User ' . $self["nick"] . ' posted mention timeline item ' . $item);
-
-                       if ($item == 0) {
-                               $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                                       dbesc($postarray['uri']),
-                                       intval($uid)
-                               );
-                               if (DBM::is_result($r)) {
-                                       $item = $r[0]['id'];
-                                       $parent_id = $r[0]['parent'];
-                               }
-                       } else {
-                               $parent_id = $postarray['parent'];
-                       }
-
-                       if (($item != 0) && !function_exists("check_item_notification")) {
-                               require_once 'include/enotify.php';
-                               notification([
-                                       'type'         => NOTIFY_TAGSELF,
-                                       'notify_flags' => $u[0]['notify-flags'],
-                                       'language'     => $u[0]['language'],
-                                       'to_name'      => $u[0]['username'],
-                                       'to_email'     => $u[0]['email'],
-                                       'uid'          => $u[0]['uid'],
-                                       'item'         => $postarray,
-                                       'link'         => $a->get_baseurl() . '/display/' . urlencode(Item::getGuidById($item)),
-                                       'source_name'  => $postarray['author-name'],
-                                       'source_link'  => $postarray['author-link'],
-                                       'source_photo' => $postarray['author-avatar'],
-                                       'verb'         => ACTIVITY_TAG,
-                                       'otype'        => 'item',
-                                       'parent'       => $parent_id
-                               ]);
-                       }
                }
        }
 
@@ -1878,8 +1751,8 @@ function twitter_fetch_own_contact(App $a, $uid)
        } else {
                $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `alias` = '%s' LIMIT 1",
                        intval($uid),
-                       dbesc("twitter::" . $own_id));
-               if (DBM::is_result($r)) {
+                       DBA::escape("twitter::" . $own_id));
+               if (DBA::isResult($r)) {
                        $contact_id = $r[0]["id"];
                } else {
                        PConfig::delete($uid, 'twitter', 'own_id');
@@ -1912,12 +1785,12 @@ function twitter_is_retweet(App $a, $uid, $body)
 
        $link = "";
        preg_match("/link='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $link = $matches[1];
        }
 
        preg_match('/link="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $link = $matches[1];
        }