X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=actions%2Fapioauthaccesstoken.php;h=76b06c28a22cc7cb8e9a124127f3ec474a0a6917;hb=32f47004df3bc795a3cbdc380ceaaf9159436a36;hp=6b36d1919e030c136cb7379a4c4d8ee9bc6d338f;hpb=d358c88f94a0acff779eb59fc35acbd81787008c;p=quix0rs-gnu-social.git diff --git a/actions/apioauthaccesstoken.php b/actions/apioauthaccesstoken.php index 6b36d1919e..76b06c28a2 100644 --- a/actions/apioauthaccesstoken.php +++ b/actions/apioauthaccesstoken.php @@ -44,7 +44,6 @@ require_once INSTALLDIR . '/lib/apioauth.php'; * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @link http://status.net/ */ - class ApiOauthAccessTokenAction extends ApiOauthAction { protected $reqToken = null; @@ -73,23 +72,22 @@ class ApiOauthAccessTokenAction extends ApiOauthAction // Spec doesn't say they MUST be. try { - $req = OAuthRequest::from_request(); $this->reqToken = $req->get_parameter('oauth_token'); $this->verifier = $req->get_parameter('oauth_verifier'); - $app = $datastore->getAppByRequestToken($this->reqToken); - $atok = $server->fetch_access_token($req); - } catch (OAuthException $e) { + $app = $datastore->getAppByRequestToken($this->reqToken); + $atok = $server->fetch_access_token($req); + } catch (Exception $e) { common_log(LOG_WARNING, 'API OAuthException - ' . $e->getMessage()); common_debug(var_export($req, true)); $code = $e->getCode(); $this->clientError($e->getMessage(), empty($code) ? 401 : $code, 'text'); + return; } if (empty($atok)) { - // Token exchange failed -- log it $msg = sprintf( @@ -99,14 +97,14 @@ class ApiOauthAccessTokenAction extends ApiOauthAction $this->verifier ); - common_log(LOG_WARNIGN, $msg); - $this->clientError(_("Invalid request token or verifier.", 400, 'text')); - + common_log(LOG_WARNING, $msg); + // TRANS: Client error given from the OAuth API when the request token or verifier is invalid. + $this->clientError(_('Invalid request token or verifier.'), 400, 'text'); } else { common_log( LOG_INFO, sprintf( - "Issued now access token '%s' for application %d (%s).", + "Issued access token '%s' for application %d (%s).", $atok->key, $app->id, $app->name @@ -121,7 +119,6 @@ class ApiOauthAccessTokenAction extends ApiOauthAction * * @param OAuthToken token the access token */ - function showAccessToken($token) { header('Content-Type: application/x-www-form-urlencoded');