X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=actions%2Ftwitapifriendships.php;h=03dd8f06358f5c0bf95659591b14d6667ff69cc2;hb=f2e3021b59f3661b3c900b06600a580b8970df2f;hp=d97b7c08eab7048aab5e61ec17b21e513003c64d;hpb=924491f08a24201c7bda45b4d4be16ccebba97c0;p=quix0rs-gnu-social.git diff --git a/actions/twitapifriendships.php b/actions/twitapifriendships.php index d97b7c08ea..03dd8f0635 100644 --- a/actions/twitapifriendships.php +++ b/actions/twitapifriendships.php @@ -42,7 +42,7 @@ class TwitapifriendshipsAction extends TwitterapiAction { if ($_SERVER['REQUEST_METHOD'] != 'POST') { $this->client_error(_('This method requires a POST.'), 400, $apidata['content-type']); - exit(); + return; } $id = $apidata['api_arg']; @@ -51,7 +51,7 @@ class TwitapifriendshipsAction extends TwitterapiAction { if (!$other) { $this->client_error(_('Could not follow user: User not found.'), 403, $apidata['content-type']); - exit(); + return; } $user = $apidata['user']; @@ -59,7 +59,7 @@ class TwitapifriendshipsAction extends TwitterapiAction { if ($user->isSubscribed($other)) { $errmsg = sprintf(_('Could not follow user: %s is already on your list.'), $other->nickname); $this->client_error($errmsg, 403, $apidata['content-type']); - exit(); + return; } $sub = new Subscription(); @@ -75,7 +75,7 @@ class TwitapifriendshipsAction extends TwitterapiAction { if (!$result) { $errmsg = sprintf(_('Could not follow user: %s is already on your list.'), $other->nickname); $this->client_error($errmsg, 400, $apidata['content-type']); - exit(); + return; } $sub->query('COMMIT'); @@ -86,27 +86,15 @@ class TwitapifriendshipsAction extends TwitterapiAction { $this->init_document($type); $this->show_profile($other, $type); $this->end_document($type); - exit(); - } - //destroy - // - //Discontinues friendship with the user specified in the ID parameter as the authenticating user. Returns the un-friended user in the requested format when successful. Returns a string describing the failure condition when unsuccessful. - // - //URL: http://twitter.com/friendships/destroy/id.format - // - //Formats: xml, json - // - //Parameters: - // - //* id. Required. The ID or screen name of the user with whom to discontinue friendship. Ex: http://twitter.com/friendships/destroy/12345.json or http://twitter.com/friendships/destroy/bob.xml + } function destroy($args, $apidata) { parent::handle($args); if (!in_array($_SERVER['REQUEST_METHOD'], array('POST', 'DELETE'))) { $this->client_error(_('This method requires a POST or DELETE.'), 400, $apidata['content-type']); - exit(); + return; } $id = $apidata['api_arg']; @@ -126,32 +114,24 @@ class TwitapifriendshipsAction extends TwitterapiAction { $sub->query('COMMIT'); } else { $this->client_error(_('You are not friends with the specified user.'), 403, $apidata['content-type']); - exit(); + return; } $type = $apidata['content-type']; $this->init_document($type); $this->show_profile($other, $type); $this->end_document($type); - exit(); - } - // Tests if a friendship exists between two users. - // - // - // URL: http://twitter.com/friendships/exists.format - // - // Formats: xml, json, none - // - // Parameters: - // - // * user_a. Required. The ID or screen_name of the first user to test friendship for. - // * user_b. Required. The ID or screen_name of the second user to test friendship for. - // * Ex: http://twitter.com/friendships/exists.xml?user_a=alice&user_b=bob + } function exists($args, $apidata) { parent::handle($args); + if (!in_array($apidata['content-type'], array('xml', 'json'))) { + common_user_error(_('API method not found!'), $code = 404); + return; + } + $user_a_id = $this->trimmed('user_a'); $user_b_id = $this->trimmed('user_b'); @@ -160,7 +140,7 @@ class TwitapifriendshipsAction extends TwitterapiAction { if (!$user_a || !$user_b) { $this->client_error(_('Two user ids or screen_names must be supplied.'), 400, $apidata['content-type']); - exit(); + return; } if ($user_a->isSubscribed($user_b)) { @@ -181,11 +161,9 @@ class TwitapifriendshipsAction extends TwitterapiAction { $this->end_document('json'); break; default: - print $result; // Really? --Zach break; } - exit(); } } \ No newline at end of file