X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=inc%2Fclasses%2Fmain%2Fcontroller%2Fclass_BaseController.php;h=825727dd5f101a487b266fec9f962144be0d4a74;hb=84e2207412d3c6ea9f940a83b2cdd4503509808a;hp=9fd257c234fa4b908fb15c23e918c486759ead41;hpb=46f92fe63badaf1a2f2cddfaf9d3959f7787bbf2;p=core.git diff --git a/inc/classes/main/controller/class_BaseController.php b/inc/classes/main/controller/class_BaseController.php index 9fd257c2..825727dd 100644 --- a/inc/classes/main/controller/class_BaseController.php +++ b/inc/classes/main/controller/class_BaseController.php @@ -6,7 +6,7 @@ * * @author Roland Haeder * @version 0.0.0 - * @copyright Copyright (c) 2007, 2008 Roland Haeder, 2009 Core Developer Team + * @copyright Copyright (c) 2007, 2008 Roland Haeder, 2009, 2010 Core Developer Team * @license GNU GPL 3.0 or any newer version * @link http://www.ship-simu.org * @@ -29,6 +29,9 @@ class BaseController extends BaseFrameworkSystem implements Registerable { */ private $filterChains = array(); + // Exception constants + const EXCEPTION_FILTER_CHAIN_INVALID = 0xf10; + /** * Protected constructor * @@ -39,10 +42,6 @@ class BaseController extends BaseFrameworkSystem implements Registerable { // Call parent constructor parent::__construct($className); - // Clean up a little - $this->removeNumberFormaters(); - $this->removeSystemArray(); - // Initialize both filter chains $this->initFilterChain('pre'); $this->initFilterChain('post'); @@ -57,19 +56,32 @@ class BaseController extends BaseFrameworkSystem implements Registerable { * @param $filterChain Name of the filter chain * @return void */ - private function initFilterChain ($filterChain) { + protected function initFilterChain ($filterChain) { + //* DEBUG: */ $this->debugOutput('CONTROLLER: ' . $filterChain . ' init: START'); $this->filterChains[$filterChain] = ObjectFactory::createObjectByConfiguredName('filter_chain_class'); + //* DEBUG: */ $this->debugOutput('CONTROLLER: ' . $filterChain . ' init: FINISHED'); } /** - * Adds a filter to a given filter group + * Adds a filter to a given filter chain * - * @param $filterGroup Group of the filter + * @param $filterChain Chain of the filter * @param $filterInstance An instance of a filter * @return void + * @throws InvalidFilterChainException If the filter chain is invalid */ - protected function add addFilter ($filterGroup, Filterable $filterInstance) { - $this->filterChains[$filterGroup]->addFilter($filterInstance); + protected function addFilter ($filterChain, Filterable $filterInstance) { + //* DEBUG: */ $this->debugOutput('CONTROLLER: ' . $filterChain . ',' . $filterInstance->__toString(). ' add: START'); + + // Test if the filter is there + if (!isset($this->filterChains[$filterChain])) { + // Throw an exception here + throw new InvalidFilterChainException(array($this, $filterChain), self::EXCEPTION_FILTER_CHAIN_INVALID); + } // END - if + + // Add the filter + $this->filterChains[$filterChain]->addFilter($filterInstance); + //* DEBUG: */ $this->debugOutput('CONTROLLER: ' . $filterChain . ',' . $filterInstance->__toString(). ' add: FINISH'); } /** @@ -95,15 +107,23 @@ class BaseController extends BaseFrameworkSystem implements Registerable { } /** - * Executes given filter chain group + * Executes given filter chain chain * - * @param $filterGroup Group of the filter to execute + * @param $filterChain Chain of the filter to execute * @param $requestInstance An instance of a request class * @param $responseInstance An instance of a response class * @return void + * @throws InvalidFilterChainException If the filter chain is invalid */ - protected function executeFilters ($filterGroup, Requestable $requestInstance, Responseable $responseInstance) { - $this->filterChains[$filterGroup]->processFilters($requestInstance, $responseInstance); + protected function executeFilters ($filterChain, Requestable $requestInstance, Responseable $responseInstance) { + // Test if the filter is there + if (!isset($this->filterChains[$filterChain])) { + // Throw an exception here + throw new InvalidFilterChainException(array($this, $filterChain), self::EXCEPTION_FILTER_CHAIN_INVALID); + } // END - if + + // Run all filters + $this->filterChains[$filterChain]->processFilters($requestInstance, $responseInstance); } /**