X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=inc%2Ffunctions.php;h=459c6962d510c5a59e978d2bebebc04823a1be77;hb=8383fc52cd2340ea1756f9e1808fa3589e27c341;hp=4fcb932fcecd2503c4887d5662c04552cb99e05b;hpb=60494e212a67fe360bfbb481eb4928480a6f379b;p=mailer.git diff --git a/inc/functions.php b/inc/functions.php index 4fcb932fce..459c6962d5 100644 --- a/inc/functions.php +++ b/inc/functions.php @@ -71,18 +71,15 @@ function OPEN_TABLE($PERCENT = "", $CLASS = "", $ALIGN="left", $VALIGN="", $td_o // Vertical align is given if (!empty($VALIGN)) $OUT .= " valign=\"".$VALIGN."\""; - $OUT .= "> - - "; - OUTPUT_HTML($OUT); + OUTPUT_HTML($OUT); } // Close a table (you may want to add some footer stuff here) function CLOSE_TABLE($ADD="") { - OUTPUT_HTML(" -"); + OUTPUT_HTML(" \n"); if (!empty($ADD)) OUTPUT_HTML($ADD); OUTPUT_HTML(""); } @@ -140,9 +137,9 @@ function OUTPUT_HTML($HTML, $NEW_LINE = true) { } // Compile and run finished rendered HTML code - while (strpos($OUTPUT, "{!") > 0) { + while (strpos($OUTPUT, '{!') > 0) { $eval = "\$OUTPUT = \"" . COMPILE_CODE(addslashes($OUTPUT)) . "\";"; - @eval($eval); + eval($eval); } // Output code here, DO NOT REMOVE! ;-) @@ -154,9 +151,9 @@ function OUTPUT_HTML($HTML, $NEW_LINE = true) { } // Compile and run finished rendered HTML code - while (strpos($OUTPUT, "{!") > 0) { + while (strpos($OUTPUT, '{!') > 0) { $eval = "\$OUTPUT = \"" . COMPILE_CODE(addslashes($OUTPUT)) . "\";"; - @eval($eval); + eval($eval); } // Output code here, DO NOT REMOVE! ;-) @@ -166,7 +163,7 @@ function OUTPUT_HTML($HTML, $NEW_LINE = true) { // Output the raw HTML code function OUTPUT_RAW ($HTML) { - if ((mxchange_installed) && (basename($_SERVER['PHP_SELF']) != "install.php")) { + if ((isBooleanConstantAndTrue('mxchange_installed')) && (basename($_SERVER['PHP_SELF']) != "install.php")) { // Not in install-mode so strip slashes away echo stripslashes($HTML); } else { @@ -179,8 +176,7 @@ function OUTPUT_RAW ($HTML) { } // Add a fatal error message to the queue array -function ADD_FATAL ($message, $extra="") -{ +function ADD_FATAL ($message, $extra="") { global $FATAL; if (empty($extra)) { // Regular text message to add to $FATAL @@ -273,23 +269,23 @@ function LOAD_TEMPLATE($template, $return=false, $content="") { } // Does the special template exists? - if (!file_exists($file)) { + if ((!file_exists($file)) || (!is_readable($file))) { // Reset to default template $file = $BASE.$template.".tpl"; } // Now does the final template exists? - if (file_exists($file)) { + if ((file_exists($file)) && (is_readable($file))) { // The local file does exists so we load it. :) $tmpl_file = implode("", file($file)); // Replace ' to our own chars to preventing them being quoted - while (strpos($tmpl_file, "\'") !== false) { $tmpl_file = str_replace("\'", "{QUOT}", $tmpl_file); } + while (strpos($tmpl_file, "\'") !== false) { $tmpl_file = str_replace("\'", '{QUOT}', $tmpl_file); } // Do we have to compile the code? if ((strpos($tmpl_file, "\$") !== false) || (strpos($tmpl_file, '{--') !== false) || (strpos($tmpl_file, '--}') > 0)) { // Okay, compile it! - $tmpl_file = "\$ret=\"".COMPILE_CODE(addslashes($tmpl_file))."\";"; + $tmpl_file = "\$ret=\"" . COMPILE_CODE(addslashes($tmpl_file)) . "\";"; eval($tmpl_file); } else { // Simply return loaded code @@ -298,7 +294,7 @@ function LOAD_TEMPLATE($template, $return=false, $content="") { // Add surrounding HTML comments to help finding bugs faster $ret = "\n".$ret."\n"; - } elseif ((IS_ADMIN()) || ((mxchange_installing) && (!mxchange_installed))) { + } elseif ((IS_ADMIN()) || ((isBooleanConstantAndTrue('mxchange_installing')) && (!isBooleanConstantAndTrue('mxchange_installed')))) { // Only admins shall see this warning or when installation mode is active $ret = "
".TEMPLATE_404."
(".basename($file).")
@@ -320,7 +316,7 @@ function LOAD_TEMPLATE($template, $return=false, $content="") { // Output direct OUTPUT_HTML($ret); } - } elseif (DEBUG_MODE) { + } elseif (isBooleanConstantAndTrue('DEBUG_MODE')) { // Warning, empty output! return "E:".$template."
\n"; } @@ -329,7 +325,7 @@ function LOAD_TEMPLATE($template, $return=false, $content="") { // Send mail out to an email address function SEND_EMAIL($TO, $SUBJECT, $MSG, $HTML='N', $FROM="") { // Compile subject line (for POINTS constant etc.) - $eval = "\$SUBJECT = \"".COMPILE_CODE(addslashes($SUBJECT))."\";"; + $eval = "\$SUBJECT = \"" . COMPILE_CODE(addslashes($SUBJECT)) . "\";"; eval($eval); $SUBJECT = html_entity_decode($SUBJECT); @@ -355,7 +351,7 @@ function SEND_EMAIL($TO, $SUBJECT, $MSG, $HTML='N', $FROM="") { // Append header $FROM .= LOAD_EMAIL_TEMPLATE("header"); } - } elseif (DEBUG_MODE) { + } elseif (isBooleanConstantAndTrue('DEBUG_MODE')) { if (empty($FROM)) { // Load email header template $FROM = LOAD_EMAIL_TEMPLATE("header"); @@ -367,7 +363,7 @@ function SEND_EMAIL($TO, $SUBJECT, $MSG, $HTML='N', $FROM="") { // Fix HTML parameter (default is no!) if (empty($HTML)) $HTML = 'N'; - if (DEBUG_MODE) { + if (isBooleanConstantAndTrue('DEBUG_MODE')) { // In debug mode we want to display the mail instead of sending it away so we can debug this part echo "
 ".htmlentities(trim($FROM))."
@@ -638,17 +634,11 @@ function TRANSLATE_STATUS($status)
 	return $ret;
 }
 //
-function GET_LANGUAGE()
-{
-	global $_COOKIE, $_GET;
-
-	if (!empty($_GET['mx_lang']))
-	{
+function GET_LANGUAGE() {
+	if (!empty($_GET['mx_lang'])) {
 		// Accept only first 2 chars
 		$lang = substr($_GET['mx_lang'], 0, 2);
-	}
-	 else
-	{
+	} else {
 		// Do nothing
 		$lang = "";
 	}
@@ -657,39 +647,33 @@ function GET_LANGUAGE()
 	$ret = DEFAULT_LANG;
 
 	// Check GET variable and cookie
-	if (!empty($lang))
-	{
+	if (!empty($lang)) {
 		// Check if main language file does exist
-		if (file_exists(PATH."inc/language/".$lang.".php"))
-		{
+		if (file_exists(PATH."inc/language/".$lang.".php")) {
 			// Okay found, so let's update cookies
 			SET_LANGUAGE($lang);
 		}
-	}
-	 elseif (!empty($_COOKIE['mx_lang']))
-	{
+	} elseif (!isSessionVariableSet('mx_lang')) {
 		// Return stored value from cookie
-		$ret = $_COOKIE['mx_lang'];
+		$ret = get_session('mx_lang');
+
+		// Fixes a warning before the session has the mx_lang constant
+		if (empty($ret)) $ret = DEFAULT_LANG;
 	}
 	return $ret;
 }
 //
-function SET_LANGUAGE($lang)
-{
+function SET_LANGUAGE($lang) {
 	global $_CONFIG;
 
 	// Accept only first 2 chars!
 	$lang = substr(SQL_ESCAPE(strip_tags($lang)), 0, 2);
 
 	// Set cookie
-	@setcookie("mx_lang", $lang, (time() + $_CONFIG['online_timeout']), COOKIE_PATH);
-
-	// Set array
-	$_COOKIE['mx_lang'] = $lang;
+	set_session("mx_lang", $lang);
 }
 //
-function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0")
-{
+function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0") {
 	global $DATA, $_CONFIG, $REPLACER;
 
 	// Keept for backward-compatiblity (please replace these variables against our new {--CONST--} syntax!)
@@ -701,31 +685,26 @@ function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0")
 	$HTTP_USER_AGENT  = getenv('HTTP_USER_AGENT');
 
 	$ADMIN = MAIN_TITLE;
-	if (!empty($_COOKIE['admin_login']))
-	{
+	if (isSessionVariableSet('admin_login')) {
 		// Load Admin data
 		$result = SQL_QUERY_ESC("SELECT email FROM "._MYSQL_PREFIX."_admins WHERE login='%s' LIMIT 1",
-			array(SQL_ESCAPE($_COOKIE['admin_login'])), __FILE__, __LINE__);
+			array(SQL_ESCAPE(get_session('admin_login'))), __FILE__, __LINE__);
 		list($ADMIN) = SQL_FETCHROW($result);
 		SQL_FREERESULT($result);
 	}
 
 	// Expiration in a nice output format
-	if ($_CONFIG['auto_purge'] == 0)
-	{
+	if ($_CONFIG['auto_purge'] == 0) {
 		// Will never expire!
 		$EXPIRATION = MAIL_WILL_NEVER_EXPIRE;
-	}
-	 elseif (function_exists('CREATE_FANCY_TIME'))
-	{
+	} elseif (function_exists('CREATE_FANCY_TIME')) {
 		// Create nice date string
 		$EXPIRATION = CREATE_FANCY_TIME($_CONFIG['auto_purge']);
-	}
-	 else
-	{
+	} else {
 		// Display days only
 		$EXPIRATION = round($_CONFIG['auto_purge']/60/60/24)." "._DAYS;
 	}
+
 	switch ($template)
 	{
 	case "bonus-mail": // Load data for the bonus mail
@@ -803,11 +782,11 @@ function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0")
 
 	case "back-admin":
 	case "back-member":
-		$points     = TRANSLATE_COMMA($DATA[10]);
+		$points		= TRANSLATE_COMMA($DATA[10]);
 		break;
 
 	case "add-points":
-		$points = $_POST['points'];
+		$points		= bigintval($_POST['points']);
 		break;
 
 	case "guest_request_confirm":
@@ -816,18 +795,14 @@ function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0")
 	}
 
 	// Load user's data
-	if ($UID > 0)
-	{
-		if (EXT_IS_ACTIVE("nickname"))
-		{
+	if ($UID > 0) {
+		if (EXT_IS_ACTIVE("nickname")) {
 			// Load nickname
 			$result = SQL_QUERY_ESC("SELECT surname, family, sex, email, nickname FROM "._MYSQL_PREFIX."_user_data WHERE userid=%d LIMIT 1",
 			 array(bigintval($UID)), __FILE__, __LINE__);
 			list($surname, $family, $sex, $email, $nick) = SQL_FETCHROW($result);
 			SQL_FREERESULT($result);
-		}
-		 else
-		{
+		} else {
 			// Load normal data
 			$result = SQL_QUERY_ESC("SELECT surname, family, sex, email FROM "._MYSQL_PREFIX."_user_data WHERE userid=%d LIMIT 1",
 			 array(bigintval($UID)), __FILE__, __LINE__);
@@ -835,9 +810,7 @@ function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0")
 			SQL_FREERESULT($result);
 			$nick = "---";
 		}
-	}
-	 else
-	{
+	} else {
 		// Neutral sex and email address is default
 		$sex = 'N';
 		$email = WEBMASTER;
@@ -853,40 +826,29 @@ function LOAD_EMAIL_TEMPLATE($template, $content="", $UID="0")
 	$BASE = PATH."templates/".GET_LANGUAGE()."/emails/";
 
 	// Check for admin/guest/member templates
-	if (strpos($template, "admin_") > -1)
-	{
+	if (strpos($template, "admin_") > -1) {
 		// Admin template found
 		$file = $BASE."admin/".$template.".tpl";
-	}
-	 elseif (strpos($template, "guest_") > -1)
-	{
+	} elseif (strpos($template, "guest_") > -1) {
 		// Guest template found
 		$file = $BASE."guest/".$template.".tpl";
-	}
-	 elseif (strpos($template, "member_") > -1)
-	{
+	} elseif (strpos($template, "member_") > -1) {
 		// Member template found
 		$file = $BASE."member/".$template.".tpl";
-	}
-	 else
-	{
+	} else {
 		// Test for extension
 		$test = substr($template, 0, strpos($template, "_"));
-		if (EXT_IS_ACTIVE($test))
-		{
+		if (EXT_IS_ACTIVE($test)) {
 			// Set extra path to extension's name
 			$file = $BASE.$test."/".$template.".tpl";
-		}
-		 else
-		{
+		} else {
 			// No special filename
 			$file = $BASE.$template.".tpl";
 		}
 	}
 
 	// Does the special template exists?
-	if (!@file_exists($file))
-	{
+	if ((!@file_exists($file)) || (!is_readable($file))) {
 		// Reset to default template
 		$file = $BASE.$template.".tpl";
 	}
@@ -941,6 +903,8 @@ function MAKE_TIME($H, $M, $S, $stamp)
 }
 //
 function LOAD_URL($URL, $addUrlData=true) {
+	global $CSS, $_CONFIG, $link, $db, $footer;
+
 	// Check if http(s):// is there
 	if ((substr($URL, 0, 7) != "http://") && (substr($URL, 0, 8) != "https://")) {
 		// Make all URLs full-qualified
@@ -983,11 +947,11 @@ function COMPILE_CODE($code, $simple = false, $constants = true, $full = true) {
 	if ($constants) {
 		// BEFORE 0.2.1 : Language and data constants
 		// WITH 0.2.1+  : Only language constants
-		$code = str_replace("{--", '".', str_replace("--}", '."', $code));
+		$code = str_replace('{--', '".', str_replace('--}', '."', $code));
 
 		// BEFORE 0.2.1 : Not used
 		// WITH 0.2.1+  : Data constants
-		$code = str_replace("{!", '".', str_replace("!}", '."', $code));
+		$code = str_replace('{!', '".', str_replace("!}", '."', $code));
 	}
 
 	// Compile QUOT and other non-HTML codes
@@ -997,7 +961,7 @@ function COMPILE_CODE($code, $simple = false, $constants = true, $full = true) {
 	}
 
 	// But shall I keep simple quotes for later use?
-	if ($simple) $code = str_replace("\'", "{QUOT}", $code);
+	if ($simple) $code = str_replace("\'", '{QUOT}', $code);
 
 	// Find $content[bla][blub] entries
 	@preg_match_all('/\$(content|DATA)((\[([a-zA-Z0-9-_]+)\])*)/', $code, $matches);
@@ -1184,7 +1148,7 @@ function ADD_SELECTION($type, $DEFAULT, $prefix="", $id="0")
 		$OUT .= "