X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=inc%2Fmodules%2Fadmin%2Fwhat-list_links.php;h=0acde7aa1984e9364687c6e7e10031988a531c34;hb=87a1790a6620f46451f1a8865c7153aa6b7ffec9;hp=13f3f973af7e6c4ddd5e7e42086d3adbb656be83;hpb=ea6cf3578750b2697b45cab74725396962b56ceb;p=mailer.git

diff --git a/inc/modules/admin/what-list_links.php b/inc/modules/admin/what-list_links.php
index 13f3f973af..0acde7aa19 100644
--- a/inc/modules/admin/what-list_links.php
+++ b/inc/modules/admin/what-list_links.php
@@ -17,7 +17,7 @@
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
  * Copyright (c) 2009 - 2011 by Mailer Developer Team                   *
- * For more information visit: http://www.mxchange.org                  *
+ * For more information visit: http://mxchange.org                      *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
  * it under the terms of the GNU General Public License as published by *
@@ -44,35 +44,35 @@ if ((!defined('__SECURITY')) || (!isAdmin())) {
 addYouAreHereLink('admin', __FILE__);
 
 if (!isExtensionActive('mailid')) {
-	displayMessage(generateExtensionInactiveNotInstalledMessage('mailid'));
+	displayMessage('{%pipe,generateExtensionInactiveNotInstalledMessage=mailid%}');
 	return;
 } // END - if
 
-if (isGetRequestParameterSet('userid')) {
+if (isGetRequestElementSet('userid')) {
 	// Check if the user already exists
-	if (fetchUserData(getRequestParameter('userid'))) {
+	if (fetchUserData(getRequestElement('userid'))) {
 		// Grab user's all unconfirmed mails
 		// @TODO Try to rewrite this to a filter
 		if (isExtensionActive('bonus')) {
 			// Load bonus id
-			$result = SQL_QUERY_ESC("SELECT `stats_id`, `bonus_id`, `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `userid`=%s ORDER BY `id` ASC",
-				array(bigintval(getRequestParameter('userid'))), __FILE__, __LINE__);
+			$result = SQL_QUERY_ESC("SELECT `stats_id`,`bonus_id`,`link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `userid`=%s ORDER BY `id` ASC",
+				array(bigintval(getRequestElement('userid'))), __FILE__, __LINE__);
 		} else {
 			// Load stats id (2nd will be ignored later! But it is needed for the same fetchrow command)
-			$result = SQL_QUERY_ESC("SELECT `stats_id`, `stats_id`, `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `userid`=%s ORDER BY `id` ASC",
-				array(bigintval(getRequestParameter('userid'))), __FILE__, __LINE__);
+			$result = SQL_QUERY_ESC("SELECT `stats_id`,`stats_id`,`link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `userid`=%s ORDER BY `id` ASC",
+				array(bigintval(getRequestElement('userid'))), __FILE__, __LINE__);
 		}
 
 		// Do we have some entries?
 		if (!SQL_HASZERONUMS($result)) {
 			// Some unconfirmed mails left
-			if (getRequestParameter('delete') == "all") {
+			if (getRequestElement('delete') == "all") {
 				// Delete all unconfirmed mails by this user
 				SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `userid`=%s LIMIT %s",
-					array(bigintval(getRequestParameter('userid')), SQL_NUMROWS($result)), __FILE__, __LINE__);
+					array(bigintval(getRequestElement('userid')), SQL_NUMROWS($result)), __FILE__, __LINE__);
 
 				// Prepare mail and send it away
-				$message = loadEmailTemplate('member_delete_links', SQL_NUMROWS($result), bigintval(getRequestParameter('userid')));
+				$message = loadEmailTemplate('member_delete_links', SQL_NUMROWS($result), bigintval(getRequestElement('userid')));
 				sendEmail(getUserData('userid'), '{--ADMIN_DELETE_LINK_SUBJECT--}', $message);
 
 				// Display message
@@ -85,25 +85,25 @@ if (isGetRequestParameterSet('userid')) {
 				// @TODO Find a way to rewrite this. See some lines above for different queries
 				while (list($id, $id2, $type) = SQL_FETCHROW($result)) {
 					// Initializes all variables
-					$DATA = '';
-					$PROBLEM = '{--ADMIN_GENERAL_MAIL_PROBLEM--}';
+					$mailId = '';
+					$problemMessage = '{--ADMIN_GENERAL_MAIL_PROBLEM--}';
 					$result_data = false;
 
 					// Load data from stats table...
 					// @TODO Rewrite this to includes/filter
 					switch ($type) {
 						case 'NORMAL':
-							$result_data = SQL_QUERY_ESC("SELECT `subject`, `timestamp_ordered` AS `timestamp`, `cat_id` FROM `{?_MYSQL_PREFIX?}_user_stats` WHERE `id`=%s LIMIT 1",
+							$result_data = SQL_QUERY_ESC("SELECT `subject`,`timestamp_ordered` AS `timestamp`,`cat_id` FROM `{?_MYSQL_PREFIX?}_user_stats` WHERE `id`=%s LIMIT 1",
 								array(bigintval($id)), __FILE__, __LINE__);
-							$type = 'mailid'; $DATA = $id; $PROBLEM = '{--NORMAL_MAIL_PROBLEM--}';
-							$LINK = '<a href="{%url=mailid.php?userid=' . getRequestParameter('userid') . '&amp;mailid=' . $id . '%}" target="_blank">' . $id . '</a>';
+							$type = 'mailid'; $mailId = $id; $problemMessage = '{--NORMAL_MAIL_PROBLEM--}';
+							$LINK = '<a href="{%url=mailid.php?userid=' . getRequestElement('userid') . '&amp;mailid=' . $id . '%}" target="_blank">' . $id . '</a>';
 							break;
 
 						case 'BONUS':
-							$result_data = SQL_QUERY_ESC("SELECT `subject`, `timestamp`, `cat_id` FROM `{?_MYSQL_PREFIX?}_bonus` WHERE `id`=%s LIMIT 1",
+							$result_data = SQL_QUERY_ESC("SELECT `subject`,`timestamp`,`cat_id` FROM `{?_MYSQL_PREFIX?}_bonus` WHERE `id`=%s LIMIT 1",
 								array(bigintval($id2)), __FILE__, __LINE__);
-							$type = 'bonusid'; $DATA = $id2; $PROBLEM = '{--BONUS_MAIL_PROBLEM--}';
-							$LINK = '<a href="{%url=mailid.php?userid=' . getRequestParameter('userid') . '&amp;bonusid=' . $id2 . '%}" target="_blank">' . $id2 . '</a>';
+							$type = 'bonusid'; $mailId = $id2; $problemMessage = '{--BONUS_MAIL_PROBLEM--}';
+							$LINK = '<a href="{%url=mailid.php?userid=' . getRequestElement('userid') . '&amp;bonusid=' . $id2 . '%}" target="_blank">' . $id2 . '</a>';
 							break;
 
 						default: // Problem in application detected!
@@ -118,15 +118,14 @@ if (isGetRequestParameterSet('userid')) {
 						$content = SQL_FETCHARRAY($result_data);
 
 						// Fix empty subject
-						if (empty($content['subject'])) $content['subject'] = '{--DEFAULT_SUBJECT_LINE--}';
+						if (empty($content['subject'])) {
+							// The subject line is empty so we use the default
+							$content['subject'] = '{--DEFAULT_SUBJECT_LINE--}';
+						} // END - if
 
 						// Prepare data for the row template
-						$content = array(
-							'link'      => $LINK,
-							'subject'   => $content['subject'],
-							'timestamp' => generateDateTime($content['timestamp'], 0),
-							'cat_id'    => $content['cat_id'],
-						);
+						$content['link']      = $LINK;
+						$content['timestamp'] = generateDateTime($content['timestamp'], 0);
 
 						// Load row template
 						$OUT .= loadTemplate('admin_list_links_row', true, $content);
@@ -134,8 +133,8 @@ if (isGetRequestParameterSet('userid')) {
 						// Load template for error
 						$OUT .= loadTemplate('admin_list_links_problem', true,
 							array(
-								'problem'	=> $PROBLEM,
-								'data'		=> $DATA
+								'problem' => $problemMessage,
+								'mail_id' => $mailId
 							)
 						);
 					}
@@ -145,12 +144,10 @@ if (isGetRequestParameterSet('userid')) {
 				} // END - while
 
 				// Remember list in constant for the template
-				$content['surname'] = getUserData('surname');
-				$content['family']  = getUserData('family');
 				$content['email']   = '<a href="' . generateEmailLink(getUserData('email'), 'user_data') . '">' . getUserData('email') . '</a>';
 				$content['rows']    = $OUT;
 				$content['nums']    = SQL_NUMROWS($result);
-				$content['userid']  = bigintval(getRequestParameter('userid'));
+				$content['userid']  = bigintval(getRequestElement('userid'));
 
 				// Free memory
 				SQL_FREERESULT($result);
@@ -160,11 +157,11 @@ if (isGetRequestParameterSet('userid')) {
 			}
 		} else {
 			// No mails left to confirm
-			displayMessage('{%message,ADMIN_MEMBER_LINKS=' . bigintval(getRequestParameter('userid')) . '%}');
+			displayMessage('{%message,ADMIN_NO_UNCONFIRMED_MAILS_LEFT=' . bigintval(getRequestElement('userid')) . '%}');
 		}
 	} else {
 		// User not found
-		displayMessage('{%message,ADMIN_MEMBER_404=' . bigintval(getRequestParameter('userid')) . '%}');
+		displayMessage('{%message,ADMIN_MEMBER_404=' . bigintval(getRequestElement('userid')) . '%}');
 	}
 } else {
 	// Output selection form with all confirmed user accounts listed