X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=lib%2Factivity.php;h=9282461c1ccce4a29ef3c769191fcd3d426d32c2;hb=3d334451c45bd93b222d58155404786ee0667a0e;hp=b8c94262685473fa7c8acae82d576bb629a42b0c;hpb=879a6f9ce773d955b043d5a8a832e8a505d5dad3;p=quix0rs-gnu-social.git
diff --git a/lib/activity.php b/lib/activity.php
index b8c9426268..9282461c1c 100644
--- a/lib/activity.php
+++ b/lib/activity.php
@@ -100,11 +100,13 @@ class Activity
public $title; // title of the activity
public $categories = array(); // list of AtomCategory objects
public $enclosures = array(); // list of enclosure URL references
+ public $attachments = array(); // list of attachments
public $extra = array(); // extra elements as array(tag, attrs, content)
public $source; // ActivitySource object representing 'home feed'
public $selfLink; //
public $editLink; //
+ public $generator; // ActivityObject representing the generating application
/**
* Turns a regular old Atom into a magical activity
@@ -243,6 +245,9 @@ class Activity
if (!empty($targetEl)) {
$this->target = new ActivityObject($targetEl);
+ } elseif (ActivityUtils::compareVerbs($this->verb, array(ActivityVerb::FAVORITE))) {
+ // StatusNet didn't send a 'target' for their Favorite atom entries
+ $this->target = clone($this->objects[0]);
}
$this->summary = ActivityUtils::childContent($entry, 'summary');
@@ -365,8 +370,11 @@ class Activity
// content
$activity['content'] = $this->content;
- // generator <-- We could use this when we know a notice is created
- // locally. Or if we know the upstream Generator.
+ // generator
+
+ if (!empty($this->generator)) {
+ $activity['generator'] = $this->generator->asArray();
+ }
// icon <-- possibly a mini object representing verb?
@@ -385,9 +393,10 @@ class Activity
if ($object instanceof Activity) {
// Sharing a post activity is more like sharing the original object
- if ($this->verb == 'share' && $object->verb == 'post') {
+ if (ActivityVerb::canonical($this->verb) == ActivityVerb::canonical(ActivityVerb::SHARE) &&
+ ActivityVerb::canonical($object->verb) == ActivityVerb::canonical(ActivityVerb::POST)) {
// XXX: Here's one for the obfuscation record books
- $object = $object->object;
+ $object = $object->objects[0];
}
}
@@ -397,47 +406,11 @@ class Activity
$activity['object']['objectType'] = 'activity';
}
-
- // Instead of adding enclosures as an extension to JSON
- // Activities, it seems like we should be using the
- // attachements property of ActivityObject
-
- $attachments = array();
-
- // XXX: OK, this is kinda cheating. We should probably figure out
- // what kind of objects these are based on mime-type and then
- // create specific object types. Right now this rely on
- // duck-typing. Also, we should include an embed code for
- // video attachments.
-
- foreach ($this->enclosures as $enclosure) {
-
- if (is_string($enclosure)) {
-
- $attachments[]['id'] = $enclosure;
-
- } else {
-
- $attachments[]['id'] = $enclosure->url;
-
- $mediaLink = new ActivityStreamsMediaLink(
- $enclosure->url,
- null,
- null,
- $enclosure->mimetype
- // XXX: Add 'size' as an extension to MediaLink?
- );
-
- $attachments[]['mediaLink'] = $mediaLink->asArray(); // extension
-
- if ($enclosure->title) {
- $attachments[]['displayName'] = $enclosure->title;
- }
+ foreach ($this->attachments as $attachment) {
+ if (empty($activity['object']['attachments'])) {
+ $activity['object']['attachments'] = array();
}
- }
-
- if (!empty($attachments)) {
- $activity['object']['attachments'] = $attachments;
+ $activity['object']['attachments'][] = $attachment->asArray();
}
}
@@ -514,7 +487,9 @@ class Activity
$activity['verb'] = ActivityVerb::canonical($this->verb);
// url
- $activity['url'] = $this->id;
+ if ($this->link) {
+ $activity['url'] = $this->link;
+ }
/* Purely extensions hereafter */
@@ -589,7 +564,13 @@ class Activity
} else {
$xs->element('id', null, $this->id);
- $xs->element('title', null, $this->title);
+
+ if ($this->title) {
+ $xs->element('title', null, $this->title);
+ } else {
+ // Require element
+ $xs->element('title', null, "");
+ }
$xs->element('content', array('type' => 'html'), $this->content);
@@ -599,8 +580,8 @@ class Activity
if (!empty($this->link)) {
$xs->element('link', array('rel' => 'alternate',
- 'type' => 'text/html'),
- $this->link);
+ 'type' => 'text/html',
+ 'href' => $this->link));
}
}
@@ -645,30 +626,24 @@ class Activity
}
if (!empty($this->context->conversation)) {
- $xs->element('link', array('rel' => 'ostatus:conversation',
+ $xs->element('link', array('rel' => ActivityContext::CONVERSATION,
'href' => $this->context->conversation));
- }
-
- foreach ($this->context->attention as $attnURI) {
- $xs->element('link', array('rel' => 'ostatus:attention',
- 'href' => $attnURI));
- $xs->element('link', array('rel' => 'mentioned',
+ $xs->element(ActivityContext::CONVERSATION, null, $this->context->conversation);
+ /* Since we use XMLWriter we just use the previously hardcoded prefix for ostatus,
+ otherwise we should use something like this:
+ $xs->elementNS(array(ActivityContext::OSTATUS => 'ostatus'), // namespace
+ 'conversation', // tag (or the element name from ActivityContext::CONVERSATION)
+ null, // attributes
+ $this->context->conversation); // content
+ */
+ }
+
+ foreach ($this->context->attention as $attnURI=>$type) {
+ $xs->element('link', array('rel' => ActivityContext::MENTIONED,
+ ActivityContext::OBJECTTYPE => $type, // FIXME: undocumented
'href' => $attnURI));
}
- // XXX: shoulda used ActivityVerb::SHARE
-
- if (!empty($this->context->forwardID)) {
- if (!empty($this->context->forwardUrl)) {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID,
- 'href' => $this->context->forwardUrl));
- } else {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID));
- }
- }
-
if (!empty($this->context->location)) {
$loc = $this->context->location;
$xs->element('georss:point', null, $loc->lat . ' ' . $loc->lon);