X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=lib%2Factivity.php;h=9282461c1ccce4a29ef3c769191fcd3d426d32c2;hb=d6b28c64830f632bb2f4b6f3c9369b9e56ad217a;hp=779be2a9ad0840b18c81281e114839f7b38f9f2f;hpb=14a111189d79cadea2f552a78eec9983a2ec099e;p=quix0rs-gnu-social.git
diff --git a/lib/activity.php b/lib/activity.php
index 779be2a9ad..9282461c1c 100644
--- a/lib/activity.php
+++ b/lib/activity.php
@@ -107,6 +107,7 @@ class Activity
public $selfLink; //
public $editLink; //
public $generator; // ActivityObject representing the generating application
+
/**
* Turns a regular old Atom into a magical activity
*
@@ -244,6 +245,9 @@ class Activity
if (!empty($targetEl)) {
$this->target = new ActivityObject($targetEl);
+ } elseif (ActivityUtils::compareVerbs($this->verb, array(ActivityVerb::FAVORITE))) {
+ // StatusNet didn't send a 'target' for their Favorite atom entries
+ $this->target = clone($this->objects[0]);
}
$this->summary = ActivityUtils::childContent($entry, 'summary');
@@ -389,9 +393,10 @@ class Activity
if ($object instanceof Activity) {
// Sharing a post activity is more like sharing the original object
- if ($this->verb == 'share' && $object->verb == 'post') {
+ if (ActivityVerb::canonical($this->verb) == ActivityVerb::canonical(ActivityVerb::SHARE) &&
+ ActivityVerb::canonical($object->verb) == ActivityVerb::canonical(ActivityVerb::POST)) {
// XXX: Here's one for the obfuscation record books
- $object = $object->object;
+ $object = $object->objects[0];
}
}
@@ -482,7 +487,9 @@ class Activity
$activity['verb'] = ActivityVerb::canonical($this->verb);
// url
- $activity['url'] = $this->id;
+ if ($this->link) {
+ $activity['url'] = $this->link;
+ }
/* Purely extensions hereafter */
@@ -573,8 +580,8 @@ class Activity
if (!empty($this->link)) {
$xs->element('link', array('rel' => 'alternate',
- 'type' => 'text/html'),
- $this->link);
+ 'type' => 'text/html',
+ 'href' => $this->link));
}
}
@@ -619,30 +626,24 @@ class Activity
}
if (!empty($this->context->conversation)) {
- $xs->element('link', array('rel' => 'ostatus:conversation',
+ $xs->element('link', array('rel' => ActivityContext::CONVERSATION,
'href' => $this->context->conversation));
- }
-
- foreach ($this->context->attention as $attnURI) {
- $xs->element('link', array('rel' => 'ostatus:attention',
- 'href' => $attnURI));
- $xs->element('link', array('rel' => 'mentioned',
+ $xs->element(ActivityContext::CONVERSATION, null, $this->context->conversation);
+ /* Since we use XMLWriter we just use the previously hardcoded prefix for ostatus,
+ otherwise we should use something like this:
+ $xs->elementNS(array(ActivityContext::OSTATUS => 'ostatus'), // namespace
+ 'conversation', // tag (or the element name from ActivityContext::CONVERSATION)
+ null, // attributes
+ $this->context->conversation); // content
+ */
+ }
+
+ foreach ($this->context->attention as $attnURI=>$type) {
+ $xs->element('link', array('rel' => ActivityContext::MENTIONED,
+ ActivityContext::OBJECTTYPE => $type, // FIXME: undocumented
'href' => $attnURI));
}
- // XXX: shoulda used ActivityVerb::SHARE
-
- if (!empty($this->context->forwardID)) {
- if (!empty($this->context->forwardUrl)) {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID,
- 'href' => $this->context->forwardUrl));
- } else {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID));
- }
- }
-
if (!empty($this->context->location)) {
$loc = $this->context->location;
$xs->element('georss:point', null, $loc->lat . ' ' . $loc->lon);