X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=mod%2Fopenid.php;h=0ebda485d023a5cf090aed7138a824538f71e7f1;hb=2d63f9deb646d30c60927026b83e08d0f47c381a;hp=7bf8c299c8c76a5aaff49f7ea27976ad87ad6451;hpb=9a3f5eaf7d4cd6b16f21e9a5f11278e55107b62f;p=friendica.git

diff --git a/mod/openid.php b/mod/openid.php
index 7bf8c299c8..0ebda485d0 100644
--- a/mod/openid.php
+++ b/mod/openid.php
@@ -8,118 +8,96 @@ function openid_content(&$a) {
 
 	$noid = get_config('system','no_openid');
 	if($noid)
-		goaway($a->get_baseurl());
+		goaway(z_root());
+
+	logger('mod_openid ' . print_r($_REQUEST,true), LOGGER_DATA);
 
 	if((x($_GET,'openid_mode')) && (x($_SESSION,'openid'))) {
+
 		$openid = new LightOpenID;
 
 		if($openid->validate()) {
 
-			if(x($_SESSION,'register')) {
-				unset($_SESSION['register']);
-				$args = '';
-				$attr = $openid->getAttributes();
-				if(is_array($attr) && count($attr)) {
-					foreach($attr as $k => $v) {
-						if($k === 'namePerson/friendly')
-							$nick = notags(trim($v));
-						if($k === 'namePerson/first')
-							$first = notags(trim($v));
-						if($k === 'namePerson')
-							$args .= '&username=' . notags(trim($v));
-						if($k === 'contact/email')
-							$args .= '&email=' . notags(trim($v));
-						if($k === 'media/image/aspect11')
-							$photosq = bin2hex(trim($v));
-						if($k === 'media/image/default')
-							$photo = bin2hex(trim($v));
-					}
-				}
-				if($nick)
-					$args .= '&nickname=' . $nick;
-				elseif($first)
-					$args .= '&nickname=' . $first;
+			$authid = $_REQUEST['openid_identity'];
 
-				if($photosq)
-					$args .= '&photo=' . $photosq;
-				elseif($photo)
-					$args .= '&photo=' . $photo;
+			if(! strlen($authid)) {
+				logger( t('OpenID protocol error. No ID returned.') . EOL);
+				goaway(z_root());
+			}
 
-				$args .= '&openid_url=' . notags(trim($_SESSION['openid']));
-				if($a->config['register_policy'] != REGISTER_CLOSED)
-					goaway($a->get_baseurl() . '/register' . $args);
-				else
-					goaway($a->get_baseurl());
+			// NOTE: we search both for normalised and non-normalised form of $authid
+			//       because the normalization step was removed from setting
+			//       mod/settings.php in 8367cad so it might have left mixed
+			//       records in the user table
+			//
+			$r = q("SELECT * FROM `user`
+				WHERE ( `openid` = '%s' OR `openid` = '%s' )
+				AND `blocked` = 0 AND `account_expired` = 0
+				AND `account_removed` = 0 AND `verified` = 1
+				LIMIT 1",
+				dbesc($authid), dbesc(normalise_openid($authid))
+			);
 
-				// NOTREACHED
-			} 
+			if($r && count($r)) {
 
+				// successful OpenID login
 
-			$r = q("SELECT * FROM `user` WHERE `openid` = '%s' AND `blocked` = 0 AND `verified` = 1 LIMIT 1",
-				dbesc($_SESSION['openid'])
-			);
-			if(! count($r)) {
-				notice( t('Login failed.') . EOL );
-				goaway($a->get_baseurl());
-  			}
-			unset($_SESSION['openid']);
-
-			$_SESSION['uid'] = $r[0]['uid'];
-			$_SESSION['theme'] = $r[0]['theme'];
-			$_SESSION['authenticated'] = 1;
-			$_SESSION['page_flags'] = $r[0]['page-flags'];
-			$_SESSION['my_url'] = $a->get_baseurl() . '/profile/' . $r[0]['nickname'];
-
-			$a->user = $r[0];
-
-			if($a->user['login_date'] === '0000-00-00 00:00:00') {
-				$_SESSION['return_url'] = 'profile_photo/new';
-				$a->module = 'profile_photo';
-				notice( t("Welcome ") . $a->user['username'] . EOL);
-				notice( t('Please upload a profile photo.') . EOL);
-			}
-			else
-				notice( t("Welcome back ") . $a->user['username'] . EOL);
+				unset($_SESSION['openid']);
 
+				require_once('include/security.php');
+				authenticate_success($r[0],true,true);
 
-			if(strlen($a->user['timezone'])) {
-				date_default_timezone_set($a->user['timezone']);
-				$a->timezone = $a->user['timezone'];
+				// just in case there was no return url set 
+				// and we fell through
+
+				goaway(z_root());
 			}
 
-			$r = q("SELECT `uid`,`username` FROM `user` WHERE `password` = '%s' AND `email` = '%s'",
-				dbesc($a->user['password']),
-				dbesc($a->user['email'])
-			);
-			if(count($r))
-				$a->identities = $r;
+			// Successful OpenID login - but we can't match it to an existing account.
+			// New registration?
 
-			$r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` = 1 LIMIT 1",
-				intval($_SESSION['uid'])
-			);
-			if(count($r)) {
-				$a->contact = $r[0];
-				$a->cid = $r[0]['id'];
-				$_SESSION['cid'] = $a->cid;
+			if($a->config['register_policy'] == REGISTER_CLOSED) {
+				notice( t('Account not found and OpenID registration is not permitted on this site.') . EOL);
+				goaway(z_root());
 			}
 
-			$l = get_language();
+			unset($_SESSION['register']);
+			$args = '';
+			$attr = $openid->getAttributes();
+			if(is_array($attr) && count($attr)) {
+				foreach($attr as $k => $v) {
+					if($k === 'namePerson/friendly')
+						$nick = notags(trim($v));
+					if($k === 'namePerson/first')
+						$first = notags(trim($v));
+					if($k === 'namePerson')
+						$args .= '&username=' . notags(trim($v));
+					if($k === 'contact/email')
+						$args .= '&email=' . notags(trim($v));
+					if($k === 'media/image/aspect11')
+						$photosq = bin2hex(trim($v));
+					if($k === 'media/image/default')
+						$photo = bin2hex(trim($v));
+				}
+			}
+			if($nick)
+				$args .= '&nickname=' . $nick;
+			elseif($first)
+				$args .= '&nickname=' . $first;
 
-			q("UPDATE `user` SET `login_date` = '%s', `language` = '%s' WHERE `uid` = %d LIMIT 1",
-				dbesc(datetime_convert()),
-				dbesc($l),
-				intval($_SESSION['uid'])
-			);
+			if($photosq)
+				$args .= '&photo=' . $photosq;
+			elseif($photo)
+				$args .= '&photo=' . $photo;
+
+			$args .= '&openid_url=' . notags(trim($authid));
 
+			goaway($a->get_baseurl() . '/register' . $args);
 
-			header('X-Account-Management-Status: active; name="' . $a->user['username'] . '"; id="' . $a->user['nickname'] .'"');
-			if(($a->module !== 'home') && isset($_SESSION['return_url']))
-				goaway($a->get_baseurl() . '/' . $_SESSION['return_url']);
-			else
-				goaway($a->get_baseurl());
+			// NOTREACHED
 		}
 	}
 	notice( t('Login failed.') . EOL);
-	goaway($a->get_baseurl());
+	goaway(z_root());
 	// NOTREACHED
-}
\ No newline at end of file
+}