X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=mod%2Fsalmon.php;h=1e16f9d14ba1d2e6b7b8fff8886b24adbcdef04d;hb=82d779a33b287699cb1e543d384445422e50710f;hp=30e87f243fd436779c1d165add5cfdf66014685b;hpb=a8a88d253296629d265242f03651419ed2982ec7;p=friendica.git diff --git a/mod/salmon.php b/mod/salmon.php index 30e87f243f..1e16f9d14b 100644 --- a/mod/salmon.php +++ b/mod/salmon.php @@ -1,22 +1,21 @@ = 500) + if($val >= 400) $err = 'Error'; - if($val == 200) + if($val >= 200 && $val < 300) $err = 'OK'; - + + logger('mod-salmon returns ' . $val); header($_SERVER["SERVER_PROTOCOL"] . ' ' . $val . ' ' . $err); killme(); @@ -25,19 +24,17 @@ function salmon_return($val) { function salmon_post(&$a) { $xml = file_get_contents('php://input'); - - $debugging = get_config('system','debugging'); - if($debugging) - file_put_contents('salmon.out','New Salmon: ' . $xml . "\n",FILE_APPEND); + + logger('mod-salmon: new salmon ' . $xml, LOGGER_DATA); $nick = (($a->argc > 1) ? notags(trim($a->argv[1])) : ''); $mentions = (($a->argc > 2 && $a->argv[2] === 'mention') ? true : false); - $r = q("SELECT * FROM `user` WHERE `nickname` = '%s' LIMIT 1", + $r = q("SELECT * FROM `user` WHERE `nickname` = '%s' AND `account_expired` = 0 LIMIT 1", dbesc($nick) ); if(! count($r)) - salmon_return(500); + http_status_exit(500); $importer = $r[0]; @@ -45,10 +42,6 @@ function salmon_post(&$a) { $dom = simplexml_load_string($xml,'SimpleXMLElement',0,NAMESPACE_SALMON_ME); - - if($debugging) - file_put_contents('salmon.out', "\n" . print_r($dom,true) . "\n" , FILE_APPEND); - // figure out where in the DOM tree our data is hiding if($dom->provenance->data) @@ -59,9 +52,8 @@ function salmon_post(&$a) { $base = $dom; if(! $base) { - if($debugging) - file_put_contents('salmon.out', "\n" . 'Unable to find salmon data in XML' . "\n" , FILE_APPEND); - salmon_return(500); + logger('mod-salmon: unable to locate salmon data in xml '); + http_status_exit(400); } // Stash the signature away for now. We have to find their key or it won't be good for anything. @@ -69,9 +61,6 @@ function salmon_post(&$a) { $signature = base64url_decode($base->sig); - if($debugging) - file_put_contents('salmon.out', "\n" . 'Encoded Signature: ' . $base->sig . "\n" , FILE_APPEND); - // unpack the data // strip whitespace so our data element will return to one big base64 blob @@ -84,12 +73,16 @@ function salmon_post(&$a) { $encoding = $base->encoding; $alg = $base->alg; - // If we're talking to status.net or one of their ilk, they aren't following the magic envelope spec - // and only signed the data element. We'll be nice and let them validate anyway. + // Salmon magic signatures have evolved and there is no way of knowing ahead of time which + // flavour we have. We'll try and verify it regardless. $stnet_signed_data = $data; + $signed_data = $data . '.' . base64url_encode($type) . '.' . base64url_encode($encoding) . '.' . base64url_encode($alg); + $compliant_format = str_replace('=','',$signed_data); + + // decode the data $data = base64url_decode($data); @@ -98,15 +91,13 @@ function salmon_post(&$a) { // Create a fake feed wrapper so simplepie doesn't choke - $tpl = load_view_file('view/fake_feed.tpl'); + $tpl = get_markup_template('fake_feed.tpl'); $base = substr($data,strpos($data,''; - if($debugging) { - file_put_contents('salmon.out', 'Processed feed: ' . $feedxml . "\n", FILE_APPEND); - } + logger('mod-salmon: Processed feed: ' . $feedxml); // Now parse it like a normal atom feed to scrape out the author URI @@ -115,10 +106,7 @@ function salmon_post(&$a) { $feed->enable_order_by_date(false); $feed->init(); - if($debugging) { - file_put_contents('salmon.out', "\n" . 'Feed parsed.' . "\n", FILE_APPEND); - } - + logger('mod-salmon: Feed parsed.'); if($feed->get_item_quantity()) { foreach($feed->get_items() as $item) { @@ -129,64 +117,51 @@ function salmon_post(&$a) { } if(! $author_link) { - if($debugging) - file_put_contents('salmon.out',"\n" . 'Could not retrieve author URI.' . "\n", FILE_APPEND); - salmon_return(500); + logger('mod-salmon: Could not retrieve author URI.'); + http_status_exit(400); } // Once we have the author URI, go to the web and try to find their public key - if($debugging) { - file_put_contents('salmon.out', "\n" . 'Fetching key for ' . $author_link . "\n", FILE_APPEND); - } + logger('mod-salmon: Fetching key for ' . $author_link ); + $key = get_salmon_key($author_link,$keyhash); if(! $key) { - if($debugging) - file_put_contents('salmon.out',"\n" . 'Could not retrieve author key.' . "\n", FILE_APPEND); - salmon_return(500); + logger('mod-salmon: Could not retrieve author key.'); + http_status_exit(400); } - // Setup RSA stuff to verify the signature - - set_include_path(get_include_path() . PATH_SEPARATOR . 'phpsec'); - - require_once('phpsec/Crypt/RSA.php'); - $key_info = explode('.',$key); $m = base64url_decode($key_info[1]); $e = base64url_decode($key_info[2]); - if($debugging) - file_put_contents('salmon.out',"\n" . print_r($key_info,true) . "\n", FILE_APPEND); + logger('mod-salmon: key details: ' . print_r($key_info,true), LOGGER_DEBUG); - $rsa = new CRYPT_RSA(); - $rsa->signatureMode = CRYPT_RSA_SIGNATURE_PKCS1; - $rsa->setHash('sha256'); - - $rsa->modulus = new Math_BigInteger($m, 256); - $rsa->k = strlen($rsa->modulus->toBytes()); - $rsa->exponent = new Math_BigInteger($e, 256); + $pubkey = metopem($m,$e); // We should have everything we need now. Let's see if it verifies. - // If it fails with the proper data format, try again using just the data - // (e.g. status.net) - $verify = $rsa->verify($signed_data,$signature); + $verify = rsa_verify($compliant_format,$signature,$pubkey); + + if(! $verify) { + logger('mod-salmon: message did not verify using protocol. Trying padding hack.'); + $verify = rsa_verify($signed_data,$signature,$pubkey); + } - if(! $verify) - $verify = $rsa->verify($stnet_signed_data,$signature); + if(! $verify) { + logger('mod-salmon: message did not verify using padding. Trying old statusnet hack.'); + $verify = rsa_verify($stnet_signed_data,$signature,$pubkey); + } if(! $verify) { - if($debugging) - file_put_contents('salmon.out',"\n" . 'Message did not verify. Discarding.' . "\n", FILE_APPEND); - salmon_return(500); + logger('mod-salmon: Message did not verify. Discarding.'); + http_status_exit(400); } - if($debugging) - file_put_contents('salmon.out',"\n" . 'Message verified.' . "\n", FILE_APPEND); + logger('mod-salmon: Message verified.'); /* @@ -195,16 +170,39 @@ function salmon_post(&$a) { * */ - $r = q("SELECT * FROM `contact` WHERE `network` = 'stat' AND `lrdd` = '%s' AND `uid` = %d LIMIT 1", + $r = q("SELECT * FROM `contact` WHERE `network` = '%s' AND ( `url` = '%s' OR `alias` = '%s' ) + AND `uid` = %d LIMIT 1", + dbesc(NETWORK_OSTATUS), + dbesc($author_link), dbesc($author_link), intval($importer['uid']) ); if(! count($r)) { - if($debugging) - file_put_contents('salmon.out',"\n" . 'Author unknown to us.' . "\n", FILE_APPEND); - salmon_return(500); + logger('mod-salmon: Author unknown to us.'); + if(get_pconfig($importer['uid'],'system','ostatus_autofriend')) { + require_once('include/follow.php'); + $result = new_contact($importer['uid'],$author_link); + if($result['success']) { + $r = q("SELECT * FROM `contact` WHERE `network` = '%s' AND ( `url` = '%s' OR `alias` = '%s' ) + AND `uid` = %d LIMIT 1", + dbesc(NETWORK_OSTATUS), + dbesc($author_link), + dbesc($author_link), + intval($importer['uid']) + ); + } + } } + // is this a follower? Or have we ignored the person? + // If so we can not accept this post. + + if((count($r)) && (($r[0]['readonly']) || ($r[0]['rel'] == CONTACT_IS_FOLLOWER) || ($r[0]['blocked']))) { + logger('mod-salmon: Ignoring this author.'); + http_status_exit(202); + // NOTREACHED + } + require_once('include/items.php'); // Placeholder for hub discovery. We shouldn't find any hubs @@ -212,9 +210,18 @@ function salmon_post(&$a) { $hub = ''; - consume_feed($feedxml,$importer,$r[0],$hub); + /** + * + * anti-spam measure: consume_feed will accept a follow activity from + * this person (and nothing else) if there is no existing contact record. + * + */ + + $contact_rec = ((count($r)) ? $r[0] : null); + + consume_feed($feedxml,$importer,$contact_rec,$hub); - salmon_return(200); + http_status_exit(200); }