X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=mod%2Fwall_attach.php;h=43f4681df336e226c346f559f22bbf5ba66157d5;hb=1aacff4ce1cafcb3ab1e232f9c01dd3daa770d15;hp=94aac2be9f1e42f25cefe74e472ea48f2e75371b;hpb=2a431b580f2e8f6a596e84175932e793678cde63;p=friendica.git

diff --git a/mod/wall_attach.php b/mod/wall_attach.php
index 94aac2be9f..43f4681df3 100644
--- a/mod/wall_attach.php
+++ b/mod/wall_attach.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -21,6 +21,7 @@
 
 use Friendica\App;
 use Friendica\Core\Session;
+use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Attach;
@@ -31,23 +32,18 @@ function wall_attach_post(App $a) {
 
 	$r_json = (!empty($_GET['response']) && $_GET['response']=='json');
 
-	if ($a->argc > 1) {
-		$nick = $a->argv[1];
-		$r = q("SELECT `user`.*, `contact`.`id` FROM `user` LEFT JOIN `contact` on `user`.`uid` = `contact`.`uid`  WHERE `user`.`nickname` = '%s' AND `user`.`blocked` = 0 and `contact`.`self` = 1 LIMIT 1",
-			DBA::escape($nick)
-		);
-
-		if (! DBA::isResult($r)) {
+	if (DI::args()->getArgc() > 1) {
+		$nick = DI::args()->getArgv()[1];
+		$owner = User::getOwnerDataByNick($nick);
+		if (!DBA::isResult($owner)) {
 			if ($r_json) {
-				echo json_encode(['error' => DI::l10n()->t('Invalid request.')]);
-				exit();
+				System::jsonExit(['error' => DI::l10n()->t('Invalid request.')]);
 			}
 			return;
 		}
 	} else {
 		if ($r_json) {
-			echo json_encode(['error' => DI::l10n()->t('Invalid request.')]);
-			exit();
+			System::jsonExit(['error' => DI::l10n()->t('Invalid request.')]);
 		}
 
 		return;
@@ -55,38 +51,30 @@ function wall_attach_post(App $a) {
 
 	$can_post  = false;
 
-	$page_owner_uid   = $r[0]['uid'];
-	$page_owner_cid   = $r[0]['id'];
-	$community_page   = (($r[0]['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? true : false);
+	$page_owner_uid = $owner['uid'];
+	$page_owner_cid = $owner['id'];
+	$community_page = $owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY;
 
 	if (local_user() && (local_user() == $page_owner_uid)) {
 		$can_post = true;
 	} elseif ($community_page && !empty(Session::getRemoteContactID($page_owner_uid))) {
 		$contact_id = Session::getRemoteContactID($page_owner_uid);
-		$r = q("SELECT `uid` FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 AND `id` = %d AND `uid` = %d LIMIT 1",
-			intval($contact_id),
-			intval($page_owner_uid)
-		);
-
-		if (DBA::isResult($r)) {
-			$can_post = true;
-		}
+		$can_post = DBA::exists('contact', ['blocked' => false, 'pending' => false, 'id' => $contact_id, 'uid' => $page_owner_uid]);
 	}
 
 	if (!$can_post) {
 		if ($r_json) {
-			echo json_encode(['error' => DI::l10n()->t('Permission denied.')]);
-			exit();
+			System::jsonExit(['error' => DI::l10n()->t('Permission denied.')]);
 		}
 		notice(DI::l10n()->t('Permission denied.') . EOL );
-		exit();
+		System::exit();
 	}
 
 	if (empty($_FILES['userfile'])) {
 		if ($r_json) {
-			echo json_encode(['error' => DI::l10n()->t('Invalid request.')]);
+			System::jsonExit(['error' => DI::l10n()->t('Invalid request.')]);
 		}
-		exit();
+		System::exit();
 	}
 
 	$src      = $_FILES['userfile']['tmp_name'];
@@ -103,24 +91,24 @@ function wall_attach_post(App $a) {
 
 	if ($filesize <= 0) {
 		$msg = DI::l10n()->t('Sorry, maybe your upload is bigger than the PHP configuration allows') . EOL .(DI::l10n()->t('Or - did you try to upload an empty file?'));
+		@unlink($src);
 		if ($r_json) {
-			echo json_encode(['error' => $msg]);
+			System::jsonExit(['error' => $msg]);
 		} else {
 			notice($msg);
 		}
-		@unlink($src);
-		exit();
+		System::exit();
 	}
 
 	if ($maxfilesize && $filesize > $maxfilesize) {
 		$msg = DI::l10n()->t('File exceeds size limit of %s', Strings::formatBytes($maxfilesize));
+		@unlink($src);
 		if ($r_json) {
-			echo json_encode(['error' => $msg]);
+			System::jsonExit(['error' => $msg]);
 		} else {
 			echo $msg . EOL;
 		}
-		@unlink($src);
-		exit();
+		System::exit();
 	}
 
 	$newid = Attach::storeFile($src, $page_owner_uid, $filename, '<' . $page_owner_cid . '>');
@@ -130,22 +118,20 @@ function wall_attach_post(App $a) {
 	if ($newid === false) {
 		$msg =  DI::l10n()->t('File upload failed.');
 		if ($r_json) {
-			echo json_encode(['error' => $msg]);
+			System::jsonExit(['error' => $msg]);
 		} else {
 			echo $msg . EOL;
 		}
-		exit();
+		System::exit();
 	}
 
 	if ($r_json) {
-		echo json_encode(['ok' => true, 'id' => $newid]);
-		exit();
+		System::jsonExit(['ok' => true, 'id' => $newid]);
 	}
 
 	$lf = "\n";
 
 	echo  $lf . $lf . '[attachment]' . $newid . '[/attachment]' . $lf;
-
-	exit();
+	System::exit();
 	// NOTREACHED
 }