X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;ds=sidebyside;f=src%2FWorker%2FNotifier.php;h=f6b1d23cf03bcf66cc8e79c7ed32f5da88d3a958;hb=1696ad962ea4fdae16a6bff29a6a98ee523108e5;hp=ca79656d46a8969c55631dd2d3a18a76cb412346;hpb=ef205878b61c64e77c2654a312181bdb88fc0440;p=friendica.git

diff --git a/src/Worker/Notifier.php b/src/Worker/Notifier.php
index ca79656d46..f6b1d23cf0 100644
--- a/src/Worker/Notifier.php
+++ b/src/Worker/Notifier.php
@@ -5,7 +5,6 @@
 namespace Friendica\Worker;
 
 use Friendica\BaseObject;
-use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\Hook;
 use Friendica\Core\Logger;
@@ -16,6 +15,7 @@ use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\Group;
 use Friendica\Model\Item;
+use Friendica\Model\ItemDeliveryData;
 use Friendica\Model\PushSubscriber;
 use Friendica\Model\User;
 use Friendica\Network\Probe;
@@ -24,7 +24,6 @@ use Friendica\Protocol\Diaspora;
 use Friendica\Protocol\OStatus;
 use Friendica\Protocol\Salmon;
 
-require_once 'include/dba.php';
 require_once 'include/items.php';
 
 /*
@@ -54,91 +53,68 @@ require_once 'include/items.php';
 
 class Notifier
 {
-	public static function execute($cmd, $item_id)
+	public static function execute($cmd, $target_id)
 	{
 		$a = BaseObject::getApp();
 
-		Logger::log('notifier: invoked: '.$cmd.': '.$item_id, Logger::DEBUG);
+		Logger::log('Invoked: ' . $cmd . ': ' . $target_id, Logger::DEBUG);
 
 		$top_level = false;
 		$recipients = [];
 		$url_recipients = [];
 
-		$normal_mode = true;
-		$recipients_relocate = [];
+		$delivery_contacts_stmt = null;
+		$target_item = [];
+		$items = [];
+		$delivery_queue_count = 0;
 
 		if ($cmd == Delivery::MAIL) {
-			$normal_mode = false;
-			$message = DBA::selectFirst('mail', ['uid', 'contact-id'], ['id' => $item_id]);
+			$message = DBA::selectFirst('mail', ['uid', 'contact-id'], ['id' => $target_id]);
 			if (!DBA::isResult($message)) {
 				return;
 			}
 			$uid = $message['uid'];
 			$recipients[] = $message['contact-id'];
 		} elseif ($cmd == Delivery::SUGGESTION) {
-			$normal_mode = false;
-			$suggest = DBA::selectFirst('fsuggest', ['uid', 'cid'], ['id' => $item_id]);
+			$suggest = DBA::selectFirst('fsuggest', ['uid', 'cid'], ['id' => $target_id]);
 			if (!DBA::isResult($suggest)) {
 				return;
 			}
 			$uid = $suggest['uid'];
 			$recipients[] = $suggest['cid'];
 		} elseif ($cmd == Delivery::REMOVAL) {
-			$r = q("SELECT `contact`.*, `user`.`prvkey` AS `uprvkey`,
-					`user`.`timezone`, `user`.`nickname`, `user`.`sprvkey`, `user`.`spubkey`,
-					`user`.`page-flags`, `user`.`prvnets`, `user`.`account-type`, `user`.`guid`
-				FROM `contact` INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
-					WHERE `contact`.`uid` = %d AND `contact`.`self` LIMIT 1",
-					intval($item_id));
-			if (!$r) {
-				return;
-			}
-			$user = $r[0];
-
-			$r = q("SELECT * FROM `contact` WHERE NOT `self` AND `uid` = %d", intval($item_id));
-			if (!$r) {
-				return;
-			}
-			foreach ($r as $contact) {
-				Contact::terminateFriendship($user, $contact, true);
-			}
-
-			$inboxes = ActivityPub\Transmitter::fetchTargetInboxesforUser(0);
-			foreach ($inboxes as $inbox) {
-				Logger::log('Account removal for user ' . $item_id . ' to ' . $inbox .' via ActivityPub', Logger::DEBUG);
-				Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
-					'APDelivery', Delivery::REMOVAL, '', $inbox, $item_id);
-			}
-
-			return;
+			return self::notifySelfRemoval($target_id, $a->queue['priority'], $a->queue['created']);
 		} elseif ($cmd == Delivery::RELOCATION) {
-			$normal_mode = false;
-			$uid = $item_id;
+			$uid = $target_id;
 
-			$recipients_relocate = q("SELECT * FROM `contact` WHERE `uid` = %d AND NOT `self` AND `network` IN ('%s', '%s')",
-						intval($uid), Protocol::DFRN, Protocol::DIASPORA);
+			$condition = ['uid' => $target_id, 'self' => false, 'network' => [Protocol::DFRN, Protocol::DIASPORA]];
+			$delivery_contacts_stmt = DBA::select('contact', ['id', 'url', 'network', 'batch'], $condition);
 		} else {
 			// find ancestors
-			$condition = ['id' => $item_id, 'visible' => true, 'moderated' => false];
+			$condition = ['id' => $target_id, 'visible' => true, 'moderated' => false];
 			$target_item = Item::selectFirst([], $condition);
 
 			if (!DBA::isResult($target_item) || !intval($target_item['parent'])) {
 				return;
 			}
 
-			$parent_id = intval($target_item['parent']);
-			$uid = $target_item['contact-uid'];
-			$updated = $target_item['edited'];
+			if (!empty($target_item['contact-uid'])) {
+				$uid = $target_item['contact-uid'];
+			} elseif (!empty($target_item['uid'])) {
+				$uid = $target_item['uid'];
+			} else {
+				Logger::log('Only public users for item ' . $target_id, Logger::DEBUG);
+				return;
+			}
 
-			$condition = ['parent' => $parent_id, 'visible' => true, 'moderated' => false];
+			$condition = ['parent' => $target_item['parent'], 'visible' => true, 'moderated' => false];
 			$params = ['order' => ['id']];
-			$ret = Item::select([], $condition, $params);
-
-			if (!DBA::isResult($ret)) {
+			$items_stmt = Item::select([], $condition, $params);
+			if (!DBA::isResult($items_stmt)) {
 				return;
 			}
 
-			$items = Item::inArray($ret);
+			$items = Item::inArray($items_stmt);
 
 			// avoid race condition with deleting entries
 			if ($items[0]['deleted']) {
@@ -148,7 +124,7 @@ class Notifier
 			}
 
 			if ((count($items) == 1) && ($items[0]['id'] === $target_item['id']) && ($items[0]['uri'] === $items[0]['parent-uri'])) {
-				Logger::log('notifier: top level post');
+				Logger::log('Top level post');
 				$top_level = true;
 			}
 		}
@@ -158,8 +134,6 @@ class Notifier
 			return;
 		}
 
-		$walltowall = ($top_level && ($owner['id'] != $items[0]['contact-id']) ? true : false);
-
 		// Should the post be transmitted to Diaspora?
 		$diaspora_delivery = true;
 
@@ -175,16 +149,16 @@ class Notifier
 		$followup = false;
 		$recipients_followup = [];
 
-		if (!in_array($cmd, [Delivery::MAIL, Delivery::SUGGESTION, Delivery::RELOCATION])) {
+		if (!empty($target_item) && !empty($items)) {
 			$parent = $items[0];
 
-			self::activityPubDelivery($a, $cmd, $item_id, $uid, $target_item, $parent);
+			$delivery_queue_count += self::activityPubDelivery($cmd, $target_item, $parent, $a->queue['priority'], $a->query_string['created']);
 
 			$fields = ['network', 'author-id', 'owner-id'];
 			$condition = ['uri' => $target_item["thr-parent"], 'uid' => $target_item["uid"]];
 			$thr_parent = Item::selectFirst($fields, $condition);
 
-			Logger::log('GUID: '.$target_item["guid"].': Parent is '.$parent['network'].'. Thread parent is '.$thr_parent['network'], Logger::DEBUG);
+			Logger::log('GUID: ' . $target_item["guid"] . ': Parent is ' . $parent['network'] . '. Thread parent is ' . $thr_parent['network'], Logger::DEBUG);
 
 			// This is IMPORTANT!!!!
 
@@ -247,7 +221,7 @@ class Notifier
 				$recipients = [$parent['contact-id']];
 				$recipients_followup  = [$parent['contact-id']];
 
-				Logger::log('notifier: followup ' . $target_item['guid'] . ' to ' . $parent['contact-id'], Logger::DEBUG);
+				Logger::log('Followup ' . $target_item['guid'] . ' to ' . $parent['contact-id'], Logger::DEBUG);
 
 				//if (!$target_item['private'] && $target_item['wall'] &&
 				if (!$target_item['private'] &&
@@ -261,15 +235,12 @@ class Notifier
 					if ($parent["network"] == Protocol::OSTATUS) {
 						// Distribute the message to the DFRN contacts as if this wasn't a followup since OStatus can't relay comments
 						// Currently it is work at progress
-						$r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `network` = '%s' AND NOT `blocked` AND NOT `pending` AND NOT `archive`",
-							intval($uid),
-							DBA::escape(Protocol::DFRN)
-						);
-						if (DBA::isResult($r)) {
-							foreach ($r as $rr) {
-								$recipients_followup[] = $rr['id'];
-							}
+						$condition = ['uid' => $uid, 'network' => Protocol::DFRN, 'blocked' => false, 'pending' => false, 'archive' => false];
+						$followup_contacts_stmt = DBA::select('contact', ['id'], $condition);
+						while($followup_contact = DBA::fetch($followup_contacts_stmt)) {
+							$recipients_followup[] = $followup_contact['id'];
 						}
+						DBA::close($followup_contacts_stmt);
 					}
 				}
 
@@ -277,16 +248,16 @@ class Notifier
 					$push_notify = false;
 				}
 
-				Logger::log("Notify ".$target_item["guid"]." via PuSH: ".($push_notify?"Yes":"No"), Logger::DEBUG);
+				Logger::log('Notify ' . $target_item["guid"] .' via PuSH: ' . ($push_notify ? "Yes":"No"), Logger::DEBUG);
 			} else {
 				$followup = false;
 
-				Logger::log('Distributing directly '.$target_item["guid"], Logger::DEBUG);
+				Logger::log('Distributing directly ' . $target_item["guid"], Logger::DEBUG);
 
 				// don't send deletions onward for other people's stuff
 
 				if ($target_item['deleted'] && !intval($target_item['wall'])) {
-					Logger::log('notifier: ignoring delete notification for non-wall item');
+					Logger::log('Ignoring delete notification for non-wall item');
 					return;
 				}
 
@@ -306,7 +277,7 @@ class Notifier
 				// a delivery fork. private groups (forum_mode == 2) do not uplink
 
 				if ((intval($parent['forum_mode']) == 1) && !$top_level && ($cmd !== 'uplink')) {
-					Worker::add($a->queue['priority'], 'Notifier', 'uplink', $item_id);
+					Worker::add($a->queue['priority'], 'Notifier', 'uplink', $target_id);
 				}
 
 				foreach ($items as $item) {
@@ -325,12 +296,26 @@ class Notifier
 				}
 
 				if (count($url_recipients)) {
-					Logger::log('notifier: '.$target_item["guid"].' url_recipients ' . print_r($url_recipients,true));
+					Logger::log('Deliver ' . $target_item["guid"] . ' to _recipients ' . json_encode($url_recipients));
 				}
 
 				$recipients = array_unique(array_merge($recipients, $allow_people, $allow_groups));
 				$deny = array_unique(array_merge($deny_people, $deny_groups));
 				$recipients = array_diff($recipients, $deny);
+
+				// If this is a public message and pubmail is set on the parent, include all your email contacts
+				if (
+					function_exists('imap_open')
+					&& !Config::get('system','imap_disabled')
+					&& $public_message
+					&& intval($target_item['pubmail'])
+				) {
+					$mail_contacts_stmt = DBA::select('contact', ['id'], ['uid' => $uid, 'network' => Protocol::MAIL]);
+					while ($mail_contact = DBA::fetch($mail_contacts_stmt)) {
+						$recipients[] = $mail_contact['id'];
+					}
+					DBA::close($mail_contacts_stmt);
+				}
 			}
 
 			// If the thread parent is OStatus then do some magic to distribute the messages.
@@ -377,26 +362,7 @@ class Notifier
 			$public_message = false;
 		}
 
-		// If this is a public message and pubmail is set on the parent, include all your email contacts
-		if (!empty($target_item) && function_exists('imap_open') && !Config::get('system','imap_disabled')) {
-			if (!strlen($target_item['allow_cid']) && !strlen($target_item['allow_gid'])
-				&& !strlen($target_item['deny_cid']) && !strlen($target_item['deny_gid'])
-				&& intval($target_item['pubmail'])) {
-				$r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `network` = '%s'",
-					intval($uid),
-					DBA::escape(Protocol::MAIL)
-				);
-				if (DBA::isResult($r)) {
-					foreach ($r as $rr) {
-						$recipients[] = $rr['id'];
-					}
-				}
-			}
-		}
-
-		if (($cmd == Delivery::RELOCATION)) {
-			$contacts = $recipients_relocate;
-		} else {
+		if (empty($delivery_contacts_stmt)) {
 			if ($followup) {
 				$recipients = $recipients_followup;
 			}
@@ -405,34 +371,47 @@ class Notifier
 			if (!empty($networks)) {
 				$condition['network'] = $networks;
 			}
-			$result = DBA::select('contact', ['id', 'url', 'network', 'batch'], $condition);
-			$contacts = DBA::toArray($result);
+			$delivery_contacts_stmt = DBA::select('contact', ['id', 'url', 'network', 'batch'], $condition);
 		}
 
 		$conversants = [];
 		$batch_delivery = false;
 
 		if ($public_message && !in_array($cmd, [Delivery::MAIL, Delivery::SUGGESTION]) && !$followup) {
-			$r1 = [];
+			$relay_list = [];
 
 			if ($diaspora_delivery) {
 				$batch_delivery = true;
 
-				$r1 = q("SELECT `batch`, ANY_VALUE(`id`) AS `id`, ANY_VALUE(`name`) AS `name`, ANY_VALUE(`network`) AS `network`
-					FROM `contact` WHERE `network` = '%s' AND `batch` != ''
-					AND `uid` = %d AND `rel` != %d AND NOT `blocked` AND NOT `pending` AND NOT `archive` GROUP BY `batch`",
-					DBA::escape(Protocol::DIASPORA),
-					intval($owner['uid']),
-					intval(Contact::SHARING)
+				$relay_list_stmt = DBA::p(
+					"SELECT
+       					`batch`,
+       					ANY_VALUE(`id`) AS `id`,
+       					ANY_VALUE(`name`) AS `name`,
+       					ANY_VALUE(`network`) AS `network`
+					FROM `contact`
+					WHERE `network` = ?
+					AND `batch` != ''
+					AND `uid` = ?
+					AND `rel` != ?
+					AND NOT `blocked`
+					AND NOT `pending`
+					AND NOT `archive`
+					GROUP BY `batch`",
+					Protocol::DIASPORA,
+					$owner['uid'],
+					Contact::SHARING
 				);
+				$relay_list = DBA::toArray($relay_list_stmt);
 
 				// Fetch the participation list
 				// The function will ensure that there are no duplicates
-				$r1 = Diaspora::participantsForThread($item_id, $r1);
+				$relay_list = Diaspora::participantsForThread($target_id, $relay_list);
 
-				// Add the relay to the list, avoid duplicates
-				if (!$followup) {
-					$r1 = Diaspora::relayList($item_id, $r1);
+				// Add the relay to the list, avoid duplicates.
+				// Don't send community posts to the relay. Forum posts via the Diaspora protocol are looking ugly.
+				if (!$followup && !self::isForumPost($target_item, $owner)) {
+					$relay_list = Diaspora::relayList($target_id, $relay_list);
 				}
 			}
 
@@ -441,16 +420,25 @@ class Notifier
 
 			$r2 = DBA::toArray(DBA::select('contact', ['id', 'name', 'network'], $condition));
 
-			$r = array_merge($r2, $r1);
+			$r = array_merge($r2, $relay_list);
 
 			if (DBA::isResult($r)) {
-				Logger::log('pubdeliver '.$target_item["guid"].': '.print_r($r,true), Logger::DEBUG);
-
 				foreach ($r as $rr) {
 					$conversants[] = $rr['id'];
-					Logger::log('notifier: delivery agent: '.$rr['name'].' '.$rr['id'].' '.$rr['network'].' '.$target_item["guid"]);
-					Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
-						'Delivery', $cmd, $item_id, (int)$rr['id']);
+
+					$delivery_queue_count++;
+
+					Logger::log('Public delivery of item ' . $target_item["guid"] . ' (' . $target_id . ') to ' . json_encode($rr), Logger::DEBUG);
+
+					// Ensure that posts with our own protocol arrives before Diaspora posts arrive.
+					// Situation is that sometimes Friendica servers receive Friendica posts over the Diaspora protocol first.
+					// The conversion in Markdown reduces the formatting, so these posts should arrive after the Friendica posts.
+					if ($rr['network'] == Protocol::DIASPORA) {
+						$deliver_options = ['priority' => $a->queue['priority'], 'dont_fork' => true];
+					} else {
+						$deliver_options = ['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true];
+					}
+					Worker::add($deliver_options, 'Delivery', $cmd, $target_id, (int)$rr['id']);
 				}
 			}
 
@@ -458,98 +446,151 @@ class Notifier
 		}
 
 		// delivery loop
-		if (DBA::isResult($contacts)) {
-			foreach ($contacts as $contact) {
-				// Don't deliver to Diaspora if it already had been done as batch delivery
-				if (($contact['network'] == Protocol::DIASPORA) && $batch_delivery) {
-					continue;
-				}
+		while ($contact = DBA::fetch($delivery_contacts_stmt)) {
+			// Don't deliver to Diaspora if it already had been done as batch delivery
+			if (($contact['network'] == Protocol::DIASPORA) && $batch_delivery) {
+				Logger::log('Already delivered  id ' . $target_id . ' via batch to ' . json_encode($contact), Logger::DEBUG);
+				continue;
+			}
 
-				// Don't deliver to folks who have already been delivered to
-				if (in_array($contact['id'], $conversants)) {
-					Logger::log('notifier: already delivered id=' . $rr['id']);
-					continue;
-				}
+			// Don't deliver to folks who have already been delivered to
+			if (in_array($contact['id'], $conversants)) {
+				Logger::log('Already delivered id ' . $target_id. ' to ' . json_encode($contact), Logger::DEBUG);
+				continue;
+			}
 
-				Logger::log("Deliver ".$item_id." to ".$contact['url']." via network ".$contact['network'], Logger::DEBUG);
+			$delivery_queue_count++;
 
-				Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
-						'Delivery', $cmd, $item_id, (int)$contact['id']);
+			Logger::log('Delivery of item ' . $target_id . ' to ' . json_encode($contact), Logger::DEBUG);
+
+			// Ensure that posts with our own protocol arrives before Diaspora posts arrive.
+			// Situation is that sometimes Friendica servers receive Friendica posts over the Diaspora protocol first.
+			// The conversion in Markdown reduces the formatting, so these posts should arrive after the Friendica posts.
+			if ($contact['network'] == Protocol::DIASPORA) {
+				$deliver_options = ['priority' => $a->queue['priority'], 'dont_fork' => true];
+			} else {
+				$deliver_options = ['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true];
 			}
+			Worker::add($deliver_options, 'Delivery', $cmd, $target_id, (int)$contact['id']);
 		}
+		DBA::close($delivery_contacts_stmt);
 
+
+		$url_recipients = array_filter($url_recipients);
 		// send salmon slaps to mentioned remote tags (@foo@example.com) in OStatus posts
 		// They are especially used for notifications to OStatus users that don't follow us.
-		if (!Config::get('system', 'dfrn_only') && count($url_recipients) && ($public_message || $push_notify) && $normal_mode) {
+		if (!Config::get('system', 'dfrn_only') && count($url_recipients) && ($public_message || $push_notify) && !empty($target_item)) {
+			$delivery_queue_count += count($url_recipients);
 			$slap = OStatus::salmon($target_item, $owner);
 			foreach ($url_recipients as $url) {
-				if ($url) {
-					Logger::log('notifier: urldelivery: ' . $url);
-					$deliver_status = Salmon::slapper($owner, $url, $slap);
-					/// @TODO Redeliver/queue these items on failure, though there is no contact record
-				}
+				Logger::log('Salmon delivery of item ' . $target_id . ' to ' . $url);
+				/// @TODO Redeliver/queue these items on failure, though there is no contact record
+				Salmon::slapper($owner, $url, $slap);
+				ItemDeliveryData::incrementQueueDone($target_id);
 			}
 		}
 
 		// Notify PuSH subscribers (Used for OStatus distribution of regular posts)
 		if ($push_notify) {
-			Logger::log('Activating internal PuSH for item '.$item_id, Logger::DEBUG);
+			Logger::log('Activating internal PuSH for item '.$target_id, Logger::DEBUG);
 
 			// Handling the pubsubhubbub requests
 			PushSubscriber::publishFeed($owner['uid'], $a->queue['priority']);
 		}
 
-		Logger::log('notifier: calling hooks for ' . $cmd . ' ' . $item_id, Logger::DEBUG);
+		if (!empty($target_item)) {
+			Logger::log('Calling hooks for ' . $cmd . ' ' . $target_id, Logger::DEBUG);
+
+			if (in_array($cmd, [Delivery::POST, Delivery::COMMENT])) {
+				ItemDeliveryData::update($target_item['id'], ['queue_count' => $delivery_queue_count]);
+			}
 
-		if ($normal_mode) {
 			Hook::fork($a->queue['priority'], 'notifier_normal', $target_item);
-		}
 
-		Addon::callHooks('notifier_end',$target_item);
+			Hook::callAll('notifier_end', $target_item);
+		}
 
 		return;
 	}
 
-	private static function activityPubDelivery($a, $cmd, $item_id, $uid, $target_item, $parent)
+	/**
+	 * @param int    $self_user_id
+	 * @param int    $priority     The priority the Notifier queue item was created with
+	 * @param string $created      The date the Notifier queue item was created on
+	 * @return bool
+	 */
+	private static function notifySelfRemoval($self_user_id, $priority, $created)
+	{
+		$owner = User::getOwnerDataById($self_user_id);
+		if (!$owner) {
+			return false;
+		}
+
+		$contacts_stmt = DBA::select('contact', [], ['self' => false, 'uid' => $self_user_id]);
+		if (!DBA::isResult($contacts_stmt)) {
+			return false;
+		}
+
+		while($contact = DBA::fetch($contacts_stmt)) {
+			Contact::terminateFriendship($owner, $contact, true);
+		}
+		DBA::close($contacts_stmt);
+
+		$inboxes = ActivityPub\Transmitter::fetchTargetInboxesforUser(0);
+		foreach ($inboxes as $inbox) {
+			Logger::log('Account removal for user ' . $self_user_id . ' to ' . $inbox .' via ActivityPub', Logger::DEBUG);
+			Worker::add(['priority' => PRIORITY_NEGLIGIBLE, 'created' => $created, 'dont_fork' => true],
+				'APDelivery', Delivery::REMOVAL, '', $inbox, $self_user_id);
+		}
+
+		return true;
+	}
+
+	/**
+	 * @param string $cmd
+	 * @param array  $target_item
+	 * @param array  $parent
+	 * @param int    $priority    The priority the Notifier queue item was created with
+	 * @param string $created     The date the Notifier queue item was created on
+	 * @return int The number of delivery tasks created
+	 */
+	private static function activityPubDelivery($cmd, array $target_item, array $parent, $priority, $created)
 	{
 		$inboxes = [];
-		$personal = false;
 
 		if ($target_item['origin']) {
-			$inboxes = ActivityPub\Transmitter::fetchTargetInboxes($target_item, $uid);
-			Logger::log('Origin item ' . $item_id . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
+			$inboxes = ActivityPub\Transmitter::fetchTargetInboxes($target_item, $target_item['contact-uid']);
+			Logger::log('Origin item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
 		} elseif (!DBA::exists('conversation', ['item-uri' => $target_item['uri'], 'protocol' => Conversation::PARCEL_ACTIVITYPUB])) {
-			Logger::log('Remote item ' . $item_id . ' with URL ' . $target_item['uri'] . ' is no AP post. It will not be distributed.', Logger::DEBUG);
-			return;
-		} else {
+			Logger::log('Remote item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' is no AP post. It will not be distributed.', Logger::DEBUG);
+			return 0;
+		} elseif ($parent['origin']) {
 			// Remote items are transmitted via the personal inboxes.
 			// Doing so ensures that the dedicated receiver will get the message.
-			$personal = true;
-			Logger::log('Remote item ' . $item_id . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
-		}
-
-		if ($parent['origin']) {
-			$parent_inboxes = ActivityPub\Transmitter::fetchTargetInboxes($parent, $uid, $personal);
-			$inboxes = array_merge($inboxes, $parent_inboxes);
+			$inboxes = ActivityPub\Transmitter::fetchTargetInboxes($parent, $target_item['contact-uid'], true, $target_item['id']);
+			Logger::log('Remote item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . ' will be distributed.', Logger::DEBUG);
 		}
 
 		if (empty($inboxes)) {
-			Logger::log('No inboxes found for item ' . $item_id . ' with URL ' . $target_item['uri'] . '. It will not be distributed.', Logger::DEBUG);
-			return;
+			Logger::log('No inboxes found for item ' . $target_item['id'] . ' with URL ' . $target_item['uri'] . '. It will not be distributed.', Logger::DEBUG);
+			return 0;
 		}
 
 		// Fill the item cache
-		ActivityPub\Transmitter::createCachedActivityFromItem($item_id, true);
+		ActivityPub\Transmitter::createCachedActivityFromItem($target_item['id'], true);
 
 		foreach ($inboxes as $inbox) {
-			Logger::log('Deliver ' . $item_id .' to ' . $inbox .' via ActivityPub', Logger::DEBUG);
+			Logger::log('Deliver ' . $target_item['id'] .' to ' . $inbox .' via ActivityPub', Logger::DEBUG);
 
-			Worker::add(['priority' => $a->queue['priority'], 'created' => $a->queue['created'], 'dont_fork' => true],
-					'APDelivery', $cmd, $item_id, $inbox, $uid);
+			Worker::add(['priority' => $priority, 'created' => $created, 'dont_fork' => true],
+					'APDelivery', $cmd, $target_item['id'], $inbox, $target_item['contact-uid']);
 		}
+
+		return count($inboxes);
 	}
 
-	private static function isForumPost($item, $owner) {
+	private static function isForumPost(array $item, array $owner)
+	{
 		if (($item['author-id'] == $item['owner-id']) ||
 			($owner['id'] == $item['contact-id']) ||
 			($item['uri'] != $item['parent-uri'])) {