X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=61d9e23aee11c0b2100774daaaca968ff344fcc7;hb=88baf1e93c2245ce391024c7dcc16fc39dd09e95;hp=208cd59d8fd0dd80f9aeac0c2032e41a4425d93d;hpb=1d22c70e65e858422ee0d17a7612f4b5c0757a42;p=mailer.git diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index 208cd59d8f..61d9e23aee 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -1,11 +1,13 @@ ### WARNING: THIS FILE IS AUTO-GENERATED BY ../../contrib/todo-builder.sh (uid=/user=quix0r) ### ### DO NOT EDIT THIS FILE. ### -./autoreg.php:58:// @TODO Add processing of request here -./beg.php:175: // @TODO Opps, what is missing here??? +./api.php:68:// @TODO Do stuff here +./autoreg.php:62:// @TODO Add processing of request here +./beg.php:173: // @TODO Opps, what is missing here??? +./cron.php:62:// @TODO Do stuff here ./inc/classes/cachesystem.class.php:516: // @TODO Add support for more types which break in last else-block -./inc/config-functions.php:149: // @TODO Make this all better... :-/ -./inc/config-functions.php:325: // @TODO Call setConfigEntry() somehow -./inc/config-functions.php:353: // @TODO Call setConfigEntry() somehow +./inc/config-functions.php:150: // @TODO Make this all better... :-/ +./inc/config-functions.php:326: // @TODO Call setConfigEntry() somehow +./inc/config-functions.php:354: // @TODO Call setConfigEntry() somehow ./inc/daily/daily_beg.php:52:// @TODO This should be converted in a daily beg rallye ./inc/daily/daily_birthday.php:99: // @TODO 4 is hard-coded here, should we move it out in config? ./inc/email-functions.php:113: * @TODO Rewrite this to an extension 'smtp' @@ -14,36 +16,34 @@ ./inc/expression-functions.php:46: // @TODO is escapeQuotes() enough for strings with single/double quotes? ./inc/extensions/ext-html_mail.php:136: // @TODO Move these arrays into config ./inc/extensions/ext-menu.php:52: // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => (edit|add)_(admin|guest|member)_menu -./inc/extensions/ext-network.php:100: // @TODO network_type_handler is an internal name and needs documentation -./inc/extensions/ext-network.php:18: * @TODO Ad-Magnet: Layer(klick?). Layerviews.Skybannerklick/-view, * -./inc/extensions/ext-network.php:19: * @TODO Ad-Magnet: Banner-View, Textlink-Klick/-View. Page-Peel * -./inc/extensions/ext-network.php:20: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * -./inc/extensions/ext-network.php:21: * @TODO ADCocktail: Zero array element is return code! * -./inc/extensions/ext-network.php:22: * @TODO adgain.de: Textlink-View is a JavaScript URL * -./inc/extensions/ext-network.php:23: * @TODO ADkracher: Textlink-View is a JavaScript URL * -./inc/extensions/ext-network.php:24: * @TODO Admono.de: highforcedbanner, traffic from abroad * -./inc/extensions/ext-network.php:25: * @TODO Affiliblatt: Layer requires script in head * -./inc/extensions/ext-network.php:26: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead * -./inc/extensions/ext-network.php:27: * @TODO AllAds4You: Traffic from abroad, High-Forced banner * -./inc/extensions/ext-network.php:28: * @TODO eu-ADS/WeltPromotion: Text for banner/buttons? * -./inc/extensions/ext-network.php:29: * @TODO FuCoExSponsor: Textlink-View is JavaScript! * -./inc/extensions/ext-network.php:30: * @TODO Fusion-Ads: Has click/banner URL in API response * -./inc/extensions/ext-network.php:31: * @TODO GeldSponsor.de Requires ID card copy/business reg. * -./inc/extensions/ext-network.php:32: * @TODO GolloX: Which charset? * -./inc/extensions/ext-network.php:33: * @TODO paid4ad: Which URLs for click and banner? * -./inc/extensions/ext-network.php:34: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * -./inc/extensions/ext-network.php:35: * @TODO SuperPromo24: Textlink view is a JavaScript * -./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * -./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Forced textlink not correct * -./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Layer not correct * -./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * -./inc/extensions/ext-network.php:40: * @TODO Der Werbepartner.cc: Surfbar click not correct * -./inc/extensions/ext-network.php:41: * @TODO Der Werbepartner.cc: Textlink not not correct * -./inc/extensions/ext-network.php:42: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL) * -./inc/extensions/ext-network.php:43: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * +./inc/extensions/ext-network.php:18: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * +./inc/extensions/ext-network.php:19: * @TODO ADCocktail: Zero array element is return code! * +./inc/extensions/ext-network.php:20: * @TODO adgain.de: Textlink-View is a JavaScript URL * +./inc/extensions/ext-network.php:21: * @TODO ADkracher: Textlink-View is a JavaScript URL * +./inc/extensions/ext-network.php:22: * @TODO Admono.de: highforcedbanner, traffic from abroad * +./inc/extensions/ext-network.php:23: * @TODO Affiliblatt: Layer requires script in head * +./inc/extensions/ext-network.php:24: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead * +./inc/extensions/ext-network.php:25: * @TODO AllAds4You: Traffic from abroad, High-Forced banner * +./inc/extensions/ext-network.php:26: * @TODO FuCoExSponsor: Textlink-View is JavaScript! * +./inc/extensions/ext-network.php:27: * @TODO Fusion-Ads: Has click/banner URL in API response * +./inc/extensions/ext-network.php:28: * @TODO GeldSponsor.de Requires ID card copy/business reg. * +./inc/extensions/ext-network.php:29: * @TODO GolloX: Please add full support * +./inc/extensions/ext-network.php:30: * @TODO MasterAd: Please add full support * +./inc/extensions/ext-network.php:31: * @TODO paid4ad: Which URLs for click and banner? * +./inc/extensions/ext-network.php:32: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * +./inc/extensions/ext-network.php:33: * @TODO SuperPromo24: Textlink view is a JavaScript * +./inc/extensions/ext-network.php:34: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * +./inc/extensions/ext-network.php:35: * @TODO Der Werbepartner.cc: Forced textlink not correct * +./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Layer not correct * +./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * +./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Surfbar click not correct * +./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Textlink not correct * +./inc/extensions/ext-network.php:40: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL) * +./inc/extensions/ext-network.php:41: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * +./inc/extensions/ext-network.php:98: // @TODO network_type_handler is an internal name and needs documentation ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-nickname.php:52: // @TODO NOT NULL DEFAULT '' is bad practice, use NULL -./inc/extensions/ext-yoomedia.php:121: // @TODO Can this be moved into a database table? +./inc/extensions/ext-yoomedia.php:120: // @TODO Can this be moved into a database table? ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y'); ./inc/extensions-functions.php:2169: // @TODO Is this really neccessary? ./inc/extensions-functions.php:2220:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' @@ -53,36 +53,40 @@ ./inc/filter/bonus_filter.php:56: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/filter/cache_filter.php:94: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. ./inc/filter/forced_filter.php:73: // @TODO This part is unfinished -./inc/filters.php:1317: // @TODO No banner found, output some default banner -./inc/functions.php:1104: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? -./inc/functions.php:1190: // @TODO Are these convertions still required? -./inc/functions.php:1211:// @TODO Rewrite this function to use readFromFile() and writeToFile() -./inc/functions.php:1820: // @TODO Find a way to cache this -./inc/functions.php:1924: // @TODO This is still very static, rewrite it somehow -./inc/functions.php:2128: // @TODO Rename column data_type to e.g. mail_status -./inc/functions.php:2478:// @TODO cacheFiles is not yet supported +./inc/filter-functions.php:117: // @TODO Remove this forced removal after a year or so +./inc/filters.php:1320: // @TODO No banner found, output some default banner +./inc/functions.php:1126: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? +./inc/functions.php:1212: // @TODO Are these convertions still required? +./inc/functions.php:1233:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1842: // @TODO Find a way to cache this +./inc/functions.php:1946: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2150: // @TODO Rename column data_type to e.g. mail_status +./inc/functions.php:2500:// @TODO cacheFiles is not yet supported ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter ./inc/header.php:66:// @TODO Find a way to not use direct module comparison ./inc/install-functions.php:446: // @TODO Comparing with DEFAULT_MAIN_TITLE doesn't work ./inc/install-functions.php:97: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); -./inc/language/de.php:1147: // @TODO Rewrite these two constants -./inc/language/de.php:1163: // @TODO Rewrite these three constants +./inc/language/de.php:1154: // @TODO Rewrite these two constants +./inc/language/de.php:1170: // @TODO Rewrite these three constants ./inc/language/de.php:46: // @TODO Please sort these language elements -./inc/language/de.php:741:// @TODO Are these constants longer used? -./inc/language-functions.php:255: // @TODO These are all valid languages, again hard-coded -./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function. +./inc/language/de.php:742:// @TODO Are these constants longer used? +./inc/language-functions.php:254: // @TODO These are all valid languages, again hard-coded ./inc/language/install_de.php:142: // @TODO Move this to e.g. ext-smtp ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no * ./inc/language/order_de.php:70: // @TODO Find better text ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * ./inc/language/refback_de.php:51: // @TODO Rewrite these constants to one -./inc/libs/admins_functions.php:528: // @TODO This can be, somehow, rewritten -./inc/libs/bonus_functions.php:195: // @TODO Move this HTML to a template +./inc/libs/admins_functions.php:537: // @TODO This can be, somehow, rewritten +./inc/libs/bonus_functions.php:115: // @TODO Rewrite this to a filter +./inc/libs/bonus_functions.php:199: // @TODO Move this HTML to a template +./inc/libs/doubler_functions.php:130:// @TODO This could be rewritten to a filter ./inc/libs/doubler_functions.php:44:// @TODO Lame description ./inc/libs/doubler_functions.php:96: // @TODO Can't this be moved into EL? ./inc/libs/forced_functions.php:457:// @TODO Can't we use our new expression language instead of this ugly code? +./inc/libs/mailid_functions.php:123: // @TODO Rewrite these blocks to filter ./inc/libs/mailid_functions.php:47: // @TODO Rewrite this to a dynamic include or so -./inc/libs/network_functions.php:1124: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine +./inc/libs/mailid_functions.php:93: // @TODO Rewrite this to a filter +./inc/libs/network_functions.php:1183: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine ./inc/libs/order_functions.php:46: // @TODO Move this array into a filter ./inc/libs/rallye_functions.php:771:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() ./inc/libs/rallye_functions.php:838: $EXPIRE = 3; // @TODO The hard-coded value... @@ -104,12 +108,12 @@ ./inc/mails/doubler_mails.php:53:// @TODO Can this be rewritten to a filter? ./inc/module-functions.php:273: // @TODO Nothing helped??? ./inc/module-functions.php:314: // @TODO Rewrite this to a filter -./inc/modules/admin/admin-inc.php:1043:// @TODO rawUserId/content is not yet supported -./inc/modules/admin/admin-inc.php:1068:// @TODO rawUserId/cacheFiles/content is not yet supported -./inc/modules/admin/admin-inc.php:163: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? -./inc/modules/admin/admin-inc.php:236: // @TODO This can be rewritten into a filter -./inc/modules/admin/admin-inc.php:521:// @TODO Try to rewrite this to adminAddMenuSelectionBox() -./inc/modules/admin/admin-inc.php:868:// @TODO cacheFiles is not yet supported +./inc/modules/admin/admin-inc.php:1055:// @TODO rawUserId/content is not yet supported +./inc/modules/admin/admin-inc.php:1080:// @TODO rawUserId/cacheFiles/content is not yet supported +./inc/modules/admin/admin-inc.php:175: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? +./inc/modules/admin/admin-inc.php:248: // @TODO This can be rewritten into a filter +./inc/modules/admin/admin-inc.php:533:// @TODO Try to rewrite this to adminAddMenuSelectionBox() +./inc/modules/admin/admin-inc.php:880:// @TODO cacheFiles is not yet supported ./inc/modules/admin/overview-inc.php:176: // @TODO Rewrite this to a filter ./inc/modules/admin/overview-inc.php:289: // @TODO Rewrite this to something with include files and/or filter ./inc/modules/admin/overview-inc.php:323: // @TODO This may also be rewritten to include files @@ -140,9 +144,9 @@ ./inc/modules/admin/what-list_mods.php:55: // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function ./inc/modules/admin/what-list_rallye_prices.php:222: // @TODO Rewrite these two constants ./inc/modules/admin/what-list_refs.php:101: // @TODO Try to rewrite some to EL -./inc/modules/admin/what-list_unconfirmed.php:114: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus -./inc/modules/admin/what-list_unconfirmed.php:84: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); -./inc/modules/admin/what-list_unconfirmed.php:87: // @TODO `id` has been used two times??? +./inc/modules/admin/what-list_unconfirmed.php:118: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus +./inc/modules/admin/what-list_unconfirmed.php:89: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); +./inc/modules/admin/what-list_unconfirmed.php:92: // @TODO `id` has been used two times??? ./inc/modules/admin/what-list_user_cats.php:54: // @TODO No longer needed? define('__CATEGORIES_BASE' , '' . $content['login'] . ''; @@ -171,8 +174,8 @@ ./inc/modules/member/what-beg.php:63:// @TODO No more needed? define('__BEG_USERID_TIMEOUT', createFancyTime(getBegUseridTimeout())); ./inc/modules/member/what-logout.php:17: * @TODO Rewrite the code to a filter * ./inc/modules/member/what-logout.php:52: // @TODO Move this in a filter, e.g. member_logout -./inc/modules/member/what-order.php:459: // @TODO Rewrite this to a filter -./inc/modules/member/what-order.php:84: // @TODO Rewrite this to SQL_FETCHARRAY() +./inc/modules/member/what-mydata.php:82: // @TODO Move this to a function (for better EL code) +./inc/modules/member/what-order.php:463: // @TODO Rewrite this to a filter ./inc/modules/member/what-payout.php:208: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:61:// @TODO Should we rewrite this to a filter? ./inc/modules/member/what-rallyes.php:99: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; @@ -181,38 +184,31 @@ ./inc/modules/member/what-unconfirmed.php:178: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() ./inc/modules/member/what-unconfirmed.php:247: // @TODO This 'userid' cannot be saved because of encapsulated EL code ./inc/modules/order.php:78: // @TODO Unused: 2,4 -./inc/mysql-manager.php:1450: // @TODO Rewrite these lines to a filter -./inc/mysql-manager.php:1474: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1780: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1977: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided -./inc/mysql-manager.php:2100: // @TODO Used generic 'userid' here -./inc/mysql-manager.php:2321:// @TODO cacheFiles is not yet supported +./inc/mysql-manager.php:1492: // @TODO Rewrite these lines to a filter +./inc/mysql-manager.php:1516: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1832: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:2000: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided +./inc/mysql-manager.php:2123: // @TODO Used generic 'userid' here +./inc/mysql-manager.php:2344:// @TODO cacheFiles is not yet supported ./inc/mysql-manager.php:408: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:44:// @TODO Can we cache this? -./inc/purge/purge-inact.php:55: // @TODO Rewrite these if() blocks to a filter ./inc/revision-functions.php:168:// @TODO This function does also set and get in 'cache_array' -./inc/template-functions.php:1143: // @TODO Deprecate this thing -./inc/template-functions.php:1154: // @TODO Deprecate this thing -./inc/template-functions.php:1276: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1325: // @TODO Add a little more infos here -./inc/template-functions.php:1691:// @TODO Lame description for this function -./inc/template-functions.php:1713: // @TODO Move this in a filter -./inc/template-functions.php:200: * @TODO On some pages this is buggy -./inc/template-functions.php:2347: // @TODO Is this needed for e.g. $GLOBALS['template_content'] ? $this->setRawTemplateData($compactedContent); -./inc/template-functions.php:288: // @TODO Remove these sanity checks if all is fine -./inc/template-functions.php:634:// @TODO $simple/$constants are deprecated -./inc/template-functions.php:732: // @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates -./inc/wrapper-functions.php:3176: // @TODO Find a way to not use direct module comparison -./inc/wrapper-functions.php:512:// @TODO Do some more sanity check here +./inc/template-functions.php:1040: // @TODO