X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=6bd635e7b7f798bdd94f4910079b00f2f66ef8fa;hb=c16ab2169b75a7dafb5b0b55523e9fe6f4f5efdb;hp=b4bd19d2311e82e4ec0f29ab2ea8d4c4688fae90;hpb=59db3a67b3cf68aaad36a9a68196c5634066ab6d;p=mailer.git

diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt
index b4bd19d231..6bd635e7b7 100644
--- a/DOCS/TODOs.txt
+++ b/DOCS/TODOs.txt
@@ -40,7 +40,7 @@
 ./inc/extensions/ext-yoomedia.php:121:		// @TODO Can this be moved into a database table?
 ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y');
 ./inc/extensions-functions.php:155:	// @TODO Do we still need this? setExtensionUpdateNotes('');
-./inc/extensions-functions.php:1945:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable'
+./inc/extensions-functions.php:1943:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable'
 ./inc/extensions-functions.php:425:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
 ./inc/extensions-functions.php:562:		// @TODO Extension is loaded, what next?
 ./inc/filter/bonus_filter.php:56:		// @TODO This query isn't right, it will only update if the user was for a longer time away!
@@ -52,19 +52,19 @@
 ./inc/functions.php:156:// @TODO Rewrite this to an extension 'smtp'
 ./inc/functions.php:1940:	// @TODO Find a way to cache this
 ./inc/functions.php:2041:	// @TODO This is still very static, rewrite it somehow
-./inc/functions.php:2233:	// @TODO Rename column data_type to e.g. mail_status
+./inc/functions.php:2236:	// @TODO Rename column data_type to e.g. mail_status
 ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter
 ./inc/install-functions.php:57:	// @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0);
-./inc/language/de.php:1071:	// @TODO Rewrite these two constants
-./inc/language/de.php:1087:	// @TODO Rewrite these three constants
-./inc/language/de.php:757:// @TODO Are these constants longer used?
+./inc/language/de.php:1072:	// @TODO Rewrite these two constants
+./inc/language/de.php:1088:	// @TODO Rewrite these three constants
+./inc/language/de.php:758:// @TODO Are these constants longer used?
 ./inc/language-functions.php:255:	// @TODO These are all valid languages, again hard-coded
 ./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function.
 ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no       *
 ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings             *
 ./inc/language/refback_de.php:53:	// @TODO Rewrite these constants to one
 ./inc/language/sponsor_de.php:117:// @TODO Rewrite these four constants to one and use sprintf()
-./inc/libs/admins_functions.php:474:		// @TODO This can be, somehow, rewritten
+./inc/libs/admins_functions.php:508:		// @TODO This can be, somehow, rewritten
 ./inc/libs/bonus_functions.php:194:		// @TODO Move this HTML to a template
 ./inc/libs/doubler_functions.php:44:// @TODO Lame description
 ./inc/libs/doubler_functions.php:93:			// @TODO Can't this be moved into EL?
@@ -90,12 +90,12 @@
 ./inc/mails/doubler_mails.php:53:// @TODO Can this be rewritten to a filter?
 ./inc/module-functions.php:267:			// @TODO Nothing helped???
 ./inc/module-functions.php:308:			// @TODO Rewrite this to a filter
-./inc/modules/admin/admin-inc.php:1373:				// @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided
+./inc/modules/admin/admin-inc.php:1420:				// @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided
 ./inc/modules/admin/admin-inc.php:171:		// @TODO This and the next getCurrentAdminId() call might be moved into the templates?
 ./inc/modules/admin/admin-inc.php:242:		// @TODO This can be rewritten into a filter
 ./inc/modules/admin/admin-inc.php:274:		// @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/modules/admin/admin-inc.php:340:					// @TODO Rewrite this to $content = SQL_FETCHARRAY()
-./inc/modules/admin/admin-inc.php:438:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
+./inc/modules/admin/admin-inc.php:485:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
 ./inc/modules/admin/overview-inc.php:162:				// @TODO Rewrite this to a filter
 ./inc/modules/admin/overview-inc.php:275:				// @TODO Rewrite this to something with include files and/or filter
 ./inc/modules/admin/overview-inc.php:309:						// @TODO This may also be rewritten to include files
@@ -108,7 +108,7 @@
 ./inc/modules/admin/what-admin_add.php:59:		// @TODO Cant this be rewritten?
 ./inc/modules/admin/what-admin_add.php:75:		// @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-adminedit.php:56:	// @TODO Kill all constants in this file
-./inc/modules/admin/what-admins_mails.php:59:				// @TODO Can this be rewritten to an API function?
+./inc/modules/admin/what-admins_mails.php:58:				// @TODO Can this be rewritten to an API function?
 ./inc/modules/admin/what-bonus.php:46:// @TODO Unused at the moment
 ./inc/modules/admin/what-config_mods.php:55:			// @TODO This can be moved into mysql-function.php, see checkModulePermissions() function
 ./inc/modules/admin/what-config_points.php:110:			// @TODO Rewrite this to a filter
@@ -123,8 +123,8 @@
 ./inc/modules/admin/what-guest_add.php:67:		// @TODO Cant this be rewritten?
 ./inc/modules/admin/what-guest_add.php:80:		// @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-holiday_list.php:46:// @TODO Unused at the moment
-./inc/modules/admin/what-list_admins_acls.php:108:	// @TODO Rewrite this to a filter
-./inc/modules/admin/what-list_admins_acls.php:136:	// @TODO Rewrite this to filter 'run_sqls'
+./inc/modules/admin/what-list_admins_acls.php:101:	// @TODO Rewrite this to a filter
+./inc/modules/admin/what-list_admins_acls.php:129:	// @TODO Rewrite this to filter 'run_sqls'
 ./inc/modules/admin/what-list_autopurge.php:47:// @TODO Rewrite those lines to filter
 ./inc/modules/admin/what-list_bonus.php:136:		// @TODO Can't this be moved into our expression language?
 ./inc/modules/admin/what-list_cats.php:54:		// @TODO No longer needed? define('__CATEGORIES_BASE'   , '<a href="{%url=modules.php?module=admin&amp;userid=');
@@ -132,7 +132,7 @@
 ./inc/modules/admin/what-list_links.php:55:		// @TODO Try to rewrite this to a filter
 ./inc/modules/admin/what-list_links.php:85:				// @TODO Find a way to rewrite this. See some lines above for different queries
 ./inc/modules/admin/what-list_links.php:93:					// @TODO Rewrite this to includes/filter
-./inc/modules/admin/what-list_refs.php:107:								// @TODO Try to rewrite some to EL
+./inc/modules/admin/what-list_refs.php:99:								// @TODO Try to rewrite some to EL
 ./inc/modules/admin/what-list_unconfirmed.php:107:	// @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
 ./inc/modules/admin/what-list_unconfirmed.php:84:	// @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
 ./inc/modules/admin/what-list_user.php:247:		// @TODO Rewrite this into a filter
@@ -149,7 +149,7 @@
 ./inc/modules/guest/what-login.php:125:	// @TODO Move this HTML code into a template
 ./inc/modules/guest/what-mediadata.php:182:// @TODO Rewrite all these if-blocks to filters
 ./inc/modules/guest/what-mediadata.php:67:	// @TODO Find a better formular than this one
-./inc/modules/guest/what-rallyes.php:89:	// @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;admin=' . $adminId . '%}">' . $login . '</a>';
+./inc/modules/guest/what-rallyes.php:89:	// @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;id=' . $adminId . '%}">' . $login . '</a>';
 ./inc/modules/guest/what-sponsor_reg.php:289:			// @TODO Maybe a default referal id?
 ./inc/modules/guest/what-stats.php:108:		// @TODO This can be somehow rewritten
 ./inc/modules/guest/what-stats.php:82:// @TODO This can be rewritten in a dynamic include
@@ -161,30 +161,29 @@
 ./inc/modules/member/what-order.php:82:		// @TODO Rewrite this to SQL_FETCHARRAY()
 ./inc/modules/member/what-payout.php:194:					// @TODO Rewrite this to a filter
 ./inc/modules/member/what-points.php:55:// @TODO Should we rewrite this to a filter?
-./inc/modules/member/what-rallyes.php:89:	// @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;admin=' . $content['admin_id'] . '%}">' . $content['login'] . '</a>';
+./inc/modules/member/what-rallyes.php:89:	// @TODO Reactivate this: $content['admin'] = '<a href="{%url=modules.php?module=index&amp;what=impressum&amp;id=' . $content['admin_id'] . '%}">' . $content['login'] . '</a>';
 ./inc/modules/member/what-reflinks.php:52:// @TODO Move this into a filter
 ./inc/modules/member/what-transfer.php:128:				// @TODO Rewrite this to a filter
 ./inc/modules/member/what-unconfirmed.php:162:	// @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
 ./inc/modules/member/what-unconfirmed.php:227:				// @TODO This 'userid' cannot be saved because of encapsulated EL code
-./inc/modules/order.php:74:		// @TODO Unused: 2,4
-./inc/mysql-manager.php:1275:			// @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
-./inc/mysql-manager.php:1339:		// @TODO Rewrite these lines to a filter
-./inc/mysql-manager.php:1363:	// @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1622:			// @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1668:// @TODO Fix inconsistency between last_module and getWhat()
+./inc/modules/order.php:78:		// @TODO Unused: 2,4
+./inc/mysql-manager.php:1381:		// @TODO Rewrite these lines to a filter
+./inc/mysql-manager.php:1405:	// @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1664:			// @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1710:// @TODO Fix inconsistency between last_module and getWhat()
 ./inc/mysql-manager.php:387:	// @TODO Try to rewrite this to one or more functions
 ./inc/mysql-manager.php:44:// @TODO Can we cache this?
 ./inc/purge/purge-inact.php:55:	// @TODO Rewrite these if() blocks to a filter
 ./inc/revision-functions.php:169:// @TODO This function does also set and get in 'cache_array'
-./inc/template-functions.php:1068:			// @TODO Deprecate this thing
-./inc/template-functions.php:1079:			// @TODO Deprecate this thing
-./inc/template-functions.php:1169:	// @TODO This can be easily moved out after the merge from EL branch to this is complete
-./inc/template-functions.php:1202:		// @TODO Add a little more infos here
-./inc/template-functions.php:1531:// @TODO Lame description for this function
-./inc/template-functions.php:1553:			// @TODO Move this in a filter
+./inc/template-functions.php:1070:			// @TODO Deprecate this thing
+./inc/template-functions.php:1081:			// @TODO Deprecate this thing
+./inc/template-functions.php:1171:	// @TODO This can be easily moved out after the merge from EL branch to this is complete
+./inc/template-functions.php:1204:		// @TODO Add a little more infos here
+./inc/template-functions.php:1533:// @TODO Lame description for this function
+./inc/template-functions.php:1555:			// @TODO Move this in a filter
 ./inc/template-functions.php:184:	 * @TODO On some pages this is buggy
 ./inc/template-functions.php:273:		// @TODO Remove this sanity-check if all is fine
-./inc/template-functions.php:596:// @TODO $simple/$constants are deprecated
+./inc/template-functions.php:598:// @TODO $simple/$constants are deprecated
 ./inc/wrapper-functions.php:512:// @TODO Do some more sanity check here
 ./inc/xml-functions.php:189:	// @TODO Handle characters
 ./mailid.php:139:					// @TODO Rewrite this to a filter
@@ -198,7 +197,6 @@
 ./network-check.php:54:// @TODO Add processing of request here
 ./view.php:68:		// @TODO No banner found, output some default banner
 ./templates/de/html/admin/admin_add_country.tpl:23:			<!-- @TODO Rewrite this selection box to our generic functions //-->
-./templates/de/html/admin/admin_admins_contct_form.tpl:4:	<!-- @TODO Shouldn't we add a title here? //-->
 ./templates/de/html/admin/admin_config_other.tpl:79:			<!-- @TODO Rewrite this selection to one of our functions //-->
 ./templates/de/html/admin/admin_config_rewrite.tpl:4:	<!-- @TODO No title here? //-->
 ./templates/de/html/admin/admin_edit_admin_menu.tpl:4:<!-- @TODO Shouldn't we add a title here? //-->
@@ -232,7 +230,7 @@
 ./inc/loader/load_cache-revision.php:2:// @DEPRECATED
 ./inc/loader/load_cache-them.php:2:// @DEPRECATED
 ./inc/loader/load-extensions.php:2:// @DEPRECATED
-./inc/modules/admin/admin-inc.php:439:// @DEPRECATED
+./inc/modules/admin/admin-inc.php:486:// @DEPRECATED
 ./inc/modules/admin/what-chk_regs.php:2:// @DEPRECATED
 ./inc/modules/admin/what-config_admins.php:2:// @DEPRECATED
 ./inc/modules/admin/what-config_email.php:2:// @DEPRECATED