X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Feditapplication.php;h=00ed3971935ed520bc132c470e832620894e1d06;hb=8912cdc7a4acaeaea3b2b323efc86333ffd5ef63;hp=4e67d9e57b05255ceb5ab6f908a0b13ddab9cc78;hpb=47f31bce47b182aa55c02c7872d7e473d3ab10f2;p=quix0rs-gnu-social.git diff --git a/actions/editapplication.php b/actions/editapplication.php index 4e67d9e57b..00ed397193 100644 --- a/actions/editapplication.php +++ b/actions/editapplication.php @@ -22,7 +22,7 @@ * @category Applications * @package StatusNet * @author Zach Copley - * @copyright 2008-2009 StatusNet, Inc. + * @copyright 2008-2011 StatusNet, Inc. * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @link http://status.net/ */ @@ -42,7 +42,7 @@ if (!defined('STATUSNET') && !defined('LACONICA')) { * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @link http://status.net/ */ -class EditApplicationAction extends OwnerDesignAction +class EditApplicationAction extends Action { var $msg = null; var $owner = null; @@ -69,8 +69,8 @@ class EditApplicationAction extends OwnerDesignAction $id = (int)$this->arg('id'); - $this->app = Oauth_application::staticGet($id); - $this->owner = User::staticGet($this->app->owner); + $this->app = Oauth_application::getKV($id); + $this->owner = User::getKV($this->app->owner); $cur = common_current_user(); if ($cur->id != $this->owner->id) { @@ -128,6 +128,7 @@ class EditApplicationAction extends OwnerDesignAction // CSRF protection $token = $this->trimmed('token'); if (!$token || $token != common_session_token()) { + // TRANS: Client error displayed when the session token does not match or is not given. $this->clientError(_('There was a problem with your session token.')); return; } @@ -209,12 +210,10 @@ class EditApplicationAction extends OwnerDesignAction $this->showForm(_('Source URL is too long.')); return; } elseif ((mb_strlen($source_url) > 0) - && !Validate::uri($source_url, - array('allowed_schemes' => array('http', 'https')))) - { - // TRANS: Validation error shown when providing an invalid source URL in the "Edit application" form. - $this->showForm(_('Source URL is not valid.')); - return; + && !common_valid_http_url($source_url)) { + // TRANS: Validation error shown when providing an invalid source URL in the "Edit application" form. + $this->showForm(_('Source URL is not valid.')); + return; } elseif (empty($organization)) { // TRANS: Validation error shown when not providing an organisation in the "Edit application" form. $this->showForm(_('Organization is required.')); @@ -228,25 +227,20 @@ class EditApplicationAction extends OwnerDesignAction $this->showForm(_('Organization homepage is required.')); return; } elseif ((mb_strlen($homepage) > 0) - && !Validate::uri($homepage, - array('allowed_schemes' => array('http', 'https')))) - { - // TRANS: Validation error shown when providing an invalid homepage URL in the "Edit application" form. - $this->showForm(_('Homepage is not a valid URL.')); - return; - } elseif (mb_strlen($callback_url) > 255) { - // TRANS: Validation error shown when providing too long a callback URL in the "Edit application" form. - $this->showForm(_('Callback is too long.')); - return; - } elseif (mb_strlen($callback_url) > 0 - && !Validate::uri($source_url, - array('allowed_schemes' => array('http', 'https')) - )) - { - // TRANS: Validation error shown when providing an invalid callback URL in the "Edit application" form. - $this->showForm(_('Callback URL is not valid.')); - return; - } + && !common_valid_http_url($homepage)) { + // TRANS: Validation error shown when providing an invalid homepage URL in the "Edit application" form. + $this->showForm(_('Homepage is not a valid URL.')); + return; + } elseif (mb_strlen($callback_url) > 255) { + // TRANS: Validation error shown when providing too long a callback URL in the "Edit application" form. + $this->showForm(_('Callback is too long.')); + return; + } elseif (mb_strlen($callback_url) > 0 + && !common_valid_http_url($callback_url)) { + // TRANS: Validation error shown when providing an invalid callback URL in the "Edit application" form. + $this->showForm(_('Callback URL is not valid.')); + return; + } $cur = common_current_user(); @@ -301,7 +295,7 @@ class EditApplicationAction extends OwnerDesignAction */ function nameExists($name) { - $newapp = Oauth_application::staticGet('name', $name); + $newapp = Oauth_application::getKV('name', $name); if (empty($newapp)) { return false; } else {