X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Feditgroup.php;h=131fdf32506524a98295c39755b1251dffcb57d8;hb=8f31a1a820bcaf8959a095c265db28b4b557bd7e;hp=7439b9d030ebb09086543a9854b10d84fd3648e8;hpb=f79aec36feaa4760201a7e88d5b31513a3c458ba;p=quix0rs-gnu-social.git diff --git a/actions/editgroup.php b/actions/editgroup.php index 7439b9d030..131fdf3250 100644 --- a/actions/editgroup.php +++ b/actions/editgroup.php @@ -29,7 +29,7 @@ * @link http://status.net/ */ -if (!defined('STATUSNET') && !defined('LACONICA')) { +if (!defined('STATUSNET') && !defined('LACONICA') && !defined('GNUSOCIAL')) { exit(1); } @@ -42,31 +42,69 @@ if (!defined('STATUSNET') && !defined('LACONICA')) { * @package StatusNet * @author Evan Prodromou * @author Zach Copley + * @author Alexei Sorokin * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @link http://status.net/ */ class EditgroupAction extends GroupAction { - var $msg; + public $message = null; + public $success = null; + protected $canPost = true; - function title() + public function title() { // TRANS: Title for form to edit a group. %s is a group nickname. return sprintf(_('Edit %s group'), $this->group->nickname); } + public function showContent() + { + $form = new GroupEditForm($this, $this->group); + $form->show(); + } + + public function showPageNoticeBlock() + { + parent::showPageNoticeBlock(); + + if ($this->message) { + $this->element( + 'p', + ($this->success) ? 'success' : 'error', + $this->message + ); + } else { + $this->element( + 'p', + 'instructions', + // TRANS: Form instructions for group edit form. + _('Use this form to edit the group.') + ); + } + } + + public function showScripts() + { + parent::showScripts(); + $this->autofocus('fullname'); + } + /** * Prepare to run + * @param array $args + * @return bool + * @throws ClientException + * @throws NicknameException */ - function prepare($args) + protected function prepare(array $args = []) { parent::prepare($args); if (!common_logged_in()) { // TRANS: Client error displayed trying to edit a group while not logged in. $this->clientError(_('You must be logged in to create a group.')); - return false; } $nickname_arg = $this->trimmed('nickname'); @@ -75,32 +113,29 @@ class EditgroupAction extends GroupAction // Permanent redirect on non-canonical nickname if ($nickname_arg != $nickname) { - $args = array('nickname' => $nickname); + $args = ['nickname' => $nickname]; common_redirect(common_local_url('editgroup', $args), 301); - return false; } if (!$nickname) { // TRANS: Client error displayed trying to edit a group while not proving a nickname for the group to edit. $this->clientError(_('No nickname.'), 404); - return false; } $groupid = $this->trimmed('groupid'); if ($groupid) { - $this->group = User_group::staticGet('id', $groupid); + $this->group = User_group::getKV('id', $groupid); } else { - $local = Local_group::staticGet('nickname', $nickname); + $local = Local_group::getKV('nickname', $nickname); if ($local) { - $this->group = User_group::staticGet('id', $local->group_id); + $this->group = User_group::getKV('id', $local->group_id); } } if (!$this->group) { // TRANS: Client error displayed trying to edit a non-existing group. $this->clientError(_('No such group.'), 404); - return false; } $cur = common_current_user(); @@ -108,78 +143,47 @@ class EditgroupAction extends GroupAction if (!$cur->isAdmin($this->group)) { // TRANS: Client error displayed trying to edit a group while not being a group admin. $this->clientError(_('You must be an admin to edit the group.'), 403); - return false; } return true; } - /** - * Handle the request - * - * On GET, show the form. On POST, try to save the group. - * - * @param array $args unused - * - * @return void - */ - function handle($args) + protected function handlePost() { - parent::handle($args); - if ($_SERVER['REQUEST_METHOD'] == 'POST') { - $this->trySave(); - } else { - $this->showForm(); - } - } - - function showForm($msg=null) - { - $this->msg = $msg; - $this->showPage(); - } - - function showContent() - { - $form = new GroupEditForm($this, $this->group); - $form->show(); - } - - function showPageNotice() - { - if ($this->msg) { - $this->element('p', 'error', $this->msg); - } else { - $this->element('p', 'instructions', - // TRANS: Form instructions for group edit form. - _('Use this form to edit the group.')); - } - } + parent::handlePost(); - function showScripts() - { - parent::showScripts(); - $this->autofocus('newnickname'); - } - - function trySave() - { $cur = common_current_user(); if (!$cur->isAdmin($this->group)) { // TRANS: Client error displayed trying to edit a group while not being a group admin. $this->clientError(_('You must be an admin to edit the group.'), 403); - return; } - if (Event::handle('StartGroupSaveForm', array($this))) { + if (Event::handle('StartGroupSaveForm', [$this])) { + + // $nickname will only be set if this changenick value is true. + $nickname = null; + if (common_config('profile', 'changenick') == true) { + try { + $nickname = Nickname::normalize($this->trimmed('newnickname'), true); + } catch (NicknameTakenException $e) { + // Abort only if the nickname is occupied by _another_ group + if ($e->profile->id != $this->group->profile_id) { + $this->setMessage($e->getMessage(), true); + return; + } + $nickname = Nickname::normalize($this->trimmed('newnickname')); // without in-use check this time + } catch (NicknameException $e) { + $this->setMessage($e->getMessage(), true); + return; + } + } - $nickname = Nickname::normalize($this->trimmed('newnickname')); - $fullname = $this->trimmed('fullname'); - $homepage = $this->trimmed('homepage'); + $fullname = $this->trimmed('fullname'); + $homepage = $this->trimmed('homepage'); $description = $this->trimmed('description'); - $location = $this->trimmed('location'); + $location = $this->trimmed('location'); $aliasstring = $this->trimmed('aliases'); - $private = $this->boolean('private'); + $private = $this->boolean('private'); if ($private) { $force_scope = 1; @@ -189,91 +193,75 @@ class EditgroupAction extends GroupAction $join_policy = User_group::JOIN_POLICY_OPEN; } - if ($this->nicknameExists($nickname)) { - // TRANS: Group edit form validation error. - $this->showForm(_('Nickname already in use. Try another one.')); - return; - } else if (!User_group::allowedNickname($nickname)) { + if (!is_null($homepage) && (strlen($homepage) > 0) && + !common_valid_http_url($homepage)) { // TRANS: Group edit form validation error. - $this->showForm(_('Not a valid nickname.')); + $this->setMessage(_('Homepage is not a valid URL.'), true); return; - } else if (!is_null($homepage) && (strlen($homepage) > 0) && - !Validate::uri($homepage, - array('allowed_schemes' => - array('http', 'https')))) { + } elseif (!is_null($fullname) && mb_strlen($fullname) > 255) { // TRANS: Group edit form validation error. - $this->showForm(_('Homepage is not a valid URL.')); + $this->setMessage(_('Full name is too long (maximum 255 characters).'), true); return; - } else if (!is_null($fullname) && mb_strlen($fullname) > 255) { + } elseif (User_group::descriptionTooLong($description)) { + $this->setMessage(sprintf( // TRANS: Group edit form validation error. - $this->showForm(_('Full name is too long (maximum 255 characters).')); - return; - } else if (User_group::descriptionTooLong($description)) { - $this->showForm(sprintf( - // TRANS: Group edit form validation error. - _m('Description is too long (maximum %d character).', - 'Description is too long (maximum %d characters).', - User_group::maxDescription()), - User_group::maxDescription())); + _m( + 'Description is too long (maximum %d character).', + 'Description is too long (maximum %d characters).', + User_group::maxDescription() + ), + User_group::maxDescription() + ), true); return; - } else if (!is_null($location) && mb_strlen($location) > 255) { + } elseif (!is_null($location) && mb_strlen($location) > 255) { // TRANS: Group edit form validation error. - $this->showForm(_('Location is too long (maximum 255 characters).')); + $this->setMessage(_('Location is too long (maximum 255 characters).'), true); return; } if (!empty($aliasstring)) { - $aliases = array_map('common_canonical_nickname', array_unique(preg_split('/[\s,]+/', $aliasstring))); + $aliases = array_map( + ['Nickname', 'normalize'], + array_unique(preg_split('/[\s,]+/', $aliasstring)) + ); } else { - $aliases = array(); + $aliases = []; } if (count($aliases) > common_config('group', 'maxaliases')) { // TRANS: Group edit form validation error. // TRANS: %d is the maximum number of allowed aliases. - $this->showForm(sprintf(_m('Too many aliases! Maximum %d allowed.', - 'Too many aliases! Maximum %d allowed.', - common_config('group', 'maxaliases')), - common_config('group', 'maxaliases'))); + $this->setMessage(sprintf( + _m( + 'Too many aliases! Maximum %d allowed.', + 'Too many aliases! Maximum %d allowed.', + common_config('group', 'maxaliases') + ), + common_config('group', 'maxaliases') + ), true); return; } - foreach ($aliases as $alias) { - if (!Nickname::isValid($alias)) { - // TRANS: Group edit form validation error. - $this->showForm(sprintf(_('Invalid alias: "%s"'), $alias)); - return; - } - if ($this->nicknameExists($alias)) { - // TRANS: Group edit form validation error. - $this->showForm(sprintf(_('Alias "%s" already in use. Try another one.'), - $alias)); - return; - } - // XXX assumes alphanum nicknames - if (strcmp($alias, $nickname) == 0) { - // TRANS: Group edit form validation error. - $this->showForm(_('Alias can\'t be the same as nickname.')); - return; - } - } - $this->group->query('BEGIN'); $orig = clone($this->group); - $this->group->nickname = $nickname; - $this->group->fullname = $fullname; - $this->group->homepage = $homepage; + if (common_config('profile', 'changenick') == true && $this->group->nickname !== $nickname) { + assert(Nickname::normalize($nickname) === $nickname); + common_debug("Changing group nickname from '{$this->group->nickname}' to '{$nickname}'."); + $this->group->nickname = $nickname; + $this->group->mainpage = common_local_url('showgroup', ['nickname' => $this->group->nickname]); + } + $this->group->fullname = $fullname; + $this->group->homepage = $homepage; $this->group->description = $description; - $this->group->location = $location; - $this->group->mainpage = common_local_url('showgroup', array('nickname' => $nickname)); + $this->group->location = $location; $this->group->join_policy = $join_policy; $this->group->force_scope = $force_scope; $result = $this->group->update($orig); - if (!$result) { + if ($result === false) { common_log_db_error($this->group, 'UPDATE', __FILE__); // TRANS: Server error displayed when editing a group fails. $this->serverError(_('Could not update group.')); @@ -286,43 +274,22 @@ class EditgroupAction extends GroupAction $this->serverError(_('Could not create aliases.')); } - if ($nickname != $orig->nickname) { - common_log(LOG_INFO, "Saving local group info."); - $local = Local_group::staticGet('group_id', $this->group->id); - $local->setNickname($nickname); - } - $this->group->query('COMMIT'); - Event::handle('EndGroupSaveForm', array($this)); - } + Event::handle('EndGroupSaveForm', [$this]); - if ($this->group->nickname != $orig->nickname) { - common_redirect(common_local_url('editgroup', - array('nickname' => $nickname)), - 303); - } else { - // TRANS: Group edit form success message. - $this->showForm(_('Options saved.')); + if ($this->group->nickname != $orig->nickname) { + common_redirect(common_local_url('editgroup', ['nickname' => $this->group->nickname]), 303); + } } + + // TRANS: Group edit form success message. + $this->setMessage(_('Options saved.')); } - function nicknameExists($nickname) + public function setMessage($msg, $error = false) { - $group = Local_group::staticGet('nickname', $nickname); - - if (!empty($group) && - $group->group_id != $this->group->id) { - return true; - } - - $alias = Group_alias::staticGet('alias', $nickname); - - if (!empty($alias) && - $alias->group_id != $this->group->id) { - return true; - } - - return false; + $this->message = $msg; + $this->success = !$error; } }