X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Ffinishaddopenid.php;h=028dc82e5a218a878adbb7fef8c62736334bd41d;hb=4a4ab2bdbfc9dad60cc94dc903462195c3a0e669;hp=237f0454f7ded23a67486bf89b3142e72d6f6670;hpb=7258969cd48d9e11e500db56665e190d05d1e4c0;p=quix0rs-gnu-social.git diff --git a/actions/finishaddopenid.php b/actions/finishaddopenid.php index 237f0454f7..028dc82e5a 100644 --- a/actions/finishaddopenid.php +++ b/actions/finishaddopenid.php @@ -26,7 +26,7 @@ class FinishaddopenidAction extends Action { function handle($args) { parent::handle($args); if (!common_logged_in()) { - common_user_error(_t('Not logged in.')); + common_user_error(_('Not logged in.')); } else { $this->try_login(); } @@ -39,13 +39,13 @@ class FinishaddopenidAction extends Action { $response = $consumer->complete(common_local_url('finishaddopenid')); if ($response->status == Auth_OpenID_CANCEL) { - $this->message(_t('OpenID authentication cancelled.')); + $this->message(_('OpenID authentication cancelled.')); return; } else if ($response->status == Auth_OpenID_FAILURE) { // Authentication failed; display the error message. - $this->message(_t('OpenID authentication failed: ') . $response->message); + $this->message(sprintf(_('OpenID authentication failed: %s'), $response->message)); } else if ($response->status == Auth_OpenID_SUCCESS) { - + $display = $response->getDisplayIdentifier(); $canonical = ($response->endpoint && $response->endpoint->canonicalID) ? $response->endpoint->canonicalID : $display; @@ -57,96 +57,47 @@ class FinishaddopenidAction extends Action { } $cur =& common_current_user(); - $other = $this->get_user($canonical); - + $other = oid_get_user($canonical); + if ($other) { if ($other->id == $cur->id) { - $this->message(_t('You already have this OpenID!')); + $this->message(_('You already have this OpenID!')); } else { - $this->message(_t('Someone else already has this OpenID.')); + $this->message(_('Someone else already has this OpenID.')); } return; } # start a transaction - + $cur->query('BEGIN'); - - $result = oid_link_user($cur->id, $display, $canonical); - + + $result = oid_link_user($cur->id, $canonical, $display); + if (!$result) { - $this->message(_t('Error connecting user.')); + $this->message(_('Error connecting user.')); return; } if ($sreg) { - if (!$this->update_user($cur, $sreg)) { - $this->message(_t('Error updating profile')); + if (!oid_update_user($cur, $sreg)) { + $this->message(_('Error updating profile')); return; } } - + # success! - + $cur->query('COMMIT'); - + + oid_set_last($display); + common_redirect(common_local_url('openidsettings')); } } function message($msg) { - common_show_header(_t('OpenID Login')); + common_show_header(_('OpenID Login')); common_element('p', NULL, $msg); common_show_footer(); } - - function get_user($canonical) { - $user = NULL; - $oid = User_openid::staticGet('canonical', $canonical); - if ($oid) { - $user = User::staticGet('id', $oid->user_id); - } - return $user; - } - - function update_user(&$user, $sreg) { - - $profile =& $user->getProfile(); - - $orig_profile = clone($profile); - - if ($sreg['fullname'] && strlen($sreg['fullname']) <= 255) { - $profile->fullname = $sreg['fullname']; - } - - if ($sreg['country']) { - if ($sreg['postcode']) { - # XXX: use postcode to get city and region - # XXX: also, store postcode somewhere -- it's valuable! - $profile->location = $sreg['postcode'] . ', ' . $sreg['country']; - } else { - $profile->location = $sreg['country']; - } - } - - # XXX save language if it's passed - # XXX save timezone if it's passed - - if (!$profile->update($orig_profile)) { - common_server_error(_t('Error saving the profile.')); - return false; - } - - $orig_user = clone($user); - - if ($sreg['email'] && Validate::email($sreg['email'], true)) { - $user->email = $sreg['email']; - } - - if (!$user->update($orig_user)) { - common_server_error(_t('Error saving the user.')); - return false; - } - - return true; - } }