X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Ffinishaddopenid.php;h=54d81b0b4e538efd0ba3c60d43f7d22566daaf53;hb=85b9e58e535d44f5973fe14f888dc19f25bcaddd;hp=e5c01c4637e80215cc999263f45a3396ec73bcb8;hpb=d1a895c5b14c429fea26b9fe12b75b98d6a37afc;p=quix0rs-gnu-social.git

diff --git a/actions/finishaddopenid.php b/actions/finishaddopenid.php
index e5c01c4637..54d81b0b4e 100644
--- a/actions/finishaddopenid.php
+++ b/actions/finishaddopenid.php
@@ -26,31 +26,29 @@ class FinishaddopenidAction extends Action {
 	function handle($args) {
 		parent::handle($args);
 		if (!common_logged_in()) {
-			common_user_error(_t('Not logged in.'));
+			common_user_error(_('Not logged in.'));
 		} else {
 			$this->try_login();
 		}
 	}
-
+	
 	function try_login() {
 
-		$consumer = oid_consumer();
+		$consumer =& oid_consumer();
 
 		$response = $consumer->complete(common_local_url('finishaddopenid'));
 
 		if ($response->status == Auth_OpenID_CANCEL) {
-			$this->message(_t('OpenID authentication cancelled.'));
+			$this->message(_('OpenID authentication cancelled.'));
 			return;
 		} else if ($response->status == Auth_OpenID_FAILURE) {
 			// Authentication failed; display the error message.
-			$this->message(_t('OpenID authentication failed: ') . $response->message);
+			$this->message(sprintf(_('OpenID authentication failed: %s'), $response->message));
 		} else if ($response->status == Auth_OpenID_SUCCESS) {
-			// This means the authentication succeeded; extract the
-			// identity URL and Simple Registration data (if it was
-			// returned).
+
 			$display = $response->getDisplayIdentifier();
-			$canonical = ($response->endpoint->canonicalID) ?
-			  $response->endpoint->canonicalID : $response->getDisplayIdentifier();
+			$canonical = ($response->endpoint && $response->endpoint->canonicalID) ?
+			  $response->endpoint->canonicalID : $display;
 
 			$sreg_resp = Auth_OpenID_SRegResponse::fromSuccessResponse($response);
 
@@ -58,98 +56,48 @@ class FinishaddopenidAction extends Action {
 				$sreg = $sreg_resp->contents();
 			}
 
-			$user = $this->get_user($canonical);
+			$cur =& common_current_user();
+			$other = oid_get_user($canonical);
 
-			if ($user) {
-				$this->message(_t('This OpenID is already associated with user "') . $user->nickname . _t('"'));
-			} else {
-				$user = common_current_user();
-				if (!$this->connect_user($user, $display, $canonical)) {
-					$this->message(_t('Error connecting user'));
-					return;
-				}
-				if ($sreg) {
-					if (!$this->update_user($user, $sreg)) {
-						$this->message(_t('Error updating profile'));
-						return;
-					}
+			if ($other) {
+				if ($other->id == $cur->id) {
+					$this->message(_('You already have this OpenID!'));
+				} else {
+					$this->message(_('Someone else already has this OpenID.'));
 				}
-				# success!
-				common_redirect(common_local_url('openidsettings'));
+				return;
 			}
-		}
-	}
 
-	function message($msg) {
-		common_show_header(_t('OpenID Login'));
-		common_element('p', NULL, $msg);
-		common_show_footer();
-	}
+			# start a transaction
 
-	function get_user($canonical) {
-		$user = NULL;
-		$oid = User_openid::staticGet('canonical', $canonical);
-		if ($oid) {
-			$user = User::staticGet('id', $oid->user_id);
-		}
-		return $user;
-	}
+			$cur->query('BEGIN');
 
-	function update_user($user, $sreg) {
+			$result = oid_link_user($cur->id, $canonical, $display);
 
-		$profile = $user->getProfile();
-
-		$orig_profile = clone($profile);
-
-		if ($sreg['fullname'] && strlen($sreg['fullname']) <= 255) {
-			$profile->fullname = $sreg['fullname'];
-		}
-
-		if ($sreg['country']) {
-			if ($sreg['postcode']) {
-				# XXX: use postcode to get city and region
-				# XXX: also, store postcode somewhere -- it's valuable!
-				$profile->location = $sreg['postcode'] . ', ' . $sreg['country'];
-			} else {
-				$profile->location = $sreg['country'];
+			if (!$result) {
+				$this->message(_('Error connecting user.'));
+				return;
+			}
+			if ($sreg) {
+				if (!oid_update_user($cur, $sreg)) {
+					$this->message(_('Error updating profile'));
+					return;
+				}
 			}
-		}
-
-		# XXX save language if it's passed
-		# XXX save timezone if it's passed
 
-		if (!$profile->update($orig_profile)) {
-			common_server_error(_t('Error saving the profile.'));
-			return false;
-		}
+			# success!
 
-		$orig_user = clone($user);
+			$cur->query('COMMIT');
 
-		if ($sreg['email'] && Validate::email($sreg['email'], true)) {
-			$user->email = $sreg['email'];
-		}
+			oid_set_last($display);
 
-		if (!$user->update($orig_user)) {
-			common_server_error(_t('Error saving the user.'));
-			return false;
+			common_redirect(common_local_url('openidsettings'));
 		}
-		
-		return true;
 	}
 
-	function connect_user($user, $display, $canonical) {
-
-		$oid = new User_openid();
-		$oid->display = $display;
-		$oid->canonical = $canonical;
-		$oid->user_id = $user->id;
-		$oid->created = DB_DataObject_Cast::dateTime();
-
-		if (!$oid->insert()) {
-			$err = PEAR::getStaticProperty('DB_DataObject','lastError');
-			common_debug('DB error ' . $err->code . ': ' . $err->message, __FILE__);
-			return false;
-		}
-		return true;
+	function message($msg) {
+		common_show_header(_('OpenID Login'));
+		common_element('p', NULL, $msg);
+		common_show_footer();
 	}
 }