X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Ffinishaddopenid.php;h=b1dce14747153b8c8104bf9dd8940c54292dd210;hb=676bbebe1a6225d77416a0e3ea57a90b25627ced;hp=e5c01c4637e80215cc999263f45a3396ec73bcb8;hpb=d1a895c5b14c429fea26b9fe12b75b98d6a37afc;p=quix0rs-gnu-social.git

diff --git a/actions/finishaddopenid.php b/actions/finishaddopenid.php
index e5c01c4637..b1dce14747 100644
--- a/actions/finishaddopenid.php
+++ b/actions/finishaddopenid.php
@@ -34,7 +34,7 @@ class FinishaddopenidAction extends Action {
 
 	function try_login() {
 
-		$consumer = oid_consumer();
+		$consumer =& oid_consumer();
 
 		$response = $consumer->complete(common_local_url('finishaddopenid'));
 
@@ -45,12 +45,10 @@ class FinishaddopenidAction extends Action {
 			// Authentication failed; display the error message.
 			$this->message(_t('OpenID authentication failed: ') . $response->message);
 		} else if ($response->status == Auth_OpenID_SUCCESS) {
-			// This means the authentication succeeded; extract the
-			// identity URL and Simple Registration data (if it was
-			// returned).
+			
 			$display = $response->getDisplayIdentifier();
-			$canonical = ($response->endpoint->canonicalID) ?
-			  $response->endpoint->canonicalID : $response->getDisplayIdentifier();
+			$canonical = ($response->endpoint && $response->endpoint->canonicalID) ?
+			  $response->endpoint->canonicalID : $display;
 
 			$sreg_resp = Auth_OpenID_SRegResponse::fromSuccessResponse($response);
 
@@ -58,25 +56,42 @@ class FinishaddopenidAction extends Action {
 				$sreg = $sreg_resp->contents();
 			}
 
-			$user = $this->get_user($canonical);
+			$cur =& common_current_user();
+			$other = oid_get_user($canonical);
+			
+			if ($other) {
+				if ($other->id == $cur->id) {
+					$this->message(_t('You already have this OpenID!'));
+				} else {
+					$this->message(_t('Someone else already has this OpenID.'));
+				}
+				return;
+			}
 
-			if ($user) {
-				$this->message(_t('This OpenID is already associated with user "') . $user->nickname . _t('"'));
-			} else {
-				$user = common_current_user();
-				if (!$this->connect_user($user, $display, $canonical)) {
-					$this->message(_t('Error connecting user'));
+			# start a transaction
+			
+			$cur->query('BEGIN');
+			
+			$result = oid_link_user($cur->id, $canonical, $display);
+			
+			if (!$result) {
+				$this->message(_t('Error connecting user.'));
+				return;
+			}
+			if ($sreg) {
+				if (!oid_update_user($cur, $sreg)) {
+					$this->message(_t('Error updating profile'));
 					return;
 				}
-				if ($sreg) {
-					if (!$this->update_user($user, $sreg)) {
-						$this->message(_t('Error updating profile'));
-						return;
-					}
-				}
-				# success!
-				common_redirect(common_local_url('openidsettings'));
 			}
+			
+			# success!
+			
+			$cur->query('COMMIT');
+
+			oid_set_last($display);
+			
+			common_redirect(common_local_url('openidsettings'));
 		}
 	}
 
@@ -85,71 +100,4 @@ class FinishaddopenidAction extends Action {
 		common_element('p', NULL, $msg);
 		common_show_footer();
 	}
-
-	function get_user($canonical) {
-		$user = NULL;
-		$oid = User_openid::staticGet('canonical', $canonical);
-		if ($oid) {
-			$user = User::staticGet('id', $oid->user_id);
-		}
-		return $user;
-	}
-
-	function update_user($user, $sreg) {
-
-		$profile = $user->getProfile();
-
-		$orig_profile = clone($profile);
-
-		if ($sreg['fullname'] && strlen($sreg['fullname']) <= 255) {
-			$profile->fullname = $sreg['fullname'];
-		}
-
-		if ($sreg['country']) {
-			if ($sreg['postcode']) {
-				# XXX: use postcode to get city and region
-				# XXX: also, store postcode somewhere -- it's valuable!
-				$profile->location = $sreg['postcode'] . ', ' . $sreg['country'];
-			} else {
-				$profile->location = $sreg['country'];
-			}
-		}
-
-		# XXX save language if it's passed
-		# XXX save timezone if it's passed
-
-		if (!$profile->update($orig_profile)) {
-			common_server_error(_t('Error saving the profile.'));
-			return false;
-		}
-
-		$orig_user = clone($user);
-
-		if ($sreg['email'] && Validate::email($sreg['email'], true)) {
-			$user->email = $sreg['email'];
-		}
-
-		if (!$user->update($orig_user)) {
-			common_server_error(_t('Error saving the user.'));
-			return false;
-		}
-		
-		return true;
-	}
-
-	function connect_user($user, $display, $canonical) {
-
-		$oid = new User_openid();
-		$oid->display = $display;
-		$oid->canonical = $canonical;
-		$oid->user_id = $user->id;
-		$oid->created = DB_DataObject_Cast::dateTime();
-
-		if (!$oid->insert()) {
-			$err = PEAR::getStaticProperty('DB_DataObject','lastError');
-			common_debug('DB error ' . $err->code . ': ' . $err->message, __FILE__);
-			return false;
-		}
-		return true;
-	}
 }