X-Git-Url: https://git.mxchange.org/?a=blobdiff_plain;f=actions%2Fnewapplication.php;h=37bede0d72f3c547a3a4e3eb15bde6253c831d00;hb=c85e78ac3c03bd584a6da3a0a7b5cb9160cc9324;hp=bc5b4edaf84c5b0935ad0294ecf1744638b0e0e7;hpb=ef016dca45b17e7a9e8aae17ffe1b5caf0e2694c;p=quix0rs-gnu-social.git diff --git a/actions/newapplication.php b/actions/newapplication.php index bc5b4edaf8..37bede0d72 100644 --- a/actions/newapplication.php +++ b/actions/newapplication.php @@ -22,14 +22,13 @@ * @category Applications * @package StatusNet * @author Zach Copley - * @copyright 2008-2009 StatusNet, Inc. + * @copyright 2008-2011 StatusNet, Inc. + * @copyright 2013 Free Software Foundation, Inc. * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @link http://status.net/ */ -if (!defined('STATUSNET') && !defined('LACONICA')) { - exit(1); -} +if (!defined('GNUSOCIAL')) { exit(1); } /** * Add a new application @@ -42,109 +41,38 @@ if (!defined('STATUSNET') && !defined('LACONICA')) { * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @link http://status.net/ */ - -class NewApplicationAction extends OwnerDesignAction +class NewApplicationAction extends FormAction { - var $msg; - function title() { + // TRANS: This is the title of the form for adding a new application. return _('New application'); } - /** - * Prepare to run - */ - - function prepare($args) - { - parent::prepare($args); - - if (!common_logged_in()) { - $this->clientError(_('You must be logged in to register an application.')); - return false; - } - - return true; - } - - /** - * Handle the request - * - * On GET, show the form. On POST, try to save the app. - * - * @param array $args unused - * - * @return void - */ - - function handle($args) - { - parent::handle($args); - - if ($_SERVER['REQUEST_METHOD'] == 'POST') { - $this->handlePost($args); - } else { - $this->showForm(); - } - } - - function handlePost($args) + protected function doPost() { - // Workaround for PHP returning empty $_POST and $_FILES when POST - // length > post_max_size in php.ini - - if (empty($_FILES) - && empty($_POST) - && ($_SERVER['CONTENT_LENGTH'] > 0) - ) { - $msg = _('The server was unable to handle that much POST ' . - 'data (%s bytes) due to its current configuration.'); - $this->clientException(sprintf($msg, $_SERVER['CONTENT_LENGTH'])); - return; + if ($this->arg('cancel')) { + common_redirect(common_local_url('oauthappssettings'), 303); + } elseif ($this->arg('save')) { + $this->trySave(); } - // CSRF protection - $token = $this->trimmed('token'); - if (!$token || $token != common_session_token()) { - $this->clientError(_('There was a problem with your session token.')); - return; - } - - $cur = common_current_user(); - - if ($this->arg('cancel')) { - common_redirect(common_local_url('oauthappssettings'), 303); - } elseif ($this->arg('save')) { - $this->trySave(); - } else { + // TRANS: Client error displayed when encountering an unexpected action on form submission. $this->clientError(_('Unexpected form submission.')); } - } - function showForm($msg=null) + protected function getForm() { - $this->msg = $msg; - $this->showPage(); + return new ApplicationEditForm($this); } - function showContent() + protected function getInstructions() { - $form = new ApplicationEditForm($this); - $form->show(); + // TRANS: Form instructions for registering a new application. + return _('Use this form to register a new application.'); } - function showPageNotice() - { - if ($this->msg) { - $this->element('p', 'error', $this->msg); - } else { - $this->element('p', 'instructions', - _('Use this form to register a new application.')); - } - } - - function trySave() + private function trySave() { $name = $this->trimmed('name'); $description = $this->trimmed('description'); @@ -156,75 +84,60 @@ class NewApplicationAction extends OwnerDesignAction $access_type = $this->arg('default_access_type'); if (empty($name)) { - $this->showForm(_('Name is required.')); - return; + // TRANS: Validation error shown when not providing a name in the "New application" form. + $this->clientError(_('Name is required.')); + } else if ($this->nameExists($name)) { + // TRANS: Validation error shown when providing a name for an application that already exists in the "New application" form. + $this->clientError(_('Name already in use. Try another one.')); } elseif (mb_strlen($name) > 255) { - $this->showForm(_('Name is too long (max 255 chars).')); - return; + // TRANS: Validation error shown when providing too long a name in the "New application" form. + $this->clientError(_('Name is too long (maximum 255 characters).')); } elseif (empty($description)) { - $this->showForm(_('Description is required.')); - return; + // TRANS: Validation error shown when not providing a description in the "New application" form. + $this->clientError(_('Description is required.')); } elseif (Oauth_application::descriptionTooLong($description)) { - $this->showForm(sprintf( - _('Description is too long (max %d chars).'), - Oauth_application::maxDescription())); - return; + $this->clientError(sprintf( + // TRANS: Form validation error in New application form. + // TRANS: %d is the maximum number of characters for the description. + _m('Description is too long (maximum %d character).', + 'Description is too long (maximum %d characters).', + Oauth_application::maxDesc()), + Oauth_application::maxDesc())); } elseif (empty($source_url)) { - $this->showForm(_('Source URL is required.')); - return; - } elseif ((strlen($source_url) > 0) - && !Validate::uri( - $source_url, - array('allowed_schemes' => array('http', 'https')) - ) - ) - { - $this->showForm(_('Source URL is not valid.')); - return; + // TRANS: Validation error shown when not providing a source URL in the "New application" form. + $this->clientError(_('Source URL is required.')); + } elseif ((strlen($source_url) > 0) && !common_valid_http_url($source_url)) { + // TRANS: Validation error shown when providing an invalid source URL in the "New application" form. + $this->clientError(_('Source URL is not valid.')); } elseif (empty($organization)) { - $this->showForm(_('Organization is required.')); - return; + // TRANS: Validation error shown when not providing an organisation in the "New application" form. + $this->clientError(_('Organization is required.')); } elseif (mb_strlen($organization) > 255) { - $this->showForm(_('Organization is too long (max 255 chars).')); - return; + // TRANS: Validation error shown when providing too long an arganisation name in the "Edit application" form. + $this->clientError(_('Organization is too long (maximum 255 characters).')); } elseif (empty($homepage)) { - $this->showForm(_('Organization homepage is required.')); - return; - } elseif ((strlen($homepage) > 0) - && !Validate::uri( - $homepage, - array('allowed_schemes' => array('http', 'https')) - ) - ) - { - $this->showForm(_('Homepage is not a valid URL.')); - return; + // TRANS: Form validation error show when an organisation name has not been provided in the new application form. + $this->clientError(_('Organization homepage is required.')); + } elseif ((strlen($homepage) > 0) && !common_valid_http_url($homepage)) { + // TRANS: Validation error shown when providing an invalid homepage URL in the "New application" form. + $this->clientError(_('Homepage is not a valid URL.')); } elseif (mb_strlen($callback_url) > 255) { - $this->showForm(_('Callback is too long.')); - return; - } elseif (strlen($callback_url) > 0 - && !Validate::uri( - $source_url, - array('allowed_schemes' => array('http', 'https')) - ) - ) - { - $this->showForm(_('Callback URL is not valid.')); - return; + // TRANS: Validation error shown when providing too long a callback URL in the "New application" form. + $this->clientError(_('Callback is too long.')); + } elseif (strlen($callback_url) > 0 && !common_valid_http_url($callback_url)) { + // TRANS: Validation error shown when providing an invalid callback URL in the "New application" form. + $this->clientError(_('Callback URL is not valid.')); } - $cur = common_current_user(); - - // Checked in prepare() above - - assert(!is_null($cur)); + // Login is checked in parent::prepare() + assert(!is_null($this->scoped)); $app = new Oauth_application(); $app->query('BEGIN'); $app->name = $name; - $app->owner = $cur->id; + $app->owner = $this->scoped->id; $app->description = $description; $app->source_url = $source_url; $app->organization = $organization; @@ -252,6 +165,8 @@ class NewApplicationAction extends OwnerDesignAction if (!$result) { common_log_db_error($consumer, 'INSERT', __FILE__); + $app->query('ROLLBACK'); + // TRANS: Server error displayed when an application could not be registered in the database through the "New application" form. $this->serverError(_('Could not create application.')); } @@ -261,17 +176,37 @@ class NewApplicationAction extends OwnerDesignAction if (!$this->app_id) { common_log_db_error($app, 'INSERT', __FILE__); - $this->serverError(_('Could not create application.')); $app->query('ROLLBACK'); + // TRANS: Server error displayed when an application could not be registered in the database through the "New application" form. + $this->serverError(_('Could not create application.')); } - $app->uploadLogo(); + try { + $app->uploadLogo(); + } catch (Exception $e) { + $app->query('ROLLBACK'); + // TRANS: Form validation error messages displayed when uploading an invalid application logo. + $this->clientError(_('Invalid image.')); + } $app->query('COMMIT'); common_redirect(common_local_url('oauthappssettings'), 303); - } + /** + * Does the app name already exist? + * + * Checks the DB to see someone has already registered an app + * with the same name. + * + * @param string $name app name to check + * + * @return boolean true if the name already exists + */ + function nameExists($name) + { + $app = Oauth_application::getKV('name', $name); + return !empty($app); + } } -